Bug 32814: Fix cataloguing/value_builder/callnumber-KU.pl

[koha-ffzg.git] / cataloguing / moveitem.pl

diff --git a/cataloguing/moveitem.pl b/cataloguing/moveitem.pl
index 79736a6..ec59c25 100755 (executable)
--- a/cataloguing/moveitem.pl
+++ b/cataloguing/moveitem.pl
@@ -19,21 +19,15 @@
 # You should have received a copy of the GNU General Public License
 # along with Koha; if not, see <http://www.gnu.org/licenses>.
 
-use strict;
-#use warnings; FIXME - Bug 2505
+use Modern::Perl;
+
 use CGI qw ( -utf8 );
-use C4::Auth;
-use C4::Output;
-use C4::Biblio;
-use C4::Items;
-use C4::Context;
-use C4::Koha;
-use C4::ClassSource;
-use C4::Acquisition qw/GetOrderFromItemnumber ModOrder GetOrder/;
-
-use Date::Calc qw(Today);
-
-use MARC::File::XML;
+use C4::Auth qw( get_template_and_user );
+use C4::Output qw( output_html_with_http_headers );
+
+use Koha::Biblios;
+use Koha::Items;
+
 my $query = CGI->new;
 
 # The biblio to move the item to
@@ -47,61 +41,57 @@ my ($template, $loggedinuser, $cookie) = get_template_and_user(
         template_name   => "cataloguing/moveitem.tt",
         query           => $query,
         type            => "intranet",
-        authnotrequired => 0,
         flagsrequired   => { editcatalogue => 'edit_items' },
-        debug           => 1,
     }
 );
 
-
-
-my $biblio = GetBiblioData($biblionumber);
-$template->param(bibliotitle => $biblio->{'title'});
+my $biblio = Koha::Biblios->find( $biblionumber );
+$template->param(biblio => $biblio);
 $template->param(biblionumber => $biblionumber);
 
 # If we already have the barcode of the item to move and the biblionumber to move the item to
-if ($barcode && $biblionumber) { 
-    
-    # We get his itemnumber
-    my $itemnumber = GetItemnumberFromBarcode($barcode);
-
-    if ($itemnumber) {
-       # And then, we get the item
-       my $item = GetItem($itemnumber);
-
-       if ($item) {
-
-           my $results = GetBiblioFromItemNumber($itemnumber, $barcode);
-           my $frombiblionumber = $results->{'biblionumber'};
-          
-           my $moveresult = MoveItemFromBiblio($itemnumber, $frombiblionumber, $biblionumber); 
-           if ($moveresult) { 
-               $template->param(success => 1);
-           } else {
-               $template->param(error => 1,
-                                errornonewitem => 1); 
-           }
-
-
-       } else {
-           $template->param(error => 1,
-                            errornoitem => 1);
-       }
-    } else {
-           $template->param(error => 1,
-                            errornoitemnumber => 1);
+if ( $barcode && $biblionumber ) {
+
+    my $itemnumber;
+    my $item = Koha::Items->find( { barcode => $barcode } );
+
+    if ($item) {
+
+        $itemnumber = $item->itemnumber;
+        my $frombiblionumber = $item->biblionumber;
+        my $to_biblio = Koha::Biblios->find($biblionumber);
+
+        my $moveresult = $item->move_to_biblio($to_biblio);
+        if ($moveresult) {
+            $template->param(
+                success => 1,
+                from_biblio => Koha::Biblios->find($frombiblionumber),
+            );
+        }
+        else {
+            $template->param(
+                error          => 1,
+                errornonewitem => 1
+            );
+        }
 
     }
+    else {
+        $template->param(
+            error       => 1,
+            errornoitem => 1
+        );
+    }
     $template->param(
-                       barcode => $barcode,  
-                       itemnumber => $itemnumber,
-                   );
-
-} else {
-    $template->param(missingparameter => 1);
-    if (!$barcode)      { $template->param(missingbarcode      => 1); }
-    if (!$biblionumber) { $template->param(missingbiblionumber => 1); }
-}
+        barcode    => $barcode,
+        itemnumber => $itemnumber,
+    );
 
+}
+else {
+    $template->param( missingparameter => 1 );
+    if ( !$barcode )      { $template->param( missingbarcode      => 1 ); }
+    if ( !$biblionumber ) { $template->param( missingbiblionumber => 1 ); }
+}
 
 output_html_with_http_headers $query, $cookie, $template->output;