Bug 27266: (QA follow-up) Remove GetBiblioData from basket scripts

[srvgit] / basket / downloadcart.pl

diff --git a/basket/downloadcart.pl b/basket/downloadcart.pl
index b69c7e2..c1e80bf 100755 (executable)
--- a/basket/downloadcart.pl
+++ b/basket/downloadcart.pl
@@ -20,26 +20,24 @@
 use Modern::Perl;
 
 use CGI qw ( -utf8 );
-use Encode qw(encode);
+use Encode qw( encode );
 
-use C4::Auth;
-use C4::Biblio;
-use C4::Items;
-use C4::Output;
+use C4::Auth qw( get_template_and_user );
+use C4::Biblio qw( GetMarcBiblio );
+use C4::Output qw( output_html_with_http_headers );
 use C4::Record;
-use C4::Ris;
+use C4::Ris qw( marc2ris );
 
 use Koha::CsvProfiles;
 
 use utf8;
-my $query = new CGI;
+my $query = CGI->new;
 
 my ( $template, $borrowernumber, $cookie ) = get_template_and_user (
     {
         template_name   => "basket/downloadcart.tt",
         query           => $query,
         type            => "intranet",
-        authnotrequired => 0,
         flagsrequired   => { catalogue => 1 },
     }
 );
@@ -71,16 +69,9 @@ if ($bib_list && $format) {
             next unless $record;
 
             if ($format eq 'iso2709') {
-                my $usmarc = $record->as_usmarc();
-                if ($usmarc){
-                    #NOTE: If we don't explicitly UTF-8 encode the output,
-                    #the browser will guess the encoding, and it won't always choose UTF-8.
-                    my $bytes = encode("UTF-8", $usmarc);
-                    if ($bytes) {
-                        $output .= $bytes;
-                    }
-
-                }
+                #NOTE: If we don't explicitly UTF-8 encode the output,
+                #the browser will guess the encoding, and it won't always choose UTF-8.
+                $output .= encode("UTF-8", $record->as_usmarc()) // q{};
             }
             elsif ($format eq 'ris') {
                 $output .= marc2ris($record);