Bug 32336: (QA follow-up) Use $metadata->schema

[srvgit] / admin / import_export_framework.pl

diff --git a/admin/import_export_framework.pl b/admin/import_export_framework.pl
index 8674ebf..9973eb9 100755 (executable)
--- a/admin/import_export_framework.pl
+++ b/admin/import_export_framework.pl
@@ -4,48 +4,62 @@
 #
 # This file is part of Koha.
 #
-# Koha is free software; you can redistribute it and/or modify it under the
-# terms of the GNU General Public License as published by the Free Software
-# Foundation; either version 2 of the License, or (at your option) any later
-# version.
+# Koha is free software; you can redistribute it and/or modify it
+# under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
 #
-# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
-# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
-# A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
+# Koha is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
 #
-# You should have received a copy of the GNU General Public License along
-# with Koha; if not, write to the Free Software Foundation, Inc.,
-# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+# You should have received a copy of the GNU General Public License
+# along with Koha; if not, see <http://www.gnu.org/licenses>.
 
-
-use strict;
-use warnings;
-use CGI;
+use Modern::Perl;
+use CGI qw ( -utf8 );
+use CGI::Cookie;
 use C4::Context;
-use C4::ImportExportFramework;
+use C4::Auth qw( check_cookie_auth );
+use C4::ImportExportFramework qw( createODS ExportFramework ImportFramework );
+
+my %cookies = CGI::Cookie->fetch();
+my ($auth_status);
+if (exists $cookies{'CGISESSID'}) {
+    ($auth_status, undef) = check_cookie_auth(
+        $cookies{'CGISESSID'}->value,
+        { parameters => 'manage_marc_frameworks' },
+    );
+}
 
-my $input = new CGI;
+my $input = CGI->new;
 
-my $frameworkcode = $input->param('frameworkcode') || '';
+unless ($auth_status eq 'ok') {
+    print $input->header(-type => 'text/plain', -status => '403 Forbidden');
+    exit 0;
+}
+
+my $frameworkcode = $input->param('frameworkcode') || 'default';
 my $action = $input->param('action') || 'export';
 
 ## Exporting
 if ($action eq 'export' && $input->request_method() eq 'GET') {
     my $strXml = '';
     my $format = $input->param('type_export_' . $frameworkcode);
-    ExportFramework($frameworkcode, \$strXml, $format);
+    if ($frameworkcode eq 'default') {
+        ExportFramework('', \$strXml, $format, 'biblio');
+    } else {
+        ExportFramework($frameworkcode, \$strXml, $format, 'biblio');
+    }
+
     if ($format eq 'csv') {
         # CSV file
+
+        # Correctly set the encoding to output plain text in UTF-8
+        binmode(STDOUT,':encoding(UTF-8)');
         print $input->header(-type => 'application/vnd.ms-excel', -attachment => 'export_' . $frameworkcode . '.csv');
         print $strXml;
-    } elsif ($format eq 'sql') {
-        # SQL file
-        print $input->header(-type => 'text/plain', -attachment => 'export_' . $frameworkcode . '.sql');
-        print $strXml;
-    } elsif ($format eq 'excel') {
-        # Excel-xml file
-        print $input->header(-type => 'application/excel', -attachment => 'export_' . $frameworkcode . '.xml');
-        print $strXml;
     } else {
         # ODS file
         my $strODS = '';
@@ -59,13 +73,13 @@ if ($action eq 'export' && $input->request_method() eq 'GET') {
     my $fieldname = 'file_import_' . $frameworkcode;
     my $filename = $input->param($fieldname);
     # upload the input file
-    if ($filename && $filename =~ /\.(csv|ods|xml|sql)$/i) {
+    if ($filename && $filename =~ /\.(csv|ods)$/i) {
         my $extension = $1;
         my $uploadFd = $input->upload($fieldname);
         if ($uploadFd && !$input->cgi_error) {
-            my $tmpfilename = $input->tmpFileName($input->param($fieldname));
+            my $tmpfilename = $input->tmpFileName(scalar $input->param($fieldname));
             $filename = $tmpfilename . '.' . $extension; # rename the tmp file with the extension
-            $ok = ImportFramework($filename, $frameworkcode, 1) if (rename($tmpfilename, $filename));
+            $ok = ImportFramework($filename, $frameworkcode, 1, 'biblio') if (rename($tmpfilename, $filename));
         }
     }
     if ($ok >= 0) { # If everything went ok go to the framework marc structure