Bug 17600: Standardize our EXPORT_OK

[srvgit] / admin / edi_accounts.pl

diff --git a/admin/edi_accounts.pl b/admin/edi_accounts.pl
index 7d86af8..293f7ef 100755 (executable)
--- a/admin/edi_accounts.pl
+++ b/admin/edi_accounts.pl
@@ -4,41 +4,40 @@
 #
 # This file is part of Koha.
 #
-# Koha is free software; you can redistribute it and/or modify it under the
-# terms of the GNU General Public License as published by the Free Software
-# Foundation; either version 3 of the License, or (at your option) any later
-# version.
+# Koha is free software; you can redistribute it and/or modify it
+# under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
 #
-# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
-# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
-# A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
+# Koha is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
 #
-# You should have received a copy of the GNU General Public License along
-# with Koha; if not, write to the Free Software Foundation, Inc.,
-# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+# You should have received a copy of the GNU General Public License
+# along with Koha; if not, see <http://www.gnu.org/licenses>.
 
-use strict;
-use warnings;
+use Modern::Perl;
 use CGI;
-use C4::Auth;
-use C4::Output;
+use C4::Auth qw( get_template_and_user );
+use C4::Output qw( output_html_with_http_headers );
 use Koha::Database;
+use Koha::Plugins;
 
-my $input = CGI->new();
+our $input = CGI->new();
+our $schema = Koha::Database->new()->schema();
 
-my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
+our ( $template, $loggedinuser, $cookie ) = get_template_and_user(
     {
         template_name   => 'admin/edi_accounts.tt',
         query           => $input,
         type            => 'intranet',
-        authnotrequired => 0,
         flagsrequired   => { acquisition => 'edi_manage' },
     }
 );
 
 my $op = $input->param('op');
 $op ||= 'display';
-my $schema = Koha::Database->new()->schema();
 
 if ( $op eq 'acct_form' ) {
     show_account();
@@ -51,6 +50,13 @@ if ( $op eq 'acct_form' ) {
         }
     );
     $template->param( vendors => \@vendors );
+
+    if ( C4::Context->config("enable_plugins") ) {
+        my @plugins = Koha::Plugins->new()->GetPlugins({
+            method => 'edifact',
+        });
+        $template->param( plugins => \@plugins );
+    }
 }
 elsif ( $op eq 'delete_confirm' ) {
     show_account();
@@ -62,21 +68,22 @@ else {
         # validate & display
         my $id     = $input->param('id');
         my $fields = {
-            description        => $input->param('description'),
-            host               => $input->param('host'),
-            username           => $input->param('username'),
-            password           => $input->param('password'),
-            vendor_id          => $input->param('vendor_id'),
-            upload_directory   => $input->param('upload_directory'),
-            download_directory => $input->param('download_directory'),
-            san                => $input->param('san'),
-            transport          => $input->param('transport'),
-            quotes_enabled     => defined $input->param('quotes_enabled'),
-            invoices_enabled   => defined $input->param('invoices_enabled'),
-            orders_enabled     => defined $input->param('orders_enabled'),
-            responses_enabled  => defined $input->param('responses_enabled'),
-            auto_orders        => defined $input->param('auto_orders'),
-            id_code_qualifier  => $input->param('id_code_qualifier'),
+            description        => scalar $input->param('description'),
+            host               => scalar $input->param('host'),
+            username           => scalar $input->param('username'),
+            password           => scalar $input->param('password'),
+            vendor_id          => scalar $input->param('vendor_id'),
+            upload_directory   => scalar $input->param('upload_directory'),
+            download_directory => scalar $input->param('download_directory'),
+            san                => scalar $input->param('san'),
+            transport          => scalar $input->param('transport'),
+            quotes_enabled     => $input->param('quotes_enabled') ? 1 : 0,
+            invoices_enabled   => $input->param('invoices_enabled') ? 1 : 0,
+            orders_enabled     => $input->param('orders_enabled') ? 1 : 0,
+            responses_enabled  => $input->param('responses_enabled') ? 1 : 0,
+            auto_orders        => $input->param('auto_orders') ? 1 : 0,
+            id_code_qualifier  => scalar $input->param('id_code_qualifier'),
+            plugin             => scalar $input->param('plugin'),
         };
 
         if ($id) {
@@ -93,7 +100,7 @@ else {
     elsif ( $op eq 'delete_confirmed' ) {
 
         $schema->resultset('VendorEdiAccount')
-          ->search( { id => $input->param('id'), } )->delete_all;
+          ->search( { id => scalar $input->param('id'), } )->delete_all;
     }
 
     # we do a default dispaly after deletes and saves