Bug 17600: Standardize our EXPORT_OK

[srvgit] / admin / columns_settings.pl

diff --git a/admin/columns_settings.pl b/admin/columns_settings.pl
index afa33c7..55d312d 100755 (executable)
--- a/admin/columns_settings.pl
+++ b/admin/columns_settings.pl
@@ -2,21 +2,18 @@
 
 use Modern::Perl;
 use CGI;
-use YAML qw( LoadFile );
-use C4::Auth;
+use C4::Auth qw( get_template_and_user );
 use C4::Context;
-use C4::Output;
+use C4::Output qw( output_html_with_http_headers );
 use C4::Utils::DataTables::TablesSettings qw( get_modules );
-my $input = new CGI;
+my $input = CGI->new;
 
 my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
     {
         template_name   => "admin/columns_settings.tt",
         query           => $input,
         type            => "intranet",
-        authnotrequired => 0,
         flagsrequired   => { parameters => 'manage_column_config' },
-        debug           => 1,
     }
 );
 
@@ -53,7 +50,8 @@ if ( $action eq 'save' ) {
         next unless $table_id =~ m|^([^#]*)#(.*)$|;
         my $default_display_length = $input->param( $table_id . '_default_display_length' );
         my $default_sort_order     = $input->param( $table_id . '_default_sort_order' );
-        if ( $default_display_length && $default_sort_order ) {
+        if (   defined $default_display_length && $default_display_length ne ""
+            && defined $default_sort_order     && $default_sort_order     ne "" ) {
             C4::Utils::DataTables::TablesSettings::update_table_settings(
                 {
                     module                 => $module,