Bug 17600: Standardize our EXPORT_OK

[srvgit] / admin / clone-rules.pl

diff --git a/admin/clone-rules.pl b/admin/clone-rules.pl
index d2412ae..9dc78d8 100755 (executable)
--- a/admin/clone-rules.pl
+++ b/admin/clone-rules.pl
@@ -25,81 +25,41 @@
 #
 # The script can be called with one of the parameters, both or none
 
-use strict;
-#use warnings; FIXME - Bug 2505
+use Modern::Perl;
 use CGI qw ( -utf8 );
 use C4::Context;
-use C4::Output;
-use C4::Auth;
-use C4::Koha;
-use C4::Debug;
-use C4::Branch; # GetBranchesLoop
+use C4::Output qw( output_html_with_http_headers );
+use C4::Auth qw( get_template_and_user );
+use Koha::CirculationRules;
 
-my $input = new CGI;
-my $dbh = C4::Context->dbh;
+my $input = CGI->new;
 
 my ($template, $loggedinuser, $cookie)
     = get_template_and_user({template_name => "admin/clone-rules.tt",
                             query => $input,
                             type => "intranet",
-                            authnotrequired => 0,
-                            flagsrequired => {parameters => 'parameters_remaining_permissions'},
-                            debug => 1,
+                            flagsrequired => {parameters => 'manage_circ_rules'},
                             });
 
 my $frombranch = $input->param("frombranch");
 my $tobranch   = $input->param("tobranch");
-my $branchloop = GetBranchesLoop;
 
 $template->param(frombranch     => $frombranch)                if ($frombranch);
 $template->param(tobranch       => $tobranch)                  if ($tobranch);
 
-$template->param(branchloop => $branchloop);
+if ($frombranch && $tobranch && $frombranch ne $tobranch) {
+    $frombranch = ( $frombranch ne '*' ? $frombranch : undef );
+    $tobranch = ( $tobranch ne '*' ? $tobranch : undef );
 
-if ($frombranch && $tobranch) {
+    Koha::CirculationRules->search({branchcode => $tobranch})->delete;
 
-    my $error; 
-
-    # First, we create a temporary table with the rules we want to clone
-    my $query = "CREATE TEMPORARY TABLE tmpissuingrules ENGINE=memory SELECT * FROM issuingrules WHERE branchcode=?";
-    my $sth = $dbh->prepare($query);
-    my $res = $sth->execute($frombranch);
-    $error = 1 unless ($res);
-
-    if (!$error) {
-       # We modify these rules according to the new branchcode
-       $query = "UPDATE tmpissuingrules SET branchcode=? WHERE branchcode=?";
-       $sth = $dbh->prepare($query);
-       $res = $sth->execute($tobranch, $frombranch);
-       $error = 1 unless ($res);
-    }
-
-    if (!$error) {
-       # We delete the rules for the existing branchode
-       $query = "DELETE FROM issuingrules WHERE branchcode=?";
-       $sth = $dbh->prepare($query);
-       $res = $sth->execute($tobranch);
-       $error = 1 unless ($res);
-    }
-
-
-    if (!$error) {
-       # We insert the new rules from our temporary table
-       $query = "INSERT INTO issuingrules SELECT * FROM tmpissuingrules WHERE branchcode=?";
-       $sth = $dbh->prepare($query);
-       $res = $sth->execute($tobranch);
-       $error = 1 unless ($res);
-    }
-
-    # Finally, we delete our temporary table
-    $query = "DROP TABLE tmpissuingrules";
-    $sth = $dbh->prepare($query);
-    $res = $sth->execute();
-
-    $template->param(result => "1");
-    $template->param(error  => $error);
+    my $rules = Koha::CirculationRules->search({ branchcode => $frombranch });
+    $rules->clone($tobranch);
+} else {
+    $template->param(error => 1);
 }
 
+$template->param(result => 1);
 
 
 output_html_with_http_headers $input, $cookie, $template->output;