Bug 3150: DBRev 22.12.00.015

[srvgit] / admin / branches.pl

diff --git a/admin/branches.pl b/admin/branches.pl
index 68b9c25..112ca42 100755 (executable)
--- a/admin/branches.pl
+++ b/admin/branches.pl
@@ -19,16 +19,22 @@
 # along with Koha; if not, see <http://www.gnu.org/licenses>.
 
 use Modern::Perl;
+
 use CGI qw ( -utf8 );
-use C4::Auth;
+use Try::Tiny qw( catch try );
+
+use C4::Auth qw( get_template_and_user );
 use C4::Context;
-use C4::Output;
+use C4::Output qw( output_html_with_http_headers );
 use C4::Koha;
+
+use Koha::Database;
 use Koha::Patrons;
 use Koha::Items;
 use Koha::Libraries;
+use Koha::SMTP::Servers;
 
-my $input        = new CGI;
+my $input        = CGI->new;
 my $branchcode   = $input->param('branchcode');
 my $categorycode = $input->param('categorycode');
 my $op           = $input->param('op') || 'list';
@@ -38,20 +44,19 @@ my ( $template, $borrowernumber, $cookie ) = get_template_and_user(
     {   template_name   => "admin/branches.tt",
         query           => $input,
         type            => "intranet",
-        authnotrequired => 0,
         flagsrequired   => { parameters => 'manage_libraries' },
-        debug           => 1,
     }
 );
 
 if ( $op eq 'add_form' ) {
-    my $library;
-    if ($branchcode) {
-        $library = Koha::Libraries->find($branchcode);
-    }
-
     $template->param(
-        library    => $library,
+        library      => Koha::Libraries->find($branchcode),
+        smtp_servers => Koha::SMTP::Servers->search,
+    );
+} elsif ( $branchcode && $op eq 'view' ) {
+    my $library = Koha::Libraries->find($branchcode);
+    $template->param(
+        library      => $library,
     );
 } elsif ( $op eq 'add_validate' ) {
     my @fields = qw(
@@ -66,42 +71,94 @@ if ( $op eq 'add_form' ) {
       branchphone
       branchfax
       branchemail
+      branchillemail
       branchreplyto
       branchreturnpath
       branchurl
       issuing
       branchip
       branchnotes
-      opac_info
       marcorgcode
       pickup_location
+      public
     );
     my $is_a_modif = $input->param('is_a_modif');
 
     if ($is_a_modif) {
         my $library = Koha::Libraries->find($branchcode);
         for my $field (@fields) {
-            $library->$field( scalar $input->param($field) );
+            if( $field =~ /^(pickup_location|public)$/  ) {
+                # Don't fallback to undef/NULL, default is 1 in DB
+                $library->$field( scalar $input->param($field) );
+            } else {
+                $library->$field( scalar $input->param($field) || undef );
+            }
         }
-        eval { $library->store; };
-        if ($@) {
-            push @messages, { type => 'alert', code => 'error_on_update' };
-        } else {
-            push @messages, { type => 'message', code => 'success_on_update' };
+
+        try {
+            Koha::Database->new->schema->txn_do(
+                sub {
+                    $library->store->discard_changes;
+                    # Deal with SMTP server
+                    my $smtp_server_id = $input->param('smtp_server');
+
+                    if ( $smtp_server_id ) {
+                        if ( $smtp_server_id eq '*' ) {
+                            $library->smtp_server({ smtp_server => undef });
+                        }
+                        else {
+                            my $smtp_server = Koha::SMTP::Servers->find( $smtp_server_id );
+                            Koha::Exceptions::BadParameter->throw( parameter => 'smtp_server' )
+                                unless $smtp_server;
+                            $library->smtp_server({ smtp_server => $smtp_server });
+                        }
+                    }
+
+                    push @messages, { type => 'message', code => 'success_on_update' };
+                }
+            );
         }
+        catch {
+            push @messages, { type => 'alert', code => 'error_on_update' };
+        };
     } else {
         $branchcode =~ s|\s||g;
         my $library = Koha::Library->new(
-            {   branchcode => $branchcode,
-                ( map { $_ => scalar $input->param($_) || undef } @fields )
+            {
+                branchcode => $branchcode,
+                (
+                    map {
+                        /^(pickup_location|public)$/ # Don't fallback to undef for those fields
+                          ? ( $_ => scalar $input->param($_) )
+                          : ( $_ => scalar $input->param($_) || undef )
+                    } @fields
+                )
             }
         );
-        eval { $library->store; };
-        if ($@) {
-            push @messages, { type => 'alert', code => 'error_on_insert' };
-        } else {
-            push @messages, { type => 'message', code => 'success_on_insert' };
+
+        try {
+            Koha::Database->new->schema->txn_do(
+                sub {
+                    $library->store->discard_changes;
+
+                    my $smtp_server_id = $input->param('smtp_server');
+
+                    if ( $smtp_server_id ) {
+                        if ( $smtp_server_id ne '*' ) {
+                            my $smtp_server = Koha::SMTP::Servers->find( $smtp_server_id );
+                            Koha::Exceptions::BadParameter->throw( parameter => 'smtp_server' )
+                                unless $smtp_server;
+                            $library->smtp_server({ smtp_server => $smtp_server });
+                        }
+                    }
+
+                    push @messages, { type => 'message', code => 'success_on_insert' };
+                }
+            );
         }
+        catch {
+            push @messages, { type => 'alert', code => 'error_on_insert' };
+        };
     }
     $op = 'list';
 } elsif ( $op eq 'delete_confirm' ) {
@@ -147,10 +204,8 @@ if ( $op eq 'add_form' ) {
     $op = 'list';
 }
 
-if ( $op eq 'list' ) {
-    my $libraries = Koha::Libraries->search( {}, { order_by => ['branchcode'] }, );
-    $template->param( libraries => $libraries, );
-}
+$template->param( libraries_count => Koha::Libraries->search->count )
+    if $op eq 'list';
 
 $template->param(
     messages => \@messages,