# You should have received a copy of the GNU General Public License
# along with Koha; if not, see <http://www.gnu.org/licenses>.
-use strict;
-use warnings;
+use Modern::Perl;
use CGI qw ( -utf8 );
-use C4::Auth;
+use C4::Auth qw( checkauth );
+use JSON qw( encode_json );
use C4::Output;
use C4::Context;
-use C4::Acquisition;
-use C4::Biblio;
-use C4::Bookseller;
-use C4::Items;
+use C4::Acquisition qw( GetInvoice GetOrder ModReceiveOrder );
+use C4::Biblio qw( GetFrameworkCode GetMarcFromKohaField TransformHtmlToXml );
+use C4::Items qw( GetMarcItem ModItemFromMarc AddItemFromMarc );
+use C4::Log qw(logaction);
use C4::Search;
-use Koha::Acquisition::Bookseller;
+use Koha::Number::Price;
+use Koha::Acquisition::Booksellers;
+use Koha::Acquisition::Orders;
-use List::MoreUtils qw/any/;
-my $input=new CGI;
+my $input=CGI->new;
my $flagsrequired = {acquisition => 'order_receive'};
checkauth($input, 0, $flagsrequired, 'intranet');
my $origquantityrec = $input->param('origquantityrec');
my $quantityrec = $input->param('quantityrec');
my $quantity = $input->param('quantity');
-my $unitprice = $input->param('cost');
+my $unitprice = $input->param('unitprice');
+my $replacementprice = $input->param('replacementprice');
+my $datereceived = $input->param('datereceived');
+my $invoice_unitprice = $input->param('invoice_unitprice');
+my $invoice_currency = $input->param('invoice_currency');
my $invoiceid = $input->param('invoiceid');
my $invoice = GetInvoice($invoiceid);
my $invoiceno = $invoice->{invoicenumber};
-my $datereceived = $invoice->{shipmentdate};
my $booksellerid = $input->param('booksellerid');
my $cnt = 0;
-my $ecost = $input->param('ecost');
-my $rrp = $input->param('rrp');
-my $order_internalnote = $input->param("order_internalnote");
my $bookfund = $input->param("bookfund");
+my $suggestion_id = $input->param("suggestionid");
my $order = GetOrder($ordernumber);
my $new_ordernumber = $ordernumber;
-#need old recievedate if we update the order, parcel.pl only shows the right parcel this way FIXME
+#bug18723 regression fix
+if (C4::Context->preference("CurrencyFormat") eq 'FR') {
+ if (rindex($unitprice, '.') ge 0) {
+ substr($unitprice, rindex($unitprice, '.'), 1, ',');
+ }
+ if (rindex($replacementprice,'.') ge 0) {
+ substr($replacementprice, rindex($replacementprice, '.'), 1, ',');
+ }
+}
+
+$unitprice = Koha::Number::Price->new( $unitprice )->unformat();
+$replacementprice = Koha::Number::Price->new( $replacementprice )->unformat();
+my $order_obj = Koha::Acquisition::Orders->find( $ordernumber );
+my $basket = $order_obj->basket;
+
+#need old receivedate if we update the order, parcel.pl only shows the right parcel this way FIXME
if ($quantityrec > $origquantityrec ) {
my @received_items = ();
- if(C4::Context->preference('AcqCreateItem') eq 'ordering') {
- @received_items = $input->param('items_to_receive');
+ if ($basket->effective_create_items eq 'ordering') {
+ @received_items = $input->multi_param('items_to_receive');
my @affects = split q{\|}, C4::Context->preference("AcqItemSetSubfieldsWhenReceived");
if ( @affects ) {
my $frameworkcode = GetFrameworkCode($biblionumber);
- my ( $itemfield ) = GetMarcFromKohaField( 'items.itemnumber', $frameworkcode );
+ my ( $itemfield ) = GetMarcFromKohaField( 'items.itemnumber' );
for my $in ( @received_items ) {
my $item = C4::Items::GetMarcItem( $biblionumber, $in );
for my $affect ( @affects ) {
}
}
- $order->{rrp} = $rrp;
- $order->{ecost} = $ecost;
- $order->{unitprice} = $unitprice;
- my $bookseller = Koha::Acquisition::Bookseller->fetch({ id => $booksellerid });
- if ( $bookseller->{listincgst} ) {
- if ( not $bookseller->{invoiceincgst} ) {
- $order->{rrp} = $order->{rrp} * ( 1 + $order->{gstrate} );
- $order->{ecost} = $order->{ecost} * ( 1 + $order->{gstrate} );
- $order->{unitprice} = $order->{unitprice} * ( 1 + $order->{gstrate} );
+ $order_obj->set(
+ {
+ order_internalnote => scalar $input->param("order_internalnote"),
+ tax_rate_on_receiving => scalar $input->param("tax_rate"),
+ replacementprice => $replacementprice,
+ unitprice => $unitprice,
+ (
+ $invoice_unitprice && $invoice_unitprice ne ''
+ ? (
+ invoice_unitprice => $invoice_unitprice,
+ invoice_currency => $invoice_currency,
+ )
+ : (
+ invoice_unitprice => undef,
+ invoice_currency => undef,
+ )
+ ),
}
- } else {
- if ( $bookseller->{invoiceincgst} ) {
- $order->{rrp} = $order->{rrp} / ( 1 + $order->{gstrate} );
- $order->{ecost} = $order->{ecost} / ( 1 + $order->{gstrate} );
- $order->{unitprice} = $order->{unitprice} / ( 1 + $order->{gstrate} );
- }
- }
+ );
+
+ $order_obj->populate_with_prices_for_receiving();
# save the quantity received.
if ( $quantityrec > 0 ) {
- ($datereceived, $new_ordernumber) = ModReceiveOrder({
- biblionumber => $biblionumber,
- ordernumber => $ordernumber,
- quantityreceived => $quantityrec,
- user => $user,
- cost => $order->{unitprice},
- ecost => $order->{ecost},
- invoiceid => $invoiceid,
- rrp => $order->{rrp},
- budget_id => $bookfund,
- datereceived => $datereceived,
- received_items => \@received_items,
- order_internalnote => $order_internalnote,
- } );
+ if ( $order_obj->subscriptionid ) {
+ # Quantity can only be modified if linked to a subscription
+ $order_obj->quantity($quantity); # quantityrec will be deduced from this value in ModReceiveOrder
+ }
+ ( $datereceived, $new_ordernumber ) = ModReceiveOrder(
+ {
+ biblionumber => $biblionumber,
+ order => $order_obj->unblessed,
+ quantityreceived => $quantityrec,
+ user => $user,
+ invoice => $invoice,
+ budget_id => $bookfund,
+ datereceived => $datereceived,
+ received_items => \@received_items,
+ }
+ );
}
# now, add items if applicable
- if (C4::Context->preference('AcqCreateItem') eq 'receiving') {
-
- my @tags = $input->param('tag');
- my @subfields = $input->param('subfield');
- my @field_values = $input->param('field_value');
- my @serials = $input->param('serial');
- my @itemid = $input->param('itemid');
- my @ind_tag = $input->param('ind_tag');
- my @indicator = $input->param('indicator');
+ if ($basket->effective_create_items eq 'receiving') {
+
+ my @tags = $input->multi_param('tag');
+ my @subfields = $input->multi_param('subfield');
+ my @field_values = $input->multi_param('field_value');
+ my @serials = $input->multi_param('serial');
+ my @itemid = $input->multi_param('itemid');
#Rebuilding ALL the data for items into a hash
# parting them on $itemid.
my %itemhash;
push @{$itemhash{$itemid[$i]}->{'tags'}},$tags[$i];
push @{$itemhash{$itemid[$i]}->{'subfields'}},$subfields[$i];
push @{$itemhash{$itemid[$i]}->{'field_values'}},$field_values[$i];
- push @{$itemhash{$itemid[$i]}->{'ind_tag'}},$ind_tag[$i];
- push @{$itemhash{$itemid[$i]}->{'indicator'}},$indicator[$i];
}
- my $order = Koha::Acquisition::Order->fetch({ ordernumber => $new_ordernumber });
+ my $new_order = Koha::Acquisition::Orders->find( $new_ordernumber );
foreach my $item (keys %itemhash){
my $xml = TransformHtmlToXml( $itemhash{$item}->{'tags'},
$itemhash{$item}->{'subfields'},
$itemhash{$item}->{'field_values'},
- $itemhash{$item}->{'indicator'},
- $itemhash{$item}->{'ind_tag'},
+ undef,
+ undef,
'ITEM' );
my $record=MARC::Record::new_from_xml($xml, 'UTF-8');
my (undef,$bibitemnum,$itemnumber) = AddItemFromMarc($record,$biblionumber);
- $order->add_item( $itemnumber );
+ $new_order->add_item( $itemnumber );
}
}
}
-ModItem(
- {
- booksellerid => $booksellerid,
- dateaccessioned => $datereceived,
- price => $unitprice,
- replacementprice => $rrp,
+my $new_order_object = Koha::Acquisition::Orders->find( $new_ordernumber ); # FIXME we should not need to refetch it
+my $items = $new_order_object->items;
+while ( my $item = $items->next ) {
+ $item->update({
+ booksellerid => $booksellerid,
+ dateaccessioned => $datereceived,
+ datelastseen => $datereceived,
+ price => $unitprice,
+ replacementprice => $replacementprice,
replacementpricedate => $datereceived,
- },
- $biblionumber,
- $_
-) foreach GetItemnumbersFromOrder($new_ordernumber);
+ });
+}
+
+if ($suggestion_id) {
+ my $reason = $input->param("reason") || '';
+ my $other_reason = $input->param("other_reason");
+ $reason = $other_reason if $reason eq 'other';
+ my $suggestion = Koha::Suggestions->find($suggestion_id);
+ $suggestion->update( { reason => $reason } ) if $suggestion;
+}
+
+# Log the receipt
+if (C4::Context->preference("AcquisitionLog")) {
+ my $infos = {
+ quantityrec => $quantityrec,
+ bookfund => $bookfund || 'unchanged',
+ tax_rate => $input->param("tax_rate"),
+ replacementprice => $replacementprice,
+ unitprice => $unitprice,
+ (
+ defined $invoice_unitprice && $invoice_unitprice ne ''
+ ? (
+ invoice_unitprice => $invoice_unitprice,
+ invoice_currency => $invoice_currency,
+ )
+ : ()
+ ),
+ };
+
+ logaction(
+ 'ACQUISITIONS',
+ 'RECEIVE_ORDER',
+ $ordernumber,
+ encode_json($infos)
+ );
+}
-print $input->redirect("/cgi-bin/koha/acqui/parcel.pl?invoiceid=$invoiceid&sticky_filters=1");
+print $input->redirect("/cgi-bin/koha/acqui/parcel.pl?invoiceid=$invoiceid");
projects / srvgit / blobdiff