fixing a sql query not using prepare(?) & execute($var) method

[koha_gimpoz] / MARCdetail.pl

diff --git a/MARCdetail.pl b/MARCdetail.pl
index 0145240..28f7c0c 100755 (executable)
--- a/MARCdetail.pl
+++ b/MARCdetail.pl
@@ -17,8 +17,30 @@
 # Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
 # Suite 330, Boston, MA  02111-1307 USA
 
+=head1 NAME
+
+MARCdetail.pl : script to show a biblio in MARC format
+
+=head1 SYNOPSIS
+
+
+=head1 DESCRIPTION
+
+This script needs a biblionumber in bib parameter (bibnumber from koha style DB. Automaticaly maps to marc biblionumber).
+It shows the biblio in a (nice) MARC format depending on MARC parameters tables.
+The template is in <templates_dir>/catalogue/MARCdetail.tmpl. this template must be divided in 11 "tabs".
+The 10 firsts presents the biblio, the 11th one presents the items attached to the biblio
+
+=head1 FUNCTIONS
+
+=over 2
+
+=cut
+
+
 use strict;
 require Exporter;
+use C4::Auth;
 use C4::Context;
 use C4::Output;
 use CGI;
@@ -38,8 +60,17 @@ my $bibid = &MARCfind_MARCbibid_from_oldbiblionumber($dbh,$biblionumber);
 my $tagslib = &MARCgettagslib($dbh,1);
 
 my $record =MARCgetbiblio($dbh,$bibid);
+#warn $record->as_formatted();
 # open template
-my $template = gettemplate("catalogue/MARCdetail.tmpl",0);
+my ($template, $loggedinuser, $cookie)
+               = get_template_and_user({template_name => "catalogue/MARCdetail.tmpl",
+                            query => $query,
+                            type => "intranet",
+                            authnotrequired => 0,
+                            flagsrequired => {catalogue => 1},
+                            debug => 1,
+                            });
+
 # fill arrays
 my @loop_data =();
 my $tag;
@@ -79,7 +110,6 @@ for (my $tabloop = 0; $tabloop<=10;$tabloop++) {
 my @fields = $record->fields();
 my %witness; #---- stores the list of subfields used at least once, with the "meaning" of the code
 my @big_array;
-warn "loop 1";
 foreach my $field (@fields) {
        my @subf=$field->subfields;
        my %this_row;
@@ -94,7 +124,6 @@ foreach my $field (@fields) {
        }
 }
 #fill big_row with missing datas
-#warn "loop 2";
 foreach my $subfield_code  (keys(%witness)) {
        for (my $i=0;$i<=$#big_array;$i++) {
                $big_array[$i]{$subfield_code}="&nbsp;" unless ($big_array[$i]{$subfield_code});
@@ -102,7 +131,6 @@ foreach my $subfield_code  (keys(%witness)) {
        }
 }
 # now, construct template !
-#warn "loop 3";
 my @item_value_loop;
 my @header_value_loop;
 for (my $i=0;$i<=$#big_array; $i++) {
@@ -118,7 +146,6 @@ for (my $i=0;$i<=$#big_array; $i++) {
 foreach my $subfield_code (keys(%witness)) {
        my %header_value;
        $header_value{header_value} = $witness{$subfield_code};
-       warn "$subfield_code => ".$witness{$subfield_code};
        push(@header_value_loop, \%header_value);
 }
 
@@ -126,5 +153,5 @@ $template->param(item_loop => \@item_value_loop,
                                                item_header_loop => \@header_value_loop,
                                                biblionumber => $biblionumber,
                                                bibid => $bibid);
-print "Content-Type: text/html\n\n", $template->output;
+print $query->header(-cookie => $cookie),$template->output;