Bug 23463: Replace new occurrence of AddItem

[srvgit] / Koha / Plugins.pm

diff --git a/Koha/Plugins.pm b/Koha/Plugins.pm
index be6bf33..9dc42c5 100644 (file)
--- a/Koha/Plugins.pm
+++ b/Koha/Plugins.pm
@@ -19,12 +19,15 @@ package Koha::Plugins;
 
 use Modern::Perl;
 
+use Class::Inspector;
+use List::MoreUtils qw(any);
 use Module::Load::Conditional qw(can_load);
+use Module::Load qw(load);
 use Module::Pluggable search_path => ['Koha::Plugin'], except => qr/::Edifact(|::Line|::Message|::Order|::Segment|::Transport)$/;
-use List::MoreUtils qw( any );
 
 use C4::Context;
 use C4::Output;
+use Koha::Plugins::Methods;
 
 BEGIN {
     my $pluginsdir = C4::Context->config("pluginsdir");
@@ -67,9 +70,64 @@ If you pass multiple keys in the metadata hash, all keys must match.
 
 sub GetPlugins {
     my ( $self, $params ) = @_;
-    my $method = $params->{method};
+
+    my $method       = $params->{method};
     my $req_metadata = $params->{metadata} // {};
 
+    my $filter = ( $method ) ? { plugin_method => $method } : undef;
+
+    my $plugin_classes = Koha::Plugins::Methods->search(
+        $filter,
+        {   columns  => 'plugin_class',
+            distinct => 1
+        }
+    )->_resultset->get_column('plugin_class');
+
+    my @plugins;
+
+    # Loop through all plugins that implement at least a method
+    while ( my $plugin_class = $plugin_classes->next ) {
+
+        load $plugin_class;
+        my $plugin = $plugin_class->new({
+            enable_plugins => $self->{'enable_plugins'}
+                # loads even if plugins are disabled
+                # FIXME: is this for testing without bothering to mock config?
+        });
+
+        next unless $plugin->is_enabled or
+                    defined($params->{all}) && $params->{all};
+
+        # filter the plugin out by metadata
+        my $plugin_metadata = $plugin->get_metadata;
+        next
+            if $plugin_metadata
+            and %$req_metadata
+            and any { !$plugin_metadata->{$_} || $plugin_metadata->{$_} ne $req_metadata->{$_} } keys %$req_metadata;
+
+        push @plugins, $plugin;
+
+    }
+
+    return @plugins;
+}
+
+=head2 InstallPlugins
+
+Koha::Plugins::InstallPlugins()
+
+This method iterates through all plugins physically present on a system.
+For each plugin module found, it will test that the plugin can be loaded,
+and if it can, will store its available methods in the plugin_methods table.
+
+NOTE: We re-load all plugins here as a protective measure in case someone
+has removed a plugin directly from the system without using the UI
+
+=cut
+
+sub InstallPlugins {
+    my ( $self, $params ) = @_;
+
     my @plugin_classes = $self->plugins();
     my @plugins;
 
@@ -79,22 +137,17 @@ sub GetPlugins {
 
             my $plugin = $plugin_class->new({ enable_plugins => $self->{'enable_plugins'} });
 
-            my $plugin_enabled = $plugin->retrieve_data('__ENABLED__');
-            $plugin->{enabled} = $plugin_enabled;
+            Koha::Plugins::Methods->search({ plugin_class => $plugin_class })->delete();
 
-            # Want all plugins. Not only enabled ones.
-            if ( defined($params->{all}) && $params->{all} ) {
-                $plugin_enabled = 1;
+            foreach my $method ( @{ Class::Inspector->methods( $plugin_class, 'public' ) } ) {
+                Koha::Plugins::Method->new(
+                    {
+                        plugin_class  => $plugin_class,
+                        plugin_method => $method,
+                    }
+                )->store();
             }
 
-            next unless $plugin_enabled;
-
-            # Limit results by method or metadata
-            next if $method && !$plugin->can($method);
-            my $plugin_metadata = $plugin->get_metadata;
-            next if $plugin_metadata
-                and %$req_metadata
-                and any { !$plugin_metadata->{$_} || $plugin_metadata->{$_} ne $req_metadata->{$_} } keys %$req_metadata;
             push @plugins, $plugin;
         } else {
             my $error = $Module::Load::Conditional::ERROR;