Bug 31333: (QA follow-up) Simplify code

[koha-ffzg.git] / Koha / Patron / Category.pm

diff --git a/Koha/Patron/Category.pm b/Koha/Patron/Category.pm
index 39c56be..b700cb2 100644 (file)
--- a/Koha/Patron/Category.pm
+++ b/Koha/Patron/Category.pm
@@ -220,14 +220,13 @@ sub can_make_suggestions {
     my ( $self ) = @_;
 
     if ( C4::Context->preference('suggestion') ) {
-        my @patron_categories = split ',', C4::Context->preference('suggestionPatronCategoryExceptions');
-        if ( @patron_categories ) {
-            my $categorycode = $self->categorycode;
-            return if grep {$_ eq $categorycode } @patron_categories;
-        }
-        return 1;
+
+        my @patron_categories = split ',', C4::Context->preference('suggestionPatronCategoryExceptions') // q{};
+
+        return !any {$_ eq $self->categorycode } @patron_categories;
     }
-    return;
+
+    return 0;
 }
 
 =head2 Internal methods