Bug 25765: (QA follow-up) Save a DB hit

[srvgit] / Koha / Item.pm

diff --git a/Koha/Item.pm b/Koha/Item.pm
index 57fe8f1..9560a56 100644 (file)
--- a/Koha/Item.pm
+++ b/Koha/Item.pm
@@ -532,7 +532,7 @@ sub can_be_transferred {
 
 =head3 pickup_locations
 
-@pickup_locations = $item->pickup_locations( {patron => $patron } )
+$pickup_locations = $item->pickup_locations( {patron => $patron } )
 
 Returns possible pickup locations for this item, according to patron's home library (if patron is defined and holds are allowed only from hold groups)
 and if item can be transferred to each pickup location.
@@ -551,8 +551,8 @@ sub pickup_locations {
 
     my @libs;
     if(defined $patron) {
-        return @libs if $branchitemrule->{holdallowed} == 3 && !$self->home_branch->validate_hold_sibling( {branchcode => $patron->branchcode} );
-        return @libs if $branchitemrule->{holdallowed} == 1 && $self->home_branch->branchcode ne $patron->branchcode;
+        return \@libs if $branchitemrule->{holdallowed} == 3 && !$self->home_branch->validate_hold_sibling( {branchcode => $patron->branchcode} );
+        return \@libs if $branchitemrule->{holdallowed} == 1 && $self->home_branch->branchcode ne $patron->branchcode;
     }
 
     if ($branchitemrule->{hold_fulfillment_policy} eq 'holdgroup') {
@@ -581,7 +581,7 @@ sub pickup_locations {
         }
     }
 
-    return wantarray ? @pickup_locations : \@pickup_locations;
+    return \@pickup_locations;
 }
 
 =head3 article_request_type