Bug 29697: Replace GetMarcBiblio occurrences with $biblio->metadata->record

[srvgit] / Koha / BackgroundJob / BatchUpdateItem.pm

diff --git a/Koha/BackgroundJob/BatchUpdateItem.pm b/Koha/BackgroundJob/BatchUpdateItem.pm
index 8336b16..d01aed7 100644 (file)
--- a/Koha/BackgroundJob/BatchUpdateItem.pm
+++ b/Koha/BackgroundJob/BatchUpdateItem.pm
@@ -27,7 +27,6 @@ use MARC::Field;
 use C4::Biblio;
 use C4::Items;
 
-use Koha::BackgroundJobs;
 use Koha::DateUtils qw( dt_from_string );
 use Koha::SearchEngine::Indexer;
 use Koha::Items;
@@ -85,9 +84,7 @@ regex_mod allows to modify existing subfield's values using a regular expression
 sub process {
     my ( $self, $args ) = @_;
 
-    my $job = Koha::BackgroundJobs->find( $args->{job_id} );
-
-    if ( !exists $args->{job_id} || !$job || $job->status eq 'cancelled' ) {
+    if ( $self->status eq 'cancelled' ) {
         return;
     }
 
@@ -95,7 +92,7 @@ sub process {
     # Then we will start from scratch and so double process the same records
 
     my $job_progress = 0;
-    $job->started_on(dt_from_string)->progress($job_progress)
+    $self->started_on(dt_from_string)->progress($job_progress)
       ->status('started')->store;
 
     my @record_ids = @{ $args->{record_ids} };
@@ -106,7 +103,6 @@ sub process {
 
     my $report = {
         total_records            => scalar @record_ids,
-        modified_itemitemnumbers => [],
         modified_fields          => 0,
     };
 
@@ -121,7 +117,7 @@ sub process {
                   $exclude_from_local_holds_priority,
                 callback => sub {
                     my ($progress) = @_;
-                    $job->progress($progress)->store;
+                    $self->progress($progress)->store;
                 },
             }
           );
@@ -134,13 +130,13 @@ sub process {
           if ( $_ =~ /Rollback failed/ );    # Rollback failed
     };
 
-    $job->discard_changes;
-    my $job_data = decode_json encode_utf8 $job->data;
+    $self->discard_changes;
+    my $job_data = decode_json encode_utf8 $self->data;
     $job_data->{report} = $report;
 
-    $job->ended_on(dt_from_string)->data( encode_json $job_data);
-    $job->status('finished') if $job->status ne 'cancelled';
-    $job->store;
+    $self->ended_on(dt_from_string)->data( encode_json $job_data);
+    $self->status('finished') if $self->status ne 'cancelled';
+    $self->store;
 }
 
 =head3 enqueue
@@ -161,6 +157,7 @@ sub enqueue {
         {
             job_size => scalar @record_ids,
             job_args => {%$args},
+            queue    => 'long_tasks',
         }
     );
 }
@@ -174,17 +171,19 @@ Sent the infos to generate the table containing the details of the modified item
 sub additional_report {
     my ( $self, $args ) = @_;
 
-    my $job = Koha::BackgroundJobs->find( $args->{job_id} );
-
-    my $itemnumbers = $job->report->{modified_itemnumbers};
-    my $items_table =
-      Koha::UI::Table::Builder::Items->new( { itemnumbers => $itemnumbers } )
-      ->build_table;
-
-    return {
-        items            => $items_table->{items},
-        item_header_loop => $items_table->{headers},
-    };
+    my $itemnumbers = $self->report->{modified_itemnumbers};
+    if ( scalar(@$itemnumbers) > C4::Context->preference('MaxItemsToDisplayForBatchMod') ) {
+        return { too_many_items_display => 1 };
+    } else {
+        my $items_table =
+          Koha::UI::Table::Builder::Items->new( { itemnumbers => $itemnumbers } )
+          ->build_table;
+
+        return {
+            items            => $items_table->{items},
+            item_header_loop => $items_table->{headers},
+        };
+    }
 }
 
 1;