Bug 30952: Adjust colors of browse search

[koha-ffzg.git] / C4 / SIP / Sip.pm

diff --git a/C4/SIP/Sip.pm b/C4/SIP/Sip.pm
index 887a5c3..4d662a2 100644 (file)
--- a/C4/SIP/Sip.pm
+++ b/C4/SIP/Sip.pm
@@ -15,20 +15,20 @@ use List::Util qw(first);
 
 use C4::SIP::Sip::Constants qw(SIP_DATETIME FID_SCREEN_MSG);
 use C4::SIP::Sip::Checksum qw(checksum);
-use C4::SIP::Logger qw(get_logger);
+use C4::SIP::Logger qw( get_logger );
 
 use base qw(Exporter);
 
 our @EXPORT_OK = qw(y_or_n timestamp add_field maybe_add add_count
     denied sipbool boolspace write_msg
     $error_detection $protocol_version $field_delimiter
-    $last_response syslog);
+    $last_response siplog);
 
 our %EXPORT_TAGS = (
     all => [qw(y_or_n timestamp add_field maybe_add
         add_count denied sipbool boolspace write_msg
         $error_detection $protocol_version
-        $field_delimiter $last_response syslog)]);
+        $field_delimiter $last_response siplog)]);
 
 our $error_detection = 0;
 our $protocol_version = 1;
@@ -68,9 +68,9 @@ sub add_field {
     my ($i, $ent);
 
     if (!defined($value)) {
-       syslog("LOG_DEBUG", "add_field: Undefined value being added to '%s'",
-              $field_id);
-               $value = '';
+    siplog("LOG_DEBUG", "add_field: Undefined value being added to '%s'",
+           $field_id);
+        $value = '';
     }
     $value=~s/\r/ /g; # CR terminates a sip message
                       # Protect against them in sip text fields
@@ -80,7 +80,7 @@ sub add_field {
     $ent = sprintf("&#%d;", ord($field_delimiter));
 
     while (($i = index($value, $field_delimiter)) != ($[-1)) {
-               substr($value, $i, 1) = $ent;
+        substr($value, $i, 1) = $ent;
     }
 
     return $field_id . $value . $field_delimiter;
@@ -99,7 +99,7 @@ sub maybe_add {
         return q{} if first { $_ eq $fid } @fields;
     }
 
-    if ( $fid eq FID_SCREEN_MSG && $server->{account}->{screen_msg_regex} ) {
+    if ( $fid eq FID_SCREEN_MSG && $server->{account}->{screen_msg_regex} && defined($value)) {
         foreach my $regex (
             ref $server->{account}->{screen_msg_regex} eq "ARRAY"
             ? @{ $server->{account}->{screen_msg_regex} }
@@ -108,7 +108,10 @@ sub maybe_add {
             $value =~ s/$regex->{find}/$regex->{replace}/g;
         }
     }
-    return (defined($value) && $value) ? add_field($fid, $value) : '';
+
+    return ( defined($value) && length($value) )
+      ? add_field( $fid, $value )
+      : '';
 }
 
 #
@@ -122,14 +125,14 @@ sub add_count {
     # If the field is unsupported, it will be undef, return blanks
     # as per the spec.
     if (!defined($count)) {
-               return ' ' x 4;
+        return ' ' x 4;
     }
 
     $count = sprintf("%04d", $count);
     if (length($count) != 4) {
-               syslog("LOG_WARNING", "handle_patron_info: %s wrong size: '%s'",
-              $label, $count);
-               $count = ' ' x 4;
+        siplog("LOG_WARNING", "handle_patron_info: %s wrong size: '%s'",
+           $label, $count);
+        $count = ' ' x 4;
     }
     return $count;
 }
@@ -198,13 +201,13 @@ sub write_msg {
     } else {
         STDOUT->autoflush(1);
         print $msg, $terminator;
-        syslog("LOG_INFO", "OUTPUT MSG: '$msg'");
+        siplog("LOG_INFO", "OUTPUT MSG: '$msg'");
     }
 
     $last_response = $msg;
 }
 
-sub syslog {
+sub siplog {
     my ( $level, $mask, @args ) = @_;
 
     my $method =