use C4::SIP::Sip::Constants qw(SIP_DATETIME FID_SCREEN_MSG);
use C4::SIP::Sip::Checksum qw(checksum);
-use C4::SIP::Logger qw(get_logger);
+use C4::SIP::Logger qw( get_logger );
use base qw(Exporter);
my ($i, $ent);
if (!defined($value)) {
- siplog("LOG_DEBUG", "add_field: Undefined value being added to '%s'",
- $field_id);
- $value = '';
+ siplog("LOG_DEBUG", "add_field: Undefined value being added to '%s'",
+ $field_id);
+ $value = '';
}
$value=~s/\r/ /g; # CR terminates a sip message
# Protect against them in sip text fields
$ent = sprintf("&#%d;", ord($field_delimiter));
while (($i = index($value, $field_delimiter)) != ($[-1)) {
- substr($value, $i, 1) = $ent;
+ substr($value, $i, 1) = $ent;
}
return $field_id . $value . $field_delimiter;
return q{} if first { $_ eq $fid } @fields;
}
- if ( $fid eq FID_SCREEN_MSG && $server->{account}->{screen_msg_regex} ) {
+ if ( $fid eq FID_SCREEN_MSG && $server->{account}->{screen_msg_regex} && defined($value)) {
foreach my $regex (
ref $server->{account}->{screen_msg_regex} eq "ARRAY"
? @{ $server->{account}->{screen_msg_regex} }
$value =~ s/$regex->{find}/$regex->{replace}/g;
}
}
- return (defined($value) && $value) ? add_field($fid, $value) : '';
+
+ return ( defined($value) && length($value) )
+ ? add_field( $fid, $value )
+ : '';
}
#
# If the field is unsupported, it will be undef, return blanks
# as per the spec.
if (!defined($count)) {
- return ' ' x 4;
+ return ' ' x 4;
}
$count = sprintf("%04d", $count);
if (length($count) != 4) {
- siplog("LOG_WARNING", "handle_patron_info: %s wrong size: '%s'",
- $label, $count);
- $count = ' ' x 4;
+ siplog("LOG_WARNING", "handle_patron_info: %s wrong size: '%s'",
+ $label, $count);
+ $count = ' ' x 4;
}
return $count;
}