Deleting Date::Manip

[koha_fer] / C4 / Reserves.pm

diff --git a/C4/Reserves.pm b/C4/Reserves.pm
index d9ffea3..f9f9747 100755 (executable)
--- a/C4/Reserves.pm
+++ b/C4/Reserves.pm
@@ -29,7 +29,8 @@ use C4::Biblio;
 use C4::Search;
 use C4::Circulation;
 
-use vars qw($VERSION @ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);
+our ($VERSION,@ISA,@EXPORT,@EXPORT_OK,%EXPORT_TAGS);
+
 my $library_name = C4::Context->preference("LibraryName");
 
 # set the version for version checking
@@ -45,7 +46,7 @@ C4::Reserves - Koha functions for dealing with reservation.
 
 =head1 DESCRIPTION
 
-this modules provides somes functions to deal with reservations.
+  this modules provides somes functions to deal with reservations.
 
 =head1 FUNCTIONS
 
@@ -61,12 +62,12 @@ this modules provides somes functions to deal with reservations.
   &GetReservesFromItemnumber
   &GetReservesFromBiblionumber
   &GetReservesFromBorrowernumber
-  GetReservesForBranch
-  GetReservesToBranch
+  &GetReservesForBranch
+  &GetReservesToBranch
   &GetReserveCount
   &GetReserveFee
-  GetReservesForBranch
-  GetReservesToBranch
+  &GetReservesForBranch
+  &GetReservesToBranch
   &GetOtherReserves
   
   &ModReserveFill
@@ -83,7 +84,7 @@ this modules provides somes functions to deal with reservations.
 
 =item AddReserve
 
-AddReserve($branch,$borrowernumber,$biblionumber,$constraint,$bibitems,$priority,$notes,$title,$checkitem,$found)
+    AddReserve($branch,$borrowernumber,$biblionumber,$constraint,$bibitems,$priority,$notes,$title,$checkitem,$found)
 
 =cut
 
@@ -245,6 +246,14 @@ sub GetReservesFromBiblionumber {
     return ( $#results + 1, \@results );
 }
 
+=item GetReservesFromItemnumber
+
+ ( $reservedate, $borrowernumber, $branchcode ) = GetReservesFromItemnumber($itemnumber);
+
+   TODO :: Description here
+
+=cut
+
 sub GetReservesFromItemnumber {
     my ( $itemnumber ) = @_;
     my $dbh   = C4::Context->dbh;
@@ -261,6 +270,14 @@ sub GetReservesFromItemnumber {
     return ( $reservedate, $borrowernumber, $branchcode );
 }
 
+=item GetReservesFromBorrowernumber
+
+    $borrowerreserv = GetReservesFromBorrowernumber($borrowernumber,$tatus);
+    
+    TODO :: Descritpion
+    
+=cut
+
 sub GetReservesFromBorrowernumber {
     my ( $borrowernumber, $status ) = @_;
     my $dbh   = C4::Context->dbh;
@@ -286,11 +303,8 @@ sub GetReservesFromBorrowernumber {
         ");
         $sth->execute($borrowernumber);
     }
-    my @borrowerreserv;
-    while ( my $data = $sth->fetchrow_hashref ) {
-        push @borrowerreserv, $data;
-    }
-    return @borrowerreserv;
+    my $data = $sth->fetchall_arrayref({});
+    return @$data;
 }
 #-------------------------------------------------------------------------------------
 
@@ -372,6 +386,14 @@ sub GetOtherReserves {
     return ( $messages, $nextreservinfo );
 }
 
+=item GetReserveFee
+
+$fee = GetReserveFee($borrowernumber,$biblionumber,$constraint,$biblionumber);
+
+Calculate the fee for a reserve
+
+=cut
+
 sub GetReserveFee {
     my ($borrowernumber, $biblionumber, $constraint, $bibitems ) = @_;
 
@@ -466,12 +488,10 @@ sub GetReserveFee {
             }
         }
     }
-
-    #  print "fee $fee";
     return $fee;
 }
 
-=head2 GetReservesToBranch
+=item GetReservesToBranch
 
 @transreserv = GetReservesToBranch( $frombranch );
 
@@ -500,7 +520,7 @@ sub GetReservesToBranch {
     return (@transreserv);
 }
 
-=head2 GetReservesForBranch
+=item GetReservesForBranch
 
 @transreserv = GetReservesForBranch($frombranch);
 
@@ -1091,14 +1111,6 @@ sub _Findgroupreserve {
     return @results;
 }
 
-=item GetReserveFee
-
-$fee = GetReserveFee($borrowernumber,$biblionumber,$constraint,$biblionumber);
-
-Calculate the fee for a reserve
-
-=cut
-
 =back
 
 =head1 AUTHOR