# Copyright 2000-2002 Katipo Communications
+# copyright 2010 BibLibre
#
# This file is part of Koha.
#
# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
#
-# You should have received a copy of the GNU General Public License along with
-# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
-# Suite 330, Boston, MA 02111-1307 USA
+# You should have received a copy of the GNU General Public License along
+# with Koha; if not, write to the Free Software Foundation, Inc.,
+# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
use strict;
+#use warnings; FIXME - Bug 2505
use Date::Calc qw/Today Date_to_Days/;
use Date::Manip qw/UnixDate/;
use C4::Circulation;
SELECT issues.*, items.itype as itemtype, items.homebranch, items.barcode
FROM issues
LEFT JOIN items USING (itemnumber)
- WHERE date_due < now()
+ WHERE date_due < CURDATE()
";
} else {
$statement = "
FROM issues
LEFT JOIN items USING (itemnumber)
LEFT JOIN biblioitems USING (biblioitemnumber)
- WHERE date_due < now()
+ WHERE date_due < CURDATE()
";
}
=head2 checkoverdues
-($count, $overdueitems) = checkoverdues($borrowernumber);
+ ($count, $overdueitems) = checkoverdues($borrowernumber);
Returns a count and a list of overdueitems for a given borrowernumber
LEFT JOIN biblio ON items.biblionumber = biblio.biblionumber
LEFT JOIN biblioitems ON items.biblioitemnumber = biblioitems.biblioitemnumber
WHERE issues.borrowernumber = ?
- AND issues.date_due < NOW()"
+ AND issues.date_due < CURDATE()"
);
# FIXME: SELECT * across 4 tables? do we really need the marc AND marcxml blobs??
$sth->execute($borrowernumber);
=head2 CalcFine
- ($amount, $chargename, $daycount, $daycounttotal) =
- &CalcFine($item, $categorycode, $branch, $days_overdue, $description, $start_date, $end_date );
+ ($amount, $chargename, $daycount, $daycounttotal) = &CalcFine($item,
+ $categorycode, $branch, $days_overdue,
+ $description, $start_date, $end_date );
Calculates the fine for a book.
=head2 GetSpecialHolidays
-&GetSpecialHolidays($date_dues,$itemnumber);
+ &GetSpecialHolidays($date_dues,$itemnumber);
return number of special days between date of the day and date due
=head2 GetRepeatableHolidays
-&GetRepeatableHolidays($date_dues, $itemnumber, $difference,);
+ &GetRepeatableHolidays($date_dues, $itemnumber, $difference,);
return number of day closed between date of the day and date due
=head2 GetWayFromItemnumber
-&Getwdayfromitemnumber($itemnumber);
+ &Getwdayfromitemnumber($itemnumber);
return the different week day from repeatable_holidays table
=head2 GetIssuesIteminfo
-&GetIssuesIteminfo($itemnumber);
+ &GetIssuesIteminfo($itemnumber);
return all data from issues about item
=head2 UpdateFine
- &UpdateFine($itemnumber, $borrowernumber, $amount, $type, $description);
+ &UpdateFine($itemnumber, $borrowernumber, $amount, $type, $description);
(Note: the following is mostly conjecture and guesswork.)
if ( my $data = $sth->fetchrow_hashref ) {
- # we're updating an existing fine. Only modify if we're adding to the charge.
+ # we're updating an existing fine. Only modify if amount changed
# Note that in the current implementation, you cannot pay against an accruing fine
# (i.e. , of accounttype 'FU'). Doing so will break accrual.
if ( $data->{'amount'} != $amount ) {
my $diff = $amount - $data->{'amount'};
- $diff = 0 if ( $data->{amount} > $amount);
+ #3341: diff could be positive or negative!
my $out = $data->{'amountoutstanding'} + $diff;
my $query = "
UPDATE accountlines
=head2 BorType
- $borrower = &BorType($borrowernumber);
+ $borrower = &BorType($borrowernumber);
Looks up a patron by borrower number.
=head2 ReplacementCost
- $cost = &ReplacementCost($itemnumber);
+ $cost = &ReplacementCost($itemnumber);
Returns the replacement cost of the item with the given item number.
=head2 GetFine
-$data->{'sum(amountoutstanding)'} = &GetFine($itemnum,$borrowernumber);
+ $data->{'sum(amountoutstanding)'} = &GetFine($itemnum,$borrowernumber);
return the total of fine
FIXME - This sub should be deprecated and removed.
It ignores branch and defaults.
-$data = &GetIssuingRules($itemtype,$categorycode);
+ $data = &GetIssuingRules($itemtype,$categorycode);
Looks up for all issuingrules an item info
=head2 GetNextIdNotify
-($result) = &GetNextIdNotify($reference);
+ ($result) = &GetNextIdNotify($reference);
Returns the new file number
=head2 NumberNotifyId
-(@notify) = &NumberNotifyId($borrowernumber);
+ (@notify) = &NumberNotifyId($borrowernumber);
Returns amount for all file per borrowers
C<@notify> array contains all file per borrowers
=head2 AmountNotify
-($totalnotify) = &AmountNotify($notifyid);
+ ($totalnotify) = &AmountNotify($notifyid);
Returns amount for all file per borrowers
C<$notifyid> is the file number
=head2 GetNotifyId
-($notify_id) = &GetNotifyId($borrowernumber,$itemnumber);
+ ($notify_id) = &GetNotifyId($borrowernumber,$itemnumber);
Returns the file number per borrower and itemnumber
=head2 CreateItemAccountLine
-() = &CreateItemAccountLine($borrowernumber,$itemnumber,$date,$amount,$description,$accounttype,$amountoutstanding,$timestamp,$notify_id,$level);
+ () = &CreateItemAccountLine($borrowernumber, $itemnumber, $date, $amount,
+ $description, $accounttype, $amountoutstanding,
+ $timestamp, $notify_id, $level);
update the account lines with file number or with file level
=head2 UpdateAccountLines
-() = &UpdateAccountLines($notify_id,$notify_level,$borrowernumber,$itemnumber);
+ () = &UpdateAccountLines($notify_id,$notify_level,$borrowernumber,$itemnumber);
update the account lines with file number or with file level
=head2 GetItems
-($items) = &GetItems($itemnumber);
+ ($items) = &GetItems($itemnumber);
Returns the list of all delays from overduerules.
=head2 GetOverdueDelays
-(@delays) = &GetOverdueDelays($categorycode);
+ (@delays) = &GetOverdueDelays($categorycode);
Returns the list of all delays from overduerules.
=head2 GetBranchcodesWithOverdueRules
-=over 4
-
-my @branchcodes = C4::Overdues::GetBranchcodesWithOverdueRules()
+ my @branchcodes = C4::Overdues::GetBranchcodesWithOverdueRules()
returns a list of branch codes for branches with overdue rules defined.
-=back
-
=cut
sub GetBranchcodesWithOverdueRules {
my $dbh = C4::Context->dbh;
- my $rqoverduebranches = $dbh->prepare("SELECT DISTINCT branchcode FROM overduerules WHERE delay1 IS NOT NULL AND branchcode <> ''");
+ my $rqoverduebranches = $dbh->prepare("SELECT DISTINCT branchcode FROM overduerules WHERE delay1 IS NOT NULL AND branchcode <> '' ORDER BY branchcode");
$rqoverduebranches->execute;
my @branches = map { shift @$_ } @{ $rqoverduebranches->fetchall_arrayref };
+ if (!$branches[0]) {
+ my $availbranches = C4::Branch::GetBranches();
+ @branches = keys %$availbranches;
+ }
return @branches;
}
=head2 CheckAccountLineLevelInfo
-($exist) = &CheckAccountLineLevelInfo($borrowernumber,$itemnumber,$accounttype,notify_level);
+ ($exist) = &CheckAccountLineLevelInfo($borrowernumber,$itemnumber,$accounttype,notify_level);
Check and Returns the list of all overdue books.
=head2 GetOverduerules
-($overduerules) = &GetOverduerules($categorycode);
+ ($overduerules) = &GetOverduerules($categorycode);
Returns the value of borrowers (debarred or not) with notify level
=head2 CheckBorrowerDebarred
-($debarredstatus) = &CheckBorrowerDebarred($borrowernumber);
+ ($debarredstatus) = &CheckBorrowerDebarred($borrowernumber);
Check if the borrowers is already debarred
=head2 UpdateBorrowerDebarred
-($borrowerstatut) = &UpdateBorrowerDebarred($borrowernumber);
+ ($borrowerstatut) = &UpdateBorrowerDebarred($borrowernumber);
update status of borrowers in borrowers table (field debarred)
=head2 CheckExistantNotifyid
- ($exist) = &CheckExistantNotifyid($borrowernumber,$itemnumber,$accounttype,$notify_id);
+ ($exist) = &CheckExistantNotifyid($borrowernumber,$itemnumber,$accounttype,$notify_id);
Check and Returns the notify id if exist else return 0.
=head2 CheckAccountLineItemInfo
- ($exist) = &CheckAccountLineItemInfo($borrowernumber,$itemnumber,$accounttype,$notify_id);
+ ($exist) = &CheckAccountLineItemInfo($borrowernumber,$itemnumber,$accounttype,$notify_id);
Check and Returns the list of all overdue items from the same file number(notify_id).
borrowers.phone,
borrowers.email,
biblio.title,
+ biblio.author,
biblio.biblionumber,
issues.date_due,
issues.returndate,
issues.branchcode,
branches.branchname,
items.barcode,
+ items.homebranch,
items.itemcallnumber,
items.location,
items.itemnumber,
WHERE (accountlines.amountoutstanding != '0.000000')
AND (accountlines.accounttype = 'FU' )
AND (issues.branchcode = ? )
- AND (issues.date_due <= NOW())
+ AND (issues.date_due < CURDATE())
";
my @getoverdues;
my $i = 0;
=head2 AddNotifyLine
-&AddNotifyLine($borrowernumber, $itemnumber, $overduelevel, $method, $notifyId)
+ &AddNotifyLine($borrowernumber, $itemnumber, $overduelevel, $method, $notifyId)
-Creat a line into notify, if the method is phone, the notification_send_date is implemented to
+Create a line into notify, if the method is phone, the notification_send_date is implemented to
=cut
=head2 RemoveNotifyLine
-&RemoveNotifyLine( $borrowernumber, $itemnumber, $notify_date );
+ &RemoveNotifyLine( $borrowernumber, $itemnumber, $notify_date );
Cancel a notification
=head1 AUTHOR
-Koha Developement team <info@koha.org>
+Koha Development Team <http://koha-community.org/>
=cut