Bug 14687: Patron's transaction history changes items' order after paying fines.

[koha-ffzg.git] / C4 / Letters.pm

diff --git a/C4/Letters.pm b/C4/Letters.pm
index 764f238..bc60bc3 100644 (file)
--- a/C4/Letters.pm
+++ b/C4/Letters.pm
@@ -35,6 +35,7 @@ use Date::Calc qw( Add_Delta_Days );
 use Encode;
 use Carp;
 use Koha::Email;
+use Koha::DateUtils qw( format_sqldatetime );
 
 use vars qw($VERSION @ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);
 
@@ -799,26 +800,17 @@ sub _parseletter {
     my ( $letter, $table, $values ) = @_;
 
     if ( $table eq 'borrowers' && $values->{'dateexpiry'} ){
-        my @dateexpiry = split /-/, $values->{'dateexpiry'};
-
-        $values->{'dateexpiry'} = C4::Dates->new(
-            sprintf(
-                '%04d-%02d-%02d',
-                Add_Delta_Days( @dateexpiry,0)
-            ),
-            'iso'
-        )->output();
+        $values->{'dateexpiry'} = format_sqldatetime( $values->{'dateexpiry'} );
     }
 
     if ( $table eq 'reserves' && $values->{'waitingdate'} ) {
         my @waitingdate = split /-/, $values->{'waitingdate'};
 
         $values->{'expirationdate'} = '';
-        if( C4::Context->preference('ExpireReservesMaxPickUpDelay') &&
-        C4::Context->preference('ReservesMaxPickUpDelay') ) {
+        if ( C4::Context->preference('ReservesMaxPickUpDelay') ) {
             my $dt = dt_from_string();
             $dt->add( days => C4::Context->preference('ReservesMaxPickUpDelay') );
-            $values->{'expirationdate'} = output_pref({ dt => $dt, dateonly => 1 });
+            $values->{'expirationdate'} = output_pref( { dt => $dt, dateonly => 1 } );
         }
 
         $values->{'waitingdate'} = output_pref({ dt => dt_from_string( $values->{'waitingdate'} ), dateonly => 1 });