use DateTime::Format::MySQL;
use Data::Dumper; # used as part of logging item record changes, not just for
# debugging; so please don't remove this
+
+use Koha::AuthorisedValues;
use Koha::DateUtils qw/dt_from_string/;
use Koha::Database;
use Koha::Items;
use Koha::SearchEngine;
use Koha::SearchEngine::Search;
+use Koha::Libraries;
use vars qw(@ISA @EXPORT);
=cut
sub AddItem {
- my $item = shift;
+ my $item = shift;
my $biblionumber = shift;
my $dbh = @_ ? shift : C4::Context->dbh;
- my $frameworkcode = @_ ? shift : GetFrameworkCode( $biblionumber );
- my $unlinked_item_subfields;
+ my $frameworkcode = @_ ? shift : GetFrameworkCode($biblionumber);
+ my $unlinked_item_subfields;
if (@_) {
- $unlinked_item_subfields = shift
- };
+ $unlinked_item_subfields = shift;
+ }
# needs old biblionumber and biblioitemnumber
$item->{'biblionumber'} = $biblionumber;
my $sth = $dbh->prepare("SELECT biblioitemnumber FROM biblioitems WHERE biblionumber=?");
$sth->execute( $item->{'biblionumber'} );
- ($item->{'biblioitemnumber'}) = $sth->fetchrow;
+ ( $item->{'biblioitemnumber'} ) = $sth->fetchrow;
_set_defaults_for_add($item);
_set_derived_columns_for_add($item);
$item->{'more_subfields_xml'} = _get_unlinked_subfields_xml($unlinked_item_subfields);
+
# FIXME - checks here
- unless ( $item->{itype} ) { # default to biblioitem.itemtype if no itype
+ unless ( $item->{itype} ) { # default to biblioitem.itemtype if no itype
my $itype_sth = $dbh->prepare("SELECT itemtype FROM biblioitems WHERE biblionumber = ?");
$itype_sth->execute( $item->{'biblionumber'} );
( $item->{'itype'} ) = $itype_sth->fetchrow_array;
}
- my ( $itemnumber, $error ) = _koha_new_item( $item, $item->{barcode} );
+ my ( $itemnumber, $error ) = _koha_new_item( $item, $item->{barcode} );
+ return if $error;
+
$item->{'itemnumber'} = $itemnumber;
ModZebra( $item->{biblionumber}, "specialUpdate", "biblioserver" );
-
- logaction("CATALOGUING", "ADD", $itemnumber, "item") if C4::Context->preference("CataloguingLog");
-
- return ($item->{biblionumber}, $item->{biblioitemnumber}, $itemnumber);
+
+ logaction( "CATALOGUING", "ADD", $itemnumber, "item" )
+ if C4::Context->preference("CataloguingLog");
+
+ return ( $item->{biblionumber}, $item->{biblioitemnumber}, $itemnumber );
}
=head2 AddItemBatchFromMarc
This API assumes that the bib record has already been
saved to the C<biblio> and C<biblioitems> tables. It does
-not expect that C<biblioitems.marc> and C<biblioitems.marcxml>
-are populated, but it will do so via a call to ModBibiloMarc.
+not expect that C<biblioitems.marcxml> are populated, but it
+will do so via a call to ModBibiloMarc.
The goal of this API is to have a similar effect to using AddBiblio
and AddItems in succession, but without inefficient repeated
sub _build_default_values_for_mod_marc {
my ($frameworkcode) = @_;
- my $cache = Koha::Cache->get_instance();
+ my $cache = Koha::Caches->get_instance();
my $cache_key = "default_value_for_mod_marc-$frameworkcode";
my $cached = $cache->get_from_cache($cache_key);
return $cached if $cached;
sub CheckItemPreSave {
my $item_ref = shift;
- require C4::Branch;
my %errors = ();
# check for valid home branch
if (exists $item_ref->{'homebranch'} and defined $item_ref->{'homebranch'}) {
- my $branch_name = C4::Branch::GetBranchName($item_ref->{'homebranch'});
- unless (defined $branch_name) {
- # relies on fact that branches.branchname is a non-NULL column,
- # so GetBranchName returns undef only if branch does not exist
+ my $home_library = Koha::Libraries->find( $item_ref->{homebranch} );
+ unless (defined $home_library) {
$errors{'invalid_homebranch'} = $item_ref->{'homebranch'};
}
}
# check for valid holding branch
if (exists $item_ref->{'holdingbranch'} and defined $item_ref->{'holdingbranch'}) {
- my $branch_name = C4::Branch::GetBranchName($item_ref->{'holdingbranch'});
- unless (defined $branch_name) {
- # relies on fact that branches.branchname is a non-NULL column,
- # so GetBranchName returns undef only if branch does not exist
+ my $holding_library = Koha::Libraries->find( $item_ref->{holdingbranch} );
+ unless (defined $holding_library) {
$errors{'invalid_holdingbranch'} = $item_ref->{'holdingbranch'};
}
}
$itemstatus{$authorisedvalue} = $lib;
}
return \%itemstatus;
- exit 1;
}
else {
$itemlocation{$authorisedvalue} = $lib;
}
return \%itemlocation;
- exit 1;
}
else {
COALESCE( localization.translation, itemtypes.description ) AS translated_description,
itemtypes.notforloan as notforloan_per_itemtype,
holding.branchurl,
+ holding.branchcode,
holding.branchname,
holding.opac_info as holding_branch_opac_info,
home.opac_info as home_branch_opac_info
$serial ||= $data->{'serial'};
+ my $av;
# get notforloan complete status if applicable
- if ( my $code = C4::Koha::GetAuthValCode( 'items.notforloan', $data->{frameworkcode} ) ) {
- $data->{notforloanvalue} = C4::Koha::GetKohaAuthorisedValueLib( $code, $data->{itemnotforloan} );
- $data->{notforloanvalueopac} = C4::Koha::GetKohaAuthorisedValueLib( $code, $data->{itemnotforloan}, 1 );
- }
+ $av = Koha::AuthorisedValues->search_by_koha_field({frameworkcode => $data->{frameworkcode}, kohafield => 'items.notforloan', authorised_value => $data->{itemnotforloan} });
+ $av = $av->count ? $av->next : undef;
+ $data->{notforloanvalue} = $av ? $av->lib : '';
+ $data->{notforloanvalueopac} = $av ? $av->opac_description : '';
# get restricted status and description if applicable
- if ( my $code = C4::Koha::GetAuthValCode( 'items.restricted', $data->{frameworkcode} ) ) {
- $data->{restrictedopac} = C4::Koha::GetKohaAuthorisedValueLib( $code, $data->{restricted}, 1 );
- $data->{restricted} = C4::Koha::GetKohaAuthorisedValueLib( $code, $data->{restricted} );
- }
+ $av = Koha::AuthorisedValues->search_by_koha_field({frameworkcode => $data->{frameworkcode}, kohafield => 'items.restricted', authorised_value => $data->{restricted} });
+ $av = $av->count ? $av->next : undef;
+ $data->{restricted} = $av ? $av->lib : '';
+ $data->{restrictedopac} = $av ? $av->opac_description : '';
# my stack procedures
- if ( my $code = C4::Koha::GetAuthValCode( 'items.stack', $data->{frameworkcode} ) ) {
- $data->{stack} = C4::Koha::GetKohaAuthorisedValueLib( $code, $data->{stack} );
- }
+ $av = Koha::AuthorisedValues->search_by_koha_field({frameworkcode => $data->{frameworkcode}, kohafield => 'items.stack', authorised_value => $data->{stack} });
+ $data->{stack} = $av->count ? $av->next->lib : '';
# Find the last 3 people who borrowed this item.
my $sth2 = $dbh->prepare("SELECT * FROM old_issues,borrowers
$sth->execute($biblionumber);
while ( my $data = $sth->fetchrow_hashref ) {
- $data->{location_intranet} = GetKohaAuthorisedValueLib('LOC', $data->{location});
- $data->{location_opac}= GetKohaAuthorisedValueLib('LOC', $data->{location}, 1);
+ my $av = Koha::AuthorisedValues->search({ category => 'LOC', authorised_value => $data->{location} });
+ $av = $av->count ? $av->next : undef;
+ $data->{location_intranet} = $av ? $av->lib : '';
+ $data->{location_opac} = $av ? $av->opac_description : '';
push @results, $data;
}
return @results;
sub get_hostitemnumbers_of {
- my ($biblionumber) = @_;
- my $marcrecord = GetMarcBiblio($biblionumber);
- my (@returnhostitemnumbers,$tag, $biblio_s, $item_s);
-
- my $marcflavor = C4::Context->preference('marcflavour');
- if ($marcflavor eq 'MARC21' || $marcflavor eq 'NORMARC') {
- $tag='773';
- $biblio_s='0';
- $item_s='9';
- } elsif ($marcflavor eq 'UNIMARC') {
- $tag='461';
- $biblio_s='0';
- $item_s='9';
+ my ($biblionumber) = @_;
+ my $marcrecord = GetMarcBiblio($biblionumber);
+
+ return unless $marcrecord;
+
+ my ( @returnhostitemnumbers, $tag, $biblio_s, $item_s );
+
+ my $marcflavor = C4::Context->preference('marcflavour');
+ if ( $marcflavor eq 'MARC21' || $marcflavor eq 'NORMARC' ) {
+ $tag = '773';
+ $biblio_s = '0';
+ $item_s = '9';
+ }
+ elsif ( $marcflavor eq 'UNIMARC' ) {
+ $tag = '461';
+ $biblio_s = '0';
+ $item_s = '9';
}
foreach my $hostfield ( $marcrecord->field($tag) ) {
my $hostbiblionumber = $hostfield->subfield($biblio_s);
my $linkeditemnumber = $hostfield->subfield($item_s);
my @itemnumbers;
- if (my $itemnumbers = get_itemnumbers_of($hostbiblionumber)->{$hostbiblionumber})
+ if ( my $itemnumbers =
+ get_itemnumbers_of($hostbiblionumber)->{$hostbiblionumber} )
{
@itemnumbers = @$itemnumbers;
}
- foreach my $itemnumber (@itemnumbers){
- if ($itemnumber eq $linkeditemnumber){
- push (@returnhostitemnumbers,$itemnumber);
+ foreach my $itemnumber (@itemnumbers) {
+ if ( $itemnumber eq $linkeditemnumber ) {
+ push( @returnhostitemnumbers, $itemnumber );
last;
}
}
}
+
return @returnhostitemnumbers;
}
=head2 ItemSafeToDelete
- ItemSafeToDelete($dbh, $biblionumber, $itemnumber);
+ ItemSafeToDelete( $biblionumber, $itemnumber);
Exported function (core API) for checking whether an item record is safe to delete.
=cut
sub ItemSafeToDelete {
- my ( $dbh, $biblionumber, $itemnumber ) = @_;
+ my ( $biblionumber, $itemnumber ) = @_;
my $status;
- $dbh ||= C4::Context->dbh;
+ my $dbh = C4::Context->dbh;
my $error;
=head2 DelItemCheck
- DelItemCheck($dbh, $biblionumber, $itemnumber);
+ DelItemCheck( $biblionumber, $itemnumber);
Exported function (core API) for deleting an item record in Koha if there no current issue.
DelItemCheck wraps ItemSafeToDelete around DelItem.
-It takes a database handle, biblionumber and itemnumber as arguments, and can optionally take a hashref with a 'do_not_commit' flag:
-
- DelItemCheck( $dbh, $biblionumber, $itemnumber, { do_not_commit => 1 } );
-
-This is done so that command line scripts calling DelItemCheck have the option of doing a 'dry-run'.
=cut
sub DelItemCheck {
- my ( $dbh, $biblionumber, $itemnumber, $options ) = @_;
- my $commit = ( defined $options && $options->{do_not_commit} eq 1 ) ? 0 : 1;
- my $status = ItemSafeToDelete( $dbh, $biblionumber, $itemnumber );
+ my ( $biblionumber, $itemnumber ) = @_;
+ my $status = ItemSafeToDelete( $biblionumber, $itemnumber );
- if ( $status == 1 && $commit ) {
+ if ( $status == 1 ) {
DelItem(
{
biblionumber => $biblionumber,
my $original_item_marc = shift;
my $frameworkcode = shift;
- my $marcstructure = GetMarcStructure(1, $frameworkcode);
+ my $marcstructure = GetMarcStructure(1, $frameworkcode, { unsafe => 1 });
# assume that this record has only one field, and that that
# field contains only the item information
my $dbh = C4::Context->dbh;
$frameworkcode = &GetFrameworkCode($bibnum) if $bibnum;
my ( $itemtagfield, $itemtagsubfield ) = &GetMarcFromKohaField( "items.itemnumber", $frameworkcode );
- my $tagslib = &GetMarcStructure( 1, $frameworkcode );
+
+ # Note: $tagslib obtained from GetMarcStructure() in 'unsafe' mode is
+ # a shared data structure. No plugin (including custom ones) should change
+ # its contents. See also GetMarcStructure.
+ my $tagslib = &GetMarcStructure( 1, $frameworkcode, { unsafe => 1 } );
# return nothing if we don't have found an existing framework.
return q{} unless $tagslib;
$query .= qq{ ORDER BY lib};
my $authorised_values_sth = $dbh->prepare( $query );
foreach my $tag ( sort keys %{$tagslib} ) {
- my $previous_tag = '';
if ( $tag ne '' ) {
# loop through each subfield
my $cntsubf;
foreach my $subfield ( sort keys %{ $tagslib->{$tag} } ) {
next if IsMarcStructureInternal($tagslib->{$tag}{$subfield});
+ next unless ( $tagslib->{$tag}->{$subfield}->{'tab'} );
next if ( $tagslib->{$tag}->{$subfield}->{'tab'} ne "10" );
my %subfield_data;
$subfield_data{tag} = $tag;
push @authorised_values, $itemtype->{itemtype};
$authorised_lib{$itemtype->{itemtype}} = $itemtype->{translated_description};
}
+ if ($defaultvalues && $defaultvalues->{'itemtype'}) {
+ $defaultvalue = $defaultvalues->{'itemtype'};
+ }
+
#---- class_sources
} elsif ( $tagslib->{$tag}->{$subfield}->{authorised_value} eq "cn_source" ) {
push @authorised_values, "" unless ( $tagslib->{$tag}->{$subfield}->{mandatory} );
projects / srvgit / blobdiff