# item status is possible
ModZebra( $biblionumber, "specialUpdate", "biblioserver" );
- logaction("CATALOGUING", "MODIFY", $itemnumber, Dumper($item)) if C4::Context->preference("CataloguingLog");
+ logaction("CATALOGUING", "MODIFY", $itemnumber, "item ".Dumper($item)) if C4::Context->preference("CataloguingLog");
}
=head2 ModItemTransfer
$datedue = $idata->{'date_due'};
if (C4::Context->preference("IndependentBranches")){
my $userenv = C4::Context->userenv;
- if ( ($userenv) && ( $userenv->{flags} % 2 != 1 ) ) {
+ unless ( C4::Context->IsSuperLibrarian() ) {
$data->{'NOTSAMEBRANCH'} = 1 if ($idata->{'bcode'} ne $userenv->{branch});
}
}
# check that there is no issue on this item before deletion.
- my $sth=$dbh->prepare("select * from issues i where i.itemnumber=?");
+ my $sth = $dbh->prepare(q{
+ SELECT COUNT(*) FROM issues
+ WHERE itemnumber = ?
+ });
$sth->execute($itemnumber);
+ my ($onloan) = $sth->fetchrow;
my $item = GetItem($itemnumber);
- my $onloan=$sth->fetchrow;
if ($onloan){
$error = "book_on_loan"
}
- elsif ( !( C4::Context->userenv->{flags} & 1 )
+ elsif ( !C4::Context->IsSuperLibrarian()
and C4::Context->preference("IndependentBranches")
and ( C4::Context->userenv->{branch} ne $item->{'homebranch'} ) )
{
}
else{
# check it doesnt have a waiting reserve
- $sth=$dbh->prepare("SELECT * FROM reserves WHERE (found = 'W' or found = 'T') AND itemnumber = ?");
+ $sth = $dbh->prepare(q{
+ SELECT COUNT(*) FROM reserves
+ WHERE (found = 'W' OR found = 'T')
+ AND itemnumber = ?
+ });
$sth->execute($itemnumber);
- my $reserve=$sth->fetchrow;
+ my ($reserve) = $sth->fetchrow;
if ($reserve){
$error = "book_reserved";
} elsif ($countanalytics > 0){
$query =~ s/,$//;
$query .= " WHERE itemnumber=?";
push @bind, $item->{'itemnumber'};
- my $sth = C4::Context->dbh->prepare($query);
+ my $sth = $dbh->prepare($query);
$sth->execute(@bind);
- if ( C4::Context->dbh->errstr ) {
- $error.="ERROR in _koha_modify_item $query".$dbh->errstr;
+ if ( $sth->err ) {
+ $error.="ERROR in _koha_modify_item $query: ".$sth->errstr;
warn $error;
}
return ($item->{'itemnumber'},$error);
$subfield_data{mandatory} = $tagslib->{$tag}->{$subfield}->{mandatory};
$subfield_data{repeatable} = $tagslib->{$tag}->{$subfield}->{repeatable};
$subfield_data{hidden} = "display:none"
- if $tagslib->{$tag}->{$subfield}->{hidden};
+ if ( ( $tagslib->{$tag}->{$subfield}->{hidden} > 4 )
+ || ( $tagslib->{$tag}->{$subfield}->{hidden} < -4 ) );
my ( $x, $defaultvalue );
if ($itemrecord) {
( $x, $defaultvalue ) = _find_value( $tag, $subfield, $itemrecord );
#---- branch
if ( $tagslib->{$tag}->{$subfield}->{'authorised_value'} eq "branches" ) {
if ( ( C4::Context->preference("IndependentBranches") )
- && ( C4::Context->userenv && C4::Context->userenv->{flags} % 2 != 1 ) ) {
+ && !C4::Context->IsSuperLibrarian() ) {
my $sth = $dbh->prepare( "SELECT branchcode,branchname FROM branches WHERE branchcode = ? ORDER BY branchname" );
$sth->execute( C4::Context->userenv->{branch} );
push @authorised_values, ""