Bug 16011: $VERSION - remove use vars $VERSION

[koha_ffzg] / C4 / External / Syndetics.pm

diff --git a/C4/External/Syndetics.pm b/C4/External/Syndetics.pm
index 31179d5..db376e5 100644 (file)
--- a/C4/External/Syndetics.pm
+++ b/C4/External/Syndetics.pm
@@ -4,18 +4,18 @@ package C4::External::Syndetics;
 #
 # This file is part of Koha.
 #
-# Koha is free software; you can redistribute it and/or modify it under the
-# terms of the GNU General Public License as published by the Free Software
-# Foundation; either version 2 of the License, or (at your option) any later
-# version.
+# Koha is free software; you can redistribute it and/or modify it
+# under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
 #
-# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
-# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
-# A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
+# Koha is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
 #
-# You should have received a copy of the GNU General Public License along with
-# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
-# Suite 330, Boston, MA  02111-1307 USA
+# You should have received a copy of the GNU General Public License
+# along with Koha; if not, see <http://www.gnu.org/licenses>.
 
 use XML::Simple;
 use XML::LibXML;
@@ -26,11 +26,11 @@ use HTTP::Request::Common;
 use strict;
 use warnings;
 
-use vars qw($VERSION @ISA @EXPORT);
+use vars qw(@ISA @EXPORT);
 
 BEGIN {
     require Exporter;
-    $VERSION = 0.03;
+    $VERSION = 3.07.00.049;
     @ISA = qw(Exporter);
     @EXPORT = qw(
         &get_syndetics_index
@@ -56,20 +56,21 @@ This module provides facilities for retrieving Syndetics.com content in Koha
 
 =head2 get_syndetics_summary
 
-=over 4
-
-my $syndetics_summary= &get_syndetics_summary( $isbn );
-
-=back
+  my $syndetics_summary= &get_syndetics_summary( $isbn );
 
 Get Summary data from Syndetics
 
 =cut
 
 sub get_syndetics_index {
-    my ( $isbn,$upc,$oclc ) = @_;
+    my ( $isbn, $upc, $oclc ) = @_;
+
+    return unless ( $isbn || $upc || $oclc );
 
     my $response = _fetch_syndetics_content('INDEX.XML', $isbn, $upc, $oclc);
+    unless ($response->content_type =~ /xml/) {
+        return;
+    }
 
     my $content = $response->content;
     my $xmlsimple = XML::Simple->new();
@@ -81,9 +82,9 @@ sub get_syndetics_index {
     for my $available_type ('SUMMARY','TOC','FICTION','AWARDS1','SERIES1','SPSUMMARY','SPREVIEW', 'AVPROFILE', 'AVSUMMARY','DBCHAPTER','LJREVIEW','PWREVIEW','SLJREVIEW','CHREVIEW','BLREVIEW','HBREVIEW','KIREVIEW','CRITICASREVIEW','ANOTES') {
         if (exists $response->{$available_type} && $response->{$available_type} =~ /$available_type/) {
             $syndetics_elements->{$available_type} = $available_type;
-            #warn "RESPONSE: $available_type : $response->{$available_type}";
         }
     }
+
     return $syndetics_elements if $syndetics_elements;
 }
 
@@ -275,6 +276,8 @@ __END__
 
 =head1 NOTES
 
+=cut
+
 =head1 AUTHOR
 
 Joshua Ferraro <jmf@liblime.com>