Fix for Bug 6402, Lists sorted by year appear to be empty
[koha_fer] / C4 / Auth_with_ldap.pm
index 78666e9..acbd923 100644 (file)
@@ -58,7 +58,7 @@ my $prefhost  = $ldap->{hostname}     or die ldapserver_error('hostname');
 my $base      = $ldap->{base}          or die ldapserver_error('base');
 $ldapname     = $ldap->{user}          ;
 $ldappassword = $ldap->{pass}          ;
-our %mapping  = %{$ldap->{mapping}} || (); #   or die ldapserver_error('mapping');
+our %mapping  = %{$ldap->{mapping}}; # FIXME dpavlin -- don't die because of || (); from 6eaf8511c70eb82d797c941ef528f4310a15e9f9
 my @mapkeys = keys %mapping;
 $debug and print STDERR "Got ", scalar(@mapkeys), " ldap mapkeys (  total  ): ", join ' ', @mapkeys, "\n";
 @mapkeys = grep {defined $mapping{$_}->{is}} @mapkeys;
@@ -122,6 +122,11 @@ sub checkpw_ldap {
             $debug and warn "LDAP bind failed as kohauser $principal_name: ". description($res);
             return 0;
         }
+
+       # FIXME dpavlin -- we really need $userldapentry leater on even if using auth_by_bind!
+       my $search = search_method($db, $userid) or return 0;   # warnings are in the sub
+       $userldapentry = $search->shift_entry;
+
        } else {
         my $search = search_method($db, $userid) or return 0;   # warnings are in the sub
         $userldapentry = $search->shift_entry;
@@ -150,6 +155,7 @@ sub checkpw_ldap {
             ($cardnumber eq $c2) or warn "update_local returned cardnumber '$c2' instead of '$cardnumber'";
         } else { # C1, D1
             # maybe update just the password?
+               return(1, $cardnumber); # FIXME dpavlin -- don't destroy ExtendedPatronAttributes
         }
     } elsif ($config{replicate}) { # A2, C2
         $borrowernumber = AddMember(%borrower) or die "AddMember failed";
@@ -160,6 +166,7 @@ sub checkpw_ldap {
                my @types = C4::Members::AttributeTypes::GetAttributeTypes();
                my @attributes = grep{my $key=$_; any{$_ eq $key}@types;} keys %borrower;
                my $extended_patron_attributes = map{{code=>$_,value=>$borrower{$_}}}@attributes;
+               my $extended_patron_attributes = [] unless $extended_patron_attributes;
                my @errors;
                #Check before add
                for (my $i; $i< scalar(@$extended_patron_attributes)-1;$i++) {
@@ -301,62 +308,77 @@ C4::Auth - Authenticates Koha users
        What are the required fields?  Well, in mysql you can check the database table "borrowers" like this:
 
        mysql> show COLUMNS from borrowers;
-               +------------------+--------------+------+-----+---------+----------------+
-               | Field            | Type         | Null | Key | Default | Extra          |
-               +------------------+--------------+------+-----+---------+----------------+
-               | borrowernumber   | int(11)      | NO   | PRI | NULL    | auto_increment | 
-               | cardnumber       | varchar(16)  | YES  | UNI | NULL    |                | 
-               | surname          | mediumtext   | NO   |     |         |                | 
-               | firstname        | text         | YES  |     | NULL    |                | 
-               | title            | mediumtext   | YES  |     | NULL    |                | 
-               | othernames       | mediumtext   | YES  |     | NULL    |                | 
-               | initials         | text         | YES  |     | NULL    |                | 
-               | streetnumber     | varchar(10)  | YES  |     | NULL    |                | 
-               | streettype       | varchar(50)  | YES  |     | NULL    |                | 
-               | address          | mediumtext   | NO   |     |         |                | 
-               | address2         | text         | YES  |     | NULL    |                | 
-               | city             | mediumtext   | NO   |     |         |                | 
-               | zipcode          | varchar(25)  | YES  |     | NULL    |                | 
-               | email            | mediumtext   | YES  |     | NULL    |                | 
-               | phone            | text         | YES  |     | NULL    |                | 
-               | mobile           | varchar(50)  | YES  |     | NULL    |                | 
-               | fax              | mediumtext   | YES  |     | NULL    |                | 
-               | emailpro         | text         | YES  |     | NULL    |                | 
-               | phonepro         | text         | YES  |     | NULL    |                | 
-               | B_streetnumber   | varchar(10)  | YES  |     | NULL    |                | 
-               | B_streettype     | varchar(50)  | YES  |     | NULL    |                | 
-               | B_address        | varchar(100) | YES  |     | NULL    |                | 
-               | B_city           | mediumtext   | YES  |     | NULL    |                | 
-               | B_zipcode        | varchar(25)  | YES  |     | NULL    |                | 
-               | B_email          | text         | YES  |     | NULL    |                | 
-               | B_phone          | mediumtext   | YES  |     | NULL    |                | 
-               | dateofbirth      | date         | YES  |     | NULL    |                | 
-               | branchcode       | varchar(10)  | NO   | MUL |         |                | 
-               | categorycode     | varchar(10)  | NO   | MUL |         |                | 
-               | dateenrolled     | date         | YES  |     | NULL    |                | 
-               | dateexpiry       | date         | YES  |     | NULL    |                | 
-               | gonenoaddress    | tinyint(1)   | YES  |     | NULL    |                | 
-               | lost             | tinyint(1)   | YES  |     | NULL    |                | 
-               | debarred         | tinyint(1)   | YES  |     | NULL    |                | 
-               | contactname      | mediumtext   | YES  |     | NULL    |                | 
-               | contactfirstname | text         | YES  |     | NULL    |                | 
-               | contacttitle     | text         | YES  |     | NULL    |                | 
-               | guarantorid      | int(11)      | YES  |     | NULL    |                | 
-               | borrowernotes    | mediumtext   | YES  |     | NULL    |                | 
-               | relationship     | varchar(100) | YES  |     | NULL    |                | 
-               | ethnicity        | varchar(50)  | YES  |     | NULL    |                | 
-               | ethnotes         | varchar(255) | YES  |     | NULL    |                | 
-               | sex              | varchar(1)   | YES  |     | NULL    |                | 
-               | password         | varchar(30)  | YES  |     | NULL    |                | 
-               | flags            | int(11)      | YES  |     | NULL    |                | 
-               | userid           | varchar(30)  | YES  | MUL | NULL    |                |  # UNIQUE in next release.
-               | opacnote         | mediumtext   | YES  |     | NULL    |                | 
-               | contactnote      | varchar(255) | YES  |     | NULL    |                | 
-               | sort1            | varchar(80)  | YES  |     | NULL    |                | 
-               | sort2            | varchar(80)  | YES  |     | NULL    |                | 
-               +------------------+--------------+------+-----+---------+----------------+
-               50 rows in set (0.01 sec)
-       
+               +---------------------+--------------+------+-----+---------+----------------+
+               | Field               | Type         | Null | Key | Default | Extra          |
+               +---------------------+--------------+------+-----+---------+----------------+
+               | borrowernumber      | int(11)      | NO   | PRI | NULL    | auto_increment |
+               | cardnumber          | varchar(16)  | YES  | UNI | NULL    |                |
+               | surname             | mediumtext   | NO   |     | NULL    |                |
+               | firstname           | text         | YES  |     | NULL    |                |
+               | title               | mediumtext   | YES  |     | NULL    |                |
+               | othernames          | mediumtext   | YES  |     | NULL    |                |
+               | initials            | text         | YES  |     | NULL    |                |
+               | streetnumber        | varchar(10)  | YES  |     | NULL    |                |
+               | streettype          | varchar(50)  | YES  |     | NULL    |                |
+               | address             | mediumtext   | NO   |     | NULL    |                |
+               | address2            | text         | YES  |     | NULL    |                |
+               | city                | mediumtext   | NO   |     | NULL    |                |
+               | state               | mediumtext   | YES  |     | NULL    |                |
+               | zipcode             | varchar(25)  | YES  |     | NULL    |                |
+               | country             | text         | YES  |     | NULL    |                |
+               | email               | mediumtext   | YES  |     | NULL    |                |
+               | phone               | text         | YES  |     | NULL    |                |
+               | mobile              | varchar(50)  | YES  |     | NULL    |                |
+               | fax                 | mediumtext   | YES  |     | NULL    |                |
+               | emailpro            | text         | YES  |     | NULL    |                |
+               | phonepro            | text         | YES  |     | NULL    |                |
+               | B_streetnumber      | varchar(10)  | YES  |     | NULL    |                |
+               | B_streettype        | varchar(50)  | YES  |     | NULL    |                |
+               | B_address           | varchar(100) | YES  |     | NULL    |                |
+               | B_address2          | text         | YES  |     | NULL    |                |
+               | B_city              | mediumtext   | YES  |     | NULL    |                |
+               | B_state             | mediumtext   | YES  |     | NULL    |                |
+               | B_zipcode           | varchar(25)  | YES  |     | NULL    |                |
+               | B_country           | text         | YES  |     | NULL    |                |
+               | B_email             | text         | YES  |     | NULL    |                |
+               | B_phone             | mediumtext   | YES  |     | NULL    |                |
+               | dateofbirth         | date         | YES  |     | NULL    |                |
+               | branchcode          | varchar(10)  | NO   | MUL |         |                |
+               | categorycode        | varchar(10)  | NO   | MUL |         |                |
+               | dateenrolled        | date         | YES  |     | NULL    |                |
+               | dateexpiry          | date         | YES  |     | NULL    |                |
+               | gonenoaddress       | tinyint(1)   | YES  |     | NULL    |                |
+               | lost                | tinyint(1)   | YES  |     | NULL    |                |
+               | debarred            | tinyint(1)   | YES  |     | NULL    |                |
+               | contactname         | mediumtext   | YES  |     | NULL    |                |
+               | contactfirstname    | text         | YES  |     | NULL    |                |
+               | contacttitle        | text         | YES  |     | NULL    |                |
+               | guarantorid         | int(11)      | YES  | MUL | NULL    |                |
+               | borrowernotes       | mediumtext   | YES  |     | NULL    |                |
+               | relationship        | varchar(100) | YES  |     | NULL    |                |
+               | ethnicity           | varchar(50)  | YES  |     | NULL    |                |
+               | ethnotes            | varchar(255) | YES  |     | NULL    |                |
+               | sex                 | varchar(1)   | YES  |     | NULL    |                |
+               | password            | varchar(30)  | YES  |     | NULL    |                |
+               | flags               | int(11)      | YES  |     | NULL    |                |
+               | userid              | varchar(30)  | YES  | MUL | NULL    |                |
+               | opacnote            | mediumtext   | YES  |     | NULL    |                |
+               | contactnote         | varchar(255) | YES  |     | NULL    |                |
+               | sort1               | varchar(80)  | YES  |     | NULL    |                |
+               | sort2               | varchar(80)  | YES  |     | NULL    |                |
+               | altcontactfirstname | varchar(255) | YES  |     | NULL    |                |
+               | altcontactsurname   | varchar(255) | YES  |     | NULL    |                |
+               | altcontactaddress1  | varchar(255) | YES  |     | NULL    |                |
+               | altcontactaddress2  | varchar(255) | YES  |     | NULL    |                |
+               | altcontactaddress3  | varchar(255) | YES  |     | NULL    |                |
+               | altcontactstate     | mediumtext   | YES  |     | NULL    |                |
+               | altcontactzipcode   | varchar(50)  | YES  |     | NULL    |                |
+               | altcontactcountry   | text         | YES  |     | NULL    |                |
+               | altcontactphone     | varchar(50)  | YES  |     | NULL    |                |
+               | smsalertnumber      | varchar(50)  | YES  |     | NULL    |                |
+               | privacy             | int(11)      | NO   |     | 1       |                |
+               +---------------------+--------------+------+-----+---------+----------------+
+               66 rows in set (0.00 sec)
                Where Null="NO", the field is required.
 
 =head1 KOHA_CONF and field mapping