# along with Koha; if not, see <http://www.gnu.org/licenses>.
-use strict;
-#use warnings; FIXME - Bug 2505
+use Modern::Perl;
use C4::Context;
use C4::Stats;
use C4::Members;
-use C4::Log qw(logaction);
use Koha::Account;
use Koha::Account::Lines;
use Koha::Account::Offsets;
use Koha::Items;
-use Mojo::Util qw(deprecated);
-use Data::Dumper qw(Dumper);
use vars qw(@ISA @EXPORT);
require Exporter;
@ISA = qw(Exporter);
@EXPORT = qw(
- &getnextacctno
- &chargelostitem
- &purge_zero_balance_fees
+ chargelostitem
+ purge_zero_balance_fees
);
}
=head1 FUNCTIONS
-=head2 getnextacctno
-
- $nextacct = &getnextacctno($borrowernumber);
-
-Returns the next unused account number for the patron with the given
-borrower number.
-
-=cut
-
-#'
-# FIXME - Okay, so what does the above actually _mean_?
-sub getnextacctno {
- my ($borrowernumber) = shift or return;
- my $sth = C4::Context->dbh->prepare(
- "SELECT accountno+1 FROM accountlines
- WHERE (borrowernumber = ?)
- ORDER BY accountno DESC
- LIMIT 1"
- );
- $sth->execute($borrowernumber);
- return ($sth->fetchrow || 1);
-}
-
=head2 chargelostitem
In a default install of Koha the following lost values are set
=cut
-sub chargelostitem{
+sub chargelostitem {
my $dbh = C4::Context->dbh();
my ($borrowernumber, $itemnumber, $amount, $description) = @_;
my $itype = Koha::ItemTypes->find({ itemtype => Koha::Items->find($itemnumber)->effective_itemtype() });
if ($usedefaultreplacementcost && $amount == 0 && $defaultreplacecost){
$replacementprice = $defaultreplacecost;
}
+ my $checkout = Koha::Checkouts->find({ itemnumber => $itemnumber });
+ my $issue_id = $checkout ? $checkout->issue_id : undef;
my $account = Koha::Account->new({ patron_id => $borrowernumber });
- # first make sure the borrower hasn't already been charged for this item
- # FIXME this should be more exact
- # there is no reason a user can't lose an item, find and return it, and lost it again
+ # first make sure the borrower hasn't already been charged for this item (for this issuance)
my $existing_charges = $account->lines->search(
{
- itemnumber => $itemnumber,
- accounttype => 'L',
+ itemnumber => $itemnumber,
+ debit_type_code => 'LOST',
+ issue_id => $issue_id
}
)->count();
# OK, they haven't
unless ($existing_charges) {
- my $checkout = Koha::Checkouts->find({ itemnumber => $itemnumber });
- my $issue_id = $checkout ? $checkout->issue_id : undef;
#add processing fee
if ($processfee && $processfee > 0){
my $accountline = $account->add_debit(
amount => $processfee,
description => $description,
note => $processingfeenote,
- user_id => C4::Context->userenv ? C4::Context->userenv->{'number'} : 0,
+ user_id => C4::Context->userenv ? C4::Context->userenv->{'number'} : undef,
+ interface => C4::Context->interface,
library_id => C4::Context->userenv ? C4::Context->userenv->{'branch'} : undef,
- type => 'processing',
+ type => 'PROCESSING',
item_id => $itemnumber,
issue_id => $issue_id,
}
amount => $replacementprice,
description => $description,
note => undef,
- user_id => C4::Context->userenv ? C4::Context->userenv->{'number'} : 0,
+ user_id => C4::Context->userenv ? C4::Context->userenv->{'number'} : undef,
+ interface => C4::Context->interface,
library_id => C4::Context->userenv ? C4::Context->userenv->{'branch'} : undef,
- type => 'lost_item',
+ type => 'LOST',
item_id => $itemnumber,
issue_id => $issue_id,
}
}
}
-=head2 manualinvoice
-
- &manualinvoice($borrowernumber, $itemnumber, $description, $type,
- $amount, $note);
-
-This function is now deprecated and not used anywhere within koha. It is due for complete removal in 19.11
-
-=cut
-
-sub manualinvoice {
- my ( $borrowernumber, $itemnum, $desc, $type, $amount, $note ) = @_;
-
- deprecated "C4::Accounts::manualinvoice is deprecated in favor of Koha::Account->add_debit";
-
- my $manager_id = 0;
- $manager_id = C4::Context->userenv->{'number'} if C4::Context->userenv;
- my $dbh = C4::Context->dbh;
- my $insert;
- my $accountno = getnextacctno($borrowernumber);
- my $amountleft = $amount;
-
- my $branchcode = C4::Context->userenv ? C4::Context->userenv->{'branch'} : undef;
-
- my $accountline = Koha::Account::Line->new(
- {
- borrowernumber => $borrowernumber,
- accountno => $accountno,
- date => \'NOW()',
- amount => $amount,
- description => $desc,
- accounttype => $type,
- amountoutstanding => $amountleft,
- itemnumber => $itemnum || undef,
- note => $note,
- manager_id => $manager_id,
- branchcode => $branchcode,
- }
- )->store();
-
- my $account_offset = Koha::Account::Offset->new(
- {
- debit_id => $accountline->id,
- type => 'Manual Debit',
- amount => $amount,
- }
- )->store();
-
- if ( C4::Context->preference("FinesLog") ) {
- logaction("FINES", 'CREATE',$borrowernumber,Dumper({
- action => 'create_fee',
- borrowernumber => $borrowernumber,
- accountno => $accountno,
- amount => $amount,
- description => $desc,
- accounttype => $type,
- amountoutstanding => $amountleft,
- note => $note,
- itemnumber => $itemnum,
- manager_id => $manager_id,
- }));
- }
-
- return 0;
-}
-
=head2 purge_zero_balance_fees
purge_zero_balance_fees( $days );
projects / koha-ffzg.git / blobdiff