+$schema->txn_rollback;
+$schema->txn_begin;
+
+### Test holds queue builder does not violate holds policy ###
+
+# Clear out existing rules relating to holdallowed
+$dbh->do("DELETE FROM circulation_rules");
+
+t::lib::Mocks::mock_preference('UseTransportCostMatrix', 0);
+
+$itemtype = $builder->build({ source => 'Itemtype', value => { notforloan => 0 } })->{itemtype};
+
+$library1 = $builder->build({
+ source => 'Branch',
+});
+$library2 = $builder->build({
+ source => 'Branch',
+});
+$library3 = $builder->build({
+ source => 'Branch',
+});
+@branchcodes = ( $library1->{branchcode}, $library2->{branchcode}, $library3->{branchcode} );
+
+my $category = $builder->build({ source => 'Category', value => {exclude_from_local_holds_priority => 0} } );
+
+my $borrower1 = $builder->build({
+ source => 'Borrower',
+ value => {
+ branchcode => $branchcodes[0],
+ categorycode => $category->{categorycode},
+ },
+});
+my $borrower2 = $builder->build({
+ source => 'Borrower',
+ value => {
+ branchcode => $branchcodes[1],
+ categorycode => $category->{categorycode},
+ },
+});
+my $borrower3 = $builder->build({
+ source => 'Borrower',
+ value => {
+ branchcode => $branchcodes[2],
+ categorycode => $category->{categorycode},
+ },
+});
+
+$dbh->do(qq{
+ INSERT INTO biblio (
+ frameworkcode,
+ author,
+ title,
+ datecreated
+ ) VALUES (
+ 'SER',
+ 'Koha test',
+ '$TITLE',
+ '2011-02-01'
+ )
+});
+$biblionumber = $dbh->selectrow_array("SELECT biblionumber FROM biblio WHERE title = '$TITLE'")
+ or BAIL_OUT("Cannot find newly created biblio record");
+
+$dbh->do(qq{
+ INSERT INTO biblioitems (
+ biblionumber,
+ itemtype
+ ) VALUES (
+ $biblionumber,
+ '$itemtype'
+ )
+});
+$biblioitemnumber = $dbh->selectrow_array("SELECT biblioitemnumber FROM biblioitems WHERE biblionumber = $biblionumber")
+ or BAIL_OUT("Cannot find newly created biblioitems record");
+
+$items_insert_sth = $dbh->prepare(qq{
+ INSERT INTO items (
+ biblionumber,
+ biblioitemnumber,
+ barcode,
+ homebranch,
+ holdingbranch,
+ notforloan,
+ damaged,
+ itemlost,
+ withdrawn,
+ onloan,
+ itype,
+ exclude_from_local_holds_priority
+ ) VALUES (
+ $biblionumber,
+ $biblioitemnumber,
+ ?,
+ ?,
+ ?,
+ 0,
+ 0,
+ 0,
+ 0,
+ NULL,
+ '$itemtype',
+ 0
+ )
+});
+# Create 3 items from 2 branches ( branches are for borrowers 1 and 2 respectively )
+$barcode = int( rand(1000000000000) );
+$items_insert_sth->execute( $barcode + 0, $branchcodes[0], $branchcodes[0] );
+$items_insert_sth->execute( $barcode + 1, $branchcodes[1], $branchcodes[1] );
+$items_insert_sth->execute( $barcode + 2, $branchcodes[1], $branchcodes[1] );
+
+$dbh->do("DELETE FROM reserves");
+my $sth = $dbh->prepare(q{
+ INSERT INTO reserves (
+ borrowernumber,
+ biblionumber,
+ branchcode,
+ priority,
+ reservedate
+ ) VALUES ( ?,?,?,?, CURRENT_DATE() )
+});
+$sth->execute( $borrower1->{borrowernumber}, $biblionumber, $branchcodes[0], 1 );
+$sth->execute( $borrower2->{borrowernumber}, $biblionumber, $branchcodes[0], 2 );
+$sth->execute( $borrower3->{borrowernumber}, $biblionumber, $branchcodes[0], 3 );
+
+my $holds_queue;
+
+$dbh->do("DELETE FROM circulation_rules");
+Koha::CirculationRules->set_rule(
+ {
+ rule_name => 'holdallowed',
+ rule_value => 'from_home_library',
+ branchcode => undef,
+ itemtype => undef,
+ }
+);
+C4::HoldsQueue::CreateQueue();
+$holds_queue = $dbh->selectall_arrayref("SELECT * FROM tmp_holdsqueue", { Slice => {} });
+is( @$holds_queue, 2, "Holds queue filling correct number for default holds policy 'from home library'" );
+is( $holds_queue->[0]->{cardnumber}, $borrower1->{cardnumber}, "Holds queue filling 1st correct hold for default holds policy 'from home library'");
+is( $holds_queue->[1]->{cardnumber}, $borrower2->{cardnumber}, "Holds queue filling 2nd correct hold for default holds policy 'from home library'");
+
+# Test skipping hold picks for closed libraries.
+# At this point in the test, we have 2 rows in the holds queue
+# 1 of which is coming from MPL. Let's enable HoldsQueueSkipClosed
+# and make today a holiday for MPL. When we run it again we should only
+# have 1 row in the holds queue
+t::lib::Mocks::mock_preference('HoldsQueueSkipClosed', 1);
+my $today = dt_from_string();
+C4::Calendar->new( branchcode => $branchcodes[0] )->insert_single_holiday(
+ day => $today->day(),
+ month => $today->month(),
+ year => $today->year(),
+ title => "$today",
+ description => "$today",
+);
+# If the test below is removed, aother tests using the holiday will fail. For some reason if we call is_holiday now
+# the holiday will get set in cache correctly, but not if we let C4::HoldsQueue call is_holiday instead.
+is( Koha::Calendar->new( branchcode => $branchcodes[0] )->is_holiday( $today ), 1, 'Is today a holiday for pickup branch' );
+C4::HoldsQueue::CreateQueue();
+$holds_queue = $dbh->selectall_arrayref("SELECT * FROM tmp_holdsqueue", { Slice => {} });
+is( scalar( @$holds_queue ), 1, "Holds not filled with items from closed libraries" );
+t::lib::Mocks::mock_preference('HoldsQueueSkipClosed', 0);
+
+$dbh->do("DELETE FROM circulation_rules");
+Koha::CirculationRules->set_rule(
+ {
+ rule_name => 'holdallowed',
+ rule_value => 'from_any_library',
+ branchcode => undef,
+ itemtype => undef,
+ }
+);
+C4::HoldsQueue::CreateQueue();
+$holds_queue = $dbh->selectall_arrayref("SELECT * FROM tmp_holdsqueue", { Slice => {} });
+is( @$holds_queue, 3, "Holds queue filling correct number for holds for default holds policy 'from any library'" );
+
+# Test skipping hold picks for closed libraries without transport cost matrix
+# At this point in the test, we have 3 rows in the holds queue
+# one of which is coming from MPL. Let's enable HoldsQueueSkipClosed
+# and use our previously created holiday for MPL
+# When we run it again we should only have 2 rows in the holds queue
+t::lib::Mocks::mock_preference( 'HoldsQueueSkipClosed', 1 );
+C4::HoldsQueue::CreateQueue();
+$holds_queue = $dbh->selectall_arrayref("SELECT * FROM tmp_holdsqueue", { Slice => {} });
+is( scalar( @$holds_queue ), 2, "Holds not filled with items from closed libraries" );
+t::lib::Mocks::mock_preference( 'HoldsQueueSkipClosed', 0 );
+
+## Test LocalHoldsPriority
+t::lib::Mocks::mock_preference('LocalHoldsPriority', 1);
+
+$dbh->do("DELETE FROM circulation_rules");
+Koha::CirculationRules->set_rule(
+ {
+ rule_name => 'holdallowed',
+ rule_value => 'from_any_library',
+ branchcode => undef,
+ itemtype => undef,
+ }
+);
+$dbh->do("DELETE FROM issues");
+
+# Test homebranch = patron branch
+t::lib::Mocks::mock_preference('LocalHoldsPriorityPatronControl', 'HomeLibrary');
+t::lib::Mocks::mock_preference('LocalHoldsPriorityItemControl', 'homebranch');
+C4::Context->clear_syspref_cache();
+$dbh->do("DELETE FROM reserves");
+$sth->execute( $borrower1->{borrowernumber}, $biblionumber, $branchcodes[0], 1 );
+$sth->execute( $borrower2->{borrowernumber}, $biblionumber, $branchcodes[0], 2 );
+$sth->execute( $borrower3->{borrowernumber}, $biblionumber, $branchcodes[0], 3 );
+
+$dbh->do("DELETE FROM items");
+# barcode, homebranch, holdingbranch, itemtype
+$items_insert_sth->execute( $barcode + 4, $branchcodes[2], $branchcodes[0] );
+
+C4::HoldsQueue::CreateQueue();
+$holds_queue = $dbh->selectall_arrayref("SELECT * FROM tmp_holdsqueue", { Slice => {} });
+is( $holds_queue->[0]->{cardnumber}, $borrower3->{cardnumber}, "Holds queue giving priority to patron who's home library matches item's home library");
+
+### Test branch transfer limits ###
+t::lib::Mocks::mock_preference('LocalHoldsPriorityPatronControl', 'HomeLibrary');
+t::lib::Mocks::mock_preference('LocalHoldsPriorityItemControl', 'holdingbranch');
+t::lib::Mocks::mock_preference( 'UseBranchTransferLimits', '1' );
+C4::Context->clear_syspref_cache();
+$dbh->do("DELETE FROM reserves");
+$sth->execute( $borrower1->{borrowernumber}, $biblionumber, $branchcodes[0], 1 );
+$sth->execute( $borrower2->{borrowernumber}, $biblionumber, $branchcodes[1], 2 );
+
+$dbh->do("DELETE FROM items");
+# barcode, homebranch, holdingbranch, itemtype
+$items_insert_sth->execute( $barcode, $branchcodes[2], $branchcodes[2] );
+my $item = Koha::Items->find( { barcode => $barcode } );
+
+my $limit1 = Koha::Item::Transfer::Limit->new(
+ {
+ toBranch => $branchcodes[0],
+ fromBranch => $branchcodes[2],
+ itemtype => $item->effective_itemtype,
+ }
+)->store();
+
+C4::HoldsQueue::CreateQueue();
+$holds_queue = $dbh->selectall_arrayref("SELECT * FROM tmp_holdsqueue", { Slice => {} });
+is( $holds_queue->[0]->{cardnumber}, $borrower2->{cardnumber}, "Holds queue skips hold transfer that would violate branch transfer limits");
+
+my $limit2 = Koha::Item::Transfer::Limit->new(
+ {
+ toBranch => $branchcodes[1],
+ fromBranch => $branchcodes[2],
+ itemtype => $item->effective_itemtype,
+ }
+)->store();
+
+C4::HoldsQueue::CreateQueue();
+$holds_queue = $dbh->selectall_arrayref("SELECT * FROM tmp_holdsqueue", { Slice => {} });
+is( $holds_queue->[0]->{cardnumber}, undef, "Holds queue doesn't fill hold where all available items would violate branch transfer limits");
+
+$limit1->delete();
+$limit2->delete();
+t::lib::Mocks::mock_preference( 'UseBranchTransferLimits', '0' );
+### END Test branch transfer limits ###
+
+# Test holdingbranch = patron branch
+t::lib::Mocks::mock_preference('LocalHoldsPriorityPatronControl', 'HomeLibrary');
+t::lib::Mocks::mock_preference('LocalHoldsPriorityItemControl', 'holdingbranch');
+C4::Context->clear_syspref_cache();
+$dbh->do("DELETE FROM reserves");
+$sth->execute( $borrower1->{borrowernumber}, $biblionumber, $branchcodes[0], 1 );
+$sth->execute( $borrower2->{borrowernumber}, $biblionumber, $branchcodes[0], 2 );
+$sth->execute( $borrower3->{borrowernumber}, $biblionumber, $branchcodes[0], 3 );
+
+$dbh->do("DELETE FROM items");
+# barcode, homebranch, holdingbranch, itemtype
+$items_insert_sth->execute( $barcode + 4, $branchcodes[0], $branchcodes[2] );
+
+C4::HoldsQueue::CreateQueue();
+$holds_queue = $dbh->selectall_arrayref("SELECT * FROM tmp_holdsqueue", { Slice => {} });
+is( $holds_queue->[0]->{cardnumber}, $borrower3->{cardnumber}, "Holds queue giving priority to patron who's home library matches item's holding library");
+
+# Test holdingbranch = pickup branch
+t::lib::Mocks::mock_preference('LocalHoldsPriorityPatronControl', 'PickupLibrary');
+t::lib::Mocks::mock_preference('LocalHoldsPriorityItemControl', 'holdingbranch');
+C4::Context->clear_syspref_cache();
+$dbh->do("DELETE FROM reserves");
+$sth->execute( $borrower1->{borrowernumber}, $biblionumber, $branchcodes[0], 1 );
+$sth->execute( $borrower2->{borrowernumber}, $biblionumber, $branchcodes[0], 2 );
+$sth->execute( $borrower3->{borrowernumber}, $biblionumber, $branchcodes[2], 3 );
+
+$dbh->do("DELETE FROM items");
+# barcode, homebranch, holdingbranch, itemtype
+$items_insert_sth->execute( $barcode + 4, $branchcodes[0], $branchcodes[2] );
+
+C4::HoldsQueue::CreateQueue();
+$holds_queue = $dbh->selectall_arrayref("SELECT * FROM tmp_holdsqueue", { Slice => {} });
+is( $holds_queue->[0]->{cardnumber}, $borrower3->{cardnumber}, "Holds queue giving priority to patron who's home library matches item's holding library");
+
+# Test homebranch = pickup branch
+t::lib::Mocks::mock_preference('LocalHoldsPriorityPatronControl', 'PickupLibrary');
+t::lib::Mocks::mock_preference('LocalHoldsPriorityItemControl', 'homebranch');
+C4::Context->clear_syspref_cache();
+$dbh->do("DELETE FROM reserves");
+$sth->execute( $borrower1->{borrowernumber}, $biblionumber, $branchcodes[0], 1 );
+$sth->execute( $borrower2->{borrowernumber}, $biblionumber, $branchcodes[0], 2 );
+$sth->execute( $borrower3->{borrowernumber}, $biblionumber, $branchcodes[2], 3 );
+
+$dbh->do("DELETE FROM items");
+# barcode, homebranch, holdingbranch, itemtype
+$items_insert_sth->execute( $barcode + 4, $branchcodes[2], $branchcodes[0] );
+
+C4::HoldsQueue::CreateQueue();
+$holds_queue = $dbh->selectall_arrayref("SELECT * FROM tmp_holdsqueue", { Slice => {} });
+is( $holds_queue->[0]->{cardnumber}, $borrower3->{cardnumber}, "Holds queue giving priority to patron who's home library matches item's holding library");
+
+t::lib::Mocks::mock_preference('LocalHoldsPriority', 0);
+## End testing of LocalHoldsPriority
+
+
+# Bug 14297
+$itemtype = $builder->build({ source => 'Itemtype', value => { notforloan => 0 } })->{itemtype};
+$borrowernumber = $borrower3->{borrowernumber};
+my $library_A = $library1->{branchcode};
+my $library_B = $library2->{branchcode};
+my $library_C = $borrower3->{branchcode};
+$dbh->do("DELETE FROM reserves");
+$dbh->do("DELETE FROM issues");
+$dbh->do("DELETE FROM items");
+$dbh->do("DELETE FROM biblio");
+$dbh->do("DELETE FROM biblioitems");
+$dbh->do("DELETE FROM transport_cost");
+$dbh->do("DELETE FROM tmp_holdsqueue");
+$dbh->do("DELETE FROM hold_fill_targets");
+
+$dbh->do("
+ INSERT INTO biblio (frameworkcode, author, title, datecreated) VALUES ('', 'Koha test', '$TITLE', '2011-02-01')
+");
+
+$biblionumber = $dbh->selectrow_array("SELECT biblionumber FROM biblio WHERE title = '$TITLE'")
+ or BAIL_OUT("Cannot find newly created biblio record");
+
+$dbh->do("INSERT INTO biblioitems (biblionumber, itemtype) VALUES ($biblionumber, '$itemtype')");
+
+$biblioitemnumber =
+ $dbh->selectrow_array("SELECT biblioitemnumber FROM biblioitems WHERE biblionumber = $biblionumber")
+ or BAIL_OUT("Cannot find newly created biblioitems record");
+
+$dbh->do("
+ INSERT INTO items (biblionumber, biblioitemnumber, homebranch, holdingbranch, notforloan, damaged, itemlost, withdrawn, onloan, itype, exclude_from_local_holds_priority)
+ VALUES ($biblionumber, $biblioitemnumber, '$library_A', '$library_A', 0, 0, 0, 0, NULL, '$itemtype', 0)
+");
+
+$dbh->do("
+ INSERT INTO items (biblionumber, biblioitemnumber, homebranch, holdingbranch, notforloan, damaged, itemlost, withdrawn, onloan, itype, exclude_from_local_holds_priority)
+ VALUES ($biblionumber, $biblioitemnumber, '$library_B', '$library_B', 0, 0, 0, 0, NULL, '$itemtype', 0)
+");
+
+Koha::CirculationRules->set_rules(
+ {
+ branchcode => $library_A,
+ itemtype => $itemtype,
+ rules => {
+ holdallowed => 'from_any_library',
+ returnbranch => 'homebranch',
+ }
+ }
+);
+
+$dbh->do( "UPDATE systempreferences SET value = ? WHERE variable = 'StaticHoldsQueueWeight'",
+ undef, join( ',', $library_B, $library_A, $library_C ) );
+$dbh->do( "UPDATE systempreferences SET value = 0 WHERE variable = 'RandomizeHoldsQueueWeight'" );
+
+my $reserve_id = AddReserve(
+ {
+ branchcode => $library_C,
+ borrowernumber => $borrowernumber,
+ biblionumber => $biblionumber,
+ priority => 1,
+ }
+);
+C4::HoldsQueue::CreateQueue();
+$holds_queue = $dbh->selectall_arrayref("SELECT * FROM tmp_holdsqueue", { Slice => {} });
+is( @$holds_queue, 1, "Bug 14297 - Holds Queue building ignoring holds where pickup & home branch don't match and item is not from le");
+# End Bug 14297
+
+# Bug 15062
+$itemtype = $builder->build({ source => 'Itemtype', value => { notforloan => 0 } })->{itemtype};
+$borrowernumber = $borrower2->{borrowernumber};
+$library_A = $library1->{branchcode};
+$library_B = $library2->{branchcode};
+$dbh->do("DELETE FROM reserves");
+$dbh->do("DELETE FROM issues");
+$dbh->do("DELETE FROM items");
+$dbh->do("DELETE FROM biblio");
+$dbh->do("DELETE FROM biblioitems");
+$dbh->do("DELETE FROM transport_cost");
+$dbh->do("DELETE FROM tmp_holdsqueue");
+$dbh->do("DELETE FROM hold_fill_targets");
+
+t::lib::Mocks::mock_preference("UseTransportCostMatrix",1);
+
+my $tc_rs = $schema->resultset('TransportCost');
+$tc_rs->create({ frombranch => $library_A, tobranch => $library_B, cost => 0, disable_transfer => 1 });
+$tc_rs->create({ frombranch => $library_B, tobranch => $library_A, cost => 0, disable_transfer => 1 });
+
+$dbh->do("
+ INSERT INTO biblio (frameworkcode, author, title, datecreated) VALUES ('', 'Koha test', '$TITLE', '2011-02-01')
+");
+
+$biblionumber = $dbh->selectrow_array("SELECT biblionumber FROM biblio WHERE title = '$TITLE'")
+ or BAIL_OUT("Cannot find newly created biblio record");
+
+$dbh->do("INSERT INTO biblioitems (biblionumber, itemtype) VALUES ($biblionumber, '$itemtype')");
+
+$biblioitemnumber =
+ $dbh->selectrow_array("SELECT biblioitemnumber FROM biblioitems WHERE biblionumber = $biblionumber")
+ or BAIL_OUT("Cannot find newly created biblioitems record");
+
+$dbh->do("
+ INSERT INTO items (biblionumber, biblioitemnumber, homebranch, holdingbranch, notforloan, damaged, itemlost, withdrawn, onloan, itype, exclude_from_local_holds_priority)
+ VALUES ($biblionumber, $biblioitemnumber, '$library_A', '$library_A', 0, 0, 0, 0, NULL, '$itemtype', 0)
+");
+
+$reserve_id = AddReserve(
+ {
+ branchcode => $library_B,
+ borrowernumber => $borrowernumber,
+ biblionumber => $biblionumber,
+ priority => 1,
+ }
+);
+
+C4::HoldsQueue::CreateQueue();
+$holds_queue = $dbh->selectall_arrayref("SELECT * FROM tmp_holdsqueue", { Slice => {} });
+is( @$holds_queue, 0, "Bug 15062 - Holds queue with Transport Cost Matrix will transfer item even if transfers disabled");
+# End Bug 15062
+
+# Test hold_fulfillment_policy
+t::lib::Mocks::mock_preference( "UseTransportCostMatrix", 0 );
+$borrowernumber = $borrower3->{borrowernumber};
+$library_A = $library1->{branchcode};
+$library_B = $library2->{branchcode};
+$library_C = $library3->{branchcode};
+$dbh->do("DELETE FROM reserves");
+$dbh->do("DELETE FROM issues");
+$dbh->do("DELETE FROM items");
+$dbh->do("DELETE FROM biblio");
+$dbh->do("DELETE FROM biblioitems");
+$dbh->do("DELETE FROM transport_cost");
+$dbh->do("DELETE FROM tmp_holdsqueue");
+$dbh->do("DELETE FROM hold_fill_targets");
+
+$dbh->do("INSERT INTO biblio (frameworkcode, author, title, datecreated) VALUES ('', 'Koha test', '$TITLE', '2011-02-01')");
+
+$biblionumber = $dbh->selectrow_array("SELECT biblionumber FROM biblio WHERE title = '$TITLE'")
+ or BAIL_OUT("Cannot find newly created biblio record");
+
+$dbh->do("INSERT INTO biblioitems (biblionumber, itemtype) VALUES ($biblionumber, '$itemtype')");
+
+$biblioitemnumber =
+ $dbh->selectrow_array("SELECT biblioitemnumber FROM biblioitems WHERE biblionumber = $biblionumber")
+ or BAIL_OUT("Cannot find newly created biblioitems record");
+
+$dbh->do("
+ INSERT INTO items (biblionumber, biblioitemnumber, homebranch, holdingbranch, notforloan, damaged, itemlost, withdrawn, onloan, itype, exclude_from_local_holds_priority)
+ VALUES ($biblionumber, $biblioitemnumber, '$library_A', '$library_B', 0, 0, 0, 0, NULL, '$itemtype', 0)
+");
+
+# With hold_fulfillment_policy = homebranch, hold should only be picked up if pickup branch = homebranch
+$dbh->do("DELETE FROM circulation_rules");
+Koha::CirculationRules->set_rules(
+ {
+ branchcode => undef,
+ itemtype => undef,
+ rules => {
+ holdallowed => 'from_any_library',
+ hold_fulfillment_policy => 'homebranch',
+ }
+ }
+);
+
+# Home branch matches pickup branch
+$reserve_id = AddReserve(
+ {
+ branchcode => $library_A,
+ borrowernumber => $borrowernumber,
+ biblionumber => $biblionumber,
+ priority => 1,
+ }
+);
+
+C4::HoldsQueue::CreateQueue();
+$holds_queue = $dbh->selectall_arrayref( "SELECT * FROM tmp_holdsqueue", { Slice => {} } );
+is( @$holds_queue, 1, "Hold where pickup branch matches home branch targeted" );
+my $target_rs = $schema->resultset('HoldFillTarget');
+is( $target_rs->next->reserve_id, $reserve_id, "Reserve id correctly set in hold fill target for title level hold" );
+Koha::Holds->find( $reserve_id )->cancel;
+
+# Holding branch matches pickup branch
+$reserve_id = AddReserve(
+ {
+ branchcode => $library_B,
+ borrowernumber => $borrowernumber,
+ biblionumber => $biblionumber,
+ priority => 1,
+ }
+);
+
+
+C4::HoldsQueue::CreateQueue();
+$holds_queue = $dbh->selectall_arrayref( "SELECT * FROM tmp_holdsqueue", { Slice => {} } );
+is( @$holds_queue, 0, "Hold where pickup ne home, pickup eq home not targeted" );
+Koha::Holds->find( $reserve_id )->cancel;
+
+# Neither branch matches pickup branch
+$reserve_id = AddReserve(
+ {
+ branchcode => $library_C,
+ borrowernumber => $borrowernumber,
+ biblionumber => $biblionumber,
+ priority => 1,
+ }
+);
+
+C4::HoldsQueue::CreateQueue();
+$holds_queue = $dbh->selectall_arrayref( "SELECT * FROM tmp_holdsqueue", { Slice => {} } );
+is( @$holds_queue, 0, "Hold where pickup ne home, pickup ne holding not targeted" );
+Koha::Holds->find( $reserve_id )->cancel;
+
+# With hold_fulfillment_policy = holdingbranch, hold should only be picked up if pickup branch = holdingbranch
+$dbh->do("DELETE FROM circulation_rules");
+Koha::CirculationRules->set_rules(
+ {
+ branchcode => undef,
+ itemtype => undef,
+ rules => {
+ holdallowed => 'from_any_library',
+ hold_fulfillment_policy => 'holdingbranch',
+ }
+ }
+);
+
+# Home branch matches pickup branch
+$reserve_id = AddReserve(
+ {
+ branchcode => $library_A,
+ borrowernumber => $borrowernumber,
+ biblionumber => $biblionumber,
+ priority => 1,
+ }
+);
+
+C4::HoldsQueue::CreateQueue();
+$holds_queue = $dbh->selectall_arrayref( "SELECT * FROM tmp_holdsqueue", { Slice => {} } );
+is( @$holds_queue, 0, "Hold where pickup eq home, pickup ne holding not targeted" );
+Koha::Holds->find( $reserve_id )->cancel;
+
+# Holding branch matches pickup branch
+$reserve_id = AddReserve(
+ {
+ branchcode => $library_B,
+ borrowernumber => $borrowernumber,
+ biblionumber => $biblionumber,
+ priority => 1,
+ }
+);
+
+C4::HoldsQueue::CreateQueue();
+$holds_queue = $dbh->selectall_arrayref( "SELECT * FROM tmp_holdsqueue", { Slice => {} } );
+is( @$holds_queue, 1, "Hold where pickup ne home, pickup eq holding targeted" );
+Koha::Holds->find( $reserve_id )->cancel;
+
+# Neither branch matches pickup branch
+$reserve_id = AddReserve(
+ {
+ branchcode => $library_C,
+ borrowernumber => $borrowernumber,
+ biblionumber => $biblionumber,
+ priority => 1,
+ }
+);
+
+C4::HoldsQueue::CreateQueue();
+$holds_queue = $dbh->selectall_arrayref( "SELECT * FROM tmp_holdsqueue", { Slice => {} } );
+is( @$holds_queue, 0, "Hold where pickup ne home, pickup ne holding not targeted" );
+Koha::Holds->find( $reserve_id )->cancel;
+
+# With hold_fulfillment_policy = any, hold should be pikcup up reguardless of matching home or holding branch
+$dbh->do("DELETE FROM circulation_rules");
+Koha::CirculationRules->set_rules(
+ {
+ branchcode => undef,
+ itemtype => undef,
+ rules => {
+ holdallowed => 'from_any_library',
+ hold_fulfillment_policy => 'any',
+ }
+ }
+);
+
+# Home branch matches pickup branch
+$reserve_id = AddReserve(
+ {
+ branchcode => $library_A,
+ borrowernumber => $borrowernumber,
+ biblionumber => $biblionumber,
+ priority => 1,
+ }
+);
+
+C4::HoldsQueue::CreateQueue();
+$holds_queue = $dbh->selectall_arrayref( "SELECT * FROM tmp_holdsqueue", { Slice => {} } );
+is( @$holds_queue, 1, "Hold where pickup eq home, pickup ne holding targeted" );
+Koha::Holds->find( $reserve_id )->cancel;
+
+# Holding branch matches pickup branch
+$reserve_id = AddReserve(
+ {
+ branchcode => $library_B,
+ borrowernumber => $borrowernumber,
+ biblionumber => $biblionumber,
+ priority => 1,
+ }
+);
+
+C4::HoldsQueue::CreateQueue();
+$holds_queue = $dbh->selectall_arrayref( "SELECT * FROM tmp_holdsqueue", { Slice => {} } );
+is( @$holds_queue, 1, "Hold where pickup ne home, pickup eq holding targeted" );
+Koha::Holds->find( $reserve_id )->cancel;
+
+# Neither branch matches pickup branch
+$reserve_id = AddReserve(
+ {
+ branchcode => $library_C,
+ borrowernumber => $borrowernumber,
+ biblionumber => $biblionumber,
+ priority => 1,
+ }
+);
+
+C4::HoldsQueue::CreateQueue();
+$holds_queue = $dbh->selectall_arrayref( "SELECT * FROM tmp_holdsqueue", { Slice => {} } );
+is( @$holds_queue, 1, "Hold where pickup ne home, pickup ne holding targeted" );
+Koha::Holds->find( $reserve_id )->cancel;
+
+# End testing hold_fulfillment_policy
+
+# Test hold itemtype limit
+t::lib::Mocks::mock_preference( "UseTransportCostMatrix", 0 );
+my $wrong_itemtype = $builder->build({ source => 'Itemtype', value => { notforloan => 0 } })->{itemtype};
+my $right_itemtype = $builder->build({ source => 'Itemtype', value => { notforloan => 0 } })->{itemtype};
+$borrowernumber = $borrower3->{borrowernumber};
+my $branchcode = $library1->{branchcode};
+$dbh->do("DELETE FROM reserves");
+$dbh->do("DELETE FROM issues");
+$dbh->do("DELETE FROM items");
+$dbh->do("DELETE FROM biblio");
+$dbh->do("DELETE FROM biblioitems");
+$dbh->do("DELETE FROM transport_cost");
+$dbh->do("DELETE FROM tmp_holdsqueue");
+$dbh->do("DELETE FROM hold_fill_targets");
+
+$dbh->do("INSERT INTO biblio (frameworkcode, author, title, datecreated) VALUES ('', 'Koha test', '$TITLE', '2011-02-01')");
+
+$biblionumber = $dbh->selectrow_array("SELECT biblionumber FROM biblio WHERE title = '$TITLE'")
+ or BAIL_OUT("Cannot find newly created biblio record");
+
+$dbh->do("INSERT INTO biblioitems (biblionumber, itemtype) VALUES ($biblionumber, '$itemtype')");
+
+$biblioitemnumber =
+ $dbh->selectrow_array("SELECT biblioitemnumber FROM biblioitems WHERE biblionumber = $biblionumber")
+ or BAIL_OUT("Cannot find newly created biblioitems record");
+
+$dbh->do("
+ INSERT INTO items (biblionumber, biblioitemnumber, homebranch, holdingbranch, notforloan, damaged, itemlost, withdrawn, onloan, itype, exclude_from_local_holds_priority)
+ VALUES ($biblionumber, $biblioitemnumber, '$library_A', '$library_B', 0, 0, 0, 0, NULL, '$right_itemtype', 0)
+");
+
+# With hold_fulfillment_policy = homebranch, hold should only be picked up if pickup branch = homebranch
+$dbh->do("DELETE FROM circulation_rules");
+Koha::CirculationRules->set_rules(
+ {
+ branchcode => undef,
+ itemtype => undef,
+ rules => {
+ holdallowed => 'from_any_library',
+ hold_fulfillment_policy => 'any',
+ }
+ }
+);
+
+# Home branch matches pickup branch
+$reserve_id = AddReserve(
+ {
+ branchcode => $library_A,
+ borrowernumber => $borrowernumber,
+ biblionumber => $biblionumber,
+ priority => 1,
+ itemtype => $wrong_itemtype,
+ }
+);
+
+C4::HoldsQueue::CreateQueue();
+$holds_queue = $dbh->selectall_arrayref( "SELECT * FROM tmp_holdsqueue", { Slice => {} } );
+is( @$holds_queue, 0, "Item with incorrect itemtype not targeted" );
+Koha::Holds->find( $reserve_id )->cancel;
+
+# Holding branch matches pickup branch
+$reserve_id = AddReserve(
+ {
+ branchcode => $library_A,
+ borrowernumber => $borrowernumber,
+ biblionumber => $biblionumber,
+ priority => 1,
+ itemtype => $right_itemtype,
+ }
+);
+
+C4::HoldsQueue::CreateQueue();
+$holds_queue = $dbh->selectall_arrayref( "SELECT * FROM tmp_holdsqueue", { Slice => {} } );
+is( @$holds_queue, 1, "Item with matching itemtype is targeted" );
+Koha::Holds->find( $reserve_id )->cancel;
+
+# Neither branch matches pickup branch
+$reserve_id = AddReserve(
+ {
+ branchcode => $library_A,
+ borrowernumber => $borrowernumber,
+ biblionumber => $biblionumber,
+ priority => 1,
+ }
+);
+
+C4::HoldsQueue::CreateQueue();
+$holds_queue = $dbh->selectall_arrayref( "SELECT * FROM tmp_holdsqueue", { Slice => {} } );
+is( @$holds_queue, 1, "Item targeted when hold itemtype is not set" );
+Koha::Holds->find( $reserve_id )->cancel;
+
+# End testing hold itemtype limit
+
+
+subtest "Test Local Holds Priority - Bib level" => sub {
+ plan tests => 3;
+
+ Koha::Biblios->delete();
+ t::lib::Mocks::mock_preference( 'LocalHoldsPriority', 1 );
+ t::lib::Mocks::mock_preference( 'LocalHoldsPriorityPatronControl', 'PickupLibrary' );
+ t::lib::Mocks::mock_preference( 'LocalHoldsPriorityItemControl', 'homebranch' );
+ my $branch = $builder->build_object( { class => 'Koha::Libraries' } );
+ my $branch2 = $builder->build_object( { class => 'Koha::Libraries' } );
+ my $category = $builder->build_object( { class => 'Koha::Patron::Categories', value => {exclude_from_local_holds_priority => 0} });
+ my $local_patron = $builder->build_object(
+ {
+ class => "Koha::Patrons",
+ value => {
+ branchcode => $branch->branchcode,
+ categorycode => $category->categorycode
+ }
+ }
+ );
+ my $other_patron = $builder->build_object(
+ {
+ class => "Koha::Patrons",
+ value => {
+ branchcode => $branch2->branchcode,
+ categorycode => $category->categorycode
+ }
+ }
+ );
+ my $biblio = $builder->build_sample_biblio();
+ my $item = $builder->build_sample_item(
+ {
+ biblionumber => $biblio->biblionumber,
+ library => $branch->branchcode,
+ exclude_from_local_holds_priority => 0,
+ }
+ );
+
+ my $reserve_id = AddReserve(
+ {
+ branchcode => $branch2->branchcode,
+ borrowernumber => $other_patron->borrowernumber,
+ biblionumber => $biblio->biblionumber,
+ priority => 1,
+ }
+ );
+ my $reserve_id2 = AddReserve(
+ {
+ branchcode => $item->homebranch,
+ borrowernumber => $local_patron->borrowernumber,
+ biblionumber => $biblio->biblionumber,
+ priority => 2,
+ }
+ );
+
+ C4::HoldsQueue::CreateQueue();
+
+ my $queue_rs = $schema->resultset('TmpHoldsqueue');
+ my $target_rs = $schema->resultset('HoldFillTarget');
+ is( $queue_rs->count(), 1,
+ "Hold queue contains one hold" );
+ is(
+ $queue_rs->next->borrowernumber,
+ $local_patron->borrowernumber,
+ "We should pick the local hold over the next available"
+ );
+ is( $target_rs->next->reserve_id, $reserve_id2, "Reserve id correctly set in hold fill target" );
+};
+
+subtest "Test Local Holds Priority - Item level" => sub {
+ plan tests => 2;
+
+ Koha::Biblios->delete();
+ t::lib::Mocks::mock_preference( 'LocalHoldsPriority', 1 );
+ t::lib::Mocks::mock_preference( 'LocalHoldsPriorityPatronControl', 'PickupLibrary' );
+ t::lib::Mocks::mock_preference( 'LocalHoldsPriorityItemControl', 'homebranch' );
+ my $branch = $builder->build_object( { class => 'Koha::Libraries' } );
+ my $branch2 = $builder->build_object( { class => 'Koha::Libraries' } );
+ my $category = $builder->build_object( { class => 'Koha::Patron::Categories', value => {exclude_from_local_holds_priority => 0} });
+ my $local_patron = $builder->build_object(
+ {
+ class => "Koha::Patrons",
+ value => {
+ branchcode => $branch->branchcode,
+ categorycode => $category->categorycode
+ }
+ }
+ );
+ my $other_patron = $builder->build_object(
+ {
+ class => "Koha::Patrons",
+ value => {
+ branchcode => $branch2->branchcode,
+ categorycode => $category->categorycode
+ }
+ }
+ );
+ my $biblio = $builder->build_sample_biblio();
+ my $item = $builder->build_sample_item(
+ {
+ biblionumber => $biblio->biblionumber,
+ library => $branch->branchcode,
+ exclude_from_local_holds_priority => 0,
+ }
+ );
+
+ my $reserve_id = AddReserve(
+ {
+ branchcode => $branch2->branchcode,
+ borrowernumber => $other_patron->borrowernumber,
+ biblionumber => $biblio->biblionumber,
+ priority => 1,
+ itemnumber => $item->id,
+ }
+ );
+ my $reserve_id2 = AddReserve(
+ {
+ branchcode => $item->homebranch,
+ borrowernumber => $local_patron->borrowernumber,
+ biblionumber => $biblio->biblionumber,
+ priority => 2,
+ itemnumber => $item->id,
+ }
+ );
+
+ C4::HoldsQueue::CreateQueue();
+
+ my $queue_rs = $schema->resultset('TmpHoldsqueue');
+ my $q = $queue_rs->next;
+ is( $queue_rs->count(), 1,
+ "Hold queue contains one hold" );
+ is(
+ $q->borrowernumber,
+ $local_patron->borrowernumber,
+ "We should pick the local hold over the next available"
+ );
+};
+
+subtest "Test Local Holds Priority - Item level hold over Record level hold (Bug 23934)" => sub {
+ plan tests => 2;
+
+ Koha::Biblios->delete();
+ t::lib::Mocks::mock_preference( 'LocalHoldsPriority', 1 );
+ t::lib::Mocks::mock_preference( 'LocalHoldsPriorityPatronControl', 'PickupLibrary' );
+ t::lib::Mocks::mock_preference( 'LocalHoldsPriorityItemControl', 'homebranch' );
+ my $branch = $builder->build_object( { class => 'Koha::Libraries' } );
+ my $branch2 = $builder->build_object( { class => 'Koha::Libraries' } );
+ my $category = $builder->build_object( { class => 'Koha::Patron::Categories', value => {exclude_from_local_holds_priority => 0} });
+ my $local_patron = $builder->build_object(
+ {
+ class => "Koha::Patrons",
+ value => {
+ branchcode => $branch->branchcode,
+ categorycode => $category->categorycode,
+ }
+ }
+ );
+ my $other_patron = $builder->build_object(
+ {
+ class => "Koha::Patrons",
+ value => {
+ branchcode => $branch2->branchcode,
+ categorycode => $category->categorycode,
+ }
+ }
+ );
+ my $biblio = $builder->build_sample_biblio();
+ my $item = $builder->build_sample_item(
+ {
+ biblionumber => $biblio->biblionumber,
+ library => $branch->branchcode,
+ exclude_from_local_holds_priority => 0,
+ }
+ );
+
+ my $reserve_id = AddReserve(
+ {
+ branchcode => $branch2->branchcode,
+ borrowernumber => $other_patron->borrowernumber,
+ biblionumber => $biblio->biblionumber,
+ priority => 1,
+ }
+ );
+ my $reserve_id2 = AddReserve(
+ {
+ branchcode => $item->homebranch,
+ borrowernumber => $local_patron->borrowernumber,
+ biblionumber => $biblio->biblionumber,
+ priority => 2,
+ itemnumber => $item->id,
+ }
+ );
+
+ C4::HoldsQueue::CreateQueue();
+
+ my $queue_rs = $schema->resultset('TmpHoldsqueue');
+ my $q = $queue_rs->next;
+ is( $queue_rs->count(), 1,
+ "Hold queue contains one hold" );
+ is(
+ $q->borrowernumber,
+ $local_patron->borrowernumber,
+ "We should pick the local hold over the next available"
+ );
+};
+
+subtest "Test Local Holds Priority - Get correct item for item level hold" => sub {
+ plan tests => 3;
+
+ Koha::Biblios->delete();
+ t::lib::Mocks::mock_preference( 'LocalHoldsPriority', 1 );
+ t::lib::Mocks::mock_preference( 'LocalHoldsPriorityPatronControl', 'PickupLibrary' );
+ t::lib::Mocks::mock_preference( 'LocalHoldsPriorityItemControl', 'homebranch' );
+ my $branch = $builder->build_object( { class => 'Koha::Libraries' } );
+ my $branch2 = $builder->build_object( { class => 'Koha::Libraries' } );
+ my $category = $builder->build_object( { class => 'Koha::Patron::Categories', value => {exclude_from_local_holds_priority => 0} });
+ my $local_patron = $builder->build_object(
+ {
+ class => "Koha::Patrons",
+ value => {
+ branchcode => $branch->branchcode,
+ categorycode => $category->categorycode,
+ }
+ }
+ );
+ my $other_patron = $builder->build_object(
+ {
+ class => "Koha::Patrons",
+ value => {
+ branchcode => $branch2->branchcode,
+ categorycode => $category->categorycode,
+ }
+ }
+ );
+ my $biblio = $builder->build_sample_biblio();
+
+ my $item1 = $builder->build_sample_item(
+ {
+ biblionumber => $biblio->biblionumber,
+ library => $branch->branchcode,
+ exclude_from_local_holds_priority => 0,
+ }
+ );
+ my $item2 = $builder->build_sample_item(
+ {
+ biblionumber => $biblio->biblionumber,
+ library => $branch->branchcode,
+ exclude_from_local_holds_priority => 0,
+ }
+ );
+ my $item3 = $builder->build_sample_item(
+ {
+ biblionumber => $biblio->biblionumber,
+ library => $branch->branchcode,
+ exclude_from_local_holds_priority => 0,
+ }
+ );
+
+ my $reserve_id2 =
+ AddReserve(
+ {
+ branchcode => $item2->homebranch,
+ borrowernumber => $local_patron->borrowernumber,
+ biblionumber => $biblio->biblionumber,
+ priority => 2,
+ itemnumber => $item2->id,
+ }
+ );
+
+
+ C4::HoldsQueue::CreateQueue();
+
+ my $queue_rs = $schema->resultset('TmpHoldsqueue');
+ my $q = $queue_rs->next;
+ is( $queue_rs->count(), 1,
+ "Hold queue contains one hold" );
+ is(
+ $q->borrowernumber,
+ $local_patron->borrowernumber,
+ "We should pick the local hold over the next available"
+ );
+ is( $q->itemnumber->id, $item2->id, "Got the correct item for item level local holds priority" );
+};
+
+subtest "Test Local Holds Priority - Ensure no duplicate requests in holds queue (Bug 18001)" => sub {
+ plan tests => 1;
+
+ $dbh->do("DELETE FROM tmp_holdsqueue");
+ $dbh->do("DELETE FROM hold_fill_targets");
+ $dbh->do("DELETE FROM reserves");
+ $dbh->do("DELETE FROM circulation_rules");
+ Koha::Biblios->delete();
+
+ t::lib::Mocks::mock_preference( 'LocalHoldsPriority', 1 );
+ t::lib::Mocks::mock_preference( 'LocalHoldsPriorityPatronControl', 'PickupLibrary' );
+ t::lib::Mocks::mock_preference( 'LocalHoldsPriorityItemControl', 'homebranch' );
+ my $branch = $builder->build_object( { class => 'Koha::Libraries' } );
+ my $branch2 = $builder->build_object( { class => 'Koha::Libraries' } );
+ my $category = $builder->build_object( { class => 'Koha::Patron::Categories', value => {exclude_from_local_holds_priority => 0} });
+ my $patron = $builder->build_object(
+ {
+ class => "Koha::Patrons",
+ value => {
+ branchcode => $branch->branchcode,
+ categorycode => $category->categorycode,
+ }
+ }
+ );
+ my $biblio = $builder->build_sample_biblio();
+ my $item1 = $builder->build_sample_item(
+ {
+ biblionumber => $biblio->biblionumber,
+ library => $branch->branchcode,
+ exclude_from_local_holds_priority => 0,
+ }
+ );
+ my $item2 = $builder->build_sample_item(
+ {
+ biblionumber => $biblio->biblionumber,
+ library => $branch->branchcode,
+ exclude_from_local_holds_priority => 0,
+ }
+ );
+
+ my $item3 = $builder->build_sample_item(
+ {
+ biblionumber => $biblio->biblionumber,
+ library => $branch->branchcode,
+ exclude_from_local_holds_priority => 0,
+ }
+ );
+
+ $reserve_id = AddReserve(
+ {
+ branchcode => $item1->homebranch,
+ borrowernumber => $patron->borrowernumber,
+ biblionumber => $biblio->id,
+ priority => 1
+ }
+ );
+
+ C4::HoldsQueue::CreateQueue();
+
+ my $queue_rs = $schema->resultset('TmpHoldsqueue');
+
+ is( $queue_rs->count(), 1,
+ "Hold queue contains one hold from chosen from three possible items" );
+};
+
+
+subtest "Item level holds info is preserved (Bug 25738)" => sub {
+
+ plan tests => 4;
+
+ $dbh->do("DELETE FROM tmp_holdsqueue");
+ $dbh->do("DELETE FROM hold_fill_targets");
+ $dbh->do("DELETE FROM reserves");
+ $dbh->do("DELETE FROM circulation_rules");
+
+ my $library = $builder->build_object({ class => 'Koha::Libraries' });
+ my $category = $builder->build_object( { class => 'Koha::Patron::Categories', value => {exclude_from_local_holds_priority => 0} });
+ my $patron_1 = $builder->build_object(
+ {
+ class => "Koha::Patrons",
+ value => {
+ branchcode => $library->branchcode,
+ categorycode => $category->categorycode
+ }
+ }
+ );
+
+ my $patron_2 = $builder->build_object(
+ {
+ class => "Koha::Patrons",
+ value => {
+ branchcode => $library->branchcode,
+ categorycode => $category->categorycode
+ }
+ }
+ );
+
+ my $biblio = $builder->build_sample_biblio();
+ my $item_1 = $builder->build_sample_item(
+ {
+ biblionumber => $biblio->biblionumber,
+ library => $library->branchcode,
+ exclude_from_local_holds_priority => 0,
+ }
+ );
+ my $item_2 = $builder->build_sample_item(
+ {
+ biblionumber => $biblio->biblionumber,
+ library => $library->branchcode,
+ exclude_from_local_holds_priority => 0,
+ }
+ );
+
+ # Add item-level hold for patron_1
+ my $reserve_id_1 = AddReserve(
+ {
+ branchcode => $library->branchcode,
+ borrowernumber => $patron_1->borrowernumber,
+ biblionumber => $biblio->id,
+ itemnumber => $item_1->itemnumber,
+ priority => 1
+ }
+ );
+
+ my $reserve_id_2 = AddReserve(
+ {
+ branchcode => $library->branchcode,
+ borrowernumber => $patron_2->borrowernumber,
+ biblionumber => $biblio->id,
+ priority => 2
+ }
+ );
+
+ C4::HoldsQueue::CreateQueue();
+
+ my $queue_rs = $schema->resultset('TmpHoldsqueue');
+
+ is( $queue_rs->count(), 2, "Hold queue contains two holds" );
+
+ my $queue_line_1 = $queue_rs->next;
+ is( $queue_line_1->item_level_request, 1, 'Request is correctly advertised as item-level' );
+ my $target_rs = $schema->resultset('HoldFillTarget')->search({borrowernumber=>$patron_1->borrowernumber});;
+ is( $target_rs->next->reserve_id, $reserve_id_1, "Reserve id correctly set in hold fill target for item level hold" );
+
+ my $queue_line_2 = $queue_rs->next;
+ is( $queue_line_2->item_level_request, 0, 'Request is correctly advertised as biblio-level' );
+
+};
+
+subtest 'Trivial test for UpdateTransportCostMatrix' => sub {
+ plan tests => 1;
+ my $recs = [
+ { frombranch => $library1->{branchcode}, tobranch => $library2->{branchcode}, cost => 1, disable_transfer => 0 },
+ { frombranch => $library2->{branchcode}, tobranch => $library3->{branchcode}, cost => 0, disable_transfer => 1 },
+ ];
+ C4::HoldsQueue::UpdateTransportCostMatrix( $recs );
+ is( $schema->resultset('TransportCost')->count, 2, 'UpdateTransportCostMatrix added two records' );
+};
+
+subtest 'Excludes from local holds priority' => sub {
+ plan tests => 8;
+
+ Koha::Holds->delete;
+
+ t::lib::Mocks::mock_preference( 'LocalHoldsPriority', 1 );
+ t::lib::Mocks::mock_preference( 'LocalHoldsPriorityPatronControl', 'PickupLibrary' );
+ t::lib::Mocks::mock_preference( 'LocalHoldsPriorityItemControl', 'homebranch' );
+
+ my $branch = $builder->build_object( { class => 'Koha::Libraries' } );
+ my $branch2 = $builder->build_object( { class => 'Koha::Libraries' } );
+ my $category = $builder->build_object( { class => 'Koha::Patron::Categories', value => {exclude_from_local_holds_priority => 0} });
+ my $excluded_category = $builder->build_object( { class => 'Koha::Patron::Categories', value => {exclude_from_local_holds_priority => 1} });
+ my $local_patron_excluded = $builder->build_object(
+ {
+ class => "Koha::Patrons",
+ value => {
+ branchcode => $branch->branchcode,
+ categorycode => $excluded_category->categorycode
+ }
+ }
+ );
+
+ my $local_patron_not_excluded = $builder->build_object(
+ {
+ class => "Koha::Patrons",
+ value => {
+ branchcode => $branch->branchcode,
+ categorycode => $category->categorycode
+ }
+ }
+ );
+
+ my $other_patron = $builder->build_object(
+ {
+ class => "Koha::Patrons",
+ value => {
+ branchcode => $branch2->branchcode,
+ categorycode => $category->categorycode
+ }
+ }
+ );
+
+ my $item1 = $builder->build_sample_item(
+ {
+ library => $branch->branchcode,
+ exclude_from_local_holds_priority => 0,
+ }
+ );
+
+ AddReserve(
+ {
+ branchcode => $other_patron->branchcode,
+ borrowernumber => $other_patron->borrowernumber,
+ biblionumber => $item1->biblionumber,
+ priority => 1,
+ itemtype => $item1->effective_itemtype
+ }
+ );
+
+ AddReserve(
+ {
+ branchcode => $local_patron_excluded->branchcode,
+ borrowernumber => $local_patron_excluded->borrowernumber,
+ biblionumber => $item1->biblionumber,
+ priority => 2,
+ itemtype => $item1->effective_itemtype
+ }
+ );
+
+ AddReserve(
+ {
+ branchcode => $local_patron_not_excluded->branchcode,
+ borrowernumber => $local_patron_not_excluded->borrowernumber,
+ biblionumber => $item1->biblionumber,
+ priority => 3,
+ itemtype => $item1->effective_itemtype
+ }
+ );
+
+ C4::HoldsQueue::CreateQueue();
+
+ my $queue_rs = $schema->resultset('TmpHoldsqueue');
+ my $next = $queue_rs->next;
+ is($queue_rs->count, 1, 'Only 1 patron queueud' );
+ is($next->borrowernumber, $local_patron_not_excluded->borrowernumber, 'Not excluded local patron is queued');
+
+ my $item2 = $builder->build_sample_item(
+ {
+ biblionumber => $item1->biblionumber,
+ library => $branch->branchcode,
+ exclude_from_local_holds_priority => 1,
+ }
+ );
+ C4::HoldsQueue::CreateQueue();
+
+ $queue_rs = $schema->resultset('TmpHoldsqueue');
+ is( $queue_rs->count, 2, '2 patrons queued' );
+ $next = $queue_rs->next;
+ is($next->borrowernumber, $local_patron_not_excluded->borrowernumber, 'Not excluded local patron is queued');
+ $next = $queue_rs->next;
+ is($next->borrowernumber, $other_patron->borrowernumber, 'Other patron is queued');
+
+ $item1->exclude_from_local_holds_priority(1)->store;
+
+ C4::HoldsQueue::CreateQueue();
+
+ $queue_rs = $schema->resultset('TmpHoldsqueue');
+ is( $queue_rs->count, 2, '2 patrons queued' );
+ $next = $queue_rs->next;
+ is($next->borrowernumber, $other_patron->borrowernumber, 'Other patron is queued');
+ $next = $queue_rs->next;
+ is($next->borrowernumber, $local_patron_excluded->borrowernumber, 'Excluded local patron is queued');
+};