Bug 17600: Standardize our EXPORT_OK

[srvgit] / cataloguing / value_builder / unimarc_field_225a.pl

diff --git a/cataloguing/value_builder/unimarc_field_225a.pl b/cataloguing/value_builder/unimarc_field_225a.pl
index bbefb3c..761302c 100755 (executable)
--- a/cataloguing/value_builder/unimarc_field_225a.pl
+++ b/cataloguing/value_builder/unimarc_field_225a.pl
@@ -5,18 +5,18 @@
 #
 # This file is part of Koha.
 #
 #
 # This file is part of Koha.
 #

-# Koha is free software; you can redistribute it and/or modify it under the
-# terms of the GNU General Public License as published by the Free Software
-# Foundation; either version 2 of the License, or (at your option) any later
-# version.
+# Koha is free software; you can redistribute it and/or modify it
+# under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.

 #
 #

-# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
-# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
-# A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
+# Koha is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.

 #
 #

-# You should have received a copy of the GNU General Public License along
-# with Koha; if not, write to the Free Software Foundation, Inc.,
-# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+# You should have received a copy of the GNU General Public License
+# along with Koha; if not, see <http://www.gnu.org/licenses>.

 
 =head1 SYNOPSIS
 
 
 =head1 SYNOPSIS
 


@@ -37,44 +37,33 @@ It need :
   if the biblio has no isbn, then the search if done on editor only
   If the biblio ha an isbn, the search is done on isbn and editor. It's faster.
 
   if the biblio has no isbn, then the search if done on editor only
   If the biblio ha an isbn, the search is done on isbn and editor. It's faster.
 

-=over 2
-

 =cut
 
 use strict;
 =cut
 
 use strict;

-use C4::Auth;
-use CGI;
+#use warnings; FIXME - Bug 2505
+use C4::Auth qw( get_template_and_user );
+use CGI qw ( -utf8 );

 use C4::Context;
 
 use C4::Context;
 

-use C4::AuthoritiesMarc;
-use C4::Output;
+use C4::Auth qw( get_template_and_user );
+use C4::Output qw( output_html_with_http_headers );
+use C4::AuthoritiesMarc qw( SearchAuthorities GetAuthority );

 
 

-=head1
+=head1 DESCRIPTION

 
 plugin_parameters : other parameters added when the plugin is called by the dopop function
 
 =cut
 
 
 plugin_parameters : other parameters added when the plugin is called by the dopop function
 
 =cut
 

-sub plugin_parameters {
-    my ( $dbh, $record, $tagslib, $i, $tabloop ) = @_;
-    return "";
-}
-

 sub plugin_javascript {
     my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_;
     my $function_name = $field_number;
     my $res = "
 sub plugin_javascript {
     my ( $dbh, $record, $tagslib, $field_number, $tabloop ) = @_;
     my $function_name = $field_number;
     my $res = "

-    <script type=\"text/javascript\">
-        function Focus$function_name(subfield_managed) {
-            return 1;
-        }
+    <script>

     
     

-        function Blur$function_name(subfield_managed) {
-            return 1;
-        }

     
         function Clic$function_name(index) {
     
         function Clic$function_name(index) {

-        // find the 010a value and the 210c. it will be used in the popup to find possibles collections
+        /* find the 010a value and the 210c. it will be used in the popup to find possibles collections */

             var isbn_found   = 0;
             var editor_found = 0;
             
             var isbn_found   = 0;
             var editor_found = 0;
             


@@ -93,7 +82,7 @@ sub plugin_javascript {
             }
                     
             defaultvalue = document.getElementById(\"$field_number\").value;
             }
                     
             defaultvalue = document.getElementById(\"$field_number\").value;

-            window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_225a.pl&index=\"+index+\"&result=\"+defaultvalue+\"&editor_found=\"+editor_found,\"unimarc225a\",'width=500,height=200,toolbar=false,scrollbars=no');
+            window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_225a.pl&index=\"+index+\"&result=\"+defaultvalue+\"&editor_found=\"+editor_found,\"unimarc225a\",'width=500,height=400,toolbar=false,scrollbars=no');

     
         }
     </script>
     
         }
     </script>


@@ -107,17 +96,15 @@ sub plugin {
     my $index        = $input->param('index');
     my $result       = $input->param('result');
     my $editor_found = $input->param('editor_found');
     my $index        = $input->param('index');
     my $result       = $input->param('result');
     my $editor_found = $input->param('editor_found');

-    my $authoritysep = C4::Context->preference("authoritysep");
+    my $AuthoritySeparator = C4::Context->preference("AuthoritySeparator");

     
     my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
         {
             template_name =>
     
     my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
         {
             template_name =>

-              "cataloguing/value_builder/unimarc_field_225a.tmpl",
+              "cataloguing/value_builder/unimarc_field_225a.tt",

             query           => $input,
             type            => "intranet",
             query           => $input,
             type            => "intranet",

-            authnotrequired => 0,

             flagsrequired   => { editcatalogue => '*' },
             flagsrequired   => { editcatalogue => '*' },

-            debug           => 1,

         }
     );
 
         }
     );
 


@@ -143,19 +130,15 @@ sub plugin {
             
     } 
     @collections = sort @collections;
             
     } 
     @collections = sort @collections;

-    #  my @collections = ["test"];
-    my $collection = CGI::scrolling_list(
-        -name     => 'f1',
-        -values   => \@collections,
-        -default  => "$result",
-        -size     => 1,
-        -multiple => 0,
-    );
+    # my @collections = ( "test" );
+    my $collection = {
+            values  => \@collections,
+            default => "$result",
+    };
+

     $template->param(
         index      => $index,
         collection => $collection
     );
     output_html_with_http_headers $input, $cookie, $template->output;
 }
     $template->param(
         index      => $index,
         collection => $collection
     );
     output_html_with_http_headers $input, $cookie, $template->output;
 }

-
-1;