- foreach my $itemx (@{$patron->{items}}) {
- my $item_id = $itemx->{barcode};
- my $item = new ILS::Item $item_id;
- if (!defined($item)) {
- syslog("LOG_WARNING",
- "renew_all: Invalid item id '%s' associated with patron '%s'",
- $item_id, $patron->id);
- $all_ok = 0;
- next;
- }
- $self->{item} = $item;
- $self->do_renew_for($borrower);
- if ($self->ok) {
- $item->{due_date} = $self->{due};
- push @{$self->{renewed} }, $item_id;
- } else {
- push @{$self->{unrenewed}}, $item_id;
- }
- }
- $self->ok($all_ok);
- return $self;
+ foreach my $itemx ( @{ $patron->{items} } ) {
+ my $item_id = $itemx->{barcode};
+ my $item = ILS::Item->new($item_id);
+ if ( !defined($item) ) {
+ syslog(
+ 'LOG_WARNING',
+ q|renew_all: Invalid item id '%s' associated with patron '%s'|,
+ $item_id,
+ $patron->id
+ );
+
+ # $all_ok = 0; Do net set as still ok
+ push @{ $self->unrenewed }, $item_id;
+ next;
+ }
+ $self->{item} = $item;
+ $self->do_renew_for($borrower);
+ if ( $self->renewal_ok ) {
+ $item->{due_date} = $self->{due};
+ push @{ $self->{renewed} }, $item_id;
+ }
+ else {
+ push @{ $self->{unrenewed} }, $item_id;
+ }
+ $self->screen_msg(q{}); # clear indiv message
+ }
+ $self->ok($all_ok);
+ return $self;