3 # This file is part of Koha.
5 # Koha is free software; you can redistribute it and/or modify it
6 # under the terms of the GNU General Public License as published by
7 # the Free Software Foundation; either version 3 of the License, or
8 # (at your option) any later version.
10 # Koha is distributed in the hope that it will be useful, but
11 # WITHOUT ANY WARRANTY; without even the implied warranty of
12 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 # GNU General Public License for more details.
15 # You should have received a copy of the GNU General Public License
16 # along with Koha; if not, see <http://www.gnu.org/licenses>.
22 use Test::More tests => 6;
25 use t::lib::TestBuilder;
30 use_ok('C4::ILSDI::Services');
33 my $schema = Koha::Database->schema;
34 my $dbh = C4::Context->dbh;
35 my $builder = t::lib::TestBuilder->new;
37 subtest 'AuthenticatePatron test' => sub {
41 $schema->storage->txn_begin;
43 my $plain_password = 'tomasito';
52 my $borrower = $builder->build({
56 password => Koha::AuthUtils::hash_password( $plain_password )
61 $query->param( 'username', $borrower->{userid});
62 $query->param( 'password', $plain_password);
64 my $reply = C4::ILSDI::Services::AuthenticatePatron( $query );
65 is( $reply->{id}, $borrower->{borrowernumber}, "userid and password - Patron authenticated" );
66 is( $reply->{code}, undef, "Error code undef");
68 $query->param('password','ilsdi-passworD');
69 $reply = C4::ILSDI::Services::AuthenticatePatron( $query );
70 is( $reply->{code}, 'PatronNotFound', "userid and wrong password - PatronNotFound" );
71 is( $reply->{id}, undef, "id undef");
73 $query->param( 'password', $plain_password );
74 $query->param( 'username', 'wrong-ilsdi-useriD' );
75 $reply = C4::ILSDI::Services::AuthenticatePatron( $query );
76 is( $reply->{code}, 'PatronNotFound', "non-existing userid - PatronNotFound" );
77 is( $reply->{id}, undef, "id undef");
79 $query->param( 'username', uc( $borrower->{userid} ));
80 $reply = C4::ILSDI::Services::AuthenticatePatron( $query );
81 is( $reply->{id}, $borrower->{borrowernumber}, "userid is not case sensitive - Patron authenticated" );
82 is( $reply->{code}, undef, "Error code undef");
84 $query->param( 'username', $borrower->{cardnumber} );
85 $reply = C4::ILSDI::Services::AuthenticatePatron( $query );
86 is( $reply->{id}, $borrower->{borrowernumber}, "cardnumber and password - Patron authenticated" );
87 is( $reply->{code}, undef, "Error code undef" );
89 $query->param( 'password', 'ilsdi-passworD' );
90 $reply = C4::ILSDI::Services::AuthenticatePatron( $query );
91 is( $reply->{code}, 'PatronNotFound', "cardnumber and wrong password - PatronNotFount" );
92 is( $reply->{id}, undef, "id undef" );
94 $query->param( 'username', 'randomcardnumber1234' );
95 $query->param( 'password', $plain_password );
96 $reply = C4::ILSDI::Services::AuthenticatePatron($query);
97 is( $reply->{code}, 'PatronNotFound', "non-existing cardnumer/userid - PatronNotFound" );
98 is( $reply->{id}, undef, "id undef");
100 $schema->storage->txn_rollback;
104 subtest 'GetPatronInfo/GetBorrowerAttributes test for extended patron attributes' => sub {
108 $schema->storage->txn_begin;
110 $schema->resultset( 'Issue' )->delete_all;
111 $schema->resultset( 'Borrower' )->delete_all;
112 $schema->resultset( 'BorrowerAttribute' )->delete_all;
113 $schema->resultset( 'BorrowerAttributeType' )->delete_all;
114 $schema->resultset( 'Category' )->delete_all;
115 $schema->resultset( 'Item' )->delete_all; # 'Branch' deps. on this
116 $schema->resultset( 'Club' )->delete_all;
117 $schema->resultset( 'Branch' )->delete_all;
119 # Configure Koha to enable ILS-DI server and extended attributes:
120 t::lib::Mocks::mock_preference( 'ILS-DI', 1 );
121 t::lib::Mocks::mock_preference( 'ExtendedPatronAttributes', 1 );
123 # Set up a library/branch for our user to belong to:
124 my $lib = $builder->build( {
127 branchcode => 'T_ILSDI',
131 # Create a new category for user to belong to:
132 my $cat = $builder->build( {
133 source => 'Category',
135 category_type => 'A',
136 BlockExpiredPatronOpacActions => -1,
140 # Create a new attribute type:
141 my $attr_type = $builder->build( {
142 source => 'BorrowerAttributeType',
146 authorised_value_category => '',
150 my $attr_type_visible = $builder->build( {
151 source => 'BorrowerAttributeType',
155 authorised_value_category => '',
161 my $brwr = $builder->build( {
162 source => 'Borrower',
164 categorycode => $cat->{'categorycode'},
165 branchcode => $lib->{'branchcode'},
170 my $auth = $builder->build( {
171 source => 'AuthorisedValue',
173 category => $cat->{'categorycode'}
177 # Set the new attribute for our user:
178 my $attr_hidden = $builder->build( {
179 source => 'BorrowerAttribute',
181 borrowernumber => $brwr->{'borrowernumber'},
182 code => $attr_type->{'code'},
183 attribute => '1337 hidden',
186 my $attr_shown = $builder->build( {
187 source => 'BorrowerAttribute',
189 borrowernumber => $brwr->{'borrowernumber'},
190 code => $attr_type_visible->{'code'},
191 attribute => '1337 shown',
195 my $fine = $builder->build(
197 source => 'Accountline',
199 borrowernumber => $brwr->{borrowernumber},
201 accounttype => 'xxx',
202 amountoutstanding => 10
207 # Prepare and send web request for IL-SDI server:
209 $query->param( 'service', 'GetPatronInfo' );
210 $query->param( 'patron_id', $brwr->{'borrowernumber'} );
211 $query->param( 'show_attributes', '1' );
212 $query->param( 'show_fines', '1' );
214 my $reply = C4::ILSDI::Services::GetPatronInfo( $query );
216 # Build a structure for comparison:
218 category_code => $attr_type_visible->{'category_code'},
219 class => $attr_type_visible->{'class'},
220 code => $attr_shown->{'code'},
221 description => $attr_type_visible->{'description'},
222 display_checkout => $attr_type_visible->{'display_checkout'},
223 value => $attr_shown->{'attribute'},
224 value_description => undef,
227 is( $reply->{'charges'}, '10.00',
228 'The \'charges\' attribute should be correctly filled (bug 17836)' );
230 is( scalar( @{$reply->{fines}->{fine}}), 1, 'There should be only 1 account line');
232 $reply->{fines}->{fine}->[0]->{accountlines_id},
233 $fine->{accountlines_id},
234 "The accountline should be the correct one"
238 is_deeply( $reply->{'attributes'}, [ $cmp ], 'Test GetPatronInfo - show_attributes parameter' );
240 ok( exists $reply->{is_expired}, 'There should be the is_expired information');
243 $schema->storage->txn_rollback;
247 subtest 'LookupPatron test' => sub {
251 $schema->storage->txn_begin;
253 $schema->resultset( 'Issue' )->delete_all;
254 $schema->resultset( 'Borrower' )->delete_all;
255 $schema->resultset( 'BorrowerAttribute' )->delete_all;
256 $schema->resultset( 'BorrowerAttributeType' )->delete_all;
257 $schema->resultset( 'Category' )->delete_all;
258 $schema->resultset( 'Item' )->delete_all; # 'Branch' deps. on this
259 $schema->resultset( 'Branch' )->delete_all;
261 my $borrower = $builder->build({
262 source => 'Borrower',
265 my $query = CGI->new();
266 my $bad_result = C4::ILSDI::Services::LookupPatron($query);
267 is( $bad_result->{message}, 'PatronNotFound', 'No parameters' );
269 $query->delete_all();
270 $query->param( 'id', $borrower->{firstname} );
271 my $optional_result = C4::ILSDI::Services::LookupPatron($query);
273 $optional_result->{id},
274 $borrower->{borrowernumber},
275 'Valid Firstname only'
278 $query->delete_all();
279 $query->param( 'id', 'ThereIsNoWayThatThisCouldPossiblyBeValid' );
280 my $bad_optional_result = C4::ILSDI::Services::LookupPatron($query);
281 is( $bad_optional_result->{message}, 'PatronNotFound', 'Invalid ID' );
283 foreach my $id_type (
291 $query->delete_all();
292 $query->param( 'id_type', $id_type );
293 $query->param( 'id', $borrower->{$id_type} );
294 my $result = C4::ILSDI::Services::LookupPatron($query);
295 is( $result->{'id'}, $borrower->{borrowernumber}, "Checking $id_type" );
299 $schema->storage->txn_rollback;
302 subtest 'Holds test' => sub {
306 $schema->storage->txn_begin;
308 t::lib::Mocks::mock_preference( 'AllowHoldsOnDamagedItems', 0 );
310 my $patron = $builder->build({
311 source => 'Borrower',
314 my $biblio = $builder->build({
318 my $biblioitems = $builder->build({
319 source => 'Biblioitem',
321 biblionumber => $biblio->{biblionumber},
325 my $item = $builder->build({
328 biblionumber => $biblio->{biblionumber},
334 $query->param( 'patron_id', $patron->{borrowernumber});
335 $query->param( 'bib_id', $biblio->{biblionumber});
337 my $reply = C4::ILSDI::Services::HoldTitle( $query );
338 is( $reply->{code}, 'damaged', "Item damaged" );
340 my $item_o = Koha::Items->find($item->{itemnumber});
341 $item_o->damaged(0)->store;
343 my $hold = $builder->build({
346 borrowernumber => $patron->{borrowernumber},
347 biblionumber => $biblio->{biblionumber},
348 itemnumber => $item->{itemnumber}
352 $reply = C4::ILSDI::Services::HoldTitle( $query );
353 is( $reply->{code}, 'itemAlreadyOnHold', "Item already on hold" );
355 my $biblio_with_no_item = $builder->build({
360 $query->param( 'patron_id', $patron->{borrowernumber});
361 $query->param( 'bib_id', $biblio_with_no_item->{biblionumber});
363 $reply = C4::ILSDI::Services::HoldTitle( $query );
364 is( $reply->{code}, 'NoItems', 'Biblio has no item' );
366 my $biblio2 = $builder->build({
370 my $biblioitems2 = $builder->build({
371 source => 'Biblioitem',
373 biblionumber => $biblio2->{biblionumber},
377 my $item2 = $builder->build({
380 biblionumber => $biblio2->{biblionumber},
385 t::lib::Mocks::mock_preference( 'ReservesControlBranch', 'PatronLibrary' );
386 my $issuingrule = $builder->build({
387 source => 'Issuingrule',
389 categorycode => $patron->{categorycode},
390 itemtype => $item2->{itype},
391 branchcode => $patron->{branchcode},
392 reservesallowed => 0,
397 $query->param( 'patron_id', $patron->{borrowernumber});
398 $query->param( 'bib_id', $biblio2->{biblionumber});
399 $query->param( 'item_id', $item2->{itemnumber});
401 $reply = C4::ILSDI::Services::HoldItem( $query );
402 is( $reply->{code}, 'tooManyReserves', "Too many reserves" );
404 my $biblio3 = $builder->build({
408 my $biblioitems3 = $builder->build({
409 source => 'Biblioitem',
411 biblionumber => $biblio3->{biblionumber},
415 # Adding a holdable item to biblio 3.
416 my $item3 = $builder->build({
419 biblionumber => $biblio3->{biblionumber},
424 my $item4 = $builder->build({
427 biblionumber => $biblio3->{biblionumber},
432 my $issuingrule2 = $builder->build({
433 source => 'Issuingrule',
435 categorycode => $patron->{categorycode},
436 itemtype => $item3->{itype},
437 branchcode => $patron->{branchcode},
438 reservesallowed => 10,
443 $query->param( 'patron_id', $patron->{borrowernumber});
444 $query->param( 'bib_id', $biblio3->{biblionumber});
445 $query->param( 'item_id', $item4->{itemnumber});
447 $reply = C4::ILSDI::Services::HoldItem( $query );
448 is( $reply->{code}, 'damaged', "Item is damaged" );
450 $schema->storage->txn_rollback;
453 subtest 'Holds test for branch transfer limits' => sub {
457 $schema->storage->txn_begin;
459 # Test enforement of branch transfer limits
460 t::lib::Mocks::mock_preference( 'UseBranchTransferLimits', '1' );
461 t::lib::Mocks::mock_preference( 'BranchTransferLimitsType', 'itemtype' );
463 my $patron = $builder->build({
464 source => 'Borrower',
467 my $origin_branch = $builder->build(
471 pickup_location => 1,
475 my $pickup_branch = $builder->build(
479 pickup_location => 1,
484 my $biblio = $builder->build({
487 my $biblioitem = $builder->build({
488 source => 'Biblioitem',
490 biblionumber => $biblio->{biblionumber},
493 my $item = $builder->build({
496 homebranch => $origin_branch->{branchcode},
497 holdingbranch => $origin_branch->{branchcode},
498 biblionumber => $biblio->{biblionumber},
504 Koha::IssuingRules->search()->delete();
505 my $issuingrule = $builder->build({
506 source => 'Issuingrule',
511 reservesallowed => 99,
515 my $limit = Koha::Item::Transfer::Limit->new({
516 toBranch => $pickup_branch->{branchcode},
517 fromBranch => $item->{holdingbranch},
518 itemtype => $item->{itype},
522 $query->param( 'pickup_location', $pickup_branch->{branchcode} );
523 $query->param( 'patron_id', $patron->{borrowernumber});
524 $query->param( 'bib_id', $biblio->{biblionumber});
525 $query->param( 'item_id', $item->{itemnumber});
527 my $reply = C4::ILSDI::Services::HoldItem( $query );
528 is( $reply->{code}, 'cannotBeTransferred', "Item hold, Item cannot be transferred" );
530 $reply = C4::ILSDI::Services::HoldTitle( $query );
531 is( $reply->{code}, 'cannotBeTransferred', "Record hold, Item cannot be transferred" );
533 t::lib::Mocks::mock_preference( 'UseBranchTransferLimits', '0' );
535 $reply = C4::ILSDI::Services::HoldItem( $query );
536 is( $reply->{code}, undef, "Item hold, Item can be transferred" );
538 Koha::Holds->search()->delete();
540 $reply = C4::ILSDI::Services::HoldTitle( $query );
541 is( $reply->{code}, undef, "Record hold, Item con be transferred" );
543 $schema->storage->txn_rollback;