6 use t::lib::TestBuilder;
10 use Test::More tests => 63;
19 use Koha::CirculationRules;
21 use Koha::DateUtils qw( dt_from_string output_pref );
23 use Koha::Item::Transfer::Limits;
26 use Koha::Library::Groups;
31 use lib $FindBin::Bin;
34 my $schema = Koha::Database->new->schema;
35 $schema->storage->txn_begin;
37 my $builder = t::lib::TestBuilder->new();
38 my $dbh = C4::Context->dbh;
40 # Create two random branches
41 my $branch_1 = $builder->build({ source => 'Branch' })->{ branchcode };
42 my $branch_2 = $builder->build({ source => 'Branch' })->{ branchcode };
44 my $category = $builder->build({ source => 'Category' });
46 my $borrowers_count = 5;
48 $dbh->do('DELETE FROM itemtypes');
49 $dbh->do('DELETE FROM reserves');
50 $dbh->do('DELETE FROM circulation_rules');
51 my $insert_sth = $dbh->prepare('INSERT INTO itemtypes (itemtype) VALUES (?)');
52 $insert_sth->execute('CAN');
53 $insert_sth->execute('CANNOT');
54 $insert_sth->execute('DUMMY');
55 $insert_sth->execute('ONLY1');
57 # Setup Test------------------------
58 my $biblio = $builder->build_sample_biblio({ itemtype => 'DUMMY' });
60 # Create item instance for testing.
61 my $itemnumber = $builder->build_sample_item({ library => $branch_1, biblionumber => $biblio->biblionumber })->itemnumber;
63 # Create some borrowers
65 foreach (1..$borrowers_count) {
66 my $borrowernumber = Koha::Patron->new({
67 firstname => 'my firstname',
68 surname => 'my surname ' . $_,
69 categorycode => $category->{categorycode},
70 branchcode => $branch_1,
71 })->store->borrowernumber;
72 push @borrowernumbers, $borrowernumber;
75 # Create five item level holds
76 foreach my $borrowernumber ( @borrowernumbers ) {
79 branchcode => $branch_1,
80 borrowernumber => $borrowernumber,
81 biblionumber => $biblio->biblionumber,
82 priority => C4::Reserves::CalculatePriority( $biblio->biblionumber ),
83 itemnumber => $itemnumber,
88 my $holds = $biblio->holds;
89 is( $holds->count, $borrowers_count, 'Test GetReserves()' );
90 is( $holds->next->priority, 1, "Reserve 1 has a priority of 1" );
91 is( $holds->next->priority, 2, "Reserve 2 has a priority of 2" );
92 is( $holds->next->priority, 3, "Reserve 3 has a priority of 3" );
93 is( $holds->next->priority, 4, "Reserve 4 has a priority of 4" );
94 is( $holds->next->priority, 5, "Reserve 5 has a priority of 5" );
96 my $item = Koha::Items->find( $itemnumber );
97 $holds = $item->current_holds;
98 my $first_hold = $holds->next;
99 my $reservedate = $first_hold->reservedate;
100 my $borrowernumber = $first_hold->borrowernumber;
101 my $branch_1code = $first_hold->branchcode;
102 my $reserve_id = $first_hold->reserve_id;
103 is( $reservedate, output_pref({ dt => dt_from_string, dateformat => 'iso', dateonly => 1 }), "holds_placed_today should return a valid reserve date");
104 is( $borrowernumber, $borrowernumbers[0], "holds_placed_today should return a valid borrowernumber");
105 is( $branch_1code, $branch_1, "holds_placed_today should return a valid branchcode");
106 ok($reserve_id, "Test holds_placed_today()");
108 my $hold = Koha::Holds->find( $reserve_id );
109 ok( $hold, "Koha::Holds found the hold" );
110 my $hold_biblio = $hold->biblio();
111 ok( $hold_biblio, "Got biblio using biblio() method" );
112 ok( $hold_biblio == $hold->biblio(), "biblio method returns stashed biblio" );
113 my $hold_item = $hold->item();
114 ok( $hold_item, "Got item using item() method" );
115 ok( $hold_item == $hold->item(), "item method returns stashed item" );
116 my $hold_branch = $hold->branch();
117 ok( $hold_branch, "Got branch using branch() method" );
118 ok( $hold_branch == $hold->branch(), "branch method returns stashed branch" );
119 my $hold_found = $hold->found();
120 $hold->set({ found => 'W'})->store();
121 is( Koha::Holds->waiting()->count(), 1, "Koha::Holds->waiting returns waiting holds" );
122 is( Koha::Holds->unfilled()->count(), 4, "Koha::Holds->unfilled returns unfilled holds" );
124 my $patron = Koha::Patrons->find( $borrowernumbers[0] );
125 $holds = $patron->holds;
126 is( $holds->next->borrowernumber, $borrowernumbers[0], "Test Koha::Patron->holds");
129 $holds = $item->current_holds;
130 $first_hold = $holds->next;
131 $borrowernumber = $first_hold->borrowernumber;
132 $branch_1code = $first_hold->branchcode;
133 $reserve_id = $first_hold->reserve_id;
136 reserve_id => $reserve_id,
138 branchcode => $branch_1,
139 itemnumber => $itemnumber,
140 suspend_until => output_pref( { dt => dt_from_string( "2013-01-01", "iso" ), dateonly => 1 } ),
143 $hold = Koha::Holds->find( $reserve_id );
144 ok( $hold->priority eq '4', "Test ModReserve, priority changed correctly" );
145 ok( $hold->suspend, "Test ModReserve, suspend hold" );
146 is( $hold->suspend_until, '2013-01-01 00:00:00', "Test ModReserve, suspend until date" );
148 ModReserve({ # call without reserve_id
150 biblionumber => $biblio->biblionumber,
151 itemnumber => $itemnumber,
152 borrowernumber => $borrowernumber,
154 $hold = Koha::Holds->find( $reserve_id );
155 ok( $hold->priority eq '3', "Test ModReserve, priority changed correctly" );
157 ToggleSuspend( $reserve_id );
158 $hold = Koha::Holds->find( $reserve_id );
159 ok( ! $hold->suspend, "Test ToggleSuspend(), no date" );
161 ToggleSuspend( $reserve_id, '2012-01-01' );
162 $hold = Koha::Holds->find( $reserve_id );
163 is( $hold->suspend_until, '2012-01-01 00:00:00', "Test ToggleSuspend(), with date" );
165 AutoUnsuspendReserves();
166 $hold = Koha::Holds->find( $reserve_id );
167 ok( ! $hold->suspend, "Test AutoUnsuspendReserves()" );
170 borrowernumber => $borrowernumber,
171 biblionumber => $biblio->biblionumber,
173 suspend_until => '2012-01-01',
175 $hold = Koha::Holds->find( $reserve_id );
176 is( $hold->suspend, 1, "Test SuspendAll()" );
177 is( $hold->suspend_until, '2012-01-01 00:00:00', "Test SuspendAll(), with date" );
180 borrowernumber => $borrowernumber,
181 biblionumber => $biblio->biblionumber,
184 $hold = Koha::Holds->find( $reserve_id );
185 is( $hold->suspend, 0, "Test resuming with SuspendAll()" );
186 is( $hold->suspend_until, undef, "Test resuming with SuspendAll(), should have no suspend until date" );
188 # Add a new hold for the borrower whose hold we canceled earlier, this time at the bib level
191 branchcode => $branch_1,
192 borrowernumber => $borrowernumbers[0],
193 biblionumber => $biblio->biblionumber,
197 $patron = Koha::Patrons->find( $borrowernumber );
198 $holds = $patron->holds;
199 my $reserveid = Koha::Holds->search({ biblionumber => $biblio->biblionumber, borrowernumber => $borrowernumbers[0] })->next->reserve_id;
200 ModReserveMinusPriority( $itemnumber, $reserveid );
201 $holds = $patron->holds;
202 is( $holds->next->itemnumber, $itemnumber, "Test ModReserveMinusPriority()" );
204 $holds = $biblio->holds;
205 $hold = $holds->next;
206 AlterPriority( 'top', $hold->reserve_id, undef, 2, 1, 6 );
207 $hold = Koha::Holds->find( $reserveid );
208 is( $hold->priority, '1', "Test AlterPriority(), move to top" );
210 AlterPriority( 'down', $hold->reserve_id, undef, 2, 1, 6 );
211 $hold = Koha::Holds->find( $reserveid );
212 is( $hold->priority, '2', "Test AlterPriority(), move down" );
214 AlterPriority( 'up', $hold->reserve_id, 1, 3, 1, 6 );
215 $hold = Koha::Holds->find( $reserveid );
216 is( $hold->priority, '1', "Test AlterPriority(), move up" );
218 AlterPriority( 'bottom', $hold->reserve_id, undef, 2, 1, 6 );
219 $hold = Koha::Holds->find( $reserveid );
220 is( $hold->priority, '6', "Test AlterPriority(), move to bottom" );
222 # Regression test for bug 2394
224 # If IndependentBranches is ON and canreservefromotherbranches is OFF,
225 # a patron is not permittedo to request an item whose homebranch (i.e.,
226 # owner of the item) is different from the patron's own library.
227 # However, if canreservefromotherbranches is turned ON, the patron can
228 # create such hold requests.
230 # Note that canreservefromotherbranches has no effect if
231 # IndependentBranches is OFF.
233 my $foreign_biblio = $builder->build_sample_biblio({ itemtype => 'DUMMY' });
234 my $foreign_itemnumber = $builder->build_sample_item({ library => $branch_2, biblionumber => $foreign_biblio->biblionumber })->itemnumber;
235 Koha::CirculationRules->set_rules(
237 categorycode => undef,
241 reservesallowed => 25,
242 holds_per_record => 99,
246 Koha::CirculationRules->set_rules(
248 categorycode => undef,
250 itemtype => 'CANNOT',
252 reservesallowed => 0,
253 holds_per_record => 99,
258 # make sure some basic sysprefs are set
259 t::lib::Mocks::mock_preference('ReservesControlBranch', 'ItemHomeLibrary');
260 t::lib::Mocks::mock_preference('item-level_itypes', 1);
262 # if IndependentBranches is OFF, a $branch_1 patron can reserve an $branch_2 item
263 t::lib::Mocks::mock_preference('IndependentBranches', 0);
266 CanItemBeReserved($borrowernumbers[0], $foreign_itemnumber)->{status}, 'OK',
267 '$branch_1 patron allowed to reserve $branch_2 item with IndependentBranches OFF (bug 2394)'
270 # if IndependentBranches is OFF, a $branch_1 patron cannot reserve an $branch_2 item
271 t::lib::Mocks::mock_preference('IndependentBranches', 1);
272 t::lib::Mocks::mock_preference('canreservefromotherbranches', 0);
274 CanItemBeReserved($borrowernumbers[0], $foreign_itemnumber)->{status} eq 'cannotReserveFromOtherBranches',
275 '$branch_1 patron NOT allowed to reserve $branch_2 item with IndependentBranches ON ... (bug 2394)'
278 # ... unless canreservefromotherbranches is ON
279 t::lib::Mocks::mock_preference('canreservefromotherbranches', 1);
281 CanItemBeReserved($borrowernumbers[0], $foreign_itemnumber)->{status} eq 'OK',
282 '... unless canreservefromotherbranches is ON (bug 2394)'
286 # Regression test for bug 11336 # Test if ModReserve correctly recalculate the priorities
287 $biblio = $builder->build_sample_biblio({ itemtype => 'DUMMY' });
288 $itemnumber = $builder->build_sample_item({ library => $branch_1, biblionumber => $biblio->biblionumber })->itemnumber;
289 my $reserveid1 = AddReserve(
291 branchcode => $branch_1,
292 borrowernumber => $borrowernumbers[0],
293 biblionumber => $biblio->biblionumber,
298 $itemnumber = $builder->build_sample_item({ library => $branch_1, biblionumber => $biblio->biblionumber })->itemnumber;
299 my $reserveid2 = AddReserve(
301 branchcode => $branch_1,
302 borrowernumber => $borrowernumbers[1],
303 biblionumber => $biblio->biblionumber,
308 $itemnumber = $builder->build_sample_item({ library => $branch_1, biblionumber => $biblio->biblionumber })->itemnumber;
309 my $reserveid3 = AddReserve(
311 branchcode => $branch_1,
312 borrowernumber => $borrowernumbers[2],
313 biblionumber => $biblio->biblionumber,
318 my $hhh = Koha::Holds->search({ biblionumber => $biblio->biblionumber });
319 my $hold3 = Koha::Holds->find( $reserveid3 );
320 is( $hold3->priority, 3, "The 3rd hold should have a priority set to 3" );
321 ModReserve({ reserve_id => $reserveid1, rank => 'del' });
322 ModReserve({ reserve_id => $reserveid2, rank => 'del' });
323 is( $hold3->discard_changes->priority, 1, "After ModReserve, the 3rd reserve becomes the first on the waiting list" );
326 Koha::Items->find($itemnumber)->damaged(1)->store; # FIXME The $itemnumber is a bit confusing here
327 t::lib::Mocks::mock_preference( 'AllowHoldsOnDamagedItems', 1 );
328 is( CanItemBeReserved( $borrowernumbers[0], $itemnumber)->{status}, 'OK', "Patron can reserve damaged item with AllowHoldsOnDamagedItems enabled" );
329 ok( defined( ( CheckReserves($itemnumber) )[1] ), "Hold can be trapped for damaged item with AllowHoldsOnDamagedItems enabled" );
331 $hold = Koha::Hold->new(
333 borrowernumber => $borrowernumbers[0],
334 itemnumber => $itemnumber,
335 biblionumber => $biblio->biblionumber,
338 is( CanItemBeReserved( $borrowernumbers[0], $itemnumber )->{status},
340 "Patron cannot place a second item level hold for a given item" );
343 t::lib::Mocks::mock_preference( 'AllowHoldsOnDamagedItems', 0 );
344 ok( CanItemBeReserved( $borrowernumbers[0], $itemnumber)->{status} eq 'damaged', "Patron cannot reserve damaged item with AllowHoldsOnDamagedItems disabled" );
345 ok( !defined( ( CheckReserves($itemnumber) )[1] ), "Hold cannot be trapped for damaged item with AllowHoldsOnDamagedItems disabled" );
347 # Items that are not for loan, but holdable should not be trapped until they are available for loan
348 Koha::Items->find($itemnumber)->damaged(0)->notforloan(-1)->store;
349 Koha::Holds->search({ biblionumber => $biblio->id })->delete();
350 is( CanItemBeReserved( $borrowernumbers[0], $itemnumber)->{status}, 'OK', "Patron can place hold on item that is not for loan but holdable ( notforloan < 0 )" );
351 $hold = Koha::Hold->new(
353 borrowernumber => $borrowernumbers[0],
354 itemnumber => $itemnumber,
355 biblionumber => $biblio->biblionumber,
358 ok( !defined( ( CheckReserves($itemnumber) )[1] ), "Hold cannot be trapped for item that is not for loan but holdable ( notforloan < 0 )" );
361 # Regression test for bug 9532
362 $biblio = $builder->build_sample_biblio({ itemtype => 'CANNOT' });
363 $item = $builder->build_sample_item({ library => $branch_1, itype => 'CANNOT', biblionumber => $biblio->biblionumber});
366 branchcode => $branch_1,
367 borrowernumber => $borrowernumbers[0],
368 biblionumber => $biblio->biblionumber,
373 CanItemBeReserved( $borrowernumbers[0], $item->itemnumber)->{status}, 'tooManyReserves',
374 "cannot request item if policy that matches on item-level item type forbids it"
377 $item->itype('CAN')->store;
379 CanItemBeReserved( $borrowernumbers[0], $item->itemnumber)->{status} eq 'OK',
380 "can request item if policy that matches on item type allows it"
383 t::lib::Mocks::mock_preference('item-level_itypes', 0);
384 $item->itype(undef)->store;
386 CanItemBeReserved( $borrowernumbers[0], $item->itemnumber)->{status} eq 'tooManyReserves',
387 "cannot request item if policy that matches on bib-level item type forbids it (bug 9532)"
391 # Test branch item rules
393 $dbh->do('DELETE FROM circulation_rules');
394 Koha::CirculationRules->set_rules(
396 categorycode => undef,
400 reservesallowed => 25,
401 holds_per_record => 99,
405 Koha::CirculationRules->set_rules(
407 branchcode => $branch_1,
408 itemtype => 'CANNOT',
411 returnbranch => 'homebranch',
415 Koha::CirculationRules->set_rules(
417 branchcode => $branch_1,
421 returnbranch => 'homebranch',
425 $biblio = $builder->build_sample_biblio({ itemtype => 'CANNOT' });
426 $itemnumber = $builder->build_sample_item({ library => $branch_1, itype => 'CANNOT', biblionumber => $biblio->biblionumber})->itemnumber;
427 is(CanItemBeReserved($borrowernumbers[0], $itemnumber)->{status}, 'notReservable',
428 "CanItemBeReserved should return 'notReservable'");
430 t::lib::Mocks::mock_preference( 'ReservesControlBranch', 'PatronLibrary' );
431 $itemnumber = $builder->build_sample_item({ library => $branch_2, itype => 'CAN', biblionumber => $biblio->biblionumber})->itemnumber;
432 is(CanItemBeReserved($borrowernumbers[0], $itemnumber)->{status},
433 'cannotReserveFromOtherBranches',
434 "CanItemBeReserved should use PatronLibrary rule when ReservesControlBranch set to 'PatronLibrary'");
435 t::lib::Mocks::mock_preference( 'ReservesControlBranch', 'ItemHomeLibrary' );
436 is(CanItemBeReserved($borrowernumbers[0], $itemnumber)->{status},
438 "CanItemBeReserved should use item home library rule when ReservesControlBranch set to 'ItemsHomeLibrary'");
440 $itemnumber = $builder->build_sample_item({ library => $branch_1, itype => 'CAN', biblionumber => $biblio->biblionumber})->itemnumber;
441 is(CanItemBeReserved($borrowernumbers[0], $itemnumber)->{status}, 'OK',
442 "CanItemBeReserved should return 'OK'");
445 t::lib::Mocks::mock_preference( 'item-level_itypes', 1 );
446 t::lib::Mocks::mock_preference( 'ReservesControlBranch', 'PatronLibrary' );
448 $dbh->do('DELETE FROM reserves');
449 $dbh->do('DELETE FROM issues');
450 $dbh->do('DELETE FROM items');
451 $dbh->do('DELETE FROM biblio');
453 $biblio = $builder->build_sample_biblio({ itemtype => 'ONLY1' });
454 $itemnumber = $builder->build_sample_item({ library => $branch_1, biblionumber => $biblio->biblionumber})->itemnumber;
456 Koha::CirculationRules->set_rules(
458 categorycode => undef,
462 reservesallowed => 1,
463 holds_per_record => 99,
467 is( CanItemBeReserved( $borrowernumbers[0], $itemnumber )->{status},
468 'OK', 'Patron can reserve item with hold limit of 1, no holds placed' );
470 my $res_id = AddReserve(
472 branchcode => $branch_1,
473 borrowernumber => $borrowernumbers[0],
474 biblionumber => $biblio->biblionumber,
479 is( CanItemBeReserved( $borrowernumbers[0], $itemnumber )->{status},
480 'tooManyReserves', 'Patron cannot reserve item with hold limit of 1, 1 bib level hold placed' );
482 #results should be the same for both ReservesControlBranch settings
483 t::lib::Mocks::mock_preference( 'ReservesControlBranch', 'ItemHomeLibrary' );
484 is( CanItemBeReserved( $borrowernumbers[0], $itemnumber )->{status},
485 'tooManyReserves', 'Patron cannot reserve item with hold limit of 1, 1 bib level hold placed' );
486 #reset for further tests
487 t::lib::Mocks::mock_preference( 'ReservesControlBranch', 'PatronLibrary' );
489 subtest 'Test max_holds per library/patron category' => sub {
492 $dbh->do('DELETE FROM reserves');
494 $biblio = $builder->build_sample_biblio;
495 $itemnumber = $builder->build_sample_item({ library => $branch_1, biblionumber => $biblio->biblionumber})->itemnumber;
496 Koha::CirculationRules->set_rules(
498 categorycode => undef,
500 itemtype => $biblio->itemtype,
502 reservesallowed => 99,
503 holds_per_record => 99,
511 branchcode => $branch_1,
512 borrowernumber => $borrowernumbers[0],
513 biblionumber => $biblio->biblionumber,
520 Koha::Holds->search( { borrowernumber => $borrowernumbers[0] } )->count();
521 is( $count, 3, 'Patron now has 3 holds' );
523 my $ret = CanItemBeReserved( $borrowernumbers[0], $itemnumber );
524 is( $ret->{status}, 'OK', 'Patron can place hold with no borrower circ rules' );
526 my $rule_all = Koha::CirculationRules->set_rule(
528 categorycode => $category->{categorycode},
530 rule_name => 'max_holds',
535 my $rule_branch = Koha::CirculationRules->set_rule(
537 branchcode => $branch_1,
538 categorycode => $category->{categorycode},
539 rule_name => 'max_holds',
544 $ret = CanItemBeReserved( $borrowernumbers[0], $itemnumber );
545 is( $ret->{status}, 'OK', 'Patron can place hold with branch/category rule of 5, category rule of 3' );
547 $rule_branch->delete();
549 $ret = CanItemBeReserved( $borrowernumbers[0], $itemnumber );
550 is( $ret->{status}, 'tooManyReserves', 'Patron cannot place hold with only a category rule of 3' );
553 $rule_branch->rule_value(3);
554 $rule_branch->store();
556 $ret = CanItemBeReserved( $borrowernumbers[0], $itemnumber );
557 is( $ret->{status}, 'tooManyReserves', 'Patron cannot place hold with only a branch/category rule of 3' );
559 $rule_branch->rule_value(5);
560 $rule_branch->update();
561 $rule_branch->rule_value(5);
562 $rule_branch->store();
564 $ret = CanItemBeReserved( $borrowernumbers[0], $itemnumber );
565 is( $ret->{status}, 'OK', 'Patron can place hold with branch/category rule of 5, category rule of 5' );
568 subtest 'Pickup location availability tests' => sub {
571 $biblio = $builder->build_sample_biblio({ itemtype => 'ONLY1' });
572 $itemnumber = $builder->build_sample_item({ library => $branch_1, biblionumber => $biblio->biblionumber})->itemnumber;
573 #Add a default rule to allow some holds
575 Koha::CirculationRules->set_rules(
578 categorycode => undef,
581 reservesallowed => 25,
582 holds_per_record => 99,
586 my $item = Koha::Items->find($itemnumber);
587 my $branch_to = $builder->build({ source => 'Branch' })->{ branchcode };
588 my $library = Koha::Libraries->find($branch_to);
589 $library->pickup_location('1')->store;
590 my $patron = $builder->build({ source => 'Borrower' })->{ borrowernumber };
592 t::lib::Mocks::mock_preference('UseBranchTransferLimits', 1);
593 t::lib::Mocks::mock_preference('BranchTransferLimitsType', 'itemtype');
595 $library->pickup_location('1')->store;
596 is(CanItemBeReserved($patron, $item->itemnumber, $branch_to)->{status},
597 'OK', 'Library is a pickup location');
599 my $limit = Koha::Item::Transfer::Limit->new({
600 fromBranch => $item->holdingbranch,
601 toBranch => $branch_to,
602 itemtype => $item->effective_itemtype,
604 is(CanItemBeReserved($patron, $item->itemnumber, $branch_to)->{status},
605 'cannotBeTransferred', 'Item cannot be transferred');
608 $library->pickup_location('0')->store;
609 is(CanItemBeReserved($patron, $item->itemnumber, $branch_to)->{status},
610 'libraryNotPickupLocation', 'Library is not a pickup location');
611 is(CanItemBeReserved($patron, $item->itemnumber, 'nonexistent')->{status},
612 'libraryNotFound', 'Cannot set unknown library as pickup location');
615 $schema->storage->txn_rollback;
617 subtest 'CanItemBeReserved / holds_per_day tests' => sub {
621 $schema->storage->txn_begin;
623 Koha::Holds->search->delete;
624 $dbh->do('DELETE FROM issues');
625 Koha::Items->search->delete;
626 Koha::Biblios->search->delete;
628 my $itemtype = $builder->build_object( { class => 'Koha::ItemTypes' } );
629 my $library = $builder->build_object( { class => 'Koha::Libraries' } );
630 my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
632 # Create 3 biblios with items
633 my $biblio_1 = $builder->build_sample_biblio({ itemtype => $itemtype->itemtype });
634 my $itemnumber_1 = $builder->build_sample_item({ library => $library->branchcode, biblionumber => $biblio_1->biblionumber})->itemnumber;
635 my $biblio_2 = $builder->build_sample_biblio({ itemtype => $itemtype->itemtype });
636 my $itemnumber_2 = $builder->build_sample_item({ library => $library->branchcode, biblionumber => $biblio_2->biblionumber})->itemnumber;
637 my $biblio_3 = $builder->build_sample_biblio({ itemtype => $itemtype->itemtype });
638 my $itemnumber_3 = $builder->build_sample_item({ library => $library->branchcode, biblionumber => $biblio_3->biblionumber})->itemnumber;
640 Koha::CirculationRules->search->delete;
641 Koha::CirculationRules->set_rules(
645 itemtype => $itemtype->itemtype,
647 reservesallowed => 1,
648 holds_per_record => 99,
655 CanItemBeReserved( $patron->borrowernumber, $itemnumber_1 ),
657 'Patron can reserve item with hold limit of 1, no holds placed'
662 branchcode => $library->branchcode,
663 borrowernumber => $patron->borrowernumber,
664 biblionumber => $biblio_1->biblionumber,
670 CanItemBeReserved( $patron->borrowernumber, $itemnumber_1 ),
671 { status => 'tooManyReserves', limit => 1 },
672 'Patron cannot reserve item with hold limit of 1, 1 bib level hold placed'
675 # Raise reservesallowed to avoid tooManyReserves from it
676 Koha::CirculationRules->set_rule(
681 itemtype => $itemtype->itemtype,
682 rule_name => 'reservesallowed',
688 CanItemBeReserved( $patron->borrowernumber, $itemnumber_2 ),
690 'Patron can reserve item with 2 reserves daily cap'
693 # Add a second reserve
694 my $res_id = AddReserve(
696 branchcode => $library->branchcode,
697 borrowernumber => $patron->borrowernumber,
698 biblionumber => $biblio_2->biblionumber,
703 CanItemBeReserved( $patron->borrowernumber, $itemnumber_2 ),
704 { status => 'tooManyReservesToday', limit => 2 },
705 'Patron cannot a third item with 2 reserves daily cap'
708 # Update last hold so reservedate is in the past, so 2 holds, but different day
709 $hold = Koha::Holds->find($res_id);
710 my $yesterday = dt_from_string() - DateTime::Duration->new( days => 1 );
711 $hold->reservedate($yesterday)->store;
714 CanItemBeReserved( $patron->borrowernumber, $itemnumber_2 ),
716 'Patron can reserve item with 2 bib level hold placed on different days, 2 reserves daily cap'
719 # Set holds_per_day to 0
720 Koha::CirculationRules->set_rule(
725 itemtype => $itemtype->itemtype,
726 rule_name => 'holds_per_day',
732 # Delete existing holds
733 Koha::Holds->search->delete;
735 CanItemBeReserved( $patron->borrowernumber, $itemnumber_2 ),
736 { status => 'tooManyReservesToday', limit => 0 },
737 'Patron cannot reserve if holds_per_day is 0 (i.e. 0 is 0)'
740 Koha::CirculationRules->set_rule(
745 itemtype => $itemtype->itemtype,
746 rule_name => 'holds_per_day',
751 Koha::Holds->search->delete;
753 CanItemBeReserved( $patron->borrowernumber, $itemnumber_2 ),
755 'Patron can reserve if holds_per_day is undef (i.e. undef is unlimited daily cap)'
759 branchcode => $library->branchcode,
760 borrowernumber => $patron->borrowernumber,
761 biblionumber => $biblio_1->biblionumber,
767 branchcode => $library->branchcode,
768 borrowernumber => $patron->borrowernumber,
769 biblionumber => $biblio_2->biblionumber,
775 CanItemBeReserved( $patron->borrowernumber, $itemnumber_3 ),
777 'Patron can reserve if holds_per_day is undef (i.e. undef is unlimited daily cap)'
781 branchcode => $library->branchcode,
782 borrowernumber => $patron->borrowernumber,
783 biblionumber => $biblio_3->biblionumber,
788 CanItemBeReserved( $patron->borrowernumber, $itemnumber_3 ),
789 { status => 'tooManyReserves', limit => 3 },
790 'Unlimited daily holds, but reached reservesallowed'
792 #results should be the same for both ReservesControlBranch settings
793 t::lib::Mocks::mock_preference('ReservesControlBranch', 'ItemHomeLibrary');
795 CanItemBeReserved( $patron->borrowernumber, $itemnumber_3 ),
796 { status => 'tooManyReserves', limit => 3 },
797 'Unlimited daily holds, but reached reservesallowed'
800 $schema->storage->txn_rollback;
803 subtest 'CanItemBeReserved / branch_not_in_hold_group' => sub {
806 $schema->storage->txn_begin;
809 Koha::Holds->search->delete;
810 $dbh->do('DELETE FROM issues');
811 Koha::CirculationRules->set_rule(
814 categorycode => undef,
816 rule_name => 'reservesallowed',
821 Koha::Items->search->delete;
822 Koha::Biblios->search->delete;
825 my $itemtype1 = $builder->build_object( { class => 'Koha::ItemTypes' } );
826 my $itemtype2 = $builder->build_object( { class => 'Koha::ItemTypes' } );
829 my $library1 = $builder->build_object( { class => 'Koha::Libraries' } );
830 my $library2 = $builder->build_object( { class => 'Koha::Libraries' } );
831 my $library3 = $builder->build_object( { class => 'Koha::Libraries' } );
833 # Create library groups hierarchy
834 my $rootgroup = $builder->build_object( { class => 'Koha::Library::Groups', value => {ft_local_hold_group => 1} } );
835 my $group1 = $builder->build_object( { class => 'Koha::Library::Groups', value => {parent_id => $rootgroup->id, branchcode => $library1->branchcode}} );
836 my $group2 = $builder->build_object( { class => 'Koha::Library::Groups', value => {parent_id => $rootgroup->id, branchcode => $library2->branchcode} } );
839 my $patron1 = $builder->build_object( { class => 'Koha::Patrons', value => {branchcode => $library1->branchcode} } );
840 my $patron3 = $builder->build_object( { class => 'Koha::Patrons', value => {branchcode => $library3->branchcode} } );
842 # Create 3 biblios with items
843 my $biblio_1 = $builder->build_sample_biblio({ itemtype => $itemtype1->itemtype });
844 my $item_1 = $builder->build_sample_item(
846 biblionumber => $biblio_1->biblionumber,
847 library => $library1->branchcode
850 my $biblio_2 = $builder->build_sample_biblio({ itemtype => $itemtype2->itemtype });
851 my $item_2 = $builder->build_sample_item(
853 biblionumber => $biblio_2->biblionumber,
854 library => $library2->branchcode
857 my $itemnumber_2 = $item_2->itemnumber;
858 my $biblio_3 = $builder->build_sample_biblio({ itemtype => $itemtype1->itemtype });
859 my $item_3 = $builder->build_sample_item(
861 biblionumber => $biblio_3->biblionumber,
862 library => $library1->branchcode
866 # Test 1: Patron 3 can place hold
868 CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2 ),
870 'Patron can place hold if no circ_rules where defined'
873 # Insert default circ rule of holds allowed only from local hold group for all libraries
874 Koha::CirculationRules->set_rules(
880 hold_fulfillment_policy => 'any',
881 returnbranch => 'any'
886 # Test 2: Patron 1 can place hold
888 CanItemBeReserved( $patron1->borrowernumber, $itemnumber_2 ),
890 'Patron can place hold because patron\'s home library is part of hold group'
893 # Test 3: Patron 3 cannot place hold
895 CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2 ),
896 { status => 'branchNotInHoldGroup' },
897 'Patron cannot place hold because patron\'s home library is not part of hold group'
900 # Insert default circ rule to "any" for library 2
901 Koha::CirculationRules->set_rules(
903 branchcode => $library2->branchcode,
907 hold_fulfillment_policy => 'any',
908 returnbranch => 'any'
913 # Test 4: Patron 3 can place hold
915 CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2 ),
917 'Patron can place hold if holdallowed is set to "any" for library 2'
920 # Update default circ rule to "hold group" for library 2
921 Koha::CirculationRules->set_rules(
923 branchcode => $library2->branchcode,
927 hold_fulfillment_policy => 'any',
928 returnbranch => 'any'
933 # Test 5: Patron 3 cannot place hold
935 CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2 ),
936 { status => 'branchNotInHoldGroup' },
937 'Patron cannot place hold if holdallowed is set to "hold group" for library 2'
940 # Insert default item rule to "any" for itemtype 2
941 Koha::CirculationRules->set_rules(
943 branchcode => $library2->branchcode,
944 itemtype => $itemtype2->itemtype,
947 hold_fulfillment_policy => 'any',
948 returnbranch => 'any'
953 # Test 6: Patron 3 can place hold
955 CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2 ),
957 'Patron can place hold if holdallowed is set to "any" for itemtype 2'
960 # Update default item rule to "hold group" for itemtype 2
961 Koha::CirculationRules->set_rules(
963 branchcode => $library2->branchcode,
964 itemtype => $itemtype2->itemtype,
967 hold_fulfillment_policy => 'any',
968 returnbranch => 'any'
973 # Test 7: Patron 3 cannot place hold
975 CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2 ),
976 { status => 'branchNotInHoldGroup' },
977 'Patron cannot place hold if holdallowed is set to "hold group" for itemtype 2'
980 # Insert branch item rule to "any" for itemtype 2 and library 2
981 Koha::CirculationRules->set_rules(
983 branchcode => $library2->branchcode,
984 itemtype => $itemtype2->itemtype,
987 hold_fulfillment_policy => 'any',
988 returnbranch => 'any'
993 # Test 8: Patron 3 can place hold
995 CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2 ),
997 'Patron can place hold if holdallowed is set to "any" for itemtype 2 and library 2'
1000 # Update branch item rule to "hold group" for itemtype 2 and library 2
1001 Koha::CirculationRules->set_rules(
1003 branchcode => $library2->branchcode,
1004 itemtype => $itemtype2->itemtype,
1007 hold_fulfillment_policy => 'any',
1008 returnbranch => 'any'
1013 # Test 9: Patron 3 cannot place hold
1015 CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2 ),
1016 { status => 'branchNotInHoldGroup' },
1017 'Patron cannot place hold if holdallowed is set to "hold group" for itemtype 2 and library 2'
1020 $schema->storage->txn_rollback;
1024 subtest 'CanItemBeReserved / pickup_not_in_hold_group' => sub {
1027 $schema->storage->txn_begin;
1030 Koha::Holds->search->delete;
1031 $dbh->do('DELETE FROM issues');
1032 Koha::CirculationRules->set_rule(
1034 branchcode => undef,
1035 categorycode => undef,
1037 rule_name => 'reservesallowed',
1042 Koha::Items->search->delete;
1043 Koha::Biblios->search->delete;
1046 my $itemtype1 = $builder->build_object( { class => 'Koha::ItemTypes' } );
1047 my $itemtype2 = $builder->build_object( { class => 'Koha::ItemTypes' } );
1050 my $library1 = $builder->build_object( { class => 'Koha::Libraries', value => {pickup_location => 1} } );
1051 my $library2 = $builder->build_object( { class => 'Koha::Libraries', value => {pickup_location => 1} } );
1052 my $library3 = $builder->build_object( { class => 'Koha::Libraries', value => {pickup_location => 1} } );
1054 # Create library groups hierarchy
1055 my $rootgroup = $builder->build_object( { class => 'Koha::Library::Groups', value => {ft_local_hold_group => 1} } );
1056 my $group1 = $builder->build_object( { class => 'Koha::Library::Groups', value => {parent_id => $rootgroup->id, branchcode => $library1->branchcode}} );
1057 my $group2 = $builder->build_object( { class => 'Koha::Library::Groups', value => {parent_id => $rootgroup->id, branchcode => $library2->branchcode} } );
1060 my $patron1 = $builder->build_object( { class => 'Koha::Patrons', value => {branchcode => $library1->branchcode} } );
1061 my $patron3 = $builder->build_object( { class => 'Koha::Patrons', value => {branchcode => $library3->branchcode} } );
1063 # Create 3 biblios with items
1064 my $biblio_1 = $builder->build_sample_biblio({ itemtype => $itemtype1->itemtype });
1065 my $item_1 = $builder->build_sample_item(
1067 biblionumber => $biblio_1->biblionumber,
1068 library => $library1->branchcode
1071 my $biblio_2 = $builder->build_sample_biblio({ itemtype => $itemtype2->itemtype });
1072 my $item_2 = $builder->build_sample_item(
1074 biblionumber => $biblio_2->biblionumber,
1075 library => $library2->branchcode
1078 my $itemnumber_2 = $item_2->itemnumber;
1079 my $biblio_3 = $builder->build_sample_biblio({ itemtype => $itemtype1->itemtype });
1080 my $item_3 = $builder->build_sample_item(
1082 biblionumber => $biblio_3->biblionumber,
1083 library => $library1->branchcode
1087 # Test 1: Patron 3 can place hold
1089 CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2, $library3->branchcode ),
1091 'Patron can place hold if no circ_rules where defined'
1094 # Insert default circ rule of holds allowed only from local hold group for all libraries
1095 Koha::CirculationRules->set_rules(
1097 branchcode => undef,
1101 hold_fulfillment_policy => 'holdgroup',
1102 returnbranch => 'any'
1107 # Test 2: Patron 1 can place hold
1109 CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2, $library1->branchcode ),
1111 'Patron can place hold because pickup location is part of hold group'
1114 # Test 3: Patron 3 cannot place hold
1116 CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2, $library3->branchcode ),
1117 { status => 'pickupNotInHoldGroup' },
1118 'Patron cannot place hold because pickup location is not part of hold group'
1121 # Insert default circ rule to "any" for library 2
1122 Koha::CirculationRules->set_rules(
1124 branchcode => $library2->branchcode,
1128 hold_fulfillment_policy => 'any',
1129 returnbranch => 'any'
1134 # Test 4: Patron 3 can place hold
1136 CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2, $library3->branchcode ),
1138 'Patron can place hold if default_branch_circ_rules is set to "any" for library 2'
1141 # Update default circ rule to "hold group" for library 2
1142 Koha::CirculationRules->set_rules(
1144 branchcode => $library2->branchcode,
1148 hold_fulfillment_policy => 'holdgroup',
1149 returnbranch => 'any'
1154 # Test 5: Patron 3 cannot place hold
1156 CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2, $library3->branchcode ),
1157 { status => 'pickupNotInHoldGroup' },
1158 'Patron cannot place hold if hold_fulfillment_policy is set to "hold group" for library 2'
1161 # Insert default item rule to "any" for itemtype 2
1162 Koha::CirculationRules->set_rules(
1164 branchcode => $library2->branchcode,
1165 itemtype => $itemtype2->itemtype,
1168 hold_fulfillment_policy => 'any',
1169 returnbranch => 'any'
1174 # Test 6: Patron 3 can place hold
1176 CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2, $library3->branchcode ),
1178 'Patron can place hold if hold_fulfillment_policy is set to "any" for itemtype 2'
1181 # Update default item rule to "hold group" for itemtype 2
1182 Koha::CirculationRules->set_rules(
1184 branchcode => $library2->branchcode,
1185 itemtype => $itemtype2->itemtype,
1188 hold_fulfillment_policy => 'holdgroup',
1189 returnbranch => 'any'
1194 # Test 7: Patron 3 cannot place hold
1196 CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2, $library3->branchcode ),
1197 { status => 'pickupNotInHoldGroup' },
1198 'Patron cannot place hold if hold_fulfillment_policy is set to "hold group" for itemtype 2'
1201 # Insert branch item rule to "any" for itemtype 2 and library 2
1202 Koha::CirculationRules->set_rules(
1204 branchcode => $library2->branchcode,
1205 itemtype => $itemtype2->itemtype,
1208 hold_fulfillment_policy => 'any',
1209 returnbranch => 'any'
1214 # Test 8: Patron 3 can place hold
1216 CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2, $library3->branchcode ),
1218 'Patron can place hold if hold_fulfillment_policy is set to "any" for itemtype 2 and library 2'
1221 # Update branch item rule to "hold group" for itemtype 2 and library 2
1222 Koha::CirculationRules->set_rules(
1224 branchcode => $library2->branchcode,
1225 itemtype => $itemtype2->itemtype,
1228 hold_fulfillment_policy => 'holdgroup',
1229 returnbranch => 'any'
1234 # Test 9: Patron 3 cannot place hold
1236 CanItemBeReserved( $patron3->borrowernumber, $itemnumber_2, $library3->branchcode ),
1237 { status => 'pickupNotInHoldGroup' },
1238 'Patron cannot place hold if hold_fulfillment_policy is set to "hold group" for itemtype 2 and library 2'
1241 $schema->storage->txn_rollback;