3 # This file is part of Koha.
5 # Koha is free software; you can redistribute it and/or modify it
6 # under the terms of the GNU General Public License as published by
7 # the Free Software Foundation; either version 3 of the License, or
8 # (at your option) any later version.
10 # Koha is distributed in the hope that it will be useful, but
11 # WITHOUT ANY WARRANTY; without even the implied warranty of
12 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 # GNU General Public License for more details.
15 # You should have received a copy of the GNU General Public License
16 # along with Koha; if not, see <http://www.gnu.org/licenses>.
21 use Test::More tests => 48;
23 use Test::Deep qw( cmp_deeply );
28 use POSIX qw( floor );
30 use t::lib::TestBuilder;
39 use C4::Overdues qw(UpdateFine CalcFine);
43 use Koha::Item::Transfers;
47 use Koha::CirculationRules;
48 use Koha::Subscriptions;
49 use Koha::Account::Lines;
50 use Koha::Account::Offsets;
55 t::lib::Mocks::mock_userenv({ branchcode => $library->{branchcode} });
59 my ( $error, $question, $alert ) = @_;
61 $s = %$error ? ' (error: ' . join( ' ', keys %$error ) . ')' : '';
62 $s .= %$question ? ' (question: ' . join( ' ', keys %$question ) . ')' : '';
63 $s .= %$alert ? ' (alert: ' . join( ' ', keys %$alert ) . ')' : '';
67 sub test_debarment_on_checkout {
69 my $item = $params->{item};
70 my $library = $params->{library};
71 my $patron = $params->{patron};
72 my $due_date = $params->{due_date} || dt_from_string;
73 my $return_date = $params->{return_date} || dt_from_string;
74 my $expected_expiration_date = $params->{expiration_date};
76 $expected_expiration_date = output_pref(
78 dt => $expected_expiration_date,
84 my $line_number = $caller[2];
85 AddIssue( $patron, $item->{barcode}, $due_date );
87 my ( undef, $message ) = AddReturn( $item->{barcode}, $library->{branchcode}, undef, $return_date );
88 is( $message->{WasReturned} && exists $message->{Debarred}, 1, 'AddReturn must have debarred the patron' )
89 or diag('AddReturn returned message ' . Dumper $message );
90 my $debarments = Koha::Patron::Debarments::GetDebarments(
91 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
92 is( scalar(@$debarments), 1, 'Test at line ' . $line_number );
94 is( $debarments->[0]->{expiration},
95 $expected_expiration_date, 'Test at line ' . $line_number );
96 Koha::Patron::Debarments::DelUniqueDebarment(
97 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
100 my $schema = Koha::Database->schema;
101 $schema->storage->txn_begin;
102 my $builder = t::lib::TestBuilder->new;
103 my $dbh = C4::Context->dbh;
105 # Prevent random failures by mocking ->now
106 my $now_value = dt_from_string;
107 my $mocked_datetime = Test::MockModule->new('DateTime');
108 $mocked_datetime->mock( 'now', sub { return $now_value->clone; } );
110 my $cache = Koha::Caches->get_instance();
111 $dbh->do(q|DELETE FROM special_holidays|);
112 $dbh->do(q|DELETE FROM repeatable_holidays|);
113 $cache->clear_from_cache('single_holidays');
115 # Start with a clean slate
116 $dbh->do('DELETE FROM issues');
117 $dbh->do('DELETE FROM borrowers');
119 my $library = $builder->build({
122 my $library2 = $builder->build({
125 my $itemtype = $builder->build(
127 source => 'Itemtype',
131 rentalcharge_daily => 0,
132 defaultreplacecost => undef,
137 my $patron_category = $builder->build(
139 source => 'Category',
141 category_type => 'P',
143 BlockExpiredPatronOpacActions => -1, # Pick the pref value
148 my $CircControl = C4::Context->preference('CircControl');
149 my $HomeOrHoldingBranch = C4::Context->preference('HomeOrHoldingBranch');
152 homebranch => $library2->{branchcode},
153 holdingbranch => $library2->{branchcode}
157 branchcode => $library2->{branchcode}
160 t::lib::Mocks::mock_preference('AutoReturnCheckedOutItems', 0);
162 # No userenv, PickupLibrary
163 t::lib::Mocks::mock_preference('IndependentBranches', '0');
164 t::lib::Mocks::mock_preference('CircControl', 'PickupLibrary');
166 C4::Context->preference('CircControl'),
168 'CircControl changed to PickupLibrary'
171 C4::Circulation::_GetCircControlBranch($item, $borrower),
172 $item->{$HomeOrHoldingBranch},
173 '_GetCircControlBranch returned item branch (no userenv defined)'
176 # No userenv, PatronLibrary
177 t::lib::Mocks::mock_preference('CircControl', 'PatronLibrary');
179 C4::Context->preference('CircControl'),
181 'CircControl changed to PatronLibrary'
184 C4::Circulation::_GetCircControlBranch($item, $borrower),
185 $borrower->{branchcode},
186 '_GetCircControlBranch returned borrower branch'
189 # No userenv, ItemHomeLibrary
190 t::lib::Mocks::mock_preference('CircControl', 'ItemHomeLibrary');
192 C4::Context->preference('CircControl'),
194 'CircControl changed to ItemHomeLibrary'
197 $item->{$HomeOrHoldingBranch},
198 C4::Circulation::_GetCircControlBranch($item, $borrower),
199 '_GetCircControlBranch returned item branch'
203 t::lib::Mocks::mock_userenv({ branchcode => $library2->{branchcode} });
204 is(C4::Context->userenv->{branch}, $library2->{branchcode}, 'userenv set');
206 # Userenv set, PickupLibrary
207 t::lib::Mocks::mock_preference('CircControl', 'PickupLibrary');
209 C4::Context->preference('CircControl'),
211 'CircControl changed to PickupLibrary'
214 C4::Circulation::_GetCircControlBranch($item, $borrower),
215 $library2->{branchcode},
216 '_GetCircControlBranch returned current branch'
219 # Userenv set, PatronLibrary
220 t::lib::Mocks::mock_preference('CircControl', 'PatronLibrary');
222 C4::Context->preference('CircControl'),
224 'CircControl changed to PatronLibrary'
227 C4::Circulation::_GetCircControlBranch($item, $borrower),
228 $borrower->{branchcode},
229 '_GetCircControlBranch returned borrower branch'
232 # Userenv set, ItemHomeLibrary
233 t::lib::Mocks::mock_preference('CircControl', 'ItemHomeLibrary');
235 C4::Context->preference('CircControl'),
237 'CircControl changed to ItemHomeLibrary'
240 C4::Circulation::_GetCircControlBranch($item, $borrower),
241 $item->{$HomeOrHoldingBranch},
242 '_GetCircControlBranch returned item branch'
245 # Reset initial configuration
246 t::lib::Mocks::mock_preference('CircControl', $CircControl);
248 C4::Context->preference('CircControl'),
250 'CircControl reset to its initial value'
253 # Set a simple circ policy
254 $dbh->do('DELETE FROM circulation_rules');
255 Koha::CirculationRules->set_rules(
257 categorycode => undef,
261 reservesallowed => 25,
263 lengthunit => 'days',
264 renewalsallowed => 1,
266 norenewalbefore => undef,
274 my ( $reused_itemnumber_1, $reused_itemnumber_2 );
275 subtest "CanBookBeRenewed tests" => sub {
278 C4::Context->set_preference('ItemsDeniedRenewal','');
279 # Generate test biblio
280 my $biblio = $builder->build_sample_biblio();
282 my $branch = $library2->{branchcode};
284 my $item_1 = $builder->build_sample_item(
286 biblionumber => $biblio->biblionumber,
288 replacementprice => 12.00,
292 $reused_itemnumber_1 = $item_1->itemnumber;
294 my $item_2 = $builder->build_sample_item(
296 biblionumber => $biblio->biblionumber,
298 replacementprice => 23.00,
302 $reused_itemnumber_2 = $item_2->itemnumber;
304 my $item_3 = $builder->build_sample_item(
306 biblionumber => $biblio->biblionumber,
308 replacementprice => 23.00,
314 my %renewing_borrower_data = (
316 surname => 'Renewal',
317 categorycode => $patron_category->{categorycode},
318 branchcode => $branch,
321 my %reserving_borrower_data = (
322 firstname => 'Katrin',
323 surname => 'Reservation',
324 categorycode => $patron_category->{categorycode},
325 branchcode => $branch,
328 my %hold_waiting_borrower_data = (
330 surname => 'Reservation',
331 categorycode => $patron_category->{categorycode},
332 branchcode => $branch,
335 my %restricted_borrower_data = (
336 firstname => 'Alice',
337 surname => 'Reservation',
338 categorycode => $patron_category->{categorycode},
339 debarred => '3228-01-01',
340 branchcode => $branch,
343 my %expired_borrower_data = (
346 categorycode => $patron_category->{categorycode},
347 branchcode => $branch,
348 dateexpiry => dt_from_string->subtract( months => 1 ),
351 my $renewing_borrowernumber = Koha::Patron->new(\%renewing_borrower_data)->store->borrowernumber;
352 my $reserving_borrowernumber = Koha::Patron->new(\%reserving_borrower_data)->store->borrowernumber;
353 my $hold_waiting_borrowernumber = Koha::Patron->new(\%hold_waiting_borrower_data)->store->borrowernumber;
354 my $restricted_borrowernumber = Koha::Patron->new(\%restricted_borrower_data)->store->borrowernumber;
355 my $expired_borrowernumber = Koha::Patron->new(\%expired_borrower_data)->store->borrowernumber;
357 my $renewing_borrower_obj = Koha::Patrons->find( $renewing_borrowernumber );
358 my $renewing_borrower = $renewing_borrower_obj->unblessed;
359 my $restricted_borrower = Koha::Patrons->find( $restricted_borrowernumber )->unblessed;
360 my $expired_borrower = Koha::Patrons->find( $expired_borrowernumber )->unblessed;
367 my $checkitem = undef;
370 my $issue = AddIssue( $renewing_borrower, $item_1->barcode);
371 my $datedue = dt_from_string( $issue->date_due() );
372 is (defined $issue->date_due(), 1, "Item 1 checked out, due date: " . $issue->date_due() );
374 my $issue2 = AddIssue( $renewing_borrower, $item_2->barcode);
375 $datedue = dt_from_string( $issue->date_due() );
376 is (defined $issue2, 1, "Item 2 checked out, due date: " . $issue2->date_due());
379 my $borrowing_borrowernumber = Koha::Checkouts->find( { itemnumber => $item_1->itemnumber } )->borrowernumber;
380 is ($borrowing_borrowernumber, $renewing_borrowernumber, "Item checked out to $renewing_borrower->{firstname} $renewing_borrower->{surname}");
382 my ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber, 1);
383 is( $renewokay, 1, 'Can renew, no holds for this title or item');
386 # Biblio-level hold, renewal test
389 branchcode => $branch,
390 borrowernumber => $reserving_borrowernumber,
391 biblionumber => $biblio->biblionumber,
392 priority => $priority,
393 reservation_date => $resdate,
394 expiration_date => $expdate,
396 itemnumber => $checkitem,
401 # Testing of feature to allow the renewal of reserved items if other items on the record can fill all needed holds
402 Koha::CirculationRules->set_rule(
404 categorycode => undef,
407 rule_name => 'onshelfholds',
411 t::lib::Mocks::mock_preference('AllowRenewalIfOtherItemsAvailable', 1 );
412 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
413 is( $renewokay, 1, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
414 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_2->itemnumber);
415 is( $renewokay, 1, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
417 # Now let's add an item level hold, we should no longer be able to renew the item
418 my $hold = Koha::Database->new()->schema()->resultset('Reserve')->create(
420 borrowernumber => $hold_waiting_borrowernumber,
421 biblionumber => $biblio->biblionumber,
422 itemnumber => $item_1->itemnumber,
423 branchcode => $branch,
427 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
428 is( $renewokay, 0, 'Bug 13919 - Renewal possible with item level hold on item');
431 # Now let's add a waiting hold on the 3rd item, it's no longer available tp check out by just anyone, so we should no longer
432 # be able to renew these items
433 $hold = Koha::Database->new()->schema()->resultset('Reserve')->create(
435 borrowernumber => $hold_waiting_borrowernumber,
436 biblionumber => $biblio->biblionumber,
437 itemnumber => $item_3->itemnumber,
438 branchcode => $branch,
443 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
444 is( $renewokay, 0, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
445 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_2->itemnumber);
446 is( $renewokay, 0, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
447 t::lib::Mocks::mock_preference('AllowRenewalIfOtherItemsAvailable', 0 );
449 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
450 is( $renewokay, 0, '(Bug 10663) Cannot renew, reserved');
451 is( $error, 'on_reserve', '(Bug 10663) Cannot renew, reserved (returned error is on_reserve)');
453 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_2->itemnumber);
454 is( $renewokay, 0, '(Bug 10663) Cannot renew, reserved');
455 is( $error, 'on_reserve', '(Bug 10663) Cannot renew, reserved (returned error is on_reserve)');
457 my $reserveid = Koha::Holds->search({ biblionumber => $biblio->biblionumber, borrowernumber => $reserving_borrowernumber })->next->reserve_id;
458 my $reserving_borrower = Koha::Patrons->find( $reserving_borrowernumber )->unblessed;
459 AddIssue($reserving_borrower, $item_3->barcode);
460 my $reserve = $dbh->selectrow_hashref(
461 'SELECT * FROM old_reserves WHERE reserve_id = ?',
465 is($reserve->{found}, 'F', 'hold marked completed when checking out item that fills it');
467 # Item-level hold, renewal test
470 branchcode => $branch,
471 borrowernumber => $reserving_borrowernumber,
472 biblionumber => $biblio->biblionumber,
473 priority => $priority,
474 reservation_date => $resdate,
475 expiration_date => $expdate,
477 itemnumber => $item_1->itemnumber,
482 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber, 1);
483 is( $renewokay, 0, '(Bug 10663) Cannot renew, item reserved');
484 is( $error, 'on_reserve', '(Bug 10663) Cannot renew, item reserved (returned error is on_reserve)');
486 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_2->itemnumber, 1);
487 is( $renewokay, 1, 'Can renew item 2, item-level hold is on item 1');
489 # Items can't fill hold for reasons
490 $item_1->notforloan(1)->store;
491 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber, 1);
492 is( $renewokay, 1, 'Can renew, item is marked not for loan, hold does not block');
493 $item_1->set({notforloan => 0, itype => $itemtype })->store;
495 # FIXME: Add more for itemtype not for loan etc.
497 # Restricted users cannot renew when RestrictionBlockRenewing is enabled
498 my $item_5 = $builder->build_sample_item(
500 biblionumber => $biblio->biblionumber,
502 replacementprice => 23.00,
506 my $datedue5 = AddIssue($restricted_borrower, $item_5->barcode);
507 is (defined $datedue5, 1, "Item with date due checked out, due date: $datedue5");
509 t::lib::Mocks::mock_preference('RestrictionBlockRenewing','1');
510 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_2->itemnumber);
511 is( $renewokay, 1, '(Bug 8236), Can renew, user is not restricted');
512 ( $renewokay, $error ) = CanBookBeRenewed($restricted_borrowernumber, $item_5->itemnumber);
513 is( $renewokay, 0, '(Bug 8236), Cannot renew, user is restricted');
515 # Users cannot renew an overdue item
516 my $item_6 = $builder->build_sample_item(
518 biblionumber => $biblio->biblionumber,
520 replacementprice => 23.00,
525 my $item_7 = $builder->build_sample_item(
527 biblionumber => $biblio->biblionumber,
529 replacementprice => 23.00,
534 my $datedue6 = AddIssue( $renewing_borrower, $item_6->barcode);
535 is (defined $datedue6, 1, "Item 2 checked out, due date: ".$datedue6->date_due);
537 my $now = dt_from_string();
538 my $five_weeks = DateTime::Duration->new(weeks => 5);
539 my $five_weeks_ago = $now - $five_weeks;
540 t::lib::Mocks::mock_preference('finesMode', 'production');
542 my $passeddatedue1 = AddIssue($renewing_borrower, $item_7->barcode, $five_weeks_ago);
543 is (defined $passeddatedue1, 1, "Item with passed date due checked out, due date: " . $passeddatedue1->date_due);
545 my ( $fine ) = CalcFine( $item_7->unblessed, $renewing_borrower->{categorycode}, $branch, $five_weeks_ago, $now );
546 C4::Overdues::UpdateFine(
548 issue_id => $passeddatedue1->id(),
549 itemnumber => $item_7->itemnumber,
550 borrowernumber => $renewing_borrower->{borrowernumber},
552 due => Koha::DateUtils::output_pref($five_weeks_ago)
556 t::lib::Mocks::mock_preference('RenewalLog', 0);
557 my $date = output_pref( { dt => dt_from_string(), dateonly => 1, dateformat => 'iso' } );
558 my %params_renewal = (
559 timestamp => { -like => $date . "%" },
560 module => "CIRCULATION",
564 timestamp => { -like => $date . "%" },
565 module => "CIRCULATION",
568 my $old_log_size = Koha::ActionLogs->count( \%params_renewal );
569 my $dt = dt_from_string();
570 Time::Fake->offset( $dt->epoch );
571 my $datedue1 = AddRenewal( $renewing_borrower->{borrowernumber}, $item_7->itemnumber, $branch );
572 my $new_log_size = Koha::ActionLogs->count( \%params_renewal );
573 is ($new_log_size, $old_log_size, 'renew log not added because of the syspref RenewalLog');
574 isnt (DateTime->compare($datedue1, $dt), 0, "AddRenewal returned a good duedate");
577 t::lib::Mocks::mock_preference('RenewalLog', 1);
578 $date = output_pref( { dt => dt_from_string(), dateonly => 1, dateformat => 'iso' } );
579 $old_log_size = Koha::ActionLogs->count( \%params_renewal );
580 AddRenewal( $renewing_borrower->{borrowernumber}, $item_7->itemnumber, $branch );
581 $new_log_size = Koha::ActionLogs->count( \%params_renewal );
582 is ($new_log_size, $old_log_size + 1, 'renew log successfully added');
584 my $fines = Koha::Account::Lines->search( { borrowernumber => $renewing_borrower->{borrowernumber}, itemnumber => $item_7->itemnumber } );
585 is( $fines->count, 2, 'AddRenewal left both fines' );
586 isnt( $fines->next->status, 'UNRETURNED', 'Fine on renewed item is closed out properly' );
587 isnt( $fines->next->status, 'UNRETURNED', 'Fine on renewed item is closed out properly' );
591 my $old_issue_log_size = Koha::ActionLogs->count( \%params_issue );
592 my $old_renew_log_size = Koha::ActionLogs->count( \%params_renewal );
593 AddIssue( $renewing_borrower,$item_7->barcode,Koha::DateUtils::output_pref({str=>$datedue6->date_due, dateformat =>'iso'}),0,$date, 0, undef );
594 $new_log_size = Koha::ActionLogs->count( \%params_renewal );
595 is ($new_log_size, $old_renew_log_size + 1, 'renew log successfully added when renewed via issuing');
596 $new_log_size = Koha::ActionLogs->count( \%params_issue );
597 is ($new_log_size, $old_issue_log_size, 'renew not logged as issue when renewed via issuing');
599 $fines = Koha::Account::Lines->search( { borrowernumber => $renewing_borrower->{borrowernumber}, itemnumber => $item_7->itemnumber } );
602 t::lib::Mocks::mock_preference('OverduesBlockRenewing','blockitem');
603 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_6->itemnumber);
604 is( $renewokay, 1, '(Bug 8236), Can renew, this item is not overdue');
605 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_7->itemnumber);
606 is( $renewokay, 0, '(Bug 8236), Cannot renew, this item is overdue');
609 $hold = Koha::Holds->search({ biblionumber => $biblio->biblionumber, borrowernumber => $reserving_borrowernumber })->next;
613 # Test automatic renewal before value for "norenewalbefore" in policy is set
614 # In this case automatic renewal is not permitted prior to due date
615 my $item_4 = $builder->build_sample_item(
617 biblionumber => $biblio->biblionumber,
619 replacementprice => 16.00,
624 $issue = AddIssue( $renewing_borrower, $item_4->barcode, undef, undef, undef, undef, { auto_renew => 1 } );
625 ( $renewokay, $error ) =
626 CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
627 is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic and premature' );
628 is( $error, 'auto_too_soon',
629 'Bug 14101: Cannot renew, renewal is automatic and premature, "No renewal before" = undef (returned code is auto_too_soon)' );
632 branchcode => $branch,
633 borrowernumber => $reserving_borrowernumber,
634 biblionumber => $biblio->biblionumber,
635 itemnumber => $bibitems,
636 priority => $priority,
637 reservation_date => $resdate,
638 expiration_date => $expdate,
641 itemnumber => $item_4->itemnumber,
645 ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
646 is( $renewokay, 0, 'Still should not be able to renew' );
647 is( $error, 'auto_too_soon', 'returned code is auto_too_soon, reserve not checked' );
648 ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber, 1 );
649 is( $renewokay, 0, 'Still should not be able to renew' );
650 is( $error, 'on_reserve', 'returned code is on_reserve, auto_too_soon limit is overridden' );
651 $dbh->do('UPDATE circulation_rules SET rule_value = 0 where rule_name = "norenewalbefore"');
652 ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber, 1 );
653 is( $renewokay, 0, 'Still should not be able to renew' );
654 is( $error, 'on_reserve', 'returned code is on_reserve, auto_renew only happens if not on reserve' );
655 ModReserveCancelAll($item_4->itemnumber, $reserving_borrowernumber);
659 $renewing_borrower_obj->autorenew_checkouts(0)->store;
660 ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
661 is( $renewokay, 1, 'No renewal before is undef, but patron opted out of auto_renewal' );
662 $renewing_borrower_obj->autorenew_checkouts(1)->store;
666 # Test premature manual renewal
667 Koha::CirculationRules->set_rule(
669 categorycode => undef,
672 rule_name => 'norenewalbefore',
677 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
678 is( $renewokay, 0, 'Bug 7413: Cannot renew, renewal is premature');
679 is( $error, 'too_soon', 'Bug 7413: Cannot renew, renewal is premature (returned code is too_soon)');
682 # Test 'exact time' setting for syspref NoRenewalBeforePrecision
683 t::lib::Mocks::mock_preference( 'NoRenewalBeforePrecision', 'exact_time' );
685 GetSoonestRenewDate( $renewing_borrowernumber, $item_1->itemnumber ),
686 $datedue->clone->add( days => -7 ),
687 'Bug 14395: Renewals permitted 7 days before due date, as expected'
691 # Test 'date' setting for syspref NoRenewalBeforePrecision
692 t::lib::Mocks::mock_preference( 'NoRenewalBeforePrecision', 'date' );
694 GetSoonestRenewDate( $renewing_borrowernumber, $item_1->itemnumber ),
695 $datedue->clone->add( days => -7 )->truncate( to => 'day' ),
696 'Bug 14395: Renewals permitted 7 days before due date, as expected'
700 # Test premature automatic renewal
701 ( $renewokay, $error ) =
702 CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
703 is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic and premature' );
704 is( $error, 'auto_too_soon',
705 'Bug 14101: Cannot renew, renewal is automatic and premature (returned code is auto_too_soon)'
708 $renewing_borrower_obj->autorenew_checkouts(0)->store;
709 ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
710 is( $renewokay, 0, 'No renewal before is 7, patron opted out of auto_renewal still cannot renew early' );
711 is( $error, 'too_soon', 'Error is too_soon, no auto' );
712 $renewing_borrower_obj->autorenew_checkouts(1)->store;
714 # Change policy so that loans can only be renewed exactly on due date (0 days prior to due date)
715 # and test automatic renewal again
716 $dbh->do(q{UPDATE circulation_rules SET rule_value = '0' WHERE rule_name = 'norenewalbefore'});
717 ( $renewokay, $error ) =
718 CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
719 is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic and premature' );
720 is( $error, 'auto_too_soon',
721 'Bug 14101: Cannot renew, renewal is automatic and premature, "No renewal before" = 0 (returned code is auto_too_soon)'
724 $renewing_borrower_obj->autorenew_checkouts(0)->store;
725 ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
726 is( $renewokay, 0, 'No renewal before is 0, patron opted out of auto_renewal still cannot renew early' );
727 is( $error, 'too_soon', 'Error is too_soon, no auto' );
728 $renewing_borrower_obj->autorenew_checkouts(1)->store;
730 # Change policy so that loans can be renewed 99 days prior to the due date
731 # and test automatic renewal again
732 $dbh->do(q{UPDATE circulation_rules SET rule_value = '99' WHERE rule_name = 'norenewalbefore'});
733 ( $renewokay, $error ) =
734 CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
735 is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic' );
736 is( $error, 'auto_renew',
737 'Bug 14101: Cannot renew, renewal is automatic (returned code is auto_renew)'
740 $renewing_borrower_obj->autorenew_checkouts(0)->store;
741 ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
742 is( $renewokay, 1, 'No renewal before is 99, patron opted out of auto_renewal so can renew' );
743 $renewing_borrower_obj->autorenew_checkouts(1)->store;
745 subtest "too_late_renewal / no_auto_renewal_after" => sub {
747 my $item_to_auto_renew = $builder->build(
750 biblionumber => $biblio->biblionumber,
751 homebranch => $branch,
752 holdingbranch => $branch,
757 my $ten_days_before = dt_from_string->add( days => -10 );
758 my $ten_days_ahead = dt_from_string->add( days => 10 );
759 AddIssue( $renewing_borrower, $item_to_auto_renew->{barcode}, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
761 Koha::CirculationRules->set_rules(
763 categorycode => undef,
767 norenewalbefore => '7',
768 no_auto_renewal_after => '9',
772 ( $renewokay, $error ) =
773 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
774 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
775 is( $error, 'auto_too_late', 'Cannot renew, too late(returned code is auto_too_late)' );
777 Koha::CirculationRules->set_rules(
779 categorycode => undef,
783 norenewalbefore => '7',
784 no_auto_renewal_after => '10',
788 ( $renewokay, $error ) =
789 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
790 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
791 is( $error, 'auto_too_late', 'Cannot auto renew, too late - no_auto_renewal_after is inclusive(returned code is auto_too_late)' );
793 Koha::CirculationRules->set_rules(
795 categorycode => undef,
799 norenewalbefore => '7',
800 no_auto_renewal_after => '11',
804 ( $renewokay, $error ) =
805 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
806 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
807 is( $error, 'auto_too_soon', 'Cannot auto renew, too soon - no_auto_renewal_after is defined(returned code is auto_too_soon)' );
809 Koha::CirculationRules->set_rules(
811 categorycode => undef,
815 norenewalbefore => '10',
816 no_auto_renewal_after => '11',
820 ( $renewokay, $error ) =
821 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
822 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
823 is( $error, 'auto_renew', 'Cannot renew, renew is automatic' );
825 Koha::CirculationRules->set_rules(
827 categorycode => undef,
831 norenewalbefore => '10',
832 no_auto_renewal_after => undef,
833 no_auto_renewal_after_hard_limit => dt_from_string->add( days => -1 ),
837 ( $renewokay, $error ) =
838 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
839 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
840 is( $error, 'auto_too_late', 'Cannot renew, too late(returned code is auto_too_late)' );
842 Koha::CirculationRules->set_rules(
844 categorycode => undef,
848 norenewalbefore => '7',
849 no_auto_renewal_after => '15',
850 no_auto_renewal_after_hard_limit => dt_from_string->add( days => -1 ),
854 ( $renewokay, $error ) =
855 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
856 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
857 is( $error, 'auto_too_late', 'Cannot renew, too late(returned code is auto_too_late)' );
859 Koha::CirculationRules->set_rules(
861 categorycode => undef,
865 norenewalbefore => '10',
866 no_auto_renewal_after => undef,
867 no_auto_renewal_after_hard_limit => dt_from_string->add( days => 1 ),
871 ( $renewokay, $error ) =
872 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
873 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
874 is( $error, 'auto_renew', 'Cannot renew, renew is automatic' );
877 subtest "auto_too_much_oweing | OPACFineNoRenewalsBlockAutoRenew & OPACFineNoRenewalsIncludeCredit" => sub {
879 my $item_to_auto_renew = $builder->build({
882 biblionumber => $biblio->biblionumber,
883 homebranch => $branch,
884 holdingbranch => $branch,
888 my $ten_days_before = dt_from_string->add( days => -10 );
889 my $ten_days_ahead = dt_from_string->add( days => 10 );
890 AddIssue( $renewing_borrower, $item_to_auto_renew->{barcode}, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
892 Koha::CirculationRules->set_rules(
894 categorycode => undef,
898 norenewalbefore => '10',
899 no_auto_renewal_after => '11',
903 C4::Context->set_preference('OPACFineNoRenewalsBlockAutoRenew','1');
904 C4::Context->set_preference('OPACFineNoRenewals','10');
905 C4::Context->set_preference('OPACFineNoRenewalsIncludeCredit','1');
906 my $fines_amount = 5;
907 my $account = Koha::Account->new({patron_id => $renewing_borrowernumber});
910 amount => $fines_amount,
913 item_id => $item_to_auto_renew->{itemnumber},
914 description => "Some fines"
916 )->status('RETURNED')->store;
917 ( $renewokay, $error ) =
918 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
919 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
920 is( $error, 'auto_renew', 'Can auto renew, OPACFineNoRenewals=10, patron has 5' );
924 amount => $fines_amount,
927 item_id => $item_to_auto_renew->{itemnumber},
928 description => "Some fines"
930 )->status('RETURNED')->store;
931 ( $renewokay, $error ) =
932 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
933 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
934 is( $error, 'auto_renew', 'Can auto renew, OPACFineNoRenewals=10, patron has 10' );
938 amount => $fines_amount,
941 item_id => $item_to_auto_renew->{itemnumber},
942 description => "Some fines"
944 )->status('RETURNED')->store;
945 ( $renewokay, $error ) =
946 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
947 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
948 is( $error, 'auto_too_much_oweing', 'Cannot auto renew, OPACFineNoRenewals=10, patron has 15' );
950 $account->add_credit(
952 amount => $fines_amount,
955 description => "Some payment"
958 ( $renewokay, $error ) =
959 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
960 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
961 is( $error, 'auto_renew', 'Can auto renew, OPACFineNoRenewals=10, OPACFineNoRenewalsIncludeCredit=1, patron has 15 debt, 5 credit' );
963 C4::Context->set_preference('OPACFineNoRenewalsIncludeCredit','0');
964 ( $renewokay, $error ) =
965 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
966 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
967 is( $error, 'auto_too_much_oweing', 'Cannot auto renew, OPACFineNoRenewals=10, OPACFineNoRenewalsIncludeCredit=1, patron has 15 debt, 5 credit' );
969 $dbh->do('DELETE FROM accountlines WHERE borrowernumber=?', undef, $renewing_borrowernumber);
970 C4::Context->set_preference('OPACFineNoRenewalsIncludeCredit','1');
973 subtest "auto_account_expired | BlockExpiredPatronOpacActions" => sub {
975 my $item_to_auto_renew = $builder->build({
978 biblionumber => $biblio->biblionumber,
979 homebranch => $branch,
980 holdingbranch => $branch,
984 Koha::CirculationRules->set_rules(
986 categorycode => undef,
990 norenewalbefore => 10,
991 no_auto_renewal_after => 11,
996 my $ten_days_before = dt_from_string->add( days => -10 );
997 my $ten_days_ahead = dt_from_string->add( days => 10 );
999 # Patron is expired and BlockExpiredPatronOpacActions=0
1000 # => auto renew is allowed
1001 t::lib::Mocks::mock_preference('BlockExpiredPatronOpacActions', 0);
1002 my $patron = $expired_borrower;
1003 my $checkout = AddIssue( $patron, $item_to_auto_renew->{barcode}, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
1004 ( $renewokay, $error ) =
1005 CanBookBeRenewed( $patron->{borrowernumber}, $item_to_auto_renew->{itemnumber} );
1006 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
1007 is( $error, 'auto_renew', 'Can auto renew, patron is expired but BlockExpiredPatronOpacActions=0' );
1008 Koha::Checkouts->find( $checkout->issue_id )->delete;
1011 # Patron is expired and BlockExpiredPatronOpacActions=1
1012 # => auto renew is not allowed
1013 t::lib::Mocks::mock_preference('BlockExpiredPatronOpacActions', 1);
1014 $patron = $expired_borrower;
1015 $checkout = AddIssue( $patron, $item_to_auto_renew->{barcode}, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
1016 ( $renewokay, $error ) =
1017 CanBookBeRenewed( $patron->{borrowernumber}, $item_to_auto_renew->{itemnumber} );
1018 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
1019 is( $error, 'auto_account_expired', 'Can not auto renew, lockExpiredPatronOpacActions=1 and patron is expired' );
1020 Koha::Checkouts->find( $checkout->issue_id )->delete;
1023 # Patron is not expired and BlockExpiredPatronOpacActions=1
1024 # => auto renew is allowed
1025 t::lib::Mocks::mock_preference('BlockExpiredPatronOpacActions', 1);
1026 $patron = $renewing_borrower;
1027 $checkout = AddIssue( $patron, $item_to_auto_renew->{barcode}, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
1028 ( $renewokay, $error ) =
1029 CanBookBeRenewed( $patron->{borrowernumber}, $item_to_auto_renew->{itemnumber} );
1030 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
1031 is( $error, 'auto_renew', 'Can auto renew, BlockExpiredPatronOpacActions=1 but patron is not expired' );
1032 Koha::Checkouts->find( $checkout->issue_id )->delete;
1035 subtest "GetLatestAutoRenewDate" => sub {
1037 my $item_to_auto_renew = $builder->build(
1040 biblionumber => $biblio->biblionumber,
1041 homebranch => $branch,
1042 holdingbranch => $branch,
1047 my $ten_days_before = dt_from_string->add( days => -10 );
1048 my $ten_days_ahead = dt_from_string->add( days => 10 );
1049 AddIssue( $renewing_borrower, $item_to_auto_renew->{barcode}, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
1050 Koha::CirculationRules->set_rules(
1052 categorycode => undef,
1053 branchcode => undef,
1056 norenewalbefore => '7',
1057 no_auto_renewal_after => '',
1058 no_auto_renewal_after_hard_limit => undef,
1062 my $latest_auto_renew_date = GetLatestAutoRenewDate( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
1063 is( $latest_auto_renew_date, undef, 'GetLatestAutoRenewDate should return undef if no_auto_renewal_after or no_auto_renewal_after_hard_limit are not defined' );
1064 my $five_days_before = dt_from_string->add( days => -5 );
1065 Koha::CirculationRules->set_rules(
1067 categorycode => undef,
1068 branchcode => undef,
1071 norenewalbefore => '10',
1072 no_auto_renewal_after => '5',
1073 no_auto_renewal_after_hard_limit => undef,
1077 $latest_auto_renew_date = GetLatestAutoRenewDate( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
1078 is( $latest_auto_renew_date->truncate( to => 'minute' ),
1079 $five_days_before->truncate( to => 'minute' ),
1080 'GetLatestAutoRenewDate should return -5 days if no_auto_renewal_after = 5 and date_due is 10 days before'
1082 my $five_days_ahead = dt_from_string->add( days => 5 );
1083 $dbh->do(q{UPDATE circulation_rules SET rule_value = '10' WHERE rule_name = 'norenewalbefore'});
1084 $dbh->do(q{UPDATE circulation_rules SET rule_value = '15' WHERE rule_name = 'no_auto_renewal_after'});
1085 $dbh->do(q{UPDATE circulation_rules SET rule_value = NULL WHERE rule_name = 'no_auto_renewal_after_hard_limit'});
1086 Koha::CirculationRules->set_rules(
1088 categorycode => undef,
1089 branchcode => undef,
1092 norenewalbefore => '10',
1093 no_auto_renewal_after => '15',
1094 no_auto_renewal_after_hard_limit => undef,
1098 $latest_auto_renew_date = GetLatestAutoRenewDate( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
1099 is( $latest_auto_renew_date->truncate( to => 'minute' ),
1100 $five_days_ahead->truncate( to => 'minute' ),
1101 'GetLatestAutoRenewDate should return +5 days if no_auto_renewal_after = 15 and date_due is 10 days before'
1103 my $two_days_ahead = dt_from_string->add( days => 2 );
1104 Koha::CirculationRules->set_rules(
1106 categorycode => undef,
1107 branchcode => undef,
1110 norenewalbefore => '10',
1111 no_auto_renewal_after => '',
1112 no_auto_renewal_after_hard_limit => dt_from_string->add( days => 2 ),
1116 $latest_auto_renew_date = GetLatestAutoRenewDate( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
1117 is( $latest_auto_renew_date->truncate( to => 'day' ),
1118 $two_days_ahead->truncate( to => 'day' ),
1119 'GetLatestAutoRenewDate should return +2 days if no_auto_renewal_after_hard_limit is defined and not no_auto_renewal_after'
1121 Koha::CirculationRules->set_rules(
1123 categorycode => undef,
1124 branchcode => undef,
1127 norenewalbefore => '10',
1128 no_auto_renewal_after => '15',
1129 no_auto_renewal_after_hard_limit => dt_from_string->add( days => 2 ),
1133 $latest_auto_renew_date = GetLatestAutoRenewDate( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
1134 is( $latest_auto_renew_date->truncate( to => 'day' ),
1135 $two_days_ahead->truncate( to => 'day' ),
1136 'GetLatestAutoRenewDate should return +2 days if no_auto_renewal_after_hard_limit is < no_auto_renewal_after'
1142 # set policy to forbid renewals
1143 Koha::CirculationRules->set_rules(
1145 categorycode => undef,
1146 branchcode => undef,
1149 norenewalbefore => undef,
1150 renewalsallowed => 0,
1155 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
1156 is( $renewokay, 0, 'Cannot renew, 0 renewals allowed');
1157 is( $error, 'too_many', 'Cannot renew, 0 renewals allowed (returned code is too_many)');
1159 # Test WhenLostForgiveFine and WhenLostChargeReplacementFee
1160 t::lib::Mocks::mock_preference('WhenLostForgiveFine','1');
1161 t::lib::Mocks::mock_preference('WhenLostChargeReplacementFee','1');
1163 C4::Overdues::UpdateFine(
1165 issue_id => $issue->id(),
1166 itemnumber => $item_1->itemnumber,
1167 borrowernumber => $renewing_borrower->{borrowernumber},
1170 due => Koha::DateUtils::output_pref($datedue)
1174 my $line = Koha::Account::Lines->search({ borrowernumber => $renewing_borrower->{borrowernumber} })->next();
1175 is( $line->debit_type_code, 'OVERDUE', 'Account line type is OVERDUE' );
1176 is( $line->status, 'UNRETURNED', 'Account line status is UNRETURNED' );
1177 is( $line->amountoutstanding+0, 15, 'Account line amount outstanding is 15.00' );
1178 is( $line->amount+0, 15, 'Account line amount is 15.00' );
1179 is( $line->issue_id, $issue->id, 'Account line issue id matches' );
1181 my $offset = Koha::Account::Offsets->search({ debit_id => $line->id })->next();
1182 is( $offset->type, 'OVERDUE', 'Account offset type is Fine' );
1183 is( $offset->amount+0, 15, 'Account offset amount is 15.00' );
1185 t::lib::Mocks::mock_preference('WhenLostForgiveFine','0');
1186 t::lib::Mocks::mock_preference('WhenLostChargeReplacementFee','0');
1188 LostItem( $item_1->itemnumber, 'test', 1 );
1190 $line = Koha::Account::Lines->find($line->id);
1191 is( $line->debit_type_code, 'OVERDUE', 'Account type remains as OVERDUE' );
1192 isnt( $line->status, 'UNRETURNED', 'Account status correctly changed from UNRETURNED to RETURNED' );
1194 my $item = Koha::Items->find($item_1->itemnumber);
1195 ok( !$item->onloan(), "Lost item marked as returned has false onloan value" );
1196 my $checkout = Koha::Checkouts->find({ itemnumber => $item_1->itemnumber });
1197 is( $checkout, undef, 'LostItem called with forced return has checked in the item' );
1199 my $total_due = $dbh->selectrow_array(
1200 'SELECT SUM( amountoutstanding ) FROM accountlines WHERE borrowernumber = ?',
1201 undef, $renewing_borrower->{borrowernumber}
1204 is( $total_due+0, 15, 'Borrower only charged replacement fee with both WhenLostForgiveFine and WhenLostChargeReplacementFee enabled' );
1206 C4::Context->dbh->do("DELETE FROM accountlines");
1208 C4::Overdues::UpdateFine(
1210 issue_id => $issue2->id(),
1211 itemnumber => $item_2->itemnumber,
1212 borrowernumber => $renewing_borrower->{borrowernumber},
1215 due => Koha::DateUtils::output_pref($datedue)
1219 LostItem( $item_2->itemnumber, 'test', 0 );
1221 my $item2 = Koha::Items->find($item_2->itemnumber);
1222 ok( $item2->onloan(), "Lost item *not* marked as returned has true onloan value" );
1223 ok( Koha::Checkouts->find({ itemnumber => $item_2->itemnumber }), 'LostItem called without forced return has checked in the item' );
1225 $total_due = $dbh->selectrow_array(
1226 'SELECT SUM( amountoutstanding ) FROM accountlines WHERE borrowernumber = ?',
1227 undef, $renewing_borrower->{borrowernumber}
1230 ok( $total_due == 15, 'Borrower only charged fine with both WhenLostForgiveFine and WhenLostChargeReplacementFee disabled' );
1232 my $future = dt_from_string();
1233 $future->add( days => 7 );
1234 my $units = C4::Overdues::get_chargeable_units('days', $future, $now, $library2->{branchcode});
1235 ok( $units == 0, '_get_chargeable_units returns 0 for items not past due date (Bug 12596)' );
1237 # Users cannot renew any item if there is an overdue item
1238 t::lib::Mocks::mock_preference('OverduesBlockRenewing','block');
1239 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_6->itemnumber);
1240 is( $renewokay, 0, '(Bug 8236), Cannot renew, one of the items is overdue');
1241 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_7->itemnumber);
1242 is( $renewokay, 0, '(Bug 8236), Cannot renew, one of the items is overdue');
1244 my $manager = $builder->build_object({ class => "Koha::Patrons" });
1245 t::lib::Mocks::mock_userenv({ patron => $manager,branchcode => $manager->branchcode });
1246 t::lib::Mocks::mock_preference('WhenLostChargeReplacementFee','1');
1247 $checkout = Koha::Checkouts->find( { itemnumber => $item_3->itemnumber } );
1248 LostItem( $item_3->itemnumber, 'test', 0 );
1249 my $accountline = Koha::Account::Lines->find( { itemnumber => $item_3->itemnumber } );
1250 is( $accountline->issue_id, $checkout->id, "Issue id added for lost replacement fee charge" );
1252 $accountline->description,
1253 sprintf( "%s %s %s",
1254 $item_3->biblio->title || '',
1255 $item_3->barcode || '',
1256 $item_3->itemcallnumber || '' ),
1257 "Account line description must not contain 'Lost Items ', but be title, barcode, itemcallnumber"
1261 subtest "GetUpcomingDueIssues" => sub {
1264 my $branch = $library2->{branchcode};
1266 #Create another record
1267 my $biblio2 = $builder->build_sample_biblio();
1270 my $item_1 = Koha::Items->find($reused_itemnumber_1);
1271 my $item_2 = Koha::Items->find($reused_itemnumber_2);
1272 my $item_3 = $builder->build_sample_item(
1274 biblionumber => $biblio2->biblionumber,
1282 my %a_borrower_data = (
1283 firstname => 'Fridolyn',
1284 surname => 'SOMERS',
1285 categorycode => $patron_category->{categorycode},
1286 branchcode => $branch,
1289 my $a_borrower_borrowernumber = Koha::Patron->new(\%a_borrower_data)->store->borrowernumber;
1290 my $a_borrower = Koha::Patrons->find( $a_borrower_borrowernumber )->unblessed;
1292 my $yesterday = DateTime->today(time_zone => C4::Context->tz())->add( days => -1 );
1293 my $two_days_ahead = DateTime->today(time_zone => C4::Context->tz())->add( days => 2 );
1294 my $today = DateTime->today(time_zone => C4::Context->tz());
1296 my $issue = AddIssue( $a_borrower, $item_1->barcode, $yesterday );
1297 my $datedue = dt_from_string( $issue->date_due() );
1298 my $issue2 = AddIssue( $a_borrower, $item_2->barcode, $two_days_ahead );
1299 my $datedue2 = dt_from_string( $issue->date_due() );
1303 # GetUpcomingDueIssues tests
1305 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => $i } );
1306 is ( scalar( @$upcoming_dues ), 0, "No items due in less than one day ($i days in advance)" );
1309 #days_in_advance needs to be inclusive, so 1 matches items due tomorrow, 0 items due today etc.
1310 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 2 } );
1311 is ( scalar ( @$upcoming_dues), 1, "Only one item due in 2 days or less" );
1314 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => $i } );
1315 is ( scalar( @$upcoming_dues ), 1,
1316 "Bug 9362: Only one item due in more than 2 days ($i days in advance)" );
1319 # Bug 11218 - Due notices not generated - GetUpcomingDueIssues needs to select due today items as well
1321 my $issue3 = AddIssue( $a_borrower, $item_3->barcode, $today );
1323 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => -1 } );
1324 is ( scalar ( @$upcoming_dues), 0, "Overdues can not be selected" );
1326 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 0 } );
1327 is ( scalar ( @$upcoming_dues), 1, "1 item is due today" );
1329 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 1 } );
1330 is ( scalar ( @$upcoming_dues), 1, "1 item is due today, none tomorrow" );
1332 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 2 } );
1333 is ( scalar ( @$upcoming_dues), 2, "2 items are due withing 2 days" );
1335 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 3 } );
1336 is ( scalar ( @$upcoming_dues), 2, "2 items are due withing 2 days" );
1338 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues();
1339 is ( scalar ( @$upcoming_dues), 2, "days_in_advance is 7 in GetUpcomingDueIssues if not provided" );
1343 subtest "Bug 13841 - Do not create new 0 amount fines" => sub {
1344 my $branch = $library2->{branchcode};
1346 my $biblio = $builder->build_sample_biblio();
1349 my $item = $builder->build_sample_item(
1351 biblionumber => $biblio->biblionumber,
1358 my %a_borrower_data = (
1359 firstname => 'Kyle',
1361 categorycode => $patron_category->{categorycode},
1362 branchcode => $branch,
1365 my $borrowernumber = Koha::Patron->new(\%a_borrower_data)->store->borrowernumber;
1367 my $borrower = Koha::Patrons->find( $borrowernumber )->unblessed;
1368 my $issue = AddIssue( $borrower, $item->barcode );
1371 issue_id => $issue->id(),
1372 itemnumber => $item->itemnumber,
1373 borrowernumber => $borrowernumber,
1379 my $hr = $dbh->selectrow_hashref(q{SELECT COUNT(*) AS count FROM accountlines WHERE borrowernumber = ? AND itemnumber = ?}, undef, $borrowernumber, $item->itemnumber );
1380 my $count = $hr->{count};
1382 is ( $count, 0, "Calling UpdateFine on non-existant fine with an amount of 0 does not result in an empty fine" );
1385 subtest "AllowRenewalIfOtherItemsAvailable tests" => sub {
1386 $dbh->do('DELETE FROM issues');
1387 $dbh->do('DELETE FROM items');
1388 $dbh->do('DELETE FROM circulation_rules');
1389 Koha::CirculationRules->set_rules(
1391 categorycode => undef,
1393 branchcode => undef,
1395 reservesallowed => 25,
1397 lengthunit => 'days',
1398 renewalsallowed => 1,
1400 norenewalbefore => undef,
1408 my $biblio = $builder->build_sample_biblio();
1410 my $item_1 = $builder->build_sample_item(
1412 biblionumber => $biblio->biblionumber,
1413 library => $library2->{branchcode},
1418 my $item_2= $builder->build_sample_item(
1420 biblionumber => $biblio->biblionumber,
1421 library => $library2->{branchcode},
1426 my $borrowernumber1 = Koha::Patron->new({
1427 firstname => 'Kyle',
1429 categorycode => $patron_category->{categorycode},
1430 branchcode => $library2->{branchcode},
1431 })->store->borrowernumber;
1432 my $borrowernumber2 = Koha::Patron->new({
1433 firstname => 'Chelsea',
1435 categorycode => $patron_category->{categorycode},
1436 branchcode => $library2->{branchcode},
1437 })->store->borrowernumber;
1439 my $borrower1 = Koha::Patrons->find( $borrowernumber1 )->unblessed;
1440 my $borrower2 = Koha::Patrons->find( $borrowernumber2 )->unblessed;
1442 my $issue = AddIssue( $borrower1, $item_1->barcode );
1444 my ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $item_1->itemnumber );
1445 is( $renewokay, 1, 'Bug 14337 - Verify the borrower can renew with no hold on the record' );
1449 branchcode => $library2->{branchcode},
1450 borrowernumber => $borrowernumber2,
1451 biblionumber => $biblio->biblionumber,
1456 Koha::CirculationRules->set_rules(
1458 categorycode => undef,
1460 branchcode => undef,
1466 t::lib::Mocks::mock_preference( 'AllowRenewalIfOtherItemsAvailable', 0 );
1467 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $item_1->itemnumber );
1468 is( $renewokay, 0, 'Bug 14337 - Verify the borrower cannot renew with a hold on the record if AllowRenewalIfOtherItemsAvailable and onshelfholds are disabled' );
1470 Koha::CirculationRules->set_rules(
1472 categorycode => undef,
1474 branchcode => undef,
1480 t::lib::Mocks::mock_preference( 'AllowRenewalIfOtherItemsAvailable', 1 );
1481 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $item_1->itemnumber );
1482 is( $renewokay, 0, 'Bug 14337 - Verify the borrower cannot renew with a hold on the record if AllowRenewalIfOtherItemsAvailable is enabled and onshelfholds is disabled' );
1484 Koha::CirculationRules->set_rules(
1486 categorycode => undef,
1488 branchcode => undef,
1494 t::lib::Mocks::mock_preference( 'AllowRenewalIfOtherItemsAvailable', 0 );
1495 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $item_1->itemnumber );
1496 is( $renewokay, 0, 'Bug 14337 - Verify the borrower cannot renew with a hold on the record if AllowRenewalIfOtherItemsAvailable is disabled and onshelfhold is enabled' );
1498 Koha::CirculationRules->set_rules(
1500 categorycode => undef,
1502 branchcode => undef,
1508 t::lib::Mocks::mock_preference( 'AllowRenewalIfOtherItemsAvailable', 1 );
1509 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $item_1->itemnumber );
1510 is( $renewokay, 1, 'Bug 14337 - Verify the borrower can renew with a hold on the record if AllowRenewalIfOtherItemsAvailable and onshelfhold are enabled' );
1512 # Setting item not checked out to be not for loan but holdable
1513 $item_2->notforloan(-1)->store;
1515 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $item_1->itemnumber );
1516 is( $renewokay, 0, 'Bug 14337 - Verify the borrower can not renew with a hold on the record if AllowRenewalIfOtherItemsAvailable is enabled but the only available item is notforloan' );
1520 # Don't allow renewing onsite checkout
1521 my $branch = $library->{branchcode};
1523 #Create another record
1524 my $biblio = $builder->build_sample_biblio();
1526 my $item = $builder->build_sample_item(
1528 biblionumber => $biblio->biblionumber,
1534 my $borrowernumber = Koha::Patron->new({
1537 categorycode => $patron_category->{categorycode},
1538 branchcode => $branch,
1539 })->store->borrowernumber;
1541 my $borrower = Koha::Patrons->find( $borrowernumber )->unblessed;
1543 my $issue = AddIssue( $borrower, $item->barcode, undef, undef, undef, undef, { onsite_checkout => 1 } );
1544 my ( $renewed, $error ) = CanBookBeRenewed( $borrowernumber, $item->itemnumber );
1545 is( $renewed, 0, 'CanBookBeRenewed should not allow to renew on-site checkout' );
1546 is( $error, 'onsite_checkout', 'A correct error code should be returned by CanBookBeRenewed for on-site checkout' );
1550 my $library = $builder->build({ source => 'Branch' });
1552 my $biblio = $builder->build_sample_biblio();
1554 my $item = $builder->build_sample_item(
1556 biblionumber => $biblio->biblionumber,
1557 library => $library->{branchcode},
1562 my $patron = $builder->build({ source => 'Borrower', value => { branchcode => $library->{branchcode}, categorycode => $patron_category->{categorycode} } } );
1564 my $issue = AddIssue( $patron, $item->barcode );
1567 issue_id => $issue->id(),
1568 itemnumber => $item->itemnumber,
1569 borrowernumber => $patron->{borrowernumber},
1576 issue_id => $issue->id(),
1577 itemnumber => $item->itemnumber,
1578 borrowernumber => $patron->{borrowernumber},
1583 is( Koha::Account::Lines->search({ issue_id => $issue->id })->count, 1, 'UpdateFine should not create a new accountline when updating an existing fine');
1586 subtest 'CanBookBeIssued & AllowReturnToBranch' => sub {
1589 my $homebranch = $builder->build( { source => 'Branch' } );
1590 my $holdingbranch = $builder->build( { source => 'Branch' } );
1591 my $otherbranch = $builder->build( { source => 'Branch' } );
1592 my $patron_1 = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } );
1593 my $patron_2 = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } );
1595 my $item = $builder->build_sample_item(
1597 homebranch => $homebranch->{branchcode},
1598 holdingbranch => $holdingbranch->{branchcode},
1602 set_userenv($holdingbranch);
1604 my $issue = AddIssue( $patron_1->unblessed, $item->{barcode} );
1605 is( ref($issue), 'Koha::Checkout', 'AddIssue should return a Koha::Checkout object' );
1607 my ( $error, $question, $alerts );
1609 # AllowReturnToBranch == anywhere
1610 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'anywhere' );
1611 ## Test that unknown barcodes don't generate internal server errors
1612 set_userenv($homebranch);
1613 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, 'KohaIsAwesome' );
1614 ok( $error->{UNKNOWN_BARCODE}, '"KohaIsAwesome" is not a valid barcode as expected.' );
1615 ## Can be issued from homebranch
1616 set_userenv($homebranch);
1617 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1618 is( keys(%$error) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1619 is( exists $question->{ISSUED_TO_ANOTHER}, 1, 'ISSUED_TO_ANOTHER must be set' );
1620 ## Can be issued from holdingbranch
1621 set_userenv($holdingbranch);
1622 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1623 is( keys(%$error) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1624 is( exists $question->{ISSUED_TO_ANOTHER}, 1, 'ISSUED_TO_ANOTHER must be set' );
1625 ## Can be issued from another branch
1626 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1627 is( keys(%$error) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1628 is( exists $question->{ISSUED_TO_ANOTHER}, 1, 'ISSUED_TO_ANOTHER must be set' );
1630 # AllowReturnToBranch == holdingbranch
1631 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'holdingbranch' );
1632 ## Cannot be issued from homebranch
1633 set_userenv($homebranch);
1634 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1635 is( keys(%$question) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1636 is( exists $error->{RETURN_IMPOSSIBLE}, 1, 'RETURN_IMPOSSIBLE must be set' );
1637 is( $error->{branch_to_return}, $holdingbranch->{branchcode}, 'branch_to_return matched holdingbranch' );
1638 ## Can be issued from holdinbranch
1639 set_userenv($holdingbranch);
1640 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1641 is( keys(%$error) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1642 is( exists $question->{ISSUED_TO_ANOTHER}, 1, 'ISSUED_TO_ANOTHER must be set' );
1643 ## Cannot be issued from another branch
1644 set_userenv($otherbranch);
1645 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1646 is( keys(%$question) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1647 is( exists $error->{RETURN_IMPOSSIBLE}, 1, 'RETURN_IMPOSSIBLE must be set' );
1648 is( $error->{branch_to_return}, $holdingbranch->{branchcode}, 'branch_to_return matches holdingbranch' );
1650 # AllowReturnToBranch == homebranch
1651 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'homebranch' );
1652 ## Can be issued from holdinbranch
1653 set_userenv($homebranch);
1654 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1655 is( keys(%$error) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1656 is( exists $question->{ISSUED_TO_ANOTHER}, 1, 'ISSUED_TO_ANOTHER must be set' );
1657 ## Cannot be issued from holdinbranch
1658 set_userenv($holdingbranch);
1659 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1660 is( keys(%$question) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1661 is( exists $error->{RETURN_IMPOSSIBLE}, 1, 'RETURN_IMPOSSIBLE must be set' );
1662 is( $error->{branch_to_return}, $homebranch->{branchcode}, 'branch_to_return matches homebranch' );
1663 ## Cannot be issued from holdinbranch
1664 set_userenv($otherbranch);
1665 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1666 is( keys(%$question) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1667 is( exists $error->{RETURN_IMPOSSIBLE}, 1, 'RETURN_IMPOSSIBLE must be set' );
1668 is( $error->{branch_to_return}, $homebranch->{branchcode}, 'branch_to_return matches homebranch' );
1670 # TODO t::lib::Mocks::mock_preference('AllowReturnToBranch', 'homeorholdingbranch');
1673 subtest 'AddIssue & AllowReturnToBranch' => sub {
1676 my $homebranch = $builder->build( { source => 'Branch' } );
1677 my $holdingbranch = $builder->build( { source => 'Branch' } );
1678 my $otherbranch = $builder->build( { source => 'Branch' } );
1679 my $patron_1 = $builder->build( { source => 'Borrower', value => { categorycode => $patron_category->{categorycode} } } );
1680 my $patron_2 = $builder->build( { source => 'Borrower', value => { categorycode => $patron_category->{categorycode} } } );
1682 my $item = $builder->build_sample_item(
1684 homebranch => $homebranch->{branchcode},
1685 holdingbranch => $holdingbranch->{branchcode},
1689 set_userenv($holdingbranch);
1691 my $ref_issue = 'Koha::Checkout';
1692 my $issue = AddIssue( $patron_1, $item->{barcode} );
1694 my ( $error, $question, $alerts );
1696 # AllowReturnToBranch == homebranch
1697 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'anywhere' );
1698 ## Can be issued from homebranch
1699 set_userenv($homebranch);
1700 is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), $ref_issue, 'AllowReturnToBranch - anywhere | Can be issued from homebranch');
1701 set_userenv($holdingbranch); AddIssue( $patron_1, $item->{barcode} ); # Reinsert the original issue
1702 ## Can be issued from holdinbranch
1703 set_userenv($holdingbranch);
1704 is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), $ref_issue, 'AllowReturnToBranch - anywhere | Can be issued from holdingbranch');
1705 set_userenv($holdingbranch); AddIssue( $patron_1, $item->{barcode} ); # Reinsert the original issue
1706 ## Can be issued from another branch
1707 set_userenv($otherbranch);
1708 is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), $ref_issue, 'AllowReturnToBranch - anywhere | Can be issued from otherbranch');
1709 set_userenv($holdingbranch); AddIssue( $patron_1, $item->{barcode} ); # Reinsert the original issue
1711 # AllowReturnToBranch == holdinbranch
1712 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'holdingbranch' );
1713 ## Cannot be issued from homebranch
1714 set_userenv($homebranch);
1715 is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), '', 'AllowReturnToBranch - holdingbranch | Cannot be issued from homebranch');
1716 ## Can be issued from holdingbranch
1717 set_userenv($holdingbranch);
1718 is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), $ref_issue, 'AllowReturnToBranch - holdingbranch | Can be issued from holdingbranch');
1719 set_userenv($holdingbranch); AddIssue( $patron_1, $item->{barcode} ); # Reinsert the original issue
1720 ## Cannot be issued from another branch
1721 set_userenv($otherbranch);
1722 is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), '', 'AllowReturnToBranch - holdingbranch | Cannot be issued from otherbranch');
1724 # AllowReturnToBranch == homebranch
1725 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'homebranch' );
1726 ## Can be issued from homebranch
1727 set_userenv($homebranch);
1728 is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), $ref_issue, 'AllowReturnToBranch - homebranch | Can be issued from homebranch' );
1729 set_userenv($holdingbranch); AddIssue( $patron_1, $item->{barcode} ); # Reinsert the original issue
1730 ## Cannot be issued from holdinbranch
1731 set_userenv($holdingbranch);
1732 is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), '', 'AllowReturnToBranch - homebranch | Cannot be issued from holdingbranch' );
1733 ## Cannot be issued from another branch
1734 set_userenv($otherbranch);
1735 is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), '', 'AllowReturnToBranch - homebranch | Cannot be issued from otherbranch' );
1736 # TODO t::lib::Mocks::mock_preference('AllowReturnToBranch', 'homeorholdingbranch');
1739 subtest 'CanBookBeIssued + Koha::Patron->is_debarred|has_overdues' => sub {
1742 my $library = $builder->build( { source => 'Branch' } );
1743 my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } );
1744 my $item_1 = $builder->build_sample_item(
1746 library => $library->{branchcode},
1749 my $item_2 = $builder->build_sample_item(
1751 library => $library->{branchcode},
1755 my ( $error, $question, $alerts );
1757 # Patron cannot issue item_1, they have overdues
1758 my $yesterday = DateTime->today( time_zone => C4::Context->tz() )->add( days => -1 );
1759 my $issue = AddIssue( $patron->unblessed, $item_1->{barcode}, $yesterday ); # Add an overdue
1761 t::lib::Mocks::mock_preference( 'OverduesBlockCirc', 'confirmation' );
1762 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->{barcode} );
1763 is( keys(%$error) + keys(%$alerts), 0, 'No key for error and alert' . str($error, $question, $alerts) );
1764 is( $question->{USERBLOCKEDOVERDUE}, 1, 'OverduesBlockCirc=confirmation, USERBLOCKEDOVERDUE should be set for question' );
1766 t::lib::Mocks::mock_preference( 'OverduesBlockCirc', 'block' );
1767 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->{barcode} );
1768 is( keys(%$question) + keys(%$alerts), 0, 'No key for question and alert ' . str($error, $question, $alerts) );
1769 is( $error->{USERBLOCKEDOVERDUE}, 1, 'OverduesBlockCirc=block, USERBLOCKEDOVERDUE should be set for error' );
1771 # Patron cannot issue item_1, they are debarred
1772 my $tomorrow = DateTime->today( time_zone => C4::Context->tz() )->add( days => 1 );
1773 Koha::Patron::Debarments::AddDebarment( { borrowernumber => $patron->borrowernumber, expiration => $tomorrow } );
1774 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->{barcode} );
1775 is( keys(%$question) + keys(%$alerts), 0, 'No key for question and alert ' . str($error, $question, $alerts) );
1776 is( $error->{USERBLOCKEDWITHENDDATE}, output_pref( { dt => $tomorrow, dateformat => 'sql', dateonly => 1 } ), 'USERBLOCKEDWITHENDDATE should be tomorrow' );
1778 Koha::Patron::Debarments::AddDebarment( { borrowernumber => $patron->borrowernumber } );
1779 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->{barcode} );
1780 is( keys(%$question) + keys(%$alerts), 0, 'No key for question and alert ' . str($error, $question, $alerts) );
1781 is( $error->{USERBLOCKEDNOENDDATE}, '9999-12-31', 'USERBLOCKEDNOENDDATE should be 9999-12-31 for unlimited debarments' );
1784 subtest 'CanBookBeIssued + Statistic patrons "X"' => sub {
1787 my $library = $builder->build_object( { class => 'Koha::Libraries' } );
1788 my $patron_category_x = $builder->build_object(
1790 class => 'Koha::Patron::Categories',
1791 value => { category_type => 'X' }
1794 my $patron = $builder->build_object(
1796 class => 'Koha::Patrons',
1798 categorycode => $patron_category_x->categorycode,
1799 gonenoaddress => undef,
1806 my $item_1 = $builder->build_sample_item(
1808 library => $library->{branchcode},
1812 my ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_1->{barcode} );
1813 is( $error->{STATS}, 1, '"Error" flag "STATS" must be set if CanBookBeIssued is called with a statistic patron (category_type=X)' );
1815 # TODO There are other tests to provide here
1818 subtest 'MultipleReserves' => sub {
1821 my $biblio = $builder->build_sample_biblio();
1823 my $branch = $library2->{branchcode};
1825 my $item_1 = $builder->build_sample_item(
1827 biblionumber => $biblio->biblionumber,
1829 replacementprice => 12.00,
1834 my $item_2 = $builder->build_sample_item(
1836 biblionumber => $biblio->biblionumber,
1838 replacementprice => 12.00,
1845 my $resdate = undef;
1846 my $expdate = undef;
1848 my $checkitem = undef;
1851 my %renewing_borrower_data = (
1852 firstname => 'John',
1853 surname => 'Renewal',
1854 categorycode => $patron_category->{categorycode},
1855 branchcode => $branch,
1857 my $renewing_borrowernumber = Koha::Patron->new(\%renewing_borrower_data)->store->borrowernumber;
1858 my $renewing_borrower = Koha::Patrons->find( $renewing_borrowernumber )->unblessed;
1859 my $issue = AddIssue( $renewing_borrower, $item_1->barcode);
1860 my $datedue = dt_from_string( $issue->date_due() );
1861 is (defined $issue->date_due(), 1, "item 1 checked out");
1862 my $borrowing_borrowernumber = Koha::Checkouts->find({ itemnumber => $item_1->itemnumber })->borrowernumber;
1864 my %reserving_borrower_data1 = (
1865 firstname => 'Katrin',
1866 surname => 'Reservation',
1867 categorycode => $patron_category->{categorycode},
1868 branchcode => $branch,
1870 my $reserving_borrowernumber1 = Koha::Patron->new(\%reserving_borrower_data1)->store->borrowernumber;
1873 branchcode => $branch,
1874 borrowernumber => $reserving_borrowernumber1,
1875 biblionumber => $biblio->biblionumber,
1876 priority => $priority,
1877 reservation_date => $resdate,
1878 expiration_date => $expdate,
1880 itemnumber => $checkitem,
1885 my %reserving_borrower_data2 = (
1886 firstname => 'Kirk',
1887 surname => 'Reservation',
1888 categorycode => $patron_category->{categorycode},
1889 branchcode => $branch,
1891 my $reserving_borrowernumber2 = Koha::Patron->new(\%reserving_borrower_data2)->store->borrowernumber;
1894 branchcode => $branch,
1895 borrowernumber => $reserving_borrowernumber2,
1896 biblionumber => $biblio->biblionumber,
1897 priority => $priority,
1898 reservation_date => $resdate,
1899 expiration_date => $expdate,
1901 itemnumber => $checkitem,
1907 my ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber, 1);
1908 is($renewokay, 0, 'Bug 17941 - should cover the case where 2 books are both reserved, so failing');
1911 my $item_3 = $builder->build_sample_item(
1913 biblionumber => $biblio->biblionumber,
1915 replacementprice => 12.00,
1921 my ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber, 1);
1922 is($renewokay, 1, 'Bug 17941 - should cover the case where 2 books are reserved, but a third one is available');
1926 subtest 'CanBookBeIssued + AllowMultipleIssuesOnABiblio' => sub {
1929 my $library = $builder->build( { source => 'Branch' } );
1930 my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } );
1932 my $biblionumber = $builder->build_sample_biblio(
1934 branchcode => $library->{branchcode},
1937 my $item_1 = $builder->build_sample_item(
1939 biblionumber => $biblionumber,
1940 library => $library->{branchcode},
1944 my $item_2 = $builder->build_sample_item(
1946 biblionumber => $biblionumber,
1947 library => $library->{branchcode},
1951 my ( $error, $question, $alerts );
1952 my $issue = AddIssue( $patron->unblessed, $item_1->{barcode}, dt_from_string->add( days => 1 ) );
1954 t::lib::Mocks::mock_preference('AllowMultipleIssuesOnABiblio', 0);
1955 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->{barcode} );
1957 { error => $error, alerts => $alerts },
1958 { error => {}, alerts => {} },
1959 'No error or alert should be raised'
1961 is( $question->{BIBLIO_ALREADY_ISSUED}, 1, 'BIBLIO_ALREADY_ISSUED question flag should be set if AllowMultipleIssuesOnABiblio=0 and issue already exists' );
1963 t::lib::Mocks::mock_preference('AllowMultipleIssuesOnABiblio', 1);
1964 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->{barcode} );
1966 { error => $error, question => $question, alerts => $alerts },
1967 { error => {}, question => {}, alerts => {} },
1968 'No BIBLIO_ALREADY_ISSUED flag should be set if AllowMultipleIssuesOnABiblio=1'
1971 # Add a subscription
1972 Koha::Subscription->new({ biblionumber => $biblionumber })->store;
1974 t::lib::Mocks::mock_preference('AllowMultipleIssuesOnABiblio', 0);
1975 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->{barcode} );
1977 { error => $error, question => $question, alerts => $alerts },
1978 { error => {}, question => {}, alerts => {} },
1979 'No BIBLIO_ALREADY_ISSUED flag should be set if it is a subscription'
1982 t::lib::Mocks::mock_preference('AllowMultipleIssuesOnABiblio', 1);
1983 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->{barcode} );
1985 { error => $error, question => $question, alerts => $alerts },
1986 { error => {}, question => {}, alerts => {} },
1987 'No BIBLIO_ALREADY_ISSUED flag should be set if it is a subscription'
1991 subtest 'AddReturn + CumulativeRestrictionPeriods' => sub {
1994 my $library = $builder->build( { source => 'Branch' } );
1995 my $patron = $builder->build( { source => 'Borrower', value => { categorycode => $patron_category->{categorycode} } } );
1998 my $biblionumber = $builder->build_sample_biblio(
2000 branchcode => $library->{branchcode},
2003 my $item_1 = $builder->build_sample_item(
2005 biblionumber => $biblionumber,
2006 library => $library->{branchcode},
2009 my $item_2 = $builder->build_sample_item(
2011 biblionumber => $biblionumber,
2012 library => $library->{branchcode},
2016 # And the circulation rule
2017 Koha::CirculationRules->search->delete;
2018 Koha::CirculationRules->set_rules(
2020 categorycode => undef,
2022 branchcode => undef,
2025 firstremind => 1, # 1 day of grace
2026 finedays => 2, # 2 days of fine per day of overdue
2027 lengthunit => 'days',
2032 # Patron cannot issue item_1, they have overdues
2033 my $now = dt_from_string;
2034 my $five_days_ago = $now->clone->subtract( days => 5 );
2035 my $ten_days_ago = $now->clone->subtract( days => 10 );
2036 AddIssue( $patron, $item_1->{barcode}, $five_days_ago ); # Add an overdue
2037 AddIssue( $patron, $item_2->{barcode}, $ten_days_ago )
2038 ; # Add another overdue
2040 t::lib::Mocks::mock_preference( 'CumulativeRestrictionPeriods', '0' );
2041 AddReturn( $item_1->{barcode}, $library->{branchcode}, undef, $now );
2042 my $debarments = Koha::Patron::Debarments::GetDebarments(
2043 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
2044 is( scalar(@$debarments), 1 );
2046 # FIXME Is it right? I'd have expected 5 * 2 - 1 instead
2047 # Same for the others
2048 my $expected_expiration = output_pref(
2050 dt => $now->clone->add( days => ( 5 - 1 ) * 2 ),
2051 dateformat => 'sql',
2055 is( $debarments->[0]->{expiration}, $expected_expiration );
2057 AddReturn( $item_2->{barcode}, $library->{branchcode}, undef, $now );
2058 $debarments = Koha::Patron::Debarments::GetDebarments(
2059 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
2060 is( scalar(@$debarments), 1 );
2061 $expected_expiration = output_pref(
2063 dt => $now->clone->add( days => ( 10 - 1 ) * 2 ),
2064 dateformat => 'sql',
2068 is( $debarments->[0]->{expiration}, $expected_expiration );
2070 Koha::Patron::Debarments::DelUniqueDebarment(
2071 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
2073 t::lib::Mocks::mock_preference( 'CumulativeRestrictionPeriods', '1' );
2074 AddIssue( $patron, $item_1->{barcode}, $five_days_ago ); # Add an overdue
2075 AddIssue( $patron, $item_2->{barcode}, $ten_days_ago )
2076 ; # Add another overdue
2077 AddReturn( $item_1->{barcode}, $library->{branchcode}, undef, $now );
2078 $debarments = Koha::Patron::Debarments::GetDebarments(
2079 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
2080 is( scalar(@$debarments), 1 );
2081 $expected_expiration = output_pref(
2083 dt => $now->clone->add( days => ( 5 - 1 ) * 2 ),
2084 dateformat => 'sql',
2088 is( $debarments->[0]->{expiration}, $expected_expiration );
2090 AddReturn( $item_2->{barcode}, $library->{branchcode}, undef, $now );
2091 $debarments = Koha::Patron::Debarments::GetDebarments(
2092 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
2093 is( scalar(@$debarments), 1 );
2094 $expected_expiration = output_pref(
2096 dt => $now->clone->add( days => ( 5 - 1 ) * 2 + ( 10 - 1 ) * 2 ),
2097 dateformat => 'sql',
2101 is( $debarments->[0]->{expiration}, $expected_expiration );
2104 subtest 'AddReturn + suspension_chargeperiod' => sub {
2107 my $library = $builder->build( { source => 'Branch' } );
2108 my $patron = $builder->build( { source => 'Borrower', value => { categorycode => $patron_category->{categorycode} } } );
2110 my $biblionumber = $builder->build_sample_biblio(
2112 branchcode => $library->{branchcode},
2115 my $item_1 = $builder->build_sample_item(
2117 biblionumber => $biblionumber,
2118 library => $library->{branchcode},
2122 # And the issuing rule
2123 Koha::CirculationRules->search->delete;
2124 Koha::CirculationRules->set_rules(
2126 categorycode => '*',
2131 firstremind => 0, # 0 day of grace
2132 finedays => 2, # 2 days of fine per day of overdue
2133 suspension_chargeperiod => 1,
2134 lengthunit => 'days',
2139 my $now = dt_from_string;
2140 my $five_days_ago = $now->clone->subtract( days => 5 );
2141 # We want to charge 2 days every day, without grace
2142 # With 5 days of overdue: 5 * Z
2143 my $expected_expiration = $now->clone->add( days => ( 5 * 2 ) / 1 );
2144 test_debarment_on_checkout(
2147 library => $library,
2149 due_date => $five_days_ago,
2150 expiration_date => $expected_expiration,
2154 # We want to charge 2 days every 2 days, without grace
2155 # With 5 days of overdue: (5 * 2) / 2
2156 Koha::CirculationRules->set_rule(
2158 categorycode => undef,
2159 branchcode => undef,
2161 rule_name => 'suspension_chargeperiod',
2166 $expected_expiration = $now->clone->add( days => floor( 5 * 2 ) / 2 );
2167 test_debarment_on_checkout(
2170 library => $library,
2172 due_date => $five_days_ago,
2173 expiration_date => $expected_expiration,
2177 # We want to charge 2 days every 3 days, with 1 day of grace
2178 # With 5 days of overdue: ((5-1) / 3 ) * 2
2179 Koha::CirculationRules->set_rules(
2181 categorycode => undef,
2182 branchcode => undef,
2185 suspension_chargeperiod => 3,
2190 $expected_expiration = $now->clone->add( days => floor( ( ( 5 - 1 ) / 3 ) * 2 ) );
2191 test_debarment_on_checkout(
2194 library => $library,
2196 due_date => $five_days_ago,
2197 expiration_date => $expected_expiration,
2201 # Use finesCalendar to know if holiday must be skipped to calculate the due date
2202 # We want to charge 2 days every days, with 0 day of grace (to not burn brains)
2203 Koha::CirculationRules->set_rules(
2205 categorycode => undef,
2206 branchcode => undef,
2210 suspension_chargeperiod => 1,
2215 t::lib::Mocks::mock_preference('finesCalendar', 'noFinesWhenClosed');
2216 t::lib::Mocks::mock_preference('SuspensionsCalendar', 'noSuspensionsWhenClosed');
2218 # Adding a holiday 2 days ago
2219 my $calendar = C4::Calendar->new(branchcode => $library->{branchcode});
2220 my $two_days_ago = $now->clone->subtract( days => 2 );
2221 $calendar->insert_single_holiday(
2222 day => $two_days_ago->day,
2223 month => $two_days_ago->month,
2224 year => $two_days_ago->year,
2225 title => 'holidayTest-2d',
2226 description => 'holidayDesc 2 days ago'
2228 # With 5 days of overdue, only 4 (x finedays=2) days must charged (one was an holiday)
2229 $expected_expiration = $now->clone->add( days => floor( ( ( 5 - 0 - 1 ) / 1 ) * 2 ) );
2230 test_debarment_on_checkout(
2233 library => $library,
2235 due_date => $five_days_ago,
2236 expiration_date => $expected_expiration,
2240 # Adding a holiday 2 days ahead, with finesCalendar=noFinesWhenClosed it should be skipped
2241 my $two_days_ahead = $now->clone->add( days => 2 );
2242 $calendar->insert_single_holiday(
2243 day => $two_days_ahead->day,
2244 month => $two_days_ahead->month,
2245 year => $two_days_ahead->year,
2246 title => 'holidayTest+2d',
2247 description => 'holidayDesc 2 days ahead'
2250 # Same as above, but we should skip D+2
2251 $expected_expiration = $now->clone->add( days => floor( ( ( 5 - 0 - 1 ) / 1 ) * 2 ) + 1 );
2252 test_debarment_on_checkout(
2255 library => $library,
2257 due_date => $five_days_ago,
2258 expiration_date => $expected_expiration,
2262 # Adding another holiday, day of expiration date
2263 my $expected_expiration_dt = dt_from_string($expected_expiration);
2264 $calendar->insert_single_holiday(
2265 day => $expected_expiration_dt->day,
2266 month => $expected_expiration_dt->month,
2267 year => $expected_expiration_dt->year,
2268 title => 'holidayTest_exp',
2269 description => 'holidayDesc on expiration date'
2271 # Expiration date will be the day after
2272 test_debarment_on_checkout(
2275 library => $library,
2277 due_date => $five_days_ago,
2278 expiration_date => $expected_expiration_dt->clone->add( days => 1 ),
2282 test_debarment_on_checkout(
2285 library => $library,
2287 return_date => $now->clone->add(days => 5),
2288 expiration_date => $now->clone->add(days => 5 + (5 * 2 - 1) ),
2293 subtest 'CanBookBeIssued + AutoReturnCheckedOutItems' => sub {
2296 my $library = $builder->build_object( { class => 'Koha::Libraries' } );
2297 my $patron1 = $builder->build_object(
2299 class => 'Koha::Patrons',
2301 library => $library->branchcode,
2302 categorycode => $patron_category->{categorycode}
2306 my $patron2 = $builder->build_object(
2308 class => 'Koha::Patrons',
2310 library => $library->branchcode,
2311 categorycode => $patron_category->{categorycode}
2316 t::lib::Mocks::mock_userenv({ branchcode => $library->branchcode });
2318 my $item = $builder->build_sample_item(
2320 library => $library->branchcode,
2324 my ( $error, $question, $alerts );
2325 my $issue = AddIssue( $patron1->unblessed, $item->{barcode} );
2327 t::lib::Mocks::mock_preference('AutoReturnCheckedOutItems', 0);
2328 ( $error, $question, $alerts ) = CanBookBeIssued( $patron2, $item->{barcode} );
2329 is( $question->{ISSUED_TO_ANOTHER}, 1, 'ISSUED_TO_ANOTHER question flag should be set if AutoReturnCheckedOutItems is disabled and item is checked out to another' );
2331 t::lib::Mocks::mock_preference('AutoReturnCheckedOutItems', 1);
2332 ( $error, $question, $alerts ) = CanBookBeIssued( $patron2, $item->{barcode} );
2333 is( $alerts->{RETURNED_FROM_ANOTHER}->{patron}->borrowernumber, $patron1->borrowernumber, 'RETURNED_FROM_ANOTHER alert flag should be set if AutoReturnCheckedOutItems is enabled and item is checked out to another' );
2335 t::lib::Mocks::mock_preference('AutoReturnCheckedOutItems', 0);
2339 subtest 'AddReturn | is_overdue' => sub {
2342 t::lib::Mocks::mock_preference('MarkLostItemsAsReturned', 'batchmod|moredetail|cronjob|additem|pendingreserves|onpayment');
2343 t::lib::Mocks::mock_preference('CalculateFinesOnReturn', 1);
2344 t::lib::Mocks::mock_preference('finesMode', 'production');
2345 t::lib::Mocks::mock_preference('MaxFine', '100');
2347 my $library = $builder->build( { source => 'Branch' } );
2348 my $patron = $builder->build( { source => 'Borrower', value => { categorycode => $patron_category->{categorycode} } } );
2349 my $manager = $builder->build_object({ class => "Koha::Patrons" });
2350 t::lib::Mocks::mock_userenv({ patron => $manager, branchcode => $manager->branchcode });
2352 my $item = $builder->build_sample_item(
2354 library => $library->{branchcode},
2355 replacementprice => 7
2359 Koha::CirculationRules->search->delete;
2360 Koha::CirculationRules->set_rules(
2362 categorycode => undef,
2364 branchcode => undef,
2367 lengthunit => 'days',
2368 fine => 1, # Charge 1 every day of overdue
2374 my $now = dt_from_string;
2375 my $one_day_ago = $now->clone->subtract( days => 1 );
2376 my $five_days_ago = $now->clone->subtract( days => 5 );
2377 my $ten_days_ago = $now->clone->subtract( days => 10 );
2378 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
2380 # No return date specified, today will be used => 10 days overdue charged
2381 AddIssue( $patron->unblessed, $item->{barcode}, $ten_days_ago ); # date due was 10d ago
2382 AddReturn( $item->{barcode}, $library->{branchcode} );
2383 is( int($patron->account->balance()), 10, 'Patron should have a charge of 10 (10 days x 1)' );
2384 Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber })->delete;
2386 # specify return date 5 days before => no overdue charged
2387 AddIssue( $patron->unblessed, $item->{barcode}, $five_days_ago ); # date due was 5d ago
2388 AddReturn( $item->{barcode}, $library->{branchcode}, undef, $ten_days_ago );
2389 is( int($patron->account->balance()), 0, 'AddReturn: pass return_date => no overdue' );
2390 Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber })->delete;
2392 # specify return date 5 days later => 5 days overdue charged
2393 AddIssue( $patron->unblessed, $item->{barcode}, $ten_days_ago ); # date due was 10d ago
2394 AddReturn( $item->{barcode}, $library->{branchcode}, undef, $five_days_ago );
2395 is( int($patron->account->balance()), 5, 'AddReturn: pass return_date => overdue' );
2396 Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber })->delete;
2398 # specify return date 5 days later, specify exemptfine => no overdue charge
2399 AddIssue( $patron->unblessed, $item->{barcode}, $ten_days_ago ); # date due was 10d ago
2400 AddReturn( $item->{barcode}, $library->{branchcode}, 1, $five_days_ago );
2401 is( int($patron->account->balance()), 0, 'AddReturn: pass return_date => no overdue' );
2402 Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber })->delete;
2404 subtest 'bug 22877' => sub {
2408 my $issue = AddIssue( $patron->unblessed, $item->{barcode}, $ten_days_ago ); # date due was 10d ago
2410 # Fake fines cronjob on this checkout
2412 CalcFine( $item, $patron->categorycode, $library->{branchcode},
2413 $ten_days_ago, $now );
2416 issue_id => $issue->issue_id,
2417 itemnumber => $item->{itemnumber},
2418 borrowernumber => $patron->borrowernumber,
2420 due => output_pref($ten_days_ago)
2423 is( int( $patron->account->balance() ),
2424 10, "Overdue fine of 10 days overdue" );
2426 # Fake longoverdue with charge and not marking returned
2427 LostItem( $item->{itemnumber}, 'cronjob', 0 );
2428 is( int( $patron->account->balance() ),
2429 17, "Lost fine of 7 plus 10 days overdue" );
2431 # Now we return it today
2432 AddReturn( $item->{barcode}, $library->{branchcode} );
2433 is( int( $patron->account->balance() ),
2434 17, "Should have a single 10 days overdue fine and lost charge" );
2438 subtest '_FixAccountForLostAndFound' => sub {
2442 t::lib::Mocks::mock_preference( 'WhenLostChargeReplacementFee', 1 );
2443 t::lib::Mocks::mock_preference( 'WhenLostForgiveFine', 0 );
2445 my $processfee_amount = 20;
2446 my $replacement_amount = 99.00;
2447 my $item_type = $builder->build_object(
2448 { class => 'Koha::ItemTypes',
2450 notforloan => undef,
2452 defaultreplacecost => undef,
2453 processfee => $processfee_amount,
2454 rentalcharge_daily => 0,
2458 my $library = $builder->build_object( { class => 'Koha::Libraries' } );
2460 my $biblio = $builder->build_sample_biblio({ author => 'Hall, Daria' });
2462 subtest 'Full write-off tests' => sub {
2466 my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
2467 my $manager = $builder->build_object({ class => "Koha::Patrons" });
2468 t::lib::Mocks::mock_userenv({ patron => $manager,branchcode => $manager->branchcode });
2470 my $item = $builder->build_sample_item(
2472 biblionumber => $biblio->biblionumber,
2473 library => $library->branchcode,
2474 replacementprice => $replacement_amount,
2475 itype => $item_type->itemtype,
2479 AddIssue( $patron->unblessed, $item->barcode );
2481 # Simulate item marked as lost
2482 $item->itemlost(3)->store;
2483 LostItem( $item->itemnumber, 1 );
2485 my $processing_fee_lines = Koha::Account::Lines->search(
2486 { borrowernumber => $patron->id, itemnumber => $item->itemnumber, debit_type_code => 'PROCESSING' } );
2487 is( $processing_fee_lines->count, 1, 'Only one processing fee produced' );
2488 my $processing_fee_line = $processing_fee_lines->next;
2489 is( $processing_fee_line->amount + 0,
2490 $processfee_amount, 'The right PROCESSING amount is generated' );
2491 is( $processing_fee_line->amountoutstanding + 0,
2492 $processfee_amount, 'The right PROCESSING amountoutstanding is generated' );
2494 my $lost_fee_lines = Koha::Account::Lines->search(
2495 { borrowernumber => $patron->id, itemnumber => $item->itemnumber, debit_type_code => 'LOST' } );
2496 is( $lost_fee_lines->count, 1, 'Only one lost item fee produced' );
2497 my $lost_fee_line = $lost_fee_lines->next;
2498 is( $lost_fee_line->amount + 0, $replacement_amount, 'The right LOST amount is generated' );
2499 is( $lost_fee_line->amountoutstanding + 0,
2500 $replacement_amount, 'The right LOST amountoutstanding is generated' );
2501 is( $lost_fee_line->status,
2502 undef, 'The LOST status was not set' );
2504 my $account = $patron->account;
2505 my $debts = $account->outstanding_debits;
2507 # Write off the debt
2508 my $credit = $account->add_credit(
2509 { amount => $account->balance,
2511 interface => 'test',
2514 $credit->apply( { debits => [ $debts->as_list ], offset_type => 'Writeoff' } );
2516 my $credit_return_id = C4::Circulation::_FixAccountForLostAndFound( $item->itemnumber, $patron->id );
2517 is( $credit_return_id, undef, 'No LOST_FOUND account line added' );
2519 $lost_fee_line->discard_changes; # reload from DB
2520 is( $lost_fee_line->amountoutstanding + 0, 0, 'Lost fee has no outstanding amount' );
2521 is( $lost_fee_line->debit_type_code,
2522 'LOST', 'Lost fee now still has account type of LOST' );
2523 is( $lost_fee_line->status, 'FOUND', "Lost fee now has account status of FOUND");
2525 is( $patron->account->balance, -0, 'The patron balance is 0, everything was written off' );
2528 subtest 'Full payment tests' => sub {
2532 my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
2534 my $item = $builder->build_sample_item(
2536 biblionumber => $biblio->biblionumber,
2537 library => $library->branchcode,
2538 replacementprice => $replacement_amount,
2539 itype => $item_type->itemtype
2543 AddIssue( $patron->unblessed, $item->barcode );
2545 # Simulate item marked as lost
2546 $item->itemlost(1)->store;
2547 LostItem( $item->itemnumber, 1 );
2549 my $processing_fee_lines = Koha::Account::Lines->search(
2550 { borrowernumber => $patron->id, itemnumber => $item->itemnumber, debit_type_code => 'PROCESSING' } );
2551 is( $processing_fee_lines->count, 1, 'Only one processing fee produced' );
2552 my $processing_fee_line = $processing_fee_lines->next;
2553 is( $processing_fee_line->amount + 0,
2554 $processfee_amount, 'The right PROCESSING amount is generated' );
2555 is( $processing_fee_line->amountoutstanding + 0,
2556 $processfee_amount, 'The right PROCESSING amountoutstanding is generated' );
2558 my $lost_fee_lines = Koha::Account::Lines->search(
2559 { borrowernumber => $patron->id, itemnumber => $item->itemnumber, debit_type_code => 'LOST' } );
2560 is( $lost_fee_lines->count, 1, 'Only one lost item fee produced' );
2561 my $lost_fee_line = $lost_fee_lines->next;
2562 is( $lost_fee_line->amount + 0, $replacement_amount, 'The right LOST amount is generated' );
2563 is( $lost_fee_line->amountoutstanding + 0,
2564 $replacement_amount, 'The right LOST amountountstanding is generated' );
2566 my $account = $patron->account;
2567 my $debts = $account->outstanding_debits;
2569 # Write off the debt
2570 my $credit = $account->add_credit(
2571 { amount => $account->balance,
2573 interface => 'test',
2576 $credit->apply( { debits => [ $debts->as_list ], offset_type => 'Payment' } );
2578 my $credit_return_id = C4::Circulation::_FixAccountForLostAndFound( $item->itemnumber, $patron->id );
2579 my $credit_return = Koha::Account::Lines->find($credit_return_id);
2581 is( $credit_return->credit_type_code, 'LOST_FOUND', 'An account line of type LOST_FOUND is added' );
2582 is( $credit_return->amount + 0,
2583 -99.00, 'The account line of type LOST_FOUND has an amount of -99' );
2584 is( $credit_return->amountoutstanding + 0,
2585 -99.00, 'The account line of type LOST_FOUND has an amountoutstanding of -99' );
2587 $lost_fee_line->discard_changes;
2588 is( $lost_fee_line->amountoutstanding + 0, 0, 'Lost fee has no outstanding amount' );
2589 is( $lost_fee_line->debit_type_code,
2590 'LOST', 'Lost fee now still has account type of LOST' );
2591 is( $lost_fee_line->status, 'FOUND', "Lost fee now has account status of FOUND");
2593 is( $patron->account->balance,
2594 -99, 'The patron balance is -99, a credit that equals the lost fee payment' );
2597 subtest 'Test without payment or write off' => sub {
2601 my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
2603 my $item = $builder->build_sample_item(
2605 biblionumber => $biblio->biblionumber,
2606 library => $library->branchcode,
2607 replacementprice => 23.00,
2608 replacementprice => $replacement_amount,
2609 itype => $item_type->itemtype
2613 AddIssue( $patron->unblessed, $item->barcode );
2615 # Simulate item marked as lost
2616 $item->itemlost(3)->store;
2617 LostItem( $item->itemnumber, 1 );
2619 my $processing_fee_lines = Koha::Account::Lines->search(
2620 { borrowernumber => $patron->id, itemnumber => $item->itemnumber, debit_type_code => 'PROCESSING' } );
2621 is( $processing_fee_lines->count, 1, 'Only one processing fee produced' );
2622 my $processing_fee_line = $processing_fee_lines->next;
2623 is( $processing_fee_line->amount + 0,
2624 $processfee_amount, 'The right PROCESSING amount is generated' );
2625 is( $processing_fee_line->amountoutstanding + 0,
2626 $processfee_amount, 'The right PROCESSING amountoutstanding is generated' );
2628 my $lost_fee_lines = Koha::Account::Lines->search(
2629 { borrowernumber => $patron->id, itemnumber => $item->itemnumber, debit_type_code => 'LOST' } );
2630 is( $lost_fee_lines->count, 1, 'Only one lost item fee produced' );
2631 my $lost_fee_line = $lost_fee_lines->next;
2632 is( $lost_fee_line->amount + 0, $replacement_amount, 'The right LOST amount is generated' );
2633 is( $lost_fee_line->amountoutstanding + 0,
2634 $replacement_amount, 'The right LOST amountountstanding is generated' );
2636 my $credit_return_id = C4::Circulation::_FixAccountForLostAndFound( $item->itemnumber, $patron->id );
2637 my $credit_return = Koha::Account::Lines->find($credit_return_id);
2639 is( $credit_return->credit_type_code, 'LOST_FOUND', 'An account line of type LOST_FOUND is added' );
2640 is( $credit_return->amount + 0, -99.00, 'The account line of type LOST_FOUND has an amount of -99' );
2641 is( $credit_return->amountoutstanding + 0, 0, 'The account line of type LOST_FOUND has an amountoutstanding of 0' );
2643 $lost_fee_line->discard_changes;
2644 is( $lost_fee_line->amountoutstanding + 0, 0, 'Lost fee has no outstanding amount' );
2645 is( $lost_fee_line->debit_type_code,
2646 'LOST', 'Lost fee now still has account type of LOST' );
2647 is( $lost_fee_line->status, 'FOUND', "Lost fee now has account status of FOUND");
2649 is( $patron->account->balance, 20, 'The patron balance is 20, still owes the processing fee' );
2652 subtest 'Test with partial payement and write off, and remaining debt' => sub {
2656 my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
2657 my $item = $builder->build_sample_item(
2659 biblionumber => $biblio->biblionumber,
2660 library => $library->branchcode,
2661 replacementprice => $replacement_amount,
2662 itype => $item_type->itemtype
2666 AddIssue( $patron->unblessed, $item->barcode );
2668 # Simulate item marked as lost
2669 $item->itemlost(1)->store;
2670 LostItem( $item->itemnumber, 1 );
2672 my $processing_fee_lines = Koha::Account::Lines->search(
2673 { borrowernumber => $patron->id, itemnumber => $item->itemnumber, debit_type_code => 'PROCESSING' } );
2674 is( $processing_fee_lines->count, 1, 'Only one processing fee produced' );
2675 my $processing_fee_line = $processing_fee_lines->next;
2676 is( $processing_fee_line->amount + 0,
2677 $processfee_amount, 'The right PROCESSING amount is generated' );
2678 is( $processing_fee_line->amountoutstanding + 0,
2679 $processfee_amount, 'The right PROCESSING amountoutstanding is generated' );
2681 my $lost_fee_lines = Koha::Account::Lines->search(
2682 { borrowernumber => $patron->id, itemnumber => $item->itemnumber, debit_type_code => 'LOST' } );
2683 is( $lost_fee_lines->count, 1, 'Only one lost item fee produced' );
2684 my $lost_fee_line = $lost_fee_lines->next;
2685 is( $lost_fee_line->amount + 0, $replacement_amount, 'The right LOST amount is generated' );
2686 is( $lost_fee_line->amountoutstanding + 0,
2687 $replacement_amount, 'The right LOST amountountstanding is generated' );
2689 my $account = $patron->account;
2690 is( $account->balance, $processfee_amount + $replacement_amount, 'Balance is PROCESSING + L' );
2693 my $payment_amount = 27;
2694 my $payment = $account->add_credit(
2695 { amount => $payment_amount,
2697 interface => 'test',
2701 $payment->apply( { debits => [ $lost_fee_line ], offset_type => 'Payment' } );
2703 # Partially write off fee
2704 my $write_off_amount = 25;
2705 my $write_off = $account->add_credit(
2706 { amount => $write_off_amount,
2708 interface => 'test',
2711 $write_off->apply( { debits => [ $lost_fee_line ], offset_type => 'Writeoff' } );
2713 is( $account->balance,
2714 $processfee_amount + $replacement_amount - $payment_amount - $write_off_amount,
2715 'Payment and write off applied'
2718 # Store the amountoutstanding value
2719 $lost_fee_line->discard_changes;
2720 my $outstanding = $lost_fee_line->amountoutstanding;
2722 my $credit_return_id = C4::Circulation::_FixAccountForLostAndFound( $item->itemnumber, $patron->id );
2723 my $credit_return = Koha::Account::Lines->find($credit_return_id);
2725 is( $account->balance, $processfee_amount - $payment_amount, 'Balance is PROCESSING - PAYMENT (LOST_FOUND)' );
2727 $lost_fee_line->discard_changes;
2728 is( $lost_fee_line->amountoutstanding + 0, 0, 'Lost fee has no outstanding amount' );
2729 is( $lost_fee_line->debit_type_code,
2730 'LOST', 'Lost fee now still has account type of LOST' );
2731 is( $lost_fee_line->status, 'FOUND', "Lost fee now has account status of FOUND");
2733 is( $credit_return->credit_type_code, 'LOST_FOUND', 'An account line of type LOST_FOUND is added' );
2734 is( $credit_return->amount + 0,
2735 ($payment_amount + $outstanding ) * -1,
2736 'The account line of type LOST_FOUND has an amount equal to the payment + outstanding'
2738 is( $credit_return->amountoutstanding + 0,
2739 $payment_amount * -1,
2740 'The account line of type LOST_FOUND has an amountoutstanding equal to the payment'
2743 is( $account->balance,
2744 $processfee_amount - $payment_amount,
2745 'The patron balance is the difference between the PROCESSING and the credit'
2749 subtest 'Partial payement, existing debits and AccountAutoReconcile' => sub {
2753 my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
2754 my $barcode = 'KD123456793';
2755 my $replacement_amount = 100;
2756 my $processfee_amount = 20;
2758 my $item_type = $builder->build_object(
2759 { class => 'Koha::ItemTypes',
2761 notforloan => undef,
2763 defaultreplacecost => undef,
2765 rentalcharge_daily => 0,
2769 my $item = Koha::Item->new(
2771 biblionumber => $biblio->biblionumber,
2772 homebranch => $library->branchcode,
2773 holdingbranch => $library->branchcode,
2774 barcode => $barcode,
2775 replacementprice => $replacement_amount,
2776 itype => $item_type->itemtype
2780 AddIssue( $patron->unblessed, $barcode );
2782 # Simulate item marked as lost
2783 $item->itemlost(1)->store;
2784 LostItem( $item->itemnumber, 1 );
2786 my $lost_fee_lines = Koha::Account::Lines->search(
2787 { borrowernumber => $patron->id, itemnumber => $item->itemnumber, debit_type_code => 'LOST' } );
2788 is( $lost_fee_lines->count, 1, 'Only one lost item fee produced' );
2789 my $lost_fee_line = $lost_fee_lines->next;
2790 is( $lost_fee_line->amount + 0, $replacement_amount, 'The right LOST amount is generated' );
2791 is( $lost_fee_line->amountoutstanding + 0,
2792 $replacement_amount, 'The right LOST amountountstanding is generated' );
2794 my $account = $patron->account;
2795 is( $account->balance, $replacement_amount, 'Balance is L' );
2798 my $payment_amount = 27;
2799 my $payment = $account->add_credit(
2800 { amount => $payment_amount,
2802 interface => 'test',
2805 $payment->apply({ debits => [ $lost_fee_line ], offset_type => 'Payment' });
2807 is( $account->balance,
2808 $replacement_amount - $payment_amount,
2812 my $manual_debit_amount = 80;
2813 $account->add_debit( { amount => $manual_debit_amount, type => 'OVERDUE', interface =>'test' } );
2815 is( $account->balance, $manual_debit_amount + $replacement_amount - $payment_amount, 'Manual debit applied' );
2817 t::lib::Mocks::mock_preference( 'AccountAutoReconcile', 1 );
2819 my $credit_return_id = C4::Circulation::_FixAccountForLostAndFound( $item->itemnumber, $patron->id );
2820 my $credit_return = Koha::Account::Lines->find($credit_return_id);
2822 is( $account->balance, $manual_debit_amount - $payment_amount, 'Balance is PROCESSING - payment (LOST_FOUND)' );
2824 my $manual_debit = Koha::Account::Lines->search({ borrowernumber => $patron->id, debit_type_code => 'OVERDUE', status => 'UNRETURNED' })->next;
2825 is( $manual_debit->amountoutstanding + 0, $manual_debit_amount - $payment_amount, 'reconcile_balance was called' );
2829 subtest '_FixOverduesOnReturn' => sub {
2832 my $manager = $builder->build_object({ class => "Koha::Patrons" });
2833 t::lib::Mocks::mock_userenv({ patron => $manager, branchcode => $manager->branchcode });
2835 my $biblio = $builder->build_sample_biblio({ author => 'Hall, Kylie' });
2837 my $branchcode = $library2->{branchcode};
2839 my $item = $builder->build_sample_item(
2841 biblionumber => $biblio->biblionumber,
2842 library => $branchcode,
2843 replacementprice => 99.00,
2848 my $patron = $builder->build( { source => 'Borrower' } );
2850 ## Start with basic call, should just close out the open fine
2851 my $accountline = Koha::Account::Line->new(
2853 borrowernumber => $patron->{borrowernumber},
2854 debit_type_code => 'OVERDUE',
2855 status => 'UNRETURNED',
2856 itemnumber => $item->itemnumber,
2858 amountoutstanding => 99.00,
2859 interface => 'test',
2863 C4::Circulation::_FixOverduesOnReturn( $patron->{borrowernumber}, $item->itemnumber, undef, 'RETURNED' );
2865 $accountline->_result()->discard_changes();
2867 is( $accountline->amountoutstanding+0, 99, 'Fine has the same amount outstanding as previously' );
2868 isnt( $accountline->status, 'UNRETURNED', 'Open fine ( account type OVERDUE ) has been closed out ( status not UNRETURNED )');
2869 is( $accountline->status, 'RETURNED', 'Passed status has been used to set as RETURNED )');
2871 ## Run again, with exemptfine enabled
2874 debit_type_code => 'OVERDUE',
2875 status => 'UNRETURNED',
2876 amountoutstanding => 99.00,
2880 C4::Circulation::_FixOverduesOnReturn( $patron->{borrowernumber}, $item->itemnumber, 1, 'RETURNED' );
2882 $accountline->_result()->discard_changes();
2883 my $offset = Koha::Account::Offsets->search({ debit_id => $accountline->id, type => 'Forgiven' })->next();
2885 is( $accountline->amountoutstanding + 0, 0, 'Fine amountoutstanding has been reduced to 0' );
2886 isnt( $accountline->status, 'UNRETURNED', 'Open fine ( account type OVERDUE ) has been closed out ( status not UNRETURNED )');
2887 is( $accountline->status, 'FORGIVEN', 'Open fine ( account type OVERDUE ) has been set to fine forgiven ( status FORGIVEN )');
2888 is( ref $offset, "Koha::Account::Offset", "Found matching offset for fine reduction via forgiveness" );
2889 is( $offset->amount + 0, -99, "Amount of offset is correct" );
2890 my $credit = $offset->credit;
2891 is( ref $credit, "Koha::Account::Line", "Found matching credit for fine forgiveness" );
2892 is( $credit->amount + 0, -99, "Credit amount is set correctly" );
2893 is( $credit->amountoutstanding + 0, 0, "Credit amountoutstanding is correctly set to 0" );
2896 subtest '_FixAccountForLostAndFound returns undef if patron is deleted' => sub {
2899 my $manager = $builder->build_object({ class => "Koha::Patrons" });
2900 t::lib::Mocks::mock_userenv({ patron => $manager, branchcode => $manager->branchcode });
2902 my $biblio = $builder->build_sample_biblio({ author => 'Hall, Kylie' });
2904 my $branchcode = $library2->{branchcode};
2906 my $item = $builder->build_sample_item(
2908 biblionumber => $biblio->biblionumber,
2909 library => $branchcode,
2910 replacementprice => 99.00,
2915 my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
2917 ## Start with basic call, should just close out the open fine
2918 my $accountline = Koha::Account::Line->new(
2920 borrowernumber => $patron->id,
2921 debit_type_code => 'LOST',
2923 itemnumber => $item->itemnumber,
2925 amountoutstanding => 99.00,
2926 interface => 'test',
2932 my $return_value = C4::Circulation::_FixAccountForLostAndFound( $patron->id, $item->itemnumber );
2934 is( $return_value, undef, "_FixAccountForLostAndFound returns undef if patron is deleted" );
2938 subtest 'Set waiting flag' => sub {
2941 my $library_1 = $builder->build( { source => 'Branch' } );
2942 my $patron_1 = $builder->build( { source => 'Borrower', value => { branchcode => $library_1->{branchcode}, categorycode => $patron_category->{categorycode} } } );
2943 my $library_2 = $builder->build( { source => 'Branch' } );
2944 my $patron_2 = $builder->build( { source => 'Borrower', value => { branchcode => $library_2->{branchcode}, categorycode => $patron_category->{categorycode} } } );
2946 my $item = $builder->build_sample_item(
2948 library => $library_1->{branchcode},
2952 set_userenv( $library_2 );
2953 my $reserve_id = AddReserve(
2955 branchcode => $library_2->{branchcode},
2956 borrowernumber => $patron_2->{borrowernumber},
2957 biblionumber => $item->{biblionumber},
2959 itemnumber => $item->{itemnumber},
2963 set_userenv( $library_1 );
2964 my $do_transfer = 1;
2965 my ( $res, $rr ) = AddReturn( $item->{barcode}, $library_1->{branchcode} );
2966 ModReserveAffect( $item->{itemnumber}, undef, $do_transfer, $reserve_id );
2967 my $hold = Koha::Holds->find( $reserve_id );
2968 is( $hold->found, 'T', 'Hold is in transit' );
2970 my ( $status ) = CheckReserves($item->{itemnumber});
2971 is( $status, 'Reserved', 'Hold is not waiting yet');
2973 set_userenv( $library_2 );
2975 AddReturn( $item->{barcode}, $library_2->{branchcode} );
2976 ModReserveAffect( $item->{itemnumber}, undef, $do_transfer, $reserve_id );
2977 $hold = Koha::Holds->find( $reserve_id );
2978 is( $hold->found, 'W', 'Hold is waiting' );
2979 ( $status ) = CheckReserves($item->{itemnumber});
2980 is( $status, 'Waiting', 'Now the hold is waiting');
2982 #Bug 21944 - Waiting transfer checked in at branch other than pickup location
2983 set_userenv( $library_1 );
2984 (undef, my $messages, undef, undef ) = AddReturn ( $item->{barcode}, $library_1->{branchcode} );
2985 $hold = Koha::Holds->find( $reserve_id );
2986 is( $hold->found, undef, 'Hold is no longer marked waiting' );
2987 is( $hold->priority, 1, "Hold is now priority one again");
2988 is( $hold->waitingdate, undef, "Hold no longer has a waiting date");
2989 is( $hold->itemnumber, $item->{itemnumber}, "Hold has retained its' itemnumber");
2990 is( $messages->{ResFound}->{ResFound}, "Reserved", "Hold is still returned");
2991 is( $messages->{ResFound}->{found}, undef, "Hold is no longer marked found in return message");
2992 is( $messages->{ResFound}->{priority}, 1, "Hold is priority 1 in return message");
2995 subtest 'Cancel transfers on lost items' => sub {
2997 my $library_1 = $builder->build( { source => 'Branch' } );
2998 my $patron_1 = $builder->build( { source => 'Borrower', value => { branchcode => $library_1->{branchcode}, categorycode => $patron_category->{categorycode} } } );
2999 my $library_2 = $builder->build( { source => 'Branch' } );
3000 my $patron_2 = $builder->build( { source => 'Borrower', value => { branchcode => $library_2->{branchcode}, categorycode => $patron_category->{categorycode} } } );
3001 my $biblio = $builder->build_sample_biblio({branchcode => $library->{branchcode}});
3002 my $item = $builder->build_sample_item({
3003 biblionumber => $biblio->biblionumber,
3004 library => $library_1->{branchcode},
3007 set_userenv( $library_2 );
3008 my $reserve_id = AddReserve(
3010 branchcode => $library_2->{branchcode},
3011 borrowernumber => $patron_2->{borrowernumber},
3012 biblionumber => $item->biblionumber,
3014 itemnumber => $item->itemnumber,
3018 #Return book and add transfer
3019 set_userenv( $library_1 );
3020 my $do_transfer = 1;
3021 my ( $res, $rr ) = AddReturn( $item->barcode, $library_1->{branchcode} );
3022 ModReserveAffect( $item->itemnumber, undef, $do_transfer, $reserve_id );
3023 C4::Circulation::transferbook( $library_2->{branchcode}, $item->barcode );
3024 my $hold = Koha::Holds->find( $reserve_id );
3025 is( $hold->found, 'T', 'Hold is in transit' );
3027 #Check transfer exists and the items holding branch is the transfer destination branch before marking it as lost
3028 my ($datesent,$frombranch,$tobranch) = GetTransfers($item->itemnumber);
3029 is( $tobranch, $library_2->{branchcode}, 'The transfer record exists in the branchtransfers table');
3030 my $itemcheck = Koha::Items->find($item->itemnumber);
3031 is( $itemcheck->holdingbranch, $library_1->{branchcode}, 'Items holding branch is the transfers origin branch before it is marked as lost' );
3033 #Simulate item being marked as lost and confirm the transfer is deleted and the items holding branch is the transfers source branch
3034 $item->itemlost(1)->store;
3035 LostItem( $item->itemnumber, 'test', 1 );
3036 ($datesent,$frombranch,$tobranch) = GetTransfers($item->itemnumber);
3037 is( $tobranch, undef, 'The transfer on the lost item has been deleted as the LostItemCancelOutstandingTransfer is enabled');
3038 $itemcheck = Koha::Items->find($item->itemnumber);
3039 is( $itemcheck->holdingbranch, $library_1->{branchcode}, 'Lost item with cancelled hold has holding branch equallying the transfers source branch' );
3042 subtest 'CanBookBeIssued | is_overdue' => sub {
3045 # Set a simple circ policy
3046 Koha::CirculationRules->set_rules(
3048 categorycode => undef,
3049 branchcode => undef,
3053 reservesallowed => 25,
3055 lengthunit => 'days',
3056 renewalsallowed => 1,
3058 norenewalbefore => undef,
3066 my $now = dt_from_string;
3067 my $five_days_go = output_pref({ dt => $now->clone->add( days => 5 ), dateonly => 1});
3068 my $ten_days_go = output_pref({ dt => $now->clone->add( days => 10), dateonly => 1 });
3069 my $library = $builder->build( { source => 'Branch' } );
3070 my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } );
3072 my $item = $builder->build_sample_item(
3074 library => $library->{branchcode},
3078 my $issue = AddIssue( $patron->unblessed, $item->{barcode}, $five_days_go ); # date due was 10d ago
3079 my $actualissue = Koha::Checkouts->find( { itemnumber => $item->{itemnumber} } );
3080 is( output_pref({ str => $actualissue->date_due, dateonly => 1}), $five_days_go, "First issue works");
3081 my ($issuingimpossible, $needsconfirmation) = CanBookBeIssued($patron,$item->{barcode},$ten_days_go, undef, undef, undef);
3082 is( $needsconfirmation->{RENEW_ISSUE}, 1, "This is a renewal");
3083 is( $needsconfirmation->{TOO_MANY}, undef, "Not too many, is a renewal");
3086 subtest 'ItemsDeniedRenewal preference' => sub {
3089 C4::Context->set_preference('ItemsDeniedRenewal','');
3091 my $idr_lib = $builder->build_object({ class => 'Koha::Libraries'});
3092 Koha::CirculationRules->set_rules(
3094 categorycode => '*',
3096 branchcode => $idr_lib->branchcode,
3098 reservesallowed => 25,
3100 lengthunit => 'days',
3101 renewalsallowed => 10,
3103 norenewalbefore => undef,
3111 my $deny_book = $builder->build_object({ class => 'Koha::Items', value => {
3112 homebranch => $idr_lib->branchcode,
3116 itemcallnumber => undef,
3120 my $allow_book = $builder->build_object({ class => 'Koha::Items', value => {
3121 homebranch => $idr_lib->branchcode,
3124 location => 'NOPROC'
3128 my $idr_borrower = $builder->build_object({ class => 'Koha::Patrons', value=> {
3129 branchcode => $idr_lib->branchcode,
3132 my $future = dt_from_string->add( days => 1 );
3133 my $deny_issue = $builder->build_object({ class => 'Koha::Checkouts', value => {
3134 returndate => undef,
3137 borrowernumber => $idr_borrower->borrowernumber,
3138 itemnumber => $deny_book->itemnumber,
3139 onsite_checkout => 0,
3140 date_due => $future,
3143 my $allow_issue = $builder->build_object({ class => 'Koha::Checkouts', value => {
3144 returndate => undef,
3147 borrowernumber => $idr_borrower->borrowernumber,
3148 itemnumber => $allow_book->itemnumber,
3149 onsite_checkout => 0,
3150 date_due => $future,
3156 my ( $idr_mayrenew, $idr_error ) =
3157 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
3158 is( $idr_mayrenew, 1, 'Renewal allowed when no rules' );
3159 is( $idr_error, undef, 'Renewal allowed when no rules' );
3161 $idr_rules="withdrawn: [1]";
3163 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
3164 ( $idr_mayrenew, $idr_error ) =
3165 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
3166 is( $idr_mayrenew, 0, 'Renewal blocked when 1 rules (withdrawn)' );
3167 is( $idr_error, 'item_denied_renewal', 'Renewal blocked when 1 rule (withdrawn)' );
3168 ( $idr_mayrenew, $idr_error ) =
3169 CanBookBeRenewed( $idr_borrower->borrowernumber, $allow_issue->itemnumber );
3170 is( $idr_mayrenew, 1, 'Renewal allowed when 1 rules not matched (withdrawn)' );
3171 is( $idr_error, undef, 'Renewal allowed when 1 rules not matched (withdrawn)' );
3173 $idr_rules="withdrawn: [1]\nitype: [HIDE,INVISIBLE]";
3175 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
3176 ( $idr_mayrenew, $idr_error ) =
3177 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
3178 is( $idr_mayrenew, 0, 'Renewal blocked when 2 rules matched (withdrawn, itype)' );
3179 is( $idr_error, 'item_denied_renewal', 'Renewal blocked when 2 rules matched (withdrawn,itype)' );
3180 ( $idr_mayrenew, $idr_error ) =
3181 CanBookBeRenewed( $idr_borrower->borrowernumber, $allow_issue->itemnumber );
3182 is( $idr_mayrenew, 1, 'Renewal allowed when 2 rules not matched (withdrawn, itype)' );
3183 is( $idr_error, undef, 'Renewal allowed when 2 rules not matched (withdrawn, itype)' );
3185 $idr_rules="withdrawn: [1]\nitype: [HIDE,INVISIBLE]\nlocation: [PROC]";
3187 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
3188 ( $idr_mayrenew, $idr_error ) =
3189 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
3190 is( $idr_mayrenew, 0, 'Renewal blocked when 3 rules matched (withdrawn, itype, location)' );
3191 is( $idr_error, 'item_denied_renewal', 'Renewal blocked when 3 rules matched (withdrawn,itype, location)' );
3192 ( $idr_mayrenew, $idr_error ) =
3193 CanBookBeRenewed( $idr_borrower->borrowernumber, $allow_issue->itemnumber );
3194 is( $idr_mayrenew, 1, 'Renewal allowed when 3 rules not matched (withdrawn, itype, location)' );
3195 is( $idr_error, undef, 'Renewal allowed when 3 rules not matched (withdrawn, itype, location)' );
3197 $idr_rules="itemcallnumber: [NULL]";
3198 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
3199 ( $idr_mayrenew, $idr_error ) =
3200 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
3201 is( $idr_mayrenew, 0, 'Renewal blocked for undef when NULL in pref' );
3202 $idr_rules="itemcallnumber: ['']";
3203 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
3204 ( $idr_mayrenew, $idr_error ) =
3205 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
3206 is( $idr_mayrenew, 1, 'Renewal not blocked for undef when "" in pref' );
3208 $idr_rules="itemnotes: [NULL]";
3209 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
3210 ( $idr_mayrenew, $idr_error ) =
3211 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
3212 is( $idr_mayrenew, 1, 'Renewal not blocked for "" when NULL in pref' );
3213 $idr_rules="itemnotes: ['']";
3214 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
3215 ( $idr_mayrenew, $idr_error ) =
3216 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
3217 is( $idr_mayrenew, 0, 'Renewal blocked for empty string when "" in pref' );
3220 subtest 'CanBookBeIssued | item-level_itypes=biblio' => sub {
3223 t::lib::Mocks::mock_preference('item-level_itypes', 0); # biblio
3224 my $library = $builder->build( { source => 'Branch' } );
3225 my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } )->store;
3227 my $item = $builder->build_sample_item(
3229 library => $library->{branchcode},
3233 my ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
3234 is_deeply( $needsconfirmation, {}, 'Item can be issued to this patron' );
3235 is_deeply( $issuingimpossible, {}, 'Item can be issued to this patron' );
3238 subtest 'CanBookBeIssued | notforloan' => sub {
3241 t::lib::Mocks::mock_preference('AllowNotForLoanOverride', 0);
3243 my $library = $builder->build( { source => 'Branch' } );
3244 my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } )->store;
3246 my $itemtype = $builder->build(
3248 source => 'Itemtype',
3249 value => { notforloan => undef, }
3252 my $item = $builder->build_sample_item(
3254 library => $library->{branchcode},
3255 itype => $itemtype->{itemtype},
3258 $item->biblioitem->itemtype($itemtype->{itemtype})->store;
3260 my ( $issuingimpossible, $needsconfirmation );
3263 subtest 'item-level_itypes = 1' => sub {
3266 t::lib::Mocks::mock_preference('item-level_itypes', 1); # item
3267 # Is for loan at item type and item level
3268 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
3269 is_deeply( $needsconfirmation, {}, 'Item can be issued to this patron' );
3270 is_deeply( $issuingimpossible, {}, 'Item can be issued to this patron' );
3272 # not for loan at item type level
3273 Koha::ItemTypes->find( $itemtype->{itemtype} )->notforloan(1)->store;
3274 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
3275 is_deeply( $needsconfirmation, {}, 'No confirmation needed, AllowNotForLoanOverride=0' );
3278 { NOT_FOR_LOAN => 1, itemtype_notforloan => $itemtype->{itemtype} },
3279 'Item can not be issued, not for loan at item type level'
3282 # not for loan at item level
3283 Koha::ItemTypes->find( $itemtype->{itemtype} )->notforloan(undef)->store;
3284 $item->notforloan( 1 )->store;
3285 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
3286 is_deeply( $needsconfirmation, {}, 'No confirmation needed, AllowNotForLoanOverride=0' );
3289 { NOT_FOR_LOAN => 1, item_notforloan => 1 },
3290 'Item can not be issued, not for loan at item type level'
3294 subtest 'item-level_itypes = 0' => sub {
3297 t::lib::Mocks::mock_preference('item-level_itypes', 0); # biblio
3299 # We set another itemtype for biblioitem
3300 my $itemtype = $builder->build(
3302 source => 'Itemtype',
3303 value => { notforloan => undef, }
3307 # for loan at item type and item level
3308 $item->notforloan(0)->store;
3309 $item->biblioitem->itemtype($itemtype->{itemtype})->store;
3310 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
3311 is_deeply( $needsconfirmation, {}, 'Item can be issued to this patron' );
3312 is_deeply( $issuingimpossible, {}, 'Item can be issued to this patron' );
3314 # not for loan at item type level
3315 Koha::ItemTypes->find( $itemtype->{itemtype} )->notforloan(1)->store;
3316 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
3317 is_deeply( $needsconfirmation, {}, 'No confirmation needed, AllowNotForLoanOverride=0' );
3320 { NOT_FOR_LOAN => 1, itemtype_notforloan => $itemtype->{itemtype} },
3321 'Item can not be issued, not for loan at item type level'
3324 # not for loan at item level
3325 Koha::ItemTypes->find( $itemtype->{itemtype} )->notforloan(undef)->store;
3326 $item->notforloan( 1 )->store;
3327 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
3328 is_deeply( $needsconfirmation, {}, 'No confirmation needed, AllowNotForLoanOverride=0' );
3331 { NOT_FOR_LOAN => 1, item_notforloan => 1 },
3332 'Item can not be issued, not for loan at item type level'
3336 # TODO test with AllowNotForLoanOverride = 1
3339 subtest 'AddReturn should clear items.onloan for unissued items' => sub {
3342 t::lib::Mocks::mock_preference( "AllowReturnToBranch", 'anywhere' );
3343 my $item = $builder->build_sample_item(
3345 onloan => '2018-01-01',
3349 AddReturn( $item->barcode, $item->homebranch );
3350 $item->discard_changes; # refresh
3351 is( $item->onloan, undef, 'AddReturn did clear items.onloan' );
3355 subtest 'AddRenewal and AddIssuingCharge tests' => sub {
3360 t::lib::Mocks::mock_preference('item-level_itypes', 1);
3362 my $issuing_charges = 15;
3363 my $title = 'A title';
3364 my $author = 'Author, An';
3365 my $barcode = 'WHATARETHEODDS';
3367 my $circ = Test::MockModule->new('C4::Circulation');
3369 'GetIssuingCharges',
3371 return $issuing_charges;
3375 my $library = $builder->build_object({ class => 'Koha::Libraries' });
3376 my $itemtype = $builder->build_object({ class => 'Koha::ItemTypes', value => { rentalcharge_daily => 0.00 }});
3377 my $patron = $builder->build_object({
3378 class => 'Koha::Patrons',
3379 value => { branchcode => $library->id }
3382 my $biblio = $builder->build_sample_biblio({ title=> $title, author => $author });
3383 my $item_id = Koha::Item->new(
3385 biblionumber => $biblio->biblionumber,
3386 homebranch => $library->id,
3387 holdingbranch => $library->id,
3388 barcode => $barcode,
3389 replacementprice => 23.00,
3390 itype => $itemtype->id
3392 )->store->itemnumber;
3393 my $item = Koha::Items->find( $item_id );
3395 my $context = Test::MockModule->new('C4::Context');
3396 $context->mock( userenv => { branch => $library->id } );
3398 # Check the item out
3399 AddIssue( $patron->unblessed, $item->barcode );
3400 t::lib::Mocks::mock_preference( 'RenewalLog', 0 );
3401 my $date = output_pref( { dt => dt_from_string(), dateonly => 1, dateformat => 'iso' } );
3402 my %params_renewal = (
3403 timestamp => { -like => $date . "%" },
3404 module => "CIRCULATION",
3405 action => "RENEWAL",
3407 my $old_log_size = Koha::ActionLogs->count( \%params_renewal );;
3408 AddRenewal( $patron->id, $item->id, $library->id );
3409 my $new_log_size = Koha::ActionLogs->count( \%params_renewal );
3410 is( $new_log_size, $old_log_size, 'renew log not added because of the syspref RenewalLog' );
3412 my $checkouts = $patron->checkouts;
3413 # The following will fail if run on 00:00:00
3414 unlike ( $checkouts->next->lastreneweddate, qr/00:00:00/, 'AddRenewal should set the renewal date with the time part');
3416 my $lines = Koha::Account::Lines->search({
3417 borrowernumber => $patron->id,
3418 itemnumber => $item->id
3421 is( $lines->count, 2 );
3423 my $line = $lines->next;
3424 is( $line->debit_type_code, 'RENT', 'The issue of item with issuing charge generates an accountline of the correct type' );
3425 is( $line->branchcode, $library->id, 'AddIssuingCharge correctly sets branchcode' );
3426 is( $line->description, '', 'AddIssue does not set a hardcoded description for the accountline' );
3428 $line = $lines->next;
3429 is( $line->debit_type_code, 'RENT_RENEW', 'The renewal of item with issuing charge generates an accountline of the correct type' );
3430 is( $line->branchcode, $library->id, 'AddRenewal correctly sets branchcode' );
3431 is( $line->description, '', 'AddRenewal does not set a hardcoded description for the accountline' );
3433 t::lib::Mocks::mock_preference( 'RenewalLog', 1 );
3435 $context = Test::MockModule->new('C4::Context');
3436 $context->mock( userenv => { branch => undef, interface => 'CRON'} ); #Test statistical logging of renewal via cron (atuo_renew)
3438 my $now = dt_from_string;
3439 $date = output_pref( { dt => $now, dateonly => 1, dateformat => 'iso' } );
3440 $old_log_size = Koha::ActionLogs->count( \%params_renewal );
3441 my $sth = $dbh->prepare("SELECT COUNT(*) FROM statistics WHERE itemnumber = ? AND branch = ?");
3442 $sth->execute($item->id, $library->id);
3443 my ($old_stats_size) = $sth->fetchrow_array;
3444 AddRenewal( $patron->id, $item->id, $library->id );
3445 $new_log_size = Koha::ActionLogs->count( \%params_renewal );
3446 $sth->execute($item->id, $library->id);
3447 my ($new_stats_size) = $sth->fetchrow_array;
3448 is( $new_log_size, $old_log_size + 1, 'renew log successfully added' );
3449 is( $new_stats_size, $old_stats_size + 1, 'renew statistic successfully added with passed branch' );
3451 AddReturn( $item->id, $library->id, undef, $date );
3452 AddIssue( $patron->unblessed, $item->barcode, $now );
3453 AddRenewal( $patron->id, $item->id, $library->id, undef, undef, 1 );
3454 my $lines_skipped = Koha::Account::Lines->search({
3455 borrowernumber => $patron->id,
3456 itemnumber => $item->id
3458 is( $lines_skipped->count, 5, 'Passing skipfinecalc causes fine calculation on renewal to be skipped' );
3462 subtest 'ProcessOfflinePayment() tests' => sub {
3469 my $patron = $builder->build_object({ class => 'Koha::Patrons' });
3470 my $library = $builder->build_object({ class => 'Koha::Libraries' });
3471 my $result = C4::Circulation::ProcessOfflinePayment({ cardnumber => $patron->cardnumber, amount => $amount, branchcode => $library->id });
3473 is( $result, 'Success.', 'The right string is returned' );
3475 my $lines = $patron->account->lines;
3476 is( $lines->count, 1, 'line created correctly');
3478 my $line = $lines->next;
3479 is( $line->amount+0, $amount * -1, 'amount picked from params' );
3480 is( $line->branchcode, $library->id, 'branchcode set correctly' );
3484 subtest 'Incremented fee tests' => sub {
3487 my $dt = dt_from_string();
3488 Time::Fake->offset( $dt->epoch );
3490 t::lib::Mocks::mock_preference( 'item-level_itypes', 1 );
3493 $builder->build_object( { class => 'Koha::Libraries' } )->store;
3495 my $module = new Test::MockModule('C4::Context');
3496 $module->mock( 'userenv', sub { { branch => $library->id } } );
3498 my $patron = $builder->build_object(
3500 class => 'Koha::Patrons',
3501 value => { categorycode => $patron_category->{categorycode} }
3505 my $itemtype = $builder->build_object(
3507 class => 'Koha::ItemTypes',
3509 notforloan => undef,
3511 rentalcharge_daily => 1,
3512 rentalcharge_daily_calendar => 0
3517 my $item = $builder->build_sample_item(
3519 library => $library->{branchcode},
3520 itype => $itemtype->id,
3524 is( $itemtype->rentalcharge_daily+0,
3525 1, 'Daily rental charge stored and retreived correctly' );
3526 is( $item->effective_itemtype, $itemtype->id,
3527 "Itemtype set correctly for item" );
3529 my $now = dt_from_string;
3530 my $dt_from = $now->clone;
3531 my $dt_to = $now->clone->add( days => 7 );
3532 my $dt_to_renew = $now->clone->add( days => 13 );
3536 AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
3537 my $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
3538 is( $accountline->amount+0, 7,
3539 "Daily rental charge calculated correctly with rentalcharge_daily_calendar = 0"
3541 $accountline->delete();
3542 AddRenewal( $patron->id, $item->id, $library->id, $dt_to_renew, $dt_to );
3543 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
3544 is( $accountline->amount+0, 6,
3545 "Daily rental charge calculated correctly with rentalcharge_daily_calendar = 0, for renewal"
3547 $accountline->delete();
3550 t::lib::Mocks::mock_preference( 'finesCalendar', 'noFinesWhenClosed' );
3551 $itemtype->rentalcharge_daily_calendar(1)->store();
3553 AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
3554 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
3555 is( $accountline->amount+0, 7,
3556 "Daily rental charge calculated correctly with rentalcharge_daily_calendar = 1"
3558 $accountline->delete();
3559 AddRenewal( $patron->id, $item->id, $library->id, $dt_to_renew, $dt_to );
3560 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
3561 is( $accountline->amount+0, 6,
3562 "Daily rental charge calculated correctly with rentalcharge_daily_calendar = 1, for renewal"
3564 $accountline->delete();
3567 my $calendar = C4::Calendar->new( branchcode => $library->id );
3568 # DateTime 1..7 (Mon..Sun), C4::Calender 0..6 (Sun..Sat)
3570 ( $dt_from->day_of_week == 6 ) ? 0
3571 : ( $dt_from->day_of_week == 7 ) ? 1
3572 : $dt_from->day_of_week + 1;
3573 my $closed_day_name = $dt_from->clone->add(days => 1)->day_name;
3574 $calendar->insert_week_day_holiday(
3575 weekday => $closed_day,
3576 title => 'Test holiday',
3577 description => 'Test holiday'
3580 AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
3581 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
3582 is( $accountline->amount+0, 6,
3583 "Daily rental charge calculated correctly with rentalcharge_daily_calendar = 1 and closed $closed_day_name"
3585 $accountline->delete();
3586 AddRenewal( $patron->id, $item->id, $library->id, $dt_to_renew, $dt_to );
3587 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
3588 is( $accountline->amount+0, 5,
3589 "Daily rental charge calculated correctly with rentalcharge_daily_calendar = 1 and closed $closed_day_name, for renewal"
3591 $accountline->delete();
3594 $itemtype->rentalcharge(2)->store;
3595 is( $itemtype->rentalcharge+0, 2,
3596 'Rental charge updated and retreived correctly' );
3598 AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
3600 Koha::Account::Lines->search( { itemnumber => $item->id } );
3601 is( $accountlines->count, '2',
3602 "Fixed charge and accrued charge recorded distinctly" );
3603 $accountlines->delete();
3604 AddRenewal( $patron->id, $item->id, $library->id, $dt_to_renew, $dt_to );
3605 $accountlines = Koha::Account::Lines->search( { itemnumber => $item->id } );
3606 is( $accountlines->count, '2',
3607 "Fixed charge and accrued charge recorded distinctly, for renewal" );
3608 $accountlines->delete();
3610 $itemtype->rentalcharge(0)->store;
3611 is( $itemtype->rentalcharge+0, 0,
3612 'Rental charge reset and retreived correctly' );
3615 Koha::CirculationRules->set_rule(
3617 categorycode => $patron->categorycode,
3618 itemtype => $itemtype->id,
3619 branchcode => $library->id,
3620 rule_name => 'lengthunit',
3621 rule_value => 'hours',
3625 $itemtype->rentalcharge_hourly('0.25')->store();
3626 is( $itemtype->rentalcharge_hourly,
3627 '0.25', 'Hourly rental charge stored and retreived correctly' );
3629 $dt_to = $now->clone->add( hours => 168 );
3630 $dt_to_renew = $now->clone->add( hours => 312 );
3632 $itemtype->rentalcharge_hourly_calendar(0)->store();
3634 AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
3635 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
3636 is( $accountline->amount + 0, 42,
3637 "Hourly rental charge calculated correctly with rentalcharge_hourly_calendar = 0 (168h * 0.25u)" );
3638 $accountline->delete();
3639 AddRenewal( $patron->id, $item->id, $library->id, $dt_to_renew, $dt_to );
3640 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
3641 is( $accountline->amount + 0, 36,
3642 "Hourly rental charge calculated correctly with rentalcharge_hourly_calendar = 0, for renewal (312h - 168h * 0.25u)" );
3643 $accountline->delete();
3646 $itemtype->rentalcharge_hourly_calendar(1)->store();
3648 AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
3649 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
3650 is( $accountline->amount + 0, 36,
3651 "Hourly rental charge calculated correctly with rentalcharge_hourly_calendar = 1 and closed $closed_day_name (168h - 24h * 0.25u)" );
3652 $accountline->delete();
3653 AddRenewal( $patron->id, $item->id, $library->id, $dt_to_renew, $dt_to );
3654 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
3655 is( $accountline->amount + 0, 30,
3656 "Hourly rental charge calculated correctly with rentalcharge_hourly_calendar = 1 and closed $closed_day_name, for renewal (312h - 168h - 24h * 0.25u" );
3657 $accountline->delete();
3660 $calendar->delete_holiday( weekday => $closed_day );
3662 AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
3663 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
3664 is( $accountline->amount + 0, 42,
3665 "Hourly rental charge calculated correctly with rentalcharge_hourly_calendar = 1 (168h - 0h * 0.25u" );
3666 $accountline->delete();
3667 AddRenewal( $patron->id, $item->id, $library->id, $dt_to_renew, $dt_to );
3668 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
3669 is( $accountline->amount + 0, 36,
3670 "Hourly rental charge calculated correctly with rentalcharge_hourly_calendar = 1, for renewal (312h - 168h - 0h * 0.25u)" );
3671 $accountline->delete();
3676 subtest 'CanBookBeIssued & RentalFeesCheckoutConfirmation' => sub {
3679 t::lib::Mocks::mock_preference('RentalFeesCheckoutConfirmation', 1);
3680 t::lib::Mocks::mock_preference('item-level_itypes', 1);
3683 $builder->build_object( { class => 'Koha::Libraries' } )->store;
3684 my $patron = $builder->build_object(
3686 class => 'Koha::Patrons',
3687 value => { categorycode => $patron_category->{categorycode} }
3691 my $itemtype = $builder->build_object(
3693 class => 'Koha::ItemTypes',
3697 rentalcharge_daily => 0
3702 my $biblioitem = $builder->build( { source => 'Biblioitem' } );
3703 my $item = $builder->build_object(
3705 class => 'Koha::Items',
3707 homebranch => $library->id,
3708 holdingbranch => $library->id,
3712 itype => $itemtype->id,
3713 biblionumber => $biblioitem->{biblionumber},
3714 biblioitemnumber => $biblioitem->{biblioitemnumber},
3719 my ( $issuingimpossible, $needsconfirmation );
3720 my $dt_from = dt_from_string();
3721 my $dt_due = $dt_from->clone->add( days => 3 );
3723 $itemtype->rentalcharge(1)->store;
3724 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, $dt_due, undef, undef, undef );
3725 is_deeply( $needsconfirmation, { RENTALCHARGE => '1.00' }, 'Item needs rentalcharge confirmation to be issued' );
3726 $itemtype->rentalcharge('0')->store;
3727 $itemtype->rentalcharge_daily(1)->store;
3728 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, $dt_due, undef, undef, undef );
3729 is_deeply( $needsconfirmation, { RENTALCHARGE => '3' }, 'Item needs rentalcharge confirmation to be issued, increment' );
3730 $itemtype->rentalcharge_daily('0')->store;
3733 subtest "Test Backdating of Returns" => sub {
3736 my $branch = $library2->{branchcode};
3737 my $biblio = $builder->build_sample_biblio();
3738 my $item = $builder->build_sample_item(
3740 biblionumber => $biblio->biblionumber,
3746 my %a_borrower_data = (
3747 firstname => 'Kyle',
3749 categorycode => $patron_category->{categorycode},
3750 branchcode => $branch,
3752 my $borrowernumber = Koha::Patron->new(\%a_borrower_data)->store->borrowernumber;
3753 my $borrower = Koha::Patrons->find( $borrowernumber )->unblessed;
3755 my $due_date = dt_from_string;
3756 my $issue = AddIssue( $borrower, $item->barcode, $due_date );
3759 issue_id => $issue->id(),
3760 itemnumber => $item->itemnumber,
3761 borrowernumber => $borrowernumber,
3763 amountoutstanding => .25,
3769 my ( undef, $message ) = AddReturn( $item->barcode, $branch, undef, $due_date );
3771 my $accountline = Koha::Account::Lines->find( { issue_id => $issue->id } );
3772 is( $accountline->amountoutstanding+0, 0, 'Fee amount outstanding was reduced to 0' );
3773 is( $accountline->amount+0, 0, 'Fee amount was reduced to 0' );
3776 subtest 'Do not return on renewal (LOST charge)' => sub {
3779 t::lib::Mocks::mock_preference('MarkLostItemsAsReturned', 'onpayment');
3780 my $library = $builder->build_object( { class => "Koha::Libraries" } );
3781 my $manager = $builder->build_object( { class => "Koha::Patrons" } );
3782 t::lib::Mocks::mock_userenv({ patron => $manager,branchcode => $manager->branchcode });
3784 my $biblio = $builder->build_sample_biblio;
3786 my $item = $builder->build_sample_item(
3788 biblionumber => $biblio->biblionumber,
3789 library => $library->branchcode,
3790 replacementprice => 99.00,
3795 my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
3796 AddIssue( $patron->unblessed, $item->barcode );
3798 my $accountline = Koha::Account::Line->new(
3800 borrowernumber => $patron->borrowernumber,
3801 debit_type_code => 'LOST',
3803 itemnumber => $item->itemnumber,
3805 amountoutstanding => 12,
3806 interface => 'something',
3810 # AddRenewal doesn't call _FixAccountForLostAndFound
3811 AddIssue( $patron->unblessed, $item->barcode );
3813 is( $patron->checkouts->count, 1,
3814 'Renewal should not return the item even if a LOST payment has been made earlier'
3818 subtest 'Filling a hold should cancel existing transfer' => sub {
3821 t::lib::Mocks::mock_preference('AutomaticItemReturn', 1);
3823 my $libraryA = $builder->build_object( { class => 'Koha::Libraries' } );
3824 my $libraryB = $builder->build_object( { class => 'Koha::Libraries' } );
3825 my $patron = $builder->build_object(
3827 class => 'Koha::Patrons',
3829 categorycode => $patron_category->{categorycode},
3830 branchcode => $libraryA->branchcode,
3835 my $item = $builder->build_sample_item({
3836 homebranch => $libraryB->branchcode,
3839 my ( undef, $message ) = AddReturn( $item->barcode, $libraryA->branchcode, undef, undef );
3840 is( Koha::Item::Transfers->search({ itemnumber => $item->itemnumber, datearrived => undef })->count, 1, "We generate a transfer on checkin");
3842 branchcode => $libraryA->branchcode,
3843 borrowernumber => $patron->borrowernumber,
3844 biblionumber => $item->biblionumber,
3845 itemnumber => $item->itemnumber
3847 my $reserves = Koha::Holds->search({ itemnumber => $item->itemnumber });
3848 is( $reserves->count, 1, "Reserve is placed");
3849 ( undef, $message ) = AddReturn( $item->barcode, $libraryA->branchcode, undef, undef );
3850 my $reserve = $reserves->next;
3851 ModReserveAffect( $item->itemnumber, $patron->borrowernumber, 0, $reserve->reserve_id );
3852 $reserve->discard_changes;
3853 ok( $reserve->found eq 'W', "Reserve is marked waiting" );
3854 is( Koha::Item::Transfers->search({ itemnumber => $item->itemnumber, datearrived => undef })->count, 0, "No outstanding transfers when hold is waiting");
3857 $schema->storage->txn_rollback;
3858 C4::Context->clear_syspref_cache();
3859 $cache->clear_from_cache('single_holidays');