3 # This file is part of Koha.
5 # Koha is free software; you can redistribute it and/or modify it
6 # under the terms of the GNU General Public License as published by
7 # the Free Software Foundation; either version 3 of the License, or
8 # (at your option) any later version.
10 # Koha is distributed in the hope that it will be useful, but
11 # WITHOUT ANY WARRANTY; without even the implied warranty of
12 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 # GNU General Public License for more details.
15 # You should have received a copy of the GNU General Public License
16 # along with Koha; if not, see <http://www.gnu.org/licenses>.
21 use Test::More tests => 46;
23 use Test::Deep qw( cmp_deeply );
28 use POSIX qw( floor );
30 use t::lib::TestBuilder;
39 use C4::Overdues qw(UpdateFine CalcFine);
45 use Koha::CirculationRules;
46 use Koha::Subscriptions;
47 use Koha::Account::Lines;
48 use Koha::Account::Offsets;
53 t::lib::Mocks::mock_userenv({ branchcode => $library->{branchcode} });
57 my ( $error, $question, $alert ) = @_;
59 $s = %$error ? ' (error: ' . join( ' ', keys %$error ) . ')' : '';
60 $s .= %$question ? ' (question: ' . join( ' ', keys %$question ) . ')' : '';
61 $s .= %$alert ? ' (alert: ' . join( ' ', keys %$alert ) . ')' : '';
65 sub test_debarment_on_checkout {
67 my $item = $params->{item};
68 my $library = $params->{library};
69 my $patron = $params->{patron};
70 my $due_date = $params->{due_date} || dt_from_string;
71 my $return_date = $params->{return_date} || dt_from_string;
72 my $expected_expiration_date = $params->{expiration_date};
74 $expected_expiration_date = output_pref(
76 dt => $expected_expiration_date,
82 my $line_number = $caller[2];
83 AddIssue( $patron, $item->{barcode}, $due_date );
85 my ( undef, $message ) = AddReturn( $item->{barcode}, $library->{branchcode}, undef, $return_date );
86 is( $message->{WasReturned} && exists $message->{Debarred}, 1, 'AddReturn must have debarred the patron' )
87 or diag('AddReturn returned message ' . Dumper $message );
88 my $debarments = Koha::Patron::Debarments::GetDebarments(
89 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
90 is( scalar(@$debarments), 1, 'Test at line ' . $line_number );
92 is( $debarments->[0]->{expiration},
93 $expected_expiration_date, 'Test at line ' . $line_number );
94 Koha::Patron::Debarments::DelUniqueDebarment(
95 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
98 my $schema = Koha::Database->schema;
99 $schema->storage->txn_begin;
100 my $builder = t::lib::TestBuilder->new;
101 my $dbh = C4::Context->dbh;
103 # Prevent random failures by mocking ->now
104 my $now_value = dt_from_string;
105 my $mocked_datetime = Test::MockModule->new('DateTime');
106 $mocked_datetime->mock( 'now', sub { return $now_value->clone; } );
109 $dbh->{RaiseError} = 1;
111 my $cache = Koha::Caches->get_instance();
112 $dbh->do(q|DELETE FROM special_holidays|);
113 $dbh->do(q|DELETE FROM repeatable_holidays|);
114 $cache->clear_from_cache('single_holidays');
116 # Start with a clean slate
117 $dbh->do('DELETE FROM issues');
118 $dbh->do('DELETE FROM borrowers');
120 my $library = $builder->build({
123 my $library2 = $builder->build({
126 my $itemtype = $builder->build(
128 source => 'Itemtype',
132 rentalcharge_daily => 0,
133 defaultreplacecost => undef,
138 my $patron_category = $builder->build(
140 source => 'Category',
142 category_type => 'P',
144 BlockExpiredPatronOpacActions => -1, # Pick the pref value
149 my $CircControl = C4::Context->preference('CircControl');
150 my $HomeOrHoldingBranch = C4::Context->preference('HomeOrHoldingBranch');
153 homebranch => $library2->{branchcode},
154 holdingbranch => $library2->{branchcode}
158 branchcode => $library2->{branchcode}
161 t::lib::Mocks::mock_preference('AutoReturnCheckedOutItems', 0);
163 # No userenv, PickupLibrary
164 t::lib::Mocks::mock_preference('IndependentBranches', '0');
165 t::lib::Mocks::mock_preference('CircControl', 'PickupLibrary');
167 C4::Context->preference('CircControl'),
169 'CircControl changed to PickupLibrary'
172 C4::Circulation::_GetCircControlBranch($item, $borrower),
173 $item->{$HomeOrHoldingBranch},
174 '_GetCircControlBranch returned item branch (no userenv defined)'
177 # No userenv, PatronLibrary
178 t::lib::Mocks::mock_preference('CircControl', 'PatronLibrary');
180 C4::Context->preference('CircControl'),
182 'CircControl changed to PatronLibrary'
185 C4::Circulation::_GetCircControlBranch($item, $borrower),
186 $borrower->{branchcode},
187 '_GetCircControlBranch returned borrower branch'
190 # No userenv, ItemHomeLibrary
191 t::lib::Mocks::mock_preference('CircControl', 'ItemHomeLibrary');
193 C4::Context->preference('CircControl'),
195 'CircControl changed to ItemHomeLibrary'
198 $item->{$HomeOrHoldingBranch},
199 C4::Circulation::_GetCircControlBranch($item, $borrower),
200 '_GetCircControlBranch returned item branch'
204 t::lib::Mocks::mock_userenv({ branchcode => $library2->{branchcode} });
205 is(C4::Context->userenv->{branch}, $library2->{branchcode}, 'userenv set');
207 # Userenv set, PickupLibrary
208 t::lib::Mocks::mock_preference('CircControl', 'PickupLibrary');
210 C4::Context->preference('CircControl'),
212 'CircControl changed to PickupLibrary'
215 C4::Circulation::_GetCircControlBranch($item, $borrower),
216 $library2->{branchcode},
217 '_GetCircControlBranch returned current branch'
220 # Userenv set, PatronLibrary
221 t::lib::Mocks::mock_preference('CircControl', 'PatronLibrary');
223 C4::Context->preference('CircControl'),
225 'CircControl changed to PatronLibrary'
228 C4::Circulation::_GetCircControlBranch($item, $borrower),
229 $borrower->{branchcode},
230 '_GetCircControlBranch returned borrower branch'
233 # Userenv set, ItemHomeLibrary
234 t::lib::Mocks::mock_preference('CircControl', 'ItemHomeLibrary');
236 C4::Context->preference('CircControl'),
238 'CircControl changed to ItemHomeLibrary'
241 C4::Circulation::_GetCircControlBranch($item, $borrower),
242 $item->{$HomeOrHoldingBranch},
243 '_GetCircControlBranch returned item branch'
246 # Reset initial configuration
247 t::lib::Mocks::mock_preference('CircControl', $CircControl);
249 C4::Context->preference('CircControl'),
251 'CircControl reset to its initial value'
254 # Set a simple circ policy
255 $dbh->do('DELETE FROM circulation_rules');
256 Koha::CirculationRules->set_rules(
258 categorycode => undef,
262 reservesallowed => 25,
264 lengthunit => 'days',
265 renewalsallowed => 1,
267 norenewalbefore => undef,
275 my ( $reused_itemnumber_1, $reused_itemnumber_2 );
276 subtest "CanBookBeRenewed tests" => sub {
279 C4::Context->set_preference('ItemsDeniedRenewal','');
280 # Generate test biblio
281 my $biblio = $builder->build_sample_biblio();
283 my $branch = $library2->{branchcode};
285 my $item_1 = $builder->build_sample_item(
287 biblionumber => $biblio->biblionumber,
289 replacementprice => 12.00,
293 $reused_itemnumber_1 = $item_1->itemnumber;
295 my $item_2 = $builder->build_sample_item(
297 biblionumber => $biblio->biblionumber,
299 replacementprice => 23.00,
303 $reused_itemnumber_2 = $item_2->itemnumber;
305 my $item_3 = $builder->build_sample_item(
307 biblionumber => $biblio->biblionumber,
309 replacementprice => 23.00,
315 my %renewing_borrower_data = (
317 surname => 'Renewal',
318 categorycode => $patron_category->{categorycode},
319 branchcode => $branch,
322 my %reserving_borrower_data = (
323 firstname => 'Katrin',
324 surname => 'Reservation',
325 categorycode => $patron_category->{categorycode},
326 branchcode => $branch,
329 my %hold_waiting_borrower_data = (
331 surname => 'Reservation',
332 categorycode => $patron_category->{categorycode},
333 branchcode => $branch,
336 my %restricted_borrower_data = (
337 firstname => 'Alice',
338 surname => 'Reservation',
339 categorycode => $patron_category->{categorycode},
340 debarred => '3228-01-01',
341 branchcode => $branch,
344 my %expired_borrower_data = (
347 categorycode => $patron_category->{categorycode},
348 branchcode => $branch,
349 dateexpiry => dt_from_string->subtract( months => 1 ),
352 my $renewing_borrowernumber = Koha::Patron->new(\%renewing_borrower_data)->store->borrowernumber;
353 my $reserving_borrowernumber = Koha::Patron->new(\%reserving_borrower_data)->store->borrowernumber;
354 my $hold_waiting_borrowernumber = Koha::Patron->new(\%hold_waiting_borrower_data)->store->borrowernumber;
355 my $restricted_borrowernumber = Koha::Patron->new(\%restricted_borrower_data)->store->borrowernumber;
356 my $expired_borrowernumber = Koha::Patron->new(\%expired_borrower_data)->store->borrowernumber;
358 my $renewing_borrower_obj = Koha::Patrons->find( $renewing_borrowernumber );
359 my $renewing_borrower = $renewing_borrower_obj->unblessed;
360 my $restricted_borrower = Koha::Patrons->find( $restricted_borrowernumber )->unblessed;
361 my $expired_borrower = Koha::Patrons->find( $expired_borrowernumber )->unblessed;
368 my $checkitem = undef;
371 my $issue = AddIssue( $renewing_borrower, $item_1->barcode);
372 my $datedue = dt_from_string( $issue->date_due() );
373 is (defined $issue->date_due(), 1, "Item 1 checked out, due date: " . $issue->date_due() );
375 my $issue2 = AddIssue( $renewing_borrower, $item_2->barcode);
376 $datedue = dt_from_string( $issue->date_due() );
377 is (defined $issue2, 1, "Item 2 checked out, due date: " . $issue2->date_due());
380 my $borrowing_borrowernumber = Koha::Checkouts->find( { itemnumber => $item_1->itemnumber } )->borrowernumber;
381 is ($borrowing_borrowernumber, $renewing_borrowernumber, "Item checked out to $renewing_borrower->{firstname} $renewing_borrower->{surname}");
383 my ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber, 1);
384 is( $renewokay, 1, 'Can renew, no holds for this title or item');
387 # Biblio-level hold, renewal test
390 branchcode => $branch,
391 borrowernumber => $reserving_borrowernumber,
392 biblionumber => $biblio->biblionumber,
393 priority => $priority,
394 reservation_date => $resdate,
395 expiration_date => $expdate,
397 itemnumber => $checkitem,
402 # Testing of feature to allow the renewal of reserved items if other items on the record can fill all needed holds
403 Koha::CirculationRules->set_rule(
405 categorycode => undef,
408 rule_name => 'onshelfholds',
412 t::lib::Mocks::mock_preference('AllowRenewalIfOtherItemsAvailable', 1 );
413 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
414 is( $renewokay, 1, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
415 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_2->itemnumber);
416 is( $renewokay, 1, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
418 # Now let's add an item level hold, we should no longer be able to renew the item
419 my $hold = Koha::Database->new()->schema()->resultset('Reserve')->create(
421 borrowernumber => $hold_waiting_borrowernumber,
422 biblionumber => $biblio->biblionumber,
423 itemnumber => $item_1->itemnumber,
424 branchcode => $branch,
428 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
429 is( $renewokay, 0, 'Bug 13919 - Renewal possible with item level hold on item');
432 # Now let's add a waiting hold on the 3rd item, it's no longer available tp check out by just anyone, so we should no longer
433 # be able to renew these items
434 $hold = Koha::Database->new()->schema()->resultset('Reserve')->create(
436 borrowernumber => $hold_waiting_borrowernumber,
437 biblionumber => $biblio->biblionumber,
438 itemnumber => $item_3->itemnumber,
439 branchcode => $branch,
444 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
445 is( $renewokay, 0, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
446 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_2->itemnumber);
447 is( $renewokay, 0, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
448 t::lib::Mocks::mock_preference('AllowRenewalIfOtherItemsAvailable', 0 );
450 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
451 is( $renewokay, 0, '(Bug 10663) Cannot renew, reserved');
452 is( $error, 'on_reserve', '(Bug 10663) Cannot renew, reserved (returned error is on_reserve)');
454 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_2->itemnumber);
455 is( $renewokay, 0, '(Bug 10663) Cannot renew, reserved');
456 is( $error, 'on_reserve', '(Bug 10663) Cannot renew, reserved (returned error is on_reserve)');
458 my $reserveid = Koha::Holds->search({ biblionumber => $biblio->biblionumber, borrowernumber => $reserving_borrowernumber })->next->reserve_id;
459 my $reserving_borrower = Koha::Patrons->find( $reserving_borrowernumber )->unblessed;
460 AddIssue($reserving_borrower, $item_3->barcode);
461 my $reserve = $dbh->selectrow_hashref(
462 'SELECT * FROM old_reserves WHERE reserve_id = ?',
466 is($reserve->{found}, 'F', 'hold marked completed when checking out item that fills it');
468 # Item-level hold, renewal test
471 branchcode => $branch,
472 borrowernumber => $reserving_borrowernumber,
473 biblionumber => $biblio->biblionumber,
474 priority => $priority,
475 reservation_date => $resdate,
476 expiration_date => $expdate,
478 itemnumber => $item_1->itemnumber,
483 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber, 1);
484 is( $renewokay, 0, '(Bug 10663) Cannot renew, item reserved');
485 is( $error, 'on_reserve', '(Bug 10663) Cannot renew, item reserved (returned error is on_reserve)');
487 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_2->itemnumber, 1);
488 is( $renewokay, 1, 'Can renew item 2, item-level hold is on item 1');
490 # Items can't fill hold for reasons
491 $item_1->notforloan(1)->store;
492 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber, 1);
493 is( $renewokay, 1, 'Can renew, item is marked not for loan, hold does not block');
494 $item_1->set({notforloan => 0, itype => $itemtype })->store;
496 # FIXME: Add more for itemtype not for loan etc.
498 # Restricted users cannot renew when RestrictionBlockRenewing is enabled
499 my $item_5 = $builder->build_sample_item(
501 biblionumber => $biblio->biblionumber,
503 replacementprice => 23.00,
507 my $datedue5 = AddIssue($restricted_borrower, $item_5->barcode);
508 is (defined $datedue5, 1, "Item with date due checked out, due date: $datedue5");
510 t::lib::Mocks::mock_preference('RestrictionBlockRenewing','1');
511 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_2->itemnumber);
512 is( $renewokay, 1, '(Bug 8236), Can renew, user is not restricted');
513 ( $renewokay, $error ) = CanBookBeRenewed($restricted_borrowernumber, $item_5->itemnumber);
514 is( $renewokay, 0, '(Bug 8236), Cannot renew, user is restricted');
516 # Users cannot renew an overdue item
517 my $item_6 = $builder->build_sample_item(
519 biblionumber => $biblio->biblionumber,
521 replacementprice => 23.00,
526 my $item_7 = $builder->build_sample_item(
528 biblionumber => $biblio->biblionumber,
530 replacementprice => 23.00,
535 my $datedue6 = AddIssue( $renewing_borrower, $item_6->barcode);
536 is (defined $datedue6, 1, "Item 2 checked out, due date: ".$datedue6->date_due);
538 my $now = dt_from_string();
539 my $five_weeks = DateTime::Duration->new(weeks => 5);
540 my $five_weeks_ago = $now - $five_weeks;
541 t::lib::Mocks::mock_preference('finesMode', 'production');
543 my $passeddatedue1 = AddIssue($renewing_borrower, $item_7->barcode, $five_weeks_ago);
544 is (defined $passeddatedue1, 1, "Item with passed date due checked out, due date: " . $passeddatedue1->date_due);
546 my ( $fine ) = CalcFine( $item_7->unblessed, $renewing_borrower->{categorycode}, $branch, $five_weeks_ago, $now );
547 C4::Overdues::UpdateFine(
549 issue_id => $passeddatedue1->id(),
550 itemnumber => $item_7->itemnumber,
551 borrowernumber => $renewing_borrower->{borrowernumber},
553 due => Koha::DateUtils::output_pref($five_weeks_ago)
557 t::lib::Mocks::mock_preference('RenewalLog', 0);
558 my $date = output_pref( { dt => dt_from_string(), dateonly => 1, dateformat => 'iso' } );
559 my %params_renewal = (
560 timestamp => { -like => $date . "%" },
561 module => "CIRCULATION",
565 timestamp => { -like => $date . "%" },
566 module => "CIRCULATION",
569 my $old_log_size = Koha::ActionLogs->count( \%params_renewal );
570 my $dt = dt_from_string();
571 Time::Fake->offset( $dt->epoch );
572 my $datedue1 = AddRenewal( $renewing_borrower->{borrowernumber}, $item_7->itemnumber, $branch );
573 my $new_log_size = Koha::ActionLogs->count( \%params_renewal );
574 is ($new_log_size, $old_log_size, 'renew log not added because of the syspref RenewalLog');
575 isnt (DateTime->compare($datedue1, $dt), 0, "AddRenewal returned a good duedate");
578 t::lib::Mocks::mock_preference('RenewalLog', 1);
579 $date = output_pref( { dt => dt_from_string(), dateonly => 1, dateformat => 'iso' } );
580 $old_log_size = Koha::ActionLogs->count( \%params_renewal );
581 AddRenewal( $renewing_borrower->{borrowernumber}, $item_7->itemnumber, $branch );
582 $new_log_size = Koha::ActionLogs->count( \%params_renewal );
583 is ($new_log_size, $old_log_size + 1, 'renew log successfully added');
585 my $fines = Koha::Account::Lines->search( { borrowernumber => $renewing_borrower->{borrowernumber}, itemnumber => $item_7->itemnumber } );
586 is( $fines->count, 2, 'AddRenewal left both fines' );
587 isnt( $fines->next->status, 'UNRETURNED', 'Fine on renewed item is closed out properly' );
588 isnt( $fines->next->status, 'UNRETURNED', 'Fine on renewed item is closed out properly' );
592 my $old_issue_log_size = Koha::ActionLogs->count( \%params_issue );
593 my $old_renew_log_size = Koha::ActionLogs->count( \%params_renewal );
594 AddIssue( $renewing_borrower,$item_7->barcode,Koha::DateUtils::output_pref({str=>$datedue6->date_due, dateformat =>'iso'}),0,$date, 0, undef );
595 $new_log_size = Koha::ActionLogs->count( \%params_renewal );
596 is ($new_log_size, $old_renew_log_size + 1, 'renew log successfully added when renewed via issuing');
597 $new_log_size = Koha::ActionLogs->count( \%params_issue );
598 is ($new_log_size, $old_issue_log_size, 'renew not logged as issue when renewed via issuing');
600 $fines = Koha::Account::Lines->search( { borrowernumber => $renewing_borrower->{borrowernumber}, itemnumber => $item_7->itemnumber } );
603 t::lib::Mocks::mock_preference('OverduesBlockRenewing','blockitem');
604 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_6->itemnumber);
605 is( $renewokay, 1, '(Bug 8236), Can renew, this item is not overdue');
606 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_7->itemnumber);
607 is( $renewokay, 0, '(Bug 8236), Cannot renew, this item is overdue');
610 $hold = Koha::Holds->search({ biblionumber => $biblio->biblionumber, borrowernumber => $reserving_borrowernumber })->next;
614 # Test automatic renewal before value for "norenewalbefore" in policy is set
615 # In this case automatic renewal is not permitted prior to due date
616 my $item_4 = $builder->build_sample_item(
618 biblionumber => $biblio->biblionumber,
620 replacementprice => 16.00,
625 $issue = AddIssue( $renewing_borrower, $item_4->barcode, undef, undef, undef, undef, { auto_renew => 1 } );
626 ( $renewokay, $error ) =
627 CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
628 is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic and premature' );
629 is( $error, 'auto_too_soon',
630 'Bug 14101: Cannot renew, renewal is automatic and premature, "No renewal before" = undef (returned code is auto_too_soon)' );
633 branchcode => $branch,
634 borrowernumber => $reserving_borrowernumber,
635 biblionumber => $biblio->biblionumber,
636 itemnumber => $bibitems,
637 priority => $priority,
638 reservation_date => $resdate,
639 expiration_date => $expdate,
642 itemnumber => $item_4->itemnumber,
646 ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
647 is( $renewokay, 0, 'Still should not be able to renew' );
648 is( $error, 'auto_too_soon', 'returned code is auto_too_soon, reserve not checked' );
649 ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber, 1 );
650 is( $renewokay, 0, 'Still should not be able to renew' );
651 is( $error, 'on_reserve', 'returned code is on_reserve, auto_too_soon limit is overridden' );
652 $dbh->do('UPDATE circulation_rules SET rule_value = 0 where rule_name = "norenewalbefore"');
653 ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber, 1 );
654 is( $renewokay, 0, 'Still should not be able to renew' );
655 is( $error, 'on_reserve', 'returned code is on_reserve, auto_renew only happens if not on reserve' );
656 ModReserveCancelAll($item_4->itemnumber, $reserving_borrowernumber);
660 $renewing_borrower_obj->autorenew_checkouts(0)->store;
661 ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
662 is( $renewokay, 1, 'No renewal before is undef, but patron opted out of auto_renewal' );
663 $renewing_borrower_obj->autorenew_checkouts(1)->store;
667 # Test premature manual renewal
668 Koha::CirculationRules->set_rule(
670 categorycode => undef,
673 rule_name => 'norenewalbefore',
678 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
679 is( $renewokay, 0, 'Bug 7413: Cannot renew, renewal is premature');
680 is( $error, 'too_soon', 'Bug 7413: Cannot renew, renewal is premature (returned code is too_soon)');
683 # Test 'exact time' setting for syspref NoRenewalBeforePrecision
684 t::lib::Mocks::mock_preference( 'NoRenewalBeforePrecision', 'exact_time' );
686 GetSoonestRenewDate( $renewing_borrowernumber, $item_1->itemnumber ),
687 $datedue->clone->add( days => -7 ),
688 'Bug 14395: Renewals permitted 7 days before due date, as expected'
692 # Test 'date' setting for syspref NoRenewalBeforePrecision
693 t::lib::Mocks::mock_preference( 'NoRenewalBeforePrecision', 'date' );
695 GetSoonestRenewDate( $renewing_borrowernumber, $item_1->itemnumber ),
696 $datedue->clone->add( days => -7 )->truncate( to => 'day' ),
697 'Bug 14395: Renewals permitted 7 days before due date, as expected'
701 # Test premature automatic renewal
702 ( $renewokay, $error ) =
703 CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
704 is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic and premature' );
705 is( $error, 'auto_too_soon',
706 'Bug 14101: Cannot renew, renewal is automatic and premature (returned code is auto_too_soon)'
709 $renewing_borrower_obj->autorenew_checkouts(0)->store;
710 ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
711 is( $renewokay, 0, 'No renewal before is 7, patron opted out of auto_renewal still cannot renew early' );
712 is( $error, 'too_soon', 'Error is too_soon, no auto' );
713 $renewing_borrower_obj->autorenew_checkouts(1)->store;
715 # Change policy so that loans can only be renewed exactly on due date (0 days prior to due date)
716 # and test automatic renewal again
717 $dbh->do(q{UPDATE circulation_rules SET rule_value = '0' WHERE rule_name = 'norenewalbefore'});
718 ( $renewokay, $error ) =
719 CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
720 is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic and premature' );
721 is( $error, 'auto_too_soon',
722 'Bug 14101: Cannot renew, renewal is automatic and premature, "No renewal before" = 0 (returned code is auto_too_soon)'
725 $renewing_borrower_obj->autorenew_checkouts(0)->store;
726 ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
727 is( $renewokay, 0, 'No renewal before is 0, patron opted out of auto_renewal still cannot renew early' );
728 is( $error, 'too_soon', 'Error is too_soon, no auto' );
729 $renewing_borrower_obj->autorenew_checkouts(1)->store;
731 # Change policy so that loans can be renewed 99 days prior to the due date
732 # and test automatic renewal again
733 $dbh->do(q{UPDATE circulation_rules SET rule_value = '99' WHERE rule_name = 'norenewalbefore'});
734 ( $renewokay, $error ) =
735 CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
736 is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic' );
737 is( $error, 'auto_renew',
738 'Bug 14101: Cannot renew, renewal is automatic (returned code is auto_renew)'
741 $renewing_borrower_obj->autorenew_checkouts(0)->store;
742 ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
743 is( $renewokay, 1, 'No renewal before is 99, patron opted out of auto_renewal so can renew' );
744 $renewing_borrower_obj->autorenew_checkouts(1)->store;
746 subtest "too_late_renewal / no_auto_renewal_after" => sub {
748 my $item_to_auto_renew = $builder->build(
751 biblionumber => $biblio->biblionumber,
752 homebranch => $branch,
753 holdingbranch => $branch,
758 my $ten_days_before = dt_from_string->add( days => -10 );
759 my $ten_days_ahead = dt_from_string->add( days => 10 );
760 AddIssue( $renewing_borrower, $item_to_auto_renew->{barcode}, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
762 Koha::CirculationRules->set_rules(
764 categorycode => undef,
768 norenewalbefore => '7',
769 no_auto_renewal_after => '9',
773 ( $renewokay, $error ) =
774 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
775 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
776 is( $error, 'auto_too_late', 'Cannot renew, too late(returned code is auto_too_late)' );
778 Koha::CirculationRules->set_rules(
780 categorycode => undef,
784 norenewalbefore => '7',
785 no_auto_renewal_after => '10',
789 ( $renewokay, $error ) =
790 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
791 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
792 is( $error, 'auto_too_late', 'Cannot auto renew, too late - no_auto_renewal_after is inclusive(returned code is auto_too_late)' );
794 Koha::CirculationRules->set_rules(
796 categorycode => undef,
800 norenewalbefore => '7',
801 no_auto_renewal_after => '11',
805 ( $renewokay, $error ) =
806 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
807 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
808 is( $error, 'auto_too_soon', 'Cannot auto renew, too soon - no_auto_renewal_after is defined(returned code is auto_too_soon)' );
810 Koha::CirculationRules->set_rules(
812 categorycode => undef,
816 norenewalbefore => '10',
817 no_auto_renewal_after => '11',
821 ( $renewokay, $error ) =
822 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
823 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
824 is( $error, 'auto_renew', 'Cannot renew, renew is automatic' );
826 Koha::CirculationRules->set_rules(
828 categorycode => undef,
832 norenewalbefore => '10',
833 no_auto_renewal_after => undef,
834 no_auto_renewal_after_hard_limit => dt_from_string->add( days => -1 ),
838 ( $renewokay, $error ) =
839 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
840 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
841 is( $error, 'auto_too_late', 'Cannot renew, too late(returned code is auto_too_late)' );
843 Koha::CirculationRules->set_rules(
845 categorycode => undef,
849 norenewalbefore => '7',
850 no_auto_renewal_after => '15',
851 no_auto_renewal_after_hard_limit => dt_from_string->add( days => -1 ),
855 ( $renewokay, $error ) =
856 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
857 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
858 is( $error, 'auto_too_late', 'Cannot renew, too late(returned code is auto_too_late)' );
860 Koha::CirculationRules->set_rules(
862 categorycode => undef,
866 norenewalbefore => '10',
867 no_auto_renewal_after => undef,
868 no_auto_renewal_after_hard_limit => dt_from_string->add( days => 1 ),
872 ( $renewokay, $error ) =
873 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
874 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
875 is( $error, 'auto_renew', 'Cannot renew, renew is automatic' );
878 subtest "auto_too_much_oweing | OPACFineNoRenewalsBlockAutoRenew & OPACFineNoRenewalsIncludeCredit" => sub {
880 my $item_to_auto_renew = $builder->build({
883 biblionumber => $biblio->biblionumber,
884 homebranch => $branch,
885 holdingbranch => $branch,
889 my $ten_days_before = dt_from_string->add( days => -10 );
890 my $ten_days_ahead = dt_from_string->add( days => 10 );
891 AddIssue( $renewing_borrower, $item_to_auto_renew->{barcode}, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
893 Koha::CirculationRules->set_rules(
895 categorycode => undef,
899 norenewalbefore => '10',
900 no_auto_renewal_after => '11',
904 C4::Context->set_preference('OPACFineNoRenewalsBlockAutoRenew','1');
905 C4::Context->set_preference('OPACFineNoRenewals','10');
906 C4::Context->set_preference('OPACFineNoRenewalsIncludeCredit','1');
907 my $fines_amount = 5;
908 my $account = Koha::Account->new({patron_id => $renewing_borrowernumber});
911 amount => $fines_amount,
914 item_id => $item_to_auto_renew->{itemnumber},
915 description => "Some fines"
917 )->status('RETURNED')->store;
918 ( $renewokay, $error ) =
919 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
920 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
921 is( $error, 'auto_renew', 'Can auto renew, OPACFineNoRenewals=10, patron has 5' );
925 amount => $fines_amount,
928 item_id => $item_to_auto_renew->{itemnumber},
929 description => "Some fines"
931 )->status('RETURNED')->store;
932 ( $renewokay, $error ) =
933 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
934 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
935 is( $error, 'auto_renew', 'Can auto renew, OPACFineNoRenewals=10, patron has 10' );
939 amount => $fines_amount,
942 item_id => $item_to_auto_renew->{itemnumber},
943 description => "Some fines"
945 )->status('RETURNED')->store;
946 ( $renewokay, $error ) =
947 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
948 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
949 is( $error, 'auto_too_much_oweing', 'Cannot auto renew, OPACFineNoRenewals=10, patron has 15' );
951 $account->add_credit(
953 amount => $fines_amount,
956 description => "Some payment"
959 ( $renewokay, $error ) =
960 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
961 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
962 is( $error, 'auto_renew', 'Can auto renew, OPACFineNoRenewals=10, OPACFineNoRenewalsIncludeCredit=1, patron has 15 debt, 5 credit' );
964 C4::Context->set_preference('OPACFineNoRenewalsIncludeCredit','0');
965 ( $renewokay, $error ) =
966 CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
967 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
968 is( $error, 'auto_too_much_oweing', 'Cannot auto renew, OPACFineNoRenewals=10, OPACFineNoRenewalsIncludeCredit=1, patron has 15 debt, 5 credit' );
970 $dbh->do('DELETE FROM accountlines WHERE borrowernumber=?', undef, $renewing_borrowernumber);
971 C4::Context->set_preference('OPACFineNoRenewalsIncludeCredit','1');
974 subtest "auto_account_expired | BlockExpiredPatronOpacActions" => sub {
976 my $item_to_auto_renew = $builder->build({
979 biblionumber => $biblio->biblionumber,
980 homebranch => $branch,
981 holdingbranch => $branch,
985 Koha::CirculationRules->set_rules(
987 categorycode => undef,
991 norenewalbefore => 10,
992 no_auto_renewal_after => 11,
997 my $ten_days_before = dt_from_string->add( days => -10 );
998 my $ten_days_ahead = dt_from_string->add( days => 10 );
1000 # Patron is expired and BlockExpiredPatronOpacActions=0
1001 # => auto renew is allowed
1002 t::lib::Mocks::mock_preference('BlockExpiredPatronOpacActions', 0);
1003 my $patron = $expired_borrower;
1004 my $checkout = AddIssue( $patron, $item_to_auto_renew->{barcode}, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
1005 ( $renewokay, $error ) =
1006 CanBookBeRenewed( $patron->{borrowernumber}, $item_to_auto_renew->{itemnumber} );
1007 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
1008 is( $error, 'auto_renew', 'Can auto renew, patron is expired but BlockExpiredPatronOpacActions=0' );
1009 Koha::Checkouts->find( $checkout->issue_id )->delete;
1012 # Patron is expired and BlockExpiredPatronOpacActions=1
1013 # => auto renew is not allowed
1014 t::lib::Mocks::mock_preference('BlockExpiredPatronOpacActions', 1);
1015 $patron = $expired_borrower;
1016 $checkout = AddIssue( $patron, $item_to_auto_renew->{barcode}, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
1017 ( $renewokay, $error ) =
1018 CanBookBeRenewed( $patron->{borrowernumber}, $item_to_auto_renew->{itemnumber} );
1019 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
1020 is( $error, 'auto_account_expired', 'Can not auto renew, lockExpiredPatronOpacActions=1 and patron is expired' );
1021 Koha::Checkouts->find( $checkout->issue_id )->delete;
1024 # Patron is not expired and BlockExpiredPatronOpacActions=1
1025 # => auto renew is allowed
1026 t::lib::Mocks::mock_preference('BlockExpiredPatronOpacActions', 1);
1027 $patron = $renewing_borrower;
1028 $checkout = AddIssue( $patron, $item_to_auto_renew->{barcode}, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
1029 ( $renewokay, $error ) =
1030 CanBookBeRenewed( $patron->{borrowernumber}, $item_to_auto_renew->{itemnumber} );
1031 is( $renewokay, 0, 'Do not renew, renewal is automatic' );
1032 is( $error, 'auto_renew', 'Can auto renew, BlockExpiredPatronOpacActions=1 but patron is not expired' );
1033 Koha::Checkouts->find( $checkout->issue_id )->delete;
1036 subtest "GetLatestAutoRenewDate" => sub {
1038 my $item_to_auto_renew = $builder->build(
1041 biblionumber => $biblio->biblionumber,
1042 homebranch => $branch,
1043 holdingbranch => $branch,
1048 my $ten_days_before = dt_from_string->add( days => -10 );
1049 my $ten_days_ahead = dt_from_string->add( days => 10 );
1050 AddIssue( $renewing_borrower, $item_to_auto_renew->{barcode}, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
1051 Koha::CirculationRules->set_rules(
1053 categorycode => undef,
1054 branchcode => undef,
1057 norenewalbefore => '7',
1058 no_auto_renewal_after => '',
1059 no_auto_renewal_after_hard_limit => undef,
1063 my $latest_auto_renew_date = GetLatestAutoRenewDate( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
1064 is( $latest_auto_renew_date, undef, 'GetLatestAutoRenewDate should return undef if no_auto_renewal_after or no_auto_renewal_after_hard_limit are not defined' );
1065 my $five_days_before = dt_from_string->add( days => -5 );
1066 Koha::CirculationRules->set_rules(
1068 categorycode => undef,
1069 branchcode => undef,
1072 norenewalbefore => '10',
1073 no_auto_renewal_after => '5',
1074 no_auto_renewal_after_hard_limit => undef,
1078 $latest_auto_renew_date = GetLatestAutoRenewDate( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
1079 is( $latest_auto_renew_date->truncate( to => 'minute' ),
1080 $five_days_before->truncate( to => 'minute' ),
1081 'GetLatestAutoRenewDate should return -5 days if no_auto_renewal_after = 5 and date_due is 10 days before'
1083 my $five_days_ahead = dt_from_string->add( days => 5 );
1084 $dbh->do(q{UPDATE circulation_rules SET rule_value = '10' WHERE rule_name = 'norenewalbefore'});
1085 $dbh->do(q{UPDATE circulation_rules SET rule_value = '15' WHERE rule_name = 'no_auto_renewal_after'});
1086 $dbh->do(q{UPDATE circulation_rules SET rule_value = NULL WHERE rule_name = 'no_auto_renewal_after_hard_limit'});
1087 Koha::CirculationRules->set_rules(
1089 categorycode => undef,
1090 branchcode => undef,
1093 norenewalbefore => '10',
1094 no_auto_renewal_after => '15',
1095 no_auto_renewal_after_hard_limit => undef,
1099 $latest_auto_renew_date = GetLatestAutoRenewDate( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
1100 is( $latest_auto_renew_date->truncate( to => 'minute' ),
1101 $five_days_ahead->truncate( to => 'minute' ),
1102 'GetLatestAutoRenewDate should return +5 days if no_auto_renewal_after = 15 and date_due is 10 days before'
1104 my $two_days_ahead = dt_from_string->add( days => 2 );
1105 Koha::CirculationRules->set_rules(
1107 categorycode => undef,
1108 branchcode => undef,
1111 norenewalbefore => '10',
1112 no_auto_renewal_after => '',
1113 no_auto_renewal_after_hard_limit => dt_from_string->add( days => 2 ),
1117 $latest_auto_renew_date = GetLatestAutoRenewDate( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
1118 is( $latest_auto_renew_date->truncate( to => 'day' ),
1119 $two_days_ahead->truncate( to => 'day' ),
1120 'GetLatestAutoRenewDate should return +2 days if no_auto_renewal_after_hard_limit is defined and not no_auto_renewal_after'
1122 Koha::CirculationRules->set_rules(
1124 categorycode => undef,
1125 branchcode => undef,
1128 norenewalbefore => '10',
1129 no_auto_renewal_after => '15',
1130 no_auto_renewal_after_hard_limit => dt_from_string->add( days => 2 ),
1134 $latest_auto_renew_date = GetLatestAutoRenewDate( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
1135 is( $latest_auto_renew_date->truncate( to => 'day' ),
1136 $two_days_ahead->truncate( to => 'day' ),
1137 'GetLatestAutoRenewDate should return +2 days if no_auto_renewal_after_hard_limit is < no_auto_renewal_after'
1143 # set policy to forbid renewals
1144 Koha::CirculationRules->set_rules(
1146 categorycode => undef,
1147 branchcode => undef,
1150 norenewalbefore => undef,
1151 renewalsallowed => 0,
1156 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
1157 is( $renewokay, 0, 'Cannot renew, 0 renewals allowed');
1158 is( $error, 'too_many', 'Cannot renew, 0 renewals allowed (returned code is too_many)');
1160 # Test WhenLostForgiveFine and WhenLostChargeReplacementFee
1161 t::lib::Mocks::mock_preference('WhenLostForgiveFine','1');
1162 t::lib::Mocks::mock_preference('WhenLostChargeReplacementFee','1');
1164 C4::Overdues::UpdateFine(
1166 issue_id => $issue->id(),
1167 itemnumber => $item_1->itemnumber,
1168 borrowernumber => $renewing_borrower->{borrowernumber},
1171 due => Koha::DateUtils::output_pref($datedue)
1175 my $line = Koha::Account::Lines->search({ borrowernumber => $renewing_borrower->{borrowernumber} })->next();
1176 is( $line->debit_type_code, 'OVERDUE', 'Account line type is OVERDUE' );
1177 is( $line->status, 'UNRETURNED', 'Account line status is UNRETURNED' );
1178 is( $line->amountoutstanding+0, 15, 'Account line amount outstanding is 15.00' );
1179 is( $line->amount+0, 15, 'Account line amount is 15.00' );
1180 is( $line->issue_id, $issue->id, 'Account line issue id matches' );
1182 my $offset = Koha::Account::Offsets->search({ debit_id => $line->id })->next();
1183 is( $offset->type, 'OVERDUE', 'Account offset type is Fine' );
1184 is( $offset->amount+0, 15, 'Account offset amount is 15.00' );
1186 t::lib::Mocks::mock_preference('WhenLostForgiveFine','0');
1187 t::lib::Mocks::mock_preference('WhenLostChargeReplacementFee','0');
1189 LostItem( $item_1->itemnumber, 'test', 1 );
1191 $line = Koha::Account::Lines->find($line->id);
1192 is( $line->debit_type_code, 'OVERDUE', 'Account type remains as OVERDUE' );
1193 isnt( $line->status, 'UNRETURNED', 'Account status correctly changed from UNRETURNED to RETURNED' );
1195 my $item = Koha::Items->find($item_1->itemnumber);
1196 ok( !$item->onloan(), "Lost item marked as returned has false onloan value" );
1197 my $checkout = Koha::Checkouts->find({ itemnumber => $item_1->itemnumber });
1198 is( $checkout, undef, 'LostItem called with forced return has checked in the item' );
1200 my $total_due = $dbh->selectrow_array(
1201 'SELECT SUM( amountoutstanding ) FROM accountlines WHERE borrowernumber = ?',
1202 undef, $renewing_borrower->{borrowernumber}
1205 is( $total_due+0, 15, 'Borrower only charged replacement fee with both WhenLostForgiveFine and WhenLostChargeReplacementFee enabled' );
1207 C4::Context->dbh->do("DELETE FROM accountlines");
1209 C4::Overdues::UpdateFine(
1211 issue_id => $issue2->id(),
1212 itemnumber => $item_2->itemnumber,
1213 borrowernumber => $renewing_borrower->{borrowernumber},
1216 due => Koha::DateUtils::output_pref($datedue)
1220 LostItem( $item_2->itemnumber, 'test', 0 );
1222 my $item2 = Koha::Items->find($item_2->itemnumber);
1223 ok( $item2->onloan(), "Lost item *not* marked as returned has true onloan value" );
1224 ok( Koha::Checkouts->find({ itemnumber => $item_2->itemnumber }), 'LostItem called without forced return has checked in the item' );
1226 $total_due = $dbh->selectrow_array(
1227 'SELECT SUM( amountoutstanding ) FROM accountlines WHERE borrowernumber = ?',
1228 undef, $renewing_borrower->{borrowernumber}
1231 ok( $total_due == 15, 'Borrower only charged fine with both WhenLostForgiveFine and WhenLostChargeReplacementFee disabled' );
1233 my $future = dt_from_string();
1234 $future->add( days => 7 );
1235 my $units = C4::Overdues::get_chargeable_units('days', $future, $now, $library2->{branchcode});
1236 ok( $units == 0, '_get_chargeable_units returns 0 for items not past due date (Bug 12596)' );
1238 # Users cannot renew any item if there is an overdue item
1239 t::lib::Mocks::mock_preference('OverduesBlockRenewing','block');
1240 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_6->itemnumber);
1241 is( $renewokay, 0, '(Bug 8236), Cannot renew, one of the items is overdue');
1242 ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_7->itemnumber);
1243 is( $renewokay, 0, '(Bug 8236), Cannot renew, one of the items is overdue');
1245 my $manager = $builder->build_object({ class => "Koha::Patrons" });
1246 t::lib::Mocks::mock_userenv({ patron => $manager,branchcode => $manager->branchcode });
1247 t::lib::Mocks::mock_preference('WhenLostChargeReplacementFee','1');
1248 $checkout = Koha::Checkouts->find( { itemnumber => $item_3->itemnumber } );
1249 LostItem( $item_3->itemnumber, 'test', 0 );
1250 my $accountline = Koha::Account::Lines->find( { itemnumber => $item_3->itemnumber } );
1251 is( $accountline->issue_id, $checkout->id, "Issue id added for lost replacement fee charge" );
1253 $accountline->description,
1254 sprintf( "%s %s %s",
1255 $item_3->biblio->title || '',
1256 $item_3->barcode || '',
1257 $item_3->itemcallnumber || '' ),
1258 "Account line description must not contain 'Lost Items ', but be title, barcode, itemcallnumber"
1262 subtest "GetUpcomingDueIssues" => sub {
1265 my $branch = $library2->{branchcode};
1267 #Create another record
1268 my $biblio2 = $builder->build_sample_biblio();
1271 my $item_1 = Koha::Items->find($reused_itemnumber_1);
1272 my $item_2 = Koha::Items->find($reused_itemnumber_2);
1273 my $item_3 = $builder->build_sample_item(
1275 biblionumber => $biblio2->biblionumber,
1283 my %a_borrower_data = (
1284 firstname => 'Fridolyn',
1285 surname => 'SOMERS',
1286 categorycode => $patron_category->{categorycode},
1287 branchcode => $branch,
1290 my $a_borrower_borrowernumber = Koha::Patron->new(\%a_borrower_data)->store->borrowernumber;
1291 my $a_borrower = Koha::Patrons->find( $a_borrower_borrowernumber )->unblessed;
1293 my $yesterday = DateTime->today(time_zone => C4::Context->tz())->add( days => -1 );
1294 my $two_days_ahead = DateTime->today(time_zone => C4::Context->tz())->add( days => 2 );
1295 my $today = DateTime->today(time_zone => C4::Context->tz());
1297 my $issue = AddIssue( $a_borrower, $item_1->barcode, $yesterday );
1298 my $datedue = dt_from_string( $issue->date_due() );
1299 my $issue2 = AddIssue( $a_borrower, $item_2->barcode, $two_days_ahead );
1300 my $datedue2 = dt_from_string( $issue->date_due() );
1304 # GetUpcomingDueIssues tests
1306 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => $i } );
1307 is ( scalar( @$upcoming_dues ), 0, "No items due in less than one day ($i days in advance)" );
1310 #days_in_advance needs to be inclusive, so 1 matches items due tomorrow, 0 items due today etc.
1311 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 2 } );
1312 is ( scalar ( @$upcoming_dues), 1, "Only one item due in 2 days or less" );
1315 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => $i } );
1316 is ( scalar( @$upcoming_dues ), 1,
1317 "Bug 9362: Only one item due in more than 2 days ($i days in advance)" );
1320 # Bug 11218 - Due notices not generated - GetUpcomingDueIssues needs to select due today items as well
1322 my $issue3 = AddIssue( $a_borrower, $item_3->barcode, $today );
1324 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => -1 } );
1325 is ( scalar ( @$upcoming_dues), 0, "Overdues can not be selected" );
1327 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 0 } );
1328 is ( scalar ( @$upcoming_dues), 1, "1 item is due today" );
1330 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 1 } );
1331 is ( scalar ( @$upcoming_dues), 1, "1 item is due today, none tomorrow" );
1333 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 2 } );
1334 is ( scalar ( @$upcoming_dues), 2, "2 items are due withing 2 days" );
1336 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 3 } );
1337 is ( scalar ( @$upcoming_dues), 2, "2 items are due withing 2 days" );
1339 $upcoming_dues = C4::Circulation::GetUpcomingDueIssues();
1340 is ( scalar ( @$upcoming_dues), 2, "days_in_advance is 7 in GetUpcomingDueIssues if not provided" );
1344 subtest "Bug 13841 - Do not create new 0 amount fines" => sub {
1345 my $branch = $library2->{branchcode};
1347 my $biblio = $builder->build_sample_biblio();
1350 my $item = $builder->build_sample_item(
1352 biblionumber => $biblio->biblionumber,
1359 my %a_borrower_data = (
1360 firstname => 'Kyle',
1362 categorycode => $patron_category->{categorycode},
1363 branchcode => $branch,
1366 my $borrowernumber = Koha::Patron->new(\%a_borrower_data)->store->borrowernumber;
1368 my $borrower = Koha::Patrons->find( $borrowernumber )->unblessed;
1369 my $issue = AddIssue( $borrower, $item->barcode );
1372 issue_id => $issue->id(),
1373 itemnumber => $item->itemnumber,
1374 borrowernumber => $borrowernumber,
1380 my $hr = $dbh->selectrow_hashref(q{SELECT COUNT(*) AS count FROM accountlines WHERE borrowernumber = ? AND itemnumber = ?}, undef, $borrowernumber, $item->itemnumber );
1381 my $count = $hr->{count};
1383 is ( $count, 0, "Calling UpdateFine on non-existant fine with an amount of 0 does not result in an empty fine" );
1386 subtest "AllowRenewalIfOtherItemsAvailable tests" => sub {
1387 $dbh->do('DELETE FROM issues');
1388 $dbh->do('DELETE FROM items');
1389 $dbh->do('DELETE FROM circulation_rules');
1390 Koha::CirculationRules->set_rules(
1392 categorycode => undef,
1394 branchcode => undef,
1396 reservesallowed => 25,
1398 lengthunit => 'days',
1399 renewalsallowed => 1,
1401 norenewalbefore => undef,
1409 my $biblio = $builder->build_sample_biblio();
1411 my $item_1 = $builder->build_sample_item(
1413 biblionumber => $biblio->biblionumber,
1414 library => $library2->{branchcode},
1419 my $item_2= $builder->build_sample_item(
1421 biblionumber => $biblio->biblionumber,
1422 library => $library2->{branchcode},
1427 my $borrowernumber1 = Koha::Patron->new({
1428 firstname => 'Kyle',
1430 categorycode => $patron_category->{categorycode},
1431 branchcode => $library2->{branchcode},
1432 })->store->borrowernumber;
1433 my $borrowernumber2 = Koha::Patron->new({
1434 firstname => 'Chelsea',
1436 categorycode => $patron_category->{categorycode},
1437 branchcode => $library2->{branchcode},
1438 })->store->borrowernumber;
1440 my $borrower1 = Koha::Patrons->find( $borrowernumber1 )->unblessed;
1441 my $borrower2 = Koha::Patrons->find( $borrowernumber2 )->unblessed;
1443 my $issue = AddIssue( $borrower1, $item_1->barcode );
1445 my ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $item_1->itemnumber );
1446 is( $renewokay, 1, 'Bug 14337 - Verify the borrower can renew with no hold on the record' );
1450 branchcode => $library2->{branchcode},
1451 borrowernumber => $borrowernumber2,
1452 biblionumber => $biblio->biblionumber,
1457 Koha::CirculationRules->set_rules(
1459 categorycode => undef,
1461 branchcode => undef,
1467 t::lib::Mocks::mock_preference( 'AllowRenewalIfOtherItemsAvailable', 0 );
1468 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $item_1->itemnumber );
1469 is( $renewokay, 0, 'Bug 14337 - Verify the borrower cannot renew with a hold on the record if AllowRenewalIfOtherItemsAvailable and onshelfholds are disabled' );
1471 Koha::CirculationRules->set_rules(
1473 categorycode => undef,
1475 branchcode => undef,
1481 t::lib::Mocks::mock_preference( 'AllowRenewalIfOtherItemsAvailable', 1 );
1482 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $item_1->itemnumber );
1483 is( $renewokay, 0, 'Bug 14337 - Verify the borrower cannot renew with a hold on the record if AllowRenewalIfOtherItemsAvailable is enabled and onshelfholds is disabled' );
1485 Koha::CirculationRules->set_rules(
1487 categorycode => undef,
1489 branchcode => undef,
1495 t::lib::Mocks::mock_preference( 'AllowRenewalIfOtherItemsAvailable', 0 );
1496 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $item_1->itemnumber );
1497 is( $renewokay, 0, 'Bug 14337 - Verify the borrower cannot renew with a hold on the record if AllowRenewalIfOtherItemsAvailable is disabled and onshelfhold is enabled' );
1499 Koha::CirculationRules->set_rules(
1501 categorycode => undef,
1503 branchcode => undef,
1509 t::lib::Mocks::mock_preference( 'AllowRenewalIfOtherItemsAvailable', 1 );
1510 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $item_1->itemnumber );
1511 is( $renewokay, 1, 'Bug 14337 - Verify the borrower can renew with a hold on the record if AllowRenewalIfOtherItemsAvailable and onshelfhold are enabled' );
1513 # Setting item not checked out to be not for loan but holdable
1514 $item_2->notforloan(-1)->store;
1516 ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $item_1->itemnumber );
1517 is( $renewokay, 0, 'Bug 14337 - Verify the borrower can not renew with a hold on the record if AllowRenewalIfOtherItemsAvailable is enabled but the only available item is notforloan' );
1521 # Don't allow renewing onsite checkout
1522 my $branch = $library->{branchcode};
1524 #Create another record
1525 my $biblio = $builder->build_sample_biblio();
1527 my $item = $builder->build_sample_item(
1529 biblionumber => $biblio->biblionumber,
1535 my $borrowernumber = Koha::Patron->new({
1538 categorycode => $patron_category->{categorycode},
1539 branchcode => $branch,
1540 })->store->borrowernumber;
1542 my $borrower = Koha::Patrons->find( $borrowernumber )->unblessed;
1544 my $issue = AddIssue( $borrower, $item->barcode, undef, undef, undef, undef, { onsite_checkout => 1 } );
1545 my ( $renewed, $error ) = CanBookBeRenewed( $borrowernumber, $item->itemnumber );
1546 is( $renewed, 0, 'CanBookBeRenewed should not allow to renew on-site checkout' );
1547 is( $error, 'onsite_checkout', 'A correct error code should be returned by CanBookBeRenewed for on-site checkout' );
1551 my $library = $builder->build({ source => 'Branch' });
1553 my $biblio = $builder->build_sample_biblio();
1555 my $item = $builder->build_sample_item(
1557 biblionumber => $biblio->biblionumber,
1558 library => $library->{branchcode},
1563 my $patron = $builder->build({ source => 'Borrower', value => { branchcode => $library->{branchcode}, categorycode => $patron_category->{categorycode} } } );
1565 my $issue = AddIssue( $patron, $item->barcode );
1568 issue_id => $issue->id(),
1569 itemnumber => $item->itemnumber,
1570 borrowernumber => $patron->{borrowernumber},
1577 issue_id => $issue->id(),
1578 itemnumber => $item->itemnumber,
1579 borrowernumber => $patron->{borrowernumber},
1584 is( Koha::Account::Lines->search({ issue_id => $issue->id })->count, 1, 'UpdateFine should not create a new accountline when updating an existing fine');
1587 subtest 'CanBookBeIssued & AllowReturnToBranch' => sub {
1590 my $homebranch = $builder->build( { source => 'Branch' } );
1591 my $holdingbranch = $builder->build( { source => 'Branch' } );
1592 my $otherbranch = $builder->build( { source => 'Branch' } );
1593 my $patron_1 = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } );
1594 my $patron_2 = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } );
1596 my $item = $builder->build_sample_item(
1598 homebranch => $homebranch->{branchcode},
1599 holdingbranch => $holdingbranch->{branchcode},
1603 set_userenv($holdingbranch);
1605 my $issue = AddIssue( $patron_1->unblessed, $item->{barcode} );
1606 is( ref($issue), 'Koha::Checkout', 'AddIssue should return a Koha::Checkout object' );
1608 my ( $error, $question, $alerts );
1610 # AllowReturnToBranch == anywhere
1611 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'anywhere' );
1612 ## Test that unknown barcodes don't generate internal server errors
1613 set_userenv($homebranch);
1614 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, 'KohaIsAwesome' );
1615 ok( $error->{UNKNOWN_BARCODE}, '"KohaIsAwesome" is not a valid barcode as expected.' );
1616 ## Can be issued from homebranch
1617 set_userenv($homebranch);
1618 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1619 is( keys(%$error) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1620 is( exists $question->{ISSUED_TO_ANOTHER}, 1, 'ISSUED_TO_ANOTHER must be set' );
1621 ## Can be issued from holdingbranch
1622 set_userenv($holdingbranch);
1623 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1624 is( keys(%$error) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1625 is( exists $question->{ISSUED_TO_ANOTHER}, 1, 'ISSUED_TO_ANOTHER must be set' );
1626 ## Can be issued from another branch
1627 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1628 is( keys(%$error) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1629 is( exists $question->{ISSUED_TO_ANOTHER}, 1, 'ISSUED_TO_ANOTHER must be set' );
1631 # AllowReturnToBranch == holdingbranch
1632 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'holdingbranch' );
1633 ## Cannot be issued from homebranch
1634 set_userenv($homebranch);
1635 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1636 is( keys(%$question) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1637 is( exists $error->{RETURN_IMPOSSIBLE}, 1, 'RETURN_IMPOSSIBLE must be set' );
1638 is( $error->{branch_to_return}, $holdingbranch->{branchcode}, 'branch_to_return matched holdingbranch' );
1639 ## Can be issued from holdinbranch
1640 set_userenv($holdingbranch);
1641 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1642 is( keys(%$error) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1643 is( exists $question->{ISSUED_TO_ANOTHER}, 1, 'ISSUED_TO_ANOTHER must be set' );
1644 ## Cannot be issued from another branch
1645 set_userenv($otherbranch);
1646 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1647 is( keys(%$question) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1648 is( exists $error->{RETURN_IMPOSSIBLE}, 1, 'RETURN_IMPOSSIBLE must be set' );
1649 is( $error->{branch_to_return}, $holdingbranch->{branchcode}, 'branch_to_return matches holdingbranch' );
1651 # AllowReturnToBranch == homebranch
1652 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'homebranch' );
1653 ## Can be issued from holdinbranch
1654 set_userenv($homebranch);
1655 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1656 is( keys(%$error) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1657 is( exists $question->{ISSUED_TO_ANOTHER}, 1, 'ISSUED_TO_ANOTHER must be set' );
1658 ## Cannot be issued from holdinbranch
1659 set_userenv($holdingbranch);
1660 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1661 is( keys(%$question) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1662 is( exists $error->{RETURN_IMPOSSIBLE}, 1, 'RETURN_IMPOSSIBLE must be set' );
1663 is( $error->{branch_to_return}, $homebranch->{branchcode}, 'branch_to_return matches homebranch' );
1664 ## Cannot be issued from holdinbranch
1665 set_userenv($otherbranch);
1666 ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1667 is( keys(%$question) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1668 is( exists $error->{RETURN_IMPOSSIBLE}, 1, 'RETURN_IMPOSSIBLE must be set' );
1669 is( $error->{branch_to_return}, $homebranch->{branchcode}, 'branch_to_return matches homebranch' );
1671 # TODO t::lib::Mocks::mock_preference('AllowReturnToBranch', 'homeorholdingbranch');
1674 subtest 'AddIssue & AllowReturnToBranch' => sub {
1677 my $homebranch = $builder->build( { source => 'Branch' } );
1678 my $holdingbranch = $builder->build( { source => 'Branch' } );
1679 my $otherbranch = $builder->build( { source => 'Branch' } );
1680 my $patron_1 = $builder->build( { source => 'Borrower', value => { categorycode => $patron_category->{categorycode} } } );
1681 my $patron_2 = $builder->build( { source => 'Borrower', value => { categorycode => $patron_category->{categorycode} } } );
1683 my $item = $builder->build_sample_item(
1685 homebranch => $homebranch->{branchcode},
1686 holdingbranch => $holdingbranch->{branchcode},
1690 set_userenv($holdingbranch);
1692 my $ref_issue = 'Koha::Checkout';
1693 my $issue = AddIssue( $patron_1, $item->{barcode} );
1695 my ( $error, $question, $alerts );
1697 # AllowReturnToBranch == homebranch
1698 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'anywhere' );
1699 ## Can be issued from homebranch
1700 set_userenv($homebranch);
1701 is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), $ref_issue, 'AllowReturnToBranch - anywhere | Can be issued from homebranch');
1702 set_userenv($holdingbranch); AddIssue( $patron_1, $item->{barcode} ); # Reinsert the original issue
1703 ## Can be issued from holdinbranch
1704 set_userenv($holdingbranch);
1705 is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), $ref_issue, 'AllowReturnToBranch - anywhere | Can be issued from holdingbranch');
1706 set_userenv($holdingbranch); AddIssue( $patron_1, $item->{barcode} ); # Reinsert the original issue
1707 ## Can be issued from another branch
1708 set_userenv($otherbranch);
1709 is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), $ref_issue, 'AllowReturnToBranch - anywhere | Can be issued from otherbranch');
1710 set_userenv($holdingbranch); AddIssue( $patron_1, $item->{barcode} ); # Reinsert the original issue
1712 # AllowReturnToBranch == holdinbranch
1713 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'holdingbranch' );
1714 ## Cannot be issued from homebranch
1715 set_userenv($homebranch);
1716 is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), '', 'AllowReturnToBranch - holdingbranch | Cannot be issued from homebranch');
1717 ## Can be issued from holdingbranch
1718 set_userenv($holdingbranch);
1719 is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), $ref_issue, 'AllowReturnToBranch - holdingbranch | Can be issued from holdingbranch');
1720 set_userenv($holdingbranch); AddIssue( $patron_1, $item->{barcode} ); # Reinsert the original issue
1721 ## Cannot be issued from another branch
1722 set_userenv($otherbranch);
1723 is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), '', 'AllowReturnToBranch - holdingbranch | Cannot be issued from otherbranch');
1725 # AllowReturnToBranch == homebranch
1726 t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'homebranch' );
1727 ## Can be issued from homebranch
1728 set_userenv($homebranch);
1729 is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), $ref_issue, 'AllowReturnToBranch - homebranch | Can be issued from homebranch' );
1730 set_userenv($holdingbranch); AddIssue( $patron_1, $item->{barcode} ); # Reinsert the original issue
1731 ## Cannot be issued from holdinbranch
1732 set_userenv($holdingbranch);
1733 is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), '', 'AllowReturnToBranch - homebranch | Cannot be issued from holdingbranch' );
1734 ## Cannot be issued from another branch
1735 set_userenv($otherbranch);
1736 is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), '', 'AllowReturnToBranch - homebranch | Cannot be issued from otherbranch' );
1737 # TODO t::lib::Mocks::mock_preference('AllowReturnToBranch', 'homeorholdingbranch');
1740 subtest 'CanBookBeIssued + Koha::Patron->is_debarred|has_overdues' => sub {
1743 my $library = $builder->build( { source => 'Branch' } );
1744 my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } );
1745 my $item_1 = $builder->build_sample_item(
1747 library => $library->{branchcode},
1750 my $item_2 = $builder->build_sample_item(
1752 library => $library->{branchcode},
1756 my ( $error, $question, $alerts );
1758 # Patron cannot issue item_1, they have overdues
1759 my $yesterday = DateTime->today( time_zone => C4::Context->tz() )->add( days => -1 );
1760 my $issue = AddIssue( $patron->unblessed, $item_1->{barcode}, $yesterday ); # Add an overdue
1762 t::lib::Mocks::mock_preference( 'OverduesBlockCirc', 'confirmation' );
1763 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->{barcode} );
1764 is( keys(%$error) + keys(%$alerts), 0, 'No key for error and alert' . str($error, $question, $alerts) );
1765 is( $question->{USERBLOCKEDOVERDUE}, 1, 'OverduesBlockCirc=confirmation, USERBLOCKEDOVERDUE should be set for question' );
1767 t::lib::Mocks::mock_preference( 'OverduesBlockCirc', 'block' );
1768 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->{barcode} );
1769 is( keys(%$question) + keys(%$alerts), 0, 'No key for question and alert ' . str($error, $question, $alerts) );
1770 is( $error->{USERBLOCKEDOVERDUE}, 1, 'OverduesBlockCirc=block, USERBLOCKEDOVERDUE should be set for error' );
1772 # Patron cannot issue item_1, they are debarred
1773 my $tomorrow = DateTime->today( time_zone => C4::Context->tz() )->add( days => 1 );
1774 Koha::Patron::Debarments::AddDebarment( { borrowernumber => $patron->borrowernumber, expiration => $tomorrow } );
1775 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->{barcode} );
1776 is( keys(%$question) + keys(%$alerts), 0, 'No key for question and alert ' . str($error, $question, $alerts) );
1777 is( $error->{USERBLOCKEDWITHENDDATE}, output_pref( { dt => $tomorrow, dateformat => 'sql', dateonly => 1 } ), 'USERBLOCKEDWITHENDDATE should be tomorrow' );
1779 Koha::Patron::Debarments::AddDebarment( { borrowernumber => $patron->borrowernumber } );
1780 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->{barcode} );
1781 is( keys(%$question) + keys(%$alerts), 0, 'No key for question and alert ' . str($error, $question, $alerts) );
1782 is( $error->{USERBLOCKEDNOENDDATE}, '9999-12-31', 'USERBLOCKEDNOENDDATE should be 9999-12-31 for unlimited debarments' );
1785 subtest 'CanBookBeIssued + Statistic patrons "X"' => sub {
1788 my $library = $builder->build_object( { class => 'Koha::Libraries' } );
1789 my $patron_category_x = $builder->build_object(
1791 class => 'Koha::Patron::Categories',
1792 value => { category_type => 'X' }
1795 my $patron = $builder->build_object(
1797 class => 'Koha::Patrons',
1799 categorycode => $patron_category_x->categorycode,
1800 gonenoaddress => undef,
1807 my $item_1 = $builder->build_sample_item(
1809 library => $library->{branchcode},
1813 my ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_1->{barcode} );
1814 is( $error->{STATS}, 1, '"Error" flag "STATS" must be set if CanBookBeIssued is called with a statistic patron (category_type=X)' );
1816 # TODO There are other tests to provide here
1819 subtest 'MultipleReserves' => sub {
1822 my $biblio = $builder->build_sample_biblio();
1824 my $branch = $library2->{branchcode};
1826 my $item_1 = $builder->build_sample_item(
1828 biblionumber => $biblio->biblionumber,
1830 replacementprice => 12.00,
1835 my $item_2 = $builder->build_sample_item(
1837 biblionumber => $biblio->biblionumber,
1839 replacementprice => 12.00,
1846 my $resdate = undef;
1847 my $expdate = undef;
1849 my $checkitem = undef;
1852 my %renewing_borrower_data = (
1853 firstname => 'John',
1854 surname => 'Renewal',
1855 categorycode => $patron_category->{categorycode},
1856 branchcode => $branch,
1858 my $renewing_borrowernumber = Koha::Patron->new(\%renewing_borrower_data)->store->borrowernumber;
1859 my $renewing_borrower = Koha::Patrons->find( $renewing_borrowernumber )->unblessed;
1860 my $issue = AddIssue( $renewing_borrower, $item_1->barcode);
1861 my $datedue = dt_from_string( $issue->date_due() );
1862 is (defined $issue->date_due(), 1, "item 1 checked out");
1863 my $borrowing_borrowernumber = Koha::Checkouts->find({ itemnumber => $item_1->itemnumber })->borrowernumber;
1865 my %reserving_borrower_data1 = (
1866 firstname => 'Katrin',
1867 surname => 'Reservation',
1868 categorycode => $patron_category->{categorycode},
1869 branchcode => $branch,
1871 my $reserving_borrowernumber1 = Koha::Patron->new(\%reserving_borrower_data1)->store->borrowernumber;
1874 branchcode => $branch,
1875 borrowernumber => $reserving_borrowernumber1,
1876 biblionumber => $biblio->biblionumber,
1877 priority => $priority,
1878 reservation_date => $resdate,
1879 expiration_date => $expdate,
1881 itemnumber => $checkitem,
1886 my %reserving_borrower_data2 = (
1887 firstname => 'Kirk',
1888 surname => 'Reservation',
1889 categorycode => $patron_category->{categorycode},
1890 branchcode => $branch,
1892 my $reserving_borrowernumber2 = Koha::Patron->new(\%reserving_borrower_data2)->store->borrowernumber;
1895 branchcode => $branch,
1896 borrowernumber => $reserving_borrowernumber2,
1897 biblionumber => $biblio->biblionumber,
1898 priority => $priority,
1899 reservation_date => $resdate,
1900 expiration_date => $expdate,
1902 itemnumber => $checkitem,
1908 my ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber, 1);
1909 is($renewokay, 0, 'Bug 17941 - should cover the case where 2 books are both reserved, so failing');
1912 my $item_3 = $builder->build_sample_item(
1914 biblionumber => $biblio->biblionumber,
1916 replacementprice => 12.00,
1922 my ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber, 1);
1923 is($renewokay, 1, 'Bug 17941 - should cover the case where 2 books are reserved, but a third one is available');
1927 subtest 'CanBookBeIssued + AllowMultipleIssuesOnABiblio' => sub {
1930 my $library = $builder->build( { source => 'Branch' } );
1931 my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } );
1933 my $biblionumber = $builder->build_sample_biblio(
1935 branchcode => $library->{branchcode},
1938 my $item_1 = $builder->build_sample_item(
1940 biblionumber => $biblionumber,
1941 library => $library->{branchcode},
1945 my $item_2 = $builder->build_sample_item(
1947 biblionumber => $biblionumber,
1948 library => $library->{branchcode},
1952 my ( $error, $question, $alerts );
1953 my $issue = AddIssue( $patron->unblessed, $item_1->{barcode}, dt_from_string->add( days => 1 ) );
1955 t::lib::Mocks::mock_preference('AllowMultipleIssuesOnABiblio', 0);
1956 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->{barcode} );
1958 { error => $error, alerts => $alerts },
1959 { error => {}, alerts => {} },
1960 'No error or alert should be raised'
1962 is( $question->{BIBLIO_ALREADY_ISSUED}, 1, 'BIBLIO_ALREADY_ISSUED question flag should be set if AllowMultipleIssuesOnABiblio=0 and issue already exists' );
1964 t::lib::Mocks::mock_preference('AllowMultipleIssuesOnABiblio', 1);
1965 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->{barcode} );
1967 { error => $error, question => $question, alerts => $alerts },
1968 { error => {}, question => {}, alerts => {} },
1969 'No BIBLIO_ALREADY_ISSUED flag should be set if AllowMultipleIssuesOnABiblio=1'
1972 # Add a subscription
1973 Koha::Subscription->new({ biblionumber => $biblionumber })->store;
1975 t::lib::Mocks::mock_preference('AllowMultipleIssuesOnABiblio', 0);
1976 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->{barcode} );
1978 { error => $error, question => $question, alerts => $alerts },
1979 { error => {}, question => {}, alerts => {} },
1980 'No BIBLIO_ALREADY_ISSUED flag should be set if it is a subscription'
1983 t::lib::Mocks::mock_preference('AllowMultipleIssuesOnABiblio', 1);
1984 ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->{barcode} );
1986 { error => $error, question => $question, alerts => $alerts },
1987 { error => {}, question => {}, alerts => {} },
1988 'No BIBLIO_ALREADY_ISSUED flag should be set if it is a subscription'
1992 subtest 'AddReturn + CumulativeRestrictionPeriods' => sub {
1995 my $library = $builder->build( { source => 'Branch' } );
1996 my $patron = $builder->build( { source => 'Borrower', value => { categorycode => $patron_category->{categorycode} } } );
1999 my $biblionumber = $builder->build_sample_biblio(
2001 branchcode => $library->{branchcode},
2004 my $item_1 = $builder->build_sample_item(
2006 biblionumber => $biblionumber,
2007 library => $library->{branchcode},
2010 my $item_2 = $builder->build_sample_item(
2012 biblionumber => $biblionumber,
2013 library => $library->{branchcode},
2017 # And the circulation rule
2018 Koha::CirculationRules->search->delete;
2019 Koha::CirculationRules->set_rules(
2021 categorycode => undef,
2023 branchcode => undef,
2026 firstremind => 1, # 1 day of grace
2027 finedays => 2, # 2 days of fine per day of overdue
2028 lengthunit => 'days',
2033 # Patron cannot issue item_1, they have overdues
2034 my $now = dt_from_string;
2035 my $five_days_ago = $now->clone->subtract( days => 5 );
2036 my $ten_days_ago = $now->clone->subtract( days => 10 );
2037 AddIssue( $patron, $item_1->{barcode}, $five_days_ago ); # Add an overdue
2038 AddIssue( $patron, $item_2->{barcode}, $ten_days_ago )
2039 ; # Add another overdue
2041 t::lib::Mocks::mock_preference( 'CumulativeRestrictionPeriods', '0' );
2042 AddReturn( $item_1->{barcode}, $library->{branchcode}, undef, $now );
2043 my $debarments = Koha::Patron::Debarments::GetDebarments(
2044 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
2045 is( scalar(@$debarments), 1 );
2047 # FIXME Is it right? I'd have expected 5 * 2 - 1 instead
2048 # Same for the others
2049 my $expected_expiration = output_pref(
2051 dt => $now->clone->add( days => ( 5 - 1 ) * 2 ),
2052 dateformat => 'sql',
2056 is( $debarments->[0]->{expiration}, $expected_expiration );
2058 AddReturn( $item_2->{barcode}, $library->{branchcode}, undef, $now );
2059 $debarments = Koha::Patron::Debarments::GetDebarments(
2060 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
2061 is( scalar(@$debarments), 1 );
2062 $expected_expiration = output_pref(
2064 dt => $now->clone->add( days => ( 10 - 1 ) * 2 ),
2065 dateformat => 'sql',
2069 is( $debarments->[0]->{expiration}, $expected_expiration );
2071 Koha::Patron::Debarments::DelUniqueDebarment(
2072 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
2074 t::lib::Mocks::mock_preference( 'CumulativeRestrictionPeriods', '1' );
2075 AddIssue( $patron, $item_1->{barcode}, $five_days_ago ); # Add an overdue
2076 AddIssue( $patron, $item_2->{barcode}, $ten_days_ago )
2077 ; # Add another overdue
2078 AddReturn( $item_1->{barcode}, $library->{branchcode}, undef, $now );
2079 $debarments = Koha::Patron::Debarments::GetDebarments(
2080 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
2081 is( scalar(@$debarments), 1 );
2082 $expected_expiration = output_pref(
2084 dt => $now->clone->add( days => ( 5 - 1 ) * 2 ),
2085 dateformat => 'sql',
2089 is( $debarments->[0]->{expiration}, $expected_expiration );
2091 AddReturn( $item_2->{barcode}, $library->{branchcode}, undef, $now );
2092 $debarments = Koha::Patron::Debarments::GetDebarments(
2093 { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
2094 is( scalar(@$debarments), 1 );
2095 $expected_expiration = output_pref(
2097 dt => $now->clone->add( days => ( 5 - 1 ) * 2 + ( 10 - 1 ) * 2 ),
2098 dateformat => 'sql',
2102 is( $debarments->[0]->{expiration}, $expected_expiration );
2105 subtest 'AddReturn + suspension_chargeperiod' => sub {
2108 my $library = $builder->build( { source => 'Branch' } );
2109 my $patron = $builder->build( { source => 'Borrower', value => { categorycode => $patron_category->{categorycode} } } );
2111 my $biblionumber = $builder->build_sample_biblio(
2113 branchcode => $library->{branchcode},
2116 my $item_1 = $builder->build_sample_item(
2118 biblionumber => $biblionumber,
2119 library => $library->{branchcode},
2123 # And the issuing rule
2124 Koha::CirculationRules->search->delete;
2125 Koha::CirculationRules->set_rules(
2127 categorycode => '*',
2132 firstremind => 0, # 0 day of grace
2133 finedays => 2, # 2 days of fine per day of overdue
2134 suspension_chargeperiod => 1,
2135 lengthunit => 'days',
2140 my $now = dt_from_string;
2141 my $five_days_ago = $now->clone->subtract( days => 5 );
2142 # We want to charge 2 days every day, without grace
2143 # With 5 days of overdue: 5 * Z
2144 my $expected_expiration = $now->clone->add( days => ( 5 * 2 ) / 1 );
2145 test_debarment_on_checkout(
2148 library => $library,
2150 due_date => $five_days_ago,
2151 expiration_date => $expected_expiration,
2155 # We want to charge 2 days every 2 days, without grace
2156 # With 5 days of overdue: (5 * 2) / 2
2157 Koha::CirculationRules->set_rule(
2159 categorycode => undef,
2160 branchcode => undef,
2162 rule_name => 'suspension_chargeperiod',
2167 $expected_expiration = $now->clone->add( days => floor( 5 * 2 ) / 2 );
2168 test_debarment_on_checkout(
2171 library => $library,
2173 due_date => $five_days_ago,
2174 expiration_date => $expected_expiration,
2178 # We want to charge 2 days every 3 days, with 1 day of grace
2179 # With 5 days of overdue: ((5-1) / 3 ) * 2
2180 Koha::CirculationRules->set_rules(
2182 categorycode => undef,
2183 branchcode => undef,
2186 suspension_chargeperiod => 3,
2191 $expected_expiration = $now->clone->add( days => floor( ( ( 5 - 1 ) / 3 ) * 2 ) );
2192 test_debarment_on_checkout(
2195 library => $library,
2197 due_date => $five_days_ago,
2198 expiration_date => $expected_expiration,
2202 # Use finesCalendar to know if holiday must be skipped to calculate the due date
2203 # We want to charge 2 days every days, with 0 day of grace (to not burn brains)
2204 Koha::CirculationRules->set_rules(
2206 categorycode => undef,
2207 branchcode => undef,
2211 suspension_chargeperiod => 1,
2216 t::lib::Mocks::mock_preference('finesCalendar', 'noFinesWhenClosed');
2217 t::lib::Mocks::mock_preference('SuspensionsCalendar', 'noSuspensionsWhenClosed');
2219 # Adding a holiday 2 days ago
2220 my $calendar = C4::Calendar->new(branchcode => $library->{branchcode});
2221 my $two_days_ago = $now->clone->subtract( days => 2 );
2222 $calendar->insert_single_holiday(
2223 day => $two_days_ago->day,
2224 month => $two_days_ago->month,
2225 year => $two_days_ago->year,
2226 title => 'holidayTest-2d',
2227 description => 'holidayDesc 2 days ago'
2229 # With 5 days of overdue, only 4 (x finedays=2) days must charged (one was an holiday)
2230 $expected_expiration = $now->clone->add( days => floor( ( ( 5 - 0 - 1 ) / 1 ) * 2 ) );
2231 test_debarment_on_checkout(
2234 library => $library,
2236 due_date => $five_days_ago,
2237 expiration_date => $expected_expiration,
2241 # Adding a holiday 2 days ahead, with finesCalendar=noFinesWhenClosed it should be skipped
2242 my $two_days_ahead = $now->clone->add( days => 2 );
2243 $calendar->insert_single_holiday(
2244 day => $two_days_ahead->day,
2245 month => $two_days_ahead->month,
2246 year => $two_days_ahead->year,
2247 title => 'holidayTest+2d',
2248 description => 'holidayDesc 2 days ahead'
2251 # Same as above, but we should skip D+2
2252 $expected_expiration = $now->clone->add( days => floor( ( ( 5 - 0 - 1 ) / 1 ) * 2 ) + 1 );
2253 test_debarment_on_checkout(
2256 library => $library,
2258 due_date => $five_days_ago,
2259 expiration_date => $expected_expiration,
2263 # Adding another holiday, day of expiration date
2264 my $expected_expiration_dt = dt_from_string($expected_expiration);
2265 $calendar->insert_single_holiday(
2266 day => $expected_expiration_dt->day,
2267 month => $expected_expiration_dt->month,
2268 year => $expected_expiration_dt->year,
2269 title => 'holidayTest_exp',
2270 description => 'holidayDesc on expiration date'
2272 # Expiration date will be the day after
2273 test_debarment_on_checkout(
2276 library => $library,
2278 due_date => $five_days_ago,
2279 expiration_date => $expected_expiration_dt->clone->add( days => 1 ),
2283 test_debarment_on_checkout(
2286 library => $library,
2288 return_date => $now->clone->add(days => 5),
2289 expiration_date => $now->clone->add(days => 5 + (5 * 2 - 1) ),
2294 subtest 'CanBookBeIssued + AutoReturnCheckedOutItems' => sub {
2297 my $library = $builder->build_object( { class => 'Koha::Libraries' } );
2298 my $patron1 = $builder->build_object(
2300 class => 'Koha::Patrons',
2302 library => $library->branchcode,
2303 categorycode => $patron_category->{categorycode}
2307 my $patron2 = $builder->build_object(
2309 class => 'Koha::Patrons',
2311 library => $library->branchcode,
2312 categorycode => $patron_category->{categorycode}
2317 t::lib::Mocks::mock_userenv({ branchcode => $library->branchcode });
2319 my $item = $builder->build_sample_item(
2321 library => $library->branchcode,
2325 my ( $error, $question, $alerts );
2326 my $issue = AddIssue( $patron1->unblessed, $item->{barcode} );
2328 t::lib::Mocks::mock_preference('AutoReturnCheckedOutItems', 0);
2329 ( $error, $question, $alerts ) = CanBookBeIssued( $patron2, $item->{barcode} );
2330 is( $question->{ISSUED_TO_ANOTHER}, 1, 'ISSUED_TO_ANOTHER question flag should be set if AutoReturnCheckedOutItems is disabled and item is checked out to another' );
2332 t::lib::Mocks::mock_preference('AutoReturnCheckedOutItems', 1);
2333 ( $error, $question, $alerts ) = CanBookBeIssued( $patron2, $item->{barcode} );
2334 is( $alerts->{RETURNED_FROM_ANOTHER}->{patron}->borrowernumber, $patron1->borrowernumber, 'RETURNED_FROM_ANOTHER alert flag should be set if AutoReturnCheckedOutItems is enabled and item is checked out to another' );
2336 t::lib::Mocks::mock_preference('AutoReturnCheckedOutItems', 0);
2340 subtest 'AddReturn | is_overdue' => sub {
2343 t::lib::Mocks::mock_preference('CalculateFinesOnReturn', 1);
2344 t::lib::Mocks::mock_preference('finesMode', 'production');
2345 t::lib::Mocks::mock_preference('MaxFine', '100');
2347 my $library = $builder->build( { source => 'Branch' } );
2348 my $patron = $builder->build( { source => 'Borrower', value => { categorycode => $patron_category->{categorycode} } } );
2349 my $manager = $builder->build_object({ class => "Koha::Patrons" });
2350 t::lib::Mocks::mock_userenv({ patron => $manager, branchcode => $manager->branchcode });
2352 my $item = $builder->build_sample_item(
2354 library => $library->{branchcode},
2355 replacementprice => 7
2359 Koha::CirculationRules->search->delete;
2360 Koha::CirculationRules->set_rules(
2362 categorycode => undef,
2364 branchcode => undef,
2367 lengthunit => 'days',
2368 fine => 1, # Charge 1 every day of overdue
2374 my $now = dt_from_string;
2375 my $one_day_ago = $now->clone->subtract( days => 1 );
2376 my $five_days_ago = $now->clone->subtract( days => 5 );
2377 my $ten_days_ago = $now->clone->subtract( days => 10 );
2378 $patron = Koha::Patrons->find( $patron->{borrowernumber} );
2380 # No return date specified, today will be used => 10 days overdue charged
2381 AddIssue( $patron->unblessed, $item->{barcode}, $ten_days_ago ); # date due was 10d ago
2382 AddReturn( $item->{barcode}, $library->{branchcode} );
2383 is( int($patron->account->balance()), 10, 'Patron should have a charge of 10 (10 days x 1)' );
2384 Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber })->delete;
2386 # specify return date 5 days before => no overdue charged
2387 AddIssue( $patron->unblessed, $item->{barcode}, $five_days_ago ); # date due was 5d ago
2388 AddReturn( $item->{barcode}, $library->{branchcode}, undef, $ten_days_ago );
2389 is( int($patron->account->balance()), 0, 'AddReturn: pass return_date => no overdue' );
2390 Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber })->delete;
2392 # specify return date 5 days later => 5 days overdue charged
2393 AddIssue( $patron->unblessed, $item->{barcode}, $ten_days_ago ); # date due was 10d ago
2394 AddReturn( $item->{barcode}, $library->{branchcode}, undef, $five_days_ago );
2395 is( int($patron->account->balance()), 5, 'AddReturn: pass return_date => overdue' );
2396 Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber })->delete;
2398 # specify return date 5 days later, specify exemptfine => no overdue charge
2399 AddIssue( $patron->unblessed, $item->{barcode}, $ten_days_ago ); # date due was 10d ago
2400 AddReturn( $item->{barcode}, $library->{branchcode}, 1, $five_days_ago );
2401 is( int($patron->account->balance()), 0, 'AddReturn: pass return_date => no overdue' );
2402 Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber })->delete;
2404 subtest 'bug 22877' => sub {
2408 my $issue = AddIssue( $patron->unblessed, $item->{barcode}, $ten_days_ago ); # date due was 10d ago
2410 # Fake fines cronjob on this checkout
2412 CalcFine( $item, $patron->categorycode, $library->{branchcode},
2413 $ten_days_ago, $now );
2416 issue_id => $issue->issue_id,
2417 itemnumber => $item->{itemnumber},
2418 borrowernumber => $patron->borrowernumber,
2420 due => output_pref($ten_days_ago)
2423 is( int( $patron->account->balance() ),
2424 10, "Overdue fine of 10 days overdue" );
2426 # Fake longoverdue with charge and not marking returned
2427 LostItem( $item->{itemnumber}, 'cronjob', 0 );
2428 is( int( $patron->account->balance() ),
2429 17, "Lost fine of 7 plus 10 days overdue" );
2431 # Now we return it today
2432 AddReturn( $item->{barcode}, $library->{branchcode} );
2433 is( int( $patron->account->balance() ),
2434 17, "Should have a single 10 days overdue fine and lost charge" );
2438 subtest '_FixAccountForLostAndFound' => sub {
2442 t::lib::Mocks::mock_preference( 'WhenLostChargeReplacementFee', 1 );
2443 t::lib::Mocks::mock_preference( 'WhenLostForgiveFine', 0 );
2445 my $processfee_amount = 20;
2446 my $replacement_amount = 99.00;
2447 my $item_type = $builder->build_object(
2448 { class => 'Koha::ItemTypes',
2450 notforloan => undef,
2452 defaultreplacecost => undef,
2453 processfee => $processfee_amount,
2454 rentalcharge_daily => 0,
2458 my $library = $builder->build_object( { class => 'Koha::Libraries' } );
2460 my $biblio = $builder->build_sample_biblio({ author => 'Hall, Daria' });
2462 subtest 'Full write-off tests' => sub {
2466 my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
2467 my $manager = $builder->build_object({ class => "Koha::Patrons" });
2468 t::lib::Mocks::mock_userenv({ patron => $manager,branchcode => $manager->branchcode });
2470 my $item = $builder->build_sample_item(
2472 biblionumber => $biblio->biblionumber,
2473 library => $library->branchcode,
2474 replacementprice => $replacement_amount,
2475 itype => $item_type->itemtype,
2479 AddIssue( $patron->unblessed, $item->barcode );
2481 # Simulate item marked as lost
2482 $item->itemlost(3)->store;
2483 LostItem( $item->itemnumber, 1 );
2485 my $processing_fee_lines = Koha::Account::Lines->search(
2486 { borrowernumber => $patron->id, itemnumber => $item->itemnumber, debit_type_code => 'PROCESSING' } );
2487 is( $processing_fee_lines->count, 1, 'Only one processing fee produced' );
2488 my $processing_fee_line = $processing_fee_lines->next;
2489 is( $processing_fee_line->amount + 0,
2490 $processfee_amount, 'The right PROCESSING amount is generated' );
2491 is( $processing_fee_line->amountoutstanding + 0,
2492 $processfee_amount, 'The right PROCESSING amountoutstanding is generated' );
2494 my $lost_fee_lines = Koha::Account::Lines->search(
2495 { borrowernumber => $patron->id, itemnumber => $item->itemnumber, debit_type_code => 'LOST' } );
2496 is( $lost_fee_lines->count, 1, 'Only one lost item fee produced' );
2497 my $lost_fee_line = $lost_fee_lines->next;
2498 is( $lost_fee_line->amount + 0, $replacement_amount, 'The right LOST amount is generated' );
2499 is( $lost_fee_line->amountoutstanding + 0,
2500 $replacement_amount, 'The right LOST amountoutstanding is generated' );
2501 is( $lost_fee_line->status,
2502 undef, 'The LOST status was not set' );
2504 my $account = $patron->account;
2505 my $debts = $account->outstanding_debits;
2507 # Write off the debt
2508 my $credit = $account->add_credit(
2509 { amount => $account->balance,
2511 interface => 'test',
2514 $credit->apply( { debits => [ $debts->as_list ], offset_type => 'Writeoff' } );
2516 my $credit_return_id = C4::Circulation::_FixAccountForLostAndFound( $item->itemnumber, $patron->id );
2517 is( $credit_return_id, undef, 'No LOST_FOUND account line added' );
2519 $lost_fee_line->discard_changes; # reload from DB
2520 is( $lost_fee_line->amountoutstanding + 0, 0, 'Lost fee has no outstanding amount' );
2521 is( $lost_fee_line->debit_type_code,
2522 'LOST', 'Lost fee now still has account type of LOST' );
2523 is( $lost_fee_line->status, 'FOUND', "Lost fee now has account status of FOUND");
2525 is( $patron->account->balance, -0, 'The patron balance is 0, everything was written off' );
2528 subtest 'Full payment tests' => sub {
2532 my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
2534 my $item = $builder->build_sample_item(
2536 biblionumber => $biblio->biblionumber,
2537 library => $library->branchcode,
2538 replacementprice => $replacement_amount,
2539 itype => $item_type->itemtype
2543 AddIssue( $patron->unblessed, $item->barcode );
2545 # Simulate item marked as lost
2546 $item->itemlost(1)->store;
2547 LostItem( $item->itemnumber, 1 );
2549 my $processing_fee_lines = Koha::Account::Lines->search(
2550 { borrowernumber => $patron->id, itemnumber => $item->itemnumber, debit_type_code => 'PROCESSING' } );
2551 is( $processing_fee_lines->count, 1, 'Only one processing fee produced' );
2552 my $processing_fee_line = $processing_fee_lines->next;
2553 is( $processing_fee_line->amount + 0,
2554 $processfee_amount, 'The right PROCESSING amount is generated' );
2555 is( $processing_fee_line->amountoutstanding + 0,
2556 $processfee_amount, 'The right PROCESSING amountoutstanding is generated' );
2558 my $lost_fee_lines = Koha::Account::Lines->search(
2559 { borrowernumber => $patron->id, itemnumber => $item->itemnumber, debit_type_code => 'LOST' } );
2560 is( $lost_fee_lines->count, 1, 'Only one lost item fee produced' );
2561 my $lost_fee_line = $lost_fee_lines->next;
2562 is( $lost_fee_line->amount + 0, $replacement_amount, 'The right LOST amount is generated' );
2563 is( $lost_fee_line->amountoutstanding + 0,
2564 $replacement_amount, 'The right LOST amountountstanding is generated' );
2566 my $account = $patron->account;
2567 my $debts = $account->outstanding_debits;
2569 # Write off the debt
2570 my $credit = $account->add_credit(
2571 { amount => $account->balance,
2573 interface => 'test',
2576 $credit->apply( { debits => [ $debts->as_list ], offset_type => 'Payment' } );
2578 my $credit_return_id = C4::Circulation::_FixAccountForLostAndFound( $item->itemnumber, $patron->id );
2579 my $credit_return = Koha::Account::Lines->find($credit_return_id);
2581 is( $credit_return->credit_type_code, 'LOST_FOUND', 'An account line of type LOST_FOUND is added' );
2582 is( $credit_return->amount + 0,
2583 -99.00, 'The account line of type LOST_FOUND has an amount of -99' );
2584 is( $credit_return->amountoutstanding + 0,
2585 -99.00, 'The account line of type LOST_FOUND has an amountoutstanding of -99' );
2587 $lost_fee_line->discard_changes;
2588 is( $lost_fee_line->amountoutstanding + 0, 0, 'Lost fee has no outstanding amount' );
2589 is( $lost_fee_line->debit_type_code,
2590 'LOST', 'Lost fee now still has account type of LOST' );
2591 is( $lost_fee_line->status, 'FOUND', "Lost fee now has account status of FOUND");
2593 is( $patron->account->balance,
2594 -99, 'The patron balance is -99, a credit that equals the lost fee payment' );
2597 subtest 'Test without payment or write off' => sub {
2601 my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
2603 my $item = $builder->build_sample_item(
2605 biblionumber => $biblio->biblionumber,
2606 library => $library->branchcode,
2607 replacementprice => 23.00,
2608 replacementprice => $replacement_amount,
2609 itype => $item_type->itemtype
2613 AddIssue( $patron->unblessed, $item->barcode );
2615 # Simulate item marked as lost
2616 $item->itemlost(3)->store;
2617 LostItem( $item->itemnumber, 1 );
2619 my $processing_fee_lines = Koha::Account::Lines->search(
2620 { borrowernumber => $patron->id, itemnumber => $item->itemnumber, debit_type_code => 'PROCESSING' } );
2621 is( $processing_fee_lines->count, 1, 'Only one processing fee produced' );
2622 my $processing_fee_line = $processing_fee_lines->next;
2623 is( $processing_fee_line->amount + 0,
2624 $processfee_amount, 'The right PROCESSING amount is generated' );
2625 is( $processing_fee_line->amountoutstanding + 0,
2626 $processfee_amount, 'The right PROCESSING amountoutstanding is generated' );
2628 my $lost_fee_lines = Koha::Account::Lines->search(
2629 { borrowernumber => $patron->id, itemnumber => $item->itemnumber, debit_type_code => 'LOST' } );
2630 is( $lost_fee_lines->count, 1, 'Only one lost item fee produced' );
2631 my $lost_fee_line = $lost_fee_lines->next;
2632 is( $lost_fee_line->amount + 0, $replacement_amount, 'The right LOST amount is generated' );
2633 is( $lost_fee_line->amountoutstanding + 0,
2634 $replacement_amount, 'The right LOST amountountstanding is generated' );
2636 my $credit_return_id = C4::Circulation::_FixAccountForLostAndFound( $item->itemnumber, $patron->id );
2637 my $credit_return = Koha::Account::Lines->find($credit_return_id);
2639 is( $credit_return->credit_type_code, 'LOST_FOUND', 'An account line of type LOST_FOUND is added' );
2640 is( $credit_return->amount + 0, -99.00, 'The account line of type LOST_FOUND has an amount of -99' );
2641 is( $credit_return->amountoutstanding + 0, 0, 'The account line of type LOST_FOUND has an amountoutstanding of 0' );
2643 $lost_fee_line->discard_changes;
2644 is( $lost_fee_line->amountoutstanding + 0, 0, 'Lost fee has no outstanding amount' );
2645 is( $lost_fee_line->debit_type_code,
2646 'LOST', 'Lost fee now still has account type of LOST' );
2647 is( $lost_fee_line->status, 'FOUND', "Lost fee now has account status of FOUND");
2649 is( $patron->account->balance, 20, 'The patron balance is 20, still owes the processing fee' );
2652 subtest 'Test with partial payement and write off, and remaining debt' => sub {
2656 my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
2657 my $item = $builder->build_sample_item(
2659 biblionumber => $biblio->biblionumber,
2660 library => $library->branchcode,
2661 replacementprice => $replacement_amount,
2662 itype => $item_type->itemtype
2666 AddIssue( $patron->unblessed, $item->barcode );
2668 # Simulate item marked as lost
2669 $item->itemlost(1)->store;
2670 LostItem( $item->itemnumber, 1 );
2672 my $processing_fee_lines = Koha::Account::Lines->search(
2673 { borrowernumber => $patron->id, itemnumber => $item->itemnumber, debit_type_code => 'PROCESSING' } );
2674 is( $processing_fee_lines->count, 1, 'Only one processing fee produced' );
2675 my $processing_fee_line = $processing_fee_lines->next;
2676 is( $processing_fee_line->amount + 0,
2677 $processfee_amount, 'The right PROCESSING amount is generated' );
2678 is( $processing_fee_line->amountoutstanding + 0,
2679 $processfee_amount, 'The right PROCESSING amountoutstanding is generated' );
2681 my $lost_fee_lines = Koha::Account::Lines->search(
2682 { borrowernumber => $patron->id, itemnumber => $item->itemnumber, debit_type_code => 'LOST' } );
2683 is( $lost_fee_lines->count, 1, 'Only one lost item fee produced' );
2684 my $lost_fee_line = $lost_fee_lines->next;
2685 is( $lost_fee_line->amount + 0, $replacement_amount, 'The right LOST amount is generated' );
2686 is( $lost_fee_line->amountoutstanding + 0,
2687 $replacement_amount, 'The right LOST amountountstanding is generated' );
2689 my $account = $patron->account;
2690 is( $account->balance, $processfee_amount + $replacement_amount, 'Balance is PROCESSING + L' );
2693 my $payment_amount = 27;
2694 my $payment = $account->add_credit(
2695 { amount => $payment_amount,
2697 interface => 'test',
2701 $payment->apply( { debits => [ $lost_fee_line ], offset_type => 'Payment' } );
2703 # Partially write off fee
2704 my $write_off_amount = 25;
2705 my $write_off = $account->add_credit(
2706 { amount => $write_off_amount,
2708 interface => 'test',
2711 $write_off->apply( { debits => [ $lost_fee_line ], offset_type => 'Writeoff' } );
2713 is( $account->balance,
2714 $processfee_amount + $replacement_amount - $payment_amount - $write_off_amount,
2715 'Payment and write off applied'
2718 # Store the amountoutstanding value
2719 $lost_fee_line->discard_changes;
2720 my $outstanding = $lost_fee_line->amountoutstanding;
2722 my $credit_return_id = C4::Circulation::_FixAccountForLostAndFound( $item->itemnumber, $patron->id );
2723 my $credit_return = Koha::Account::Lines->find($credit_return_id);
2725 is( $account->balance, $processfee_amount - $payment_amount, 'Balance is PROCESSING - PAYMENT (LOST_FOUND)' );
2727 $lost_fee_line->discard_changes;
2728 is( $lost_fee_line->amountoutstanding + 0, 0, 'Lost fee has no outstanding amount' );
2729 is( $lost_fee_line->debit_type_code,
2730 'LOST', 'Lost fee now still has account type of LOST' );
2731 is( $lost_fee_line->status, 'FOUND', "Lost fee now has account status of FOUND");
2733 is( $credit_return->credit_type_code, 'LOST_FOUND', 'An account line of type LOST_FOUND is added' );
2734 is( $credit_return->amount + 0,
2735 ($payment_amount + $outstanding ) * -1,
2736 'The account line of type LOST_FOUND has an amount equal to the payment + outstanding'
2738 is( $credit_return->amountoutstanding + 0,
2739 $payment_amount * -1,
2740 'The account line of type LOST_FOUND has an amountoutstanding equal to the payment'
2743 is( $account->balance,
2744 $processfee_amount - $payment_amount,
2745 'The patron balance is the difference between the PROCESSING and the credit'
2749 subtest 'Partial payement, existing debits and AccountAutoReconcile' => sub {
2753 my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
2754 my $barcode = 'KD123456793';
2755 my $replacement_amount = 100;
2756 my $processfee_amount = 20;
2758 my $item_type = $builder->build_object(
2759 { class => 'Koha::ItemTypes',
2761 notforloan => undef,
2763 defaultreplacecost => undef,
2765 rentalcharge_daily => 0,
2769 my $item = Koha::Item->new(
2771 biblionumber => $biblio->biblionumber,
2772 homebranch => $library->branchcode,
2773 holdingbranch => $library->branchcode,
2774 barcode => $barcode,
2775 replacementprice => $replacement_amount,
2776 itype => $item_type->itemtype
2780 AddIssue( $patron->unblessed, $barcode );
2782 # Simulate item marked as lost
2783 $item->itemlost(1)->store;
2784 LostItem( $item->itemnumber, 1 );
2786 my $lost_fee_lines = Koha::Account::Lines->search(
2787 { borrowernumber => $patron->id, itemnumber => $item->itemnumber, debit_type_code => 'LOST' } );
2788 is( $lost_fee_lines->count, 1, 'Only one lost item fee produced' );
2789 my $lost_fee_line = $lost_fee_lines->next;
2790 is( $lost_fee_line->amount + 0, $replacement_amount, 'The right LOST amount is generated' );
2791 is( $lost_fee_line->amountoutstanding + 0,
2792 $replacement_amount, 'The right LOST amountountstanding is generated' );
2794 my $account = $patron->account;
2795 is( $account->balance, $replacement_amount, 'Balance is L' );
2798 my $payment_amount = 27;
2799 my $payment = $account->add_credit(
2800 { amount => $payment_amount,
2802 interface => 'test',
2805 $payment->apply({ debits => [ $lost_fee_line ], offset_type => 'Payment' });
2807 is( $account->balance,
2808 $replacement_amount - $payment_amount,
2812 my $manual_debit_amount = 80;
2813 $account->add_debit( { amount => $manual_debit_amount, type => 'OVERDUE', interface =>'test' } );
2815 is( $account->balance, $manual_debit_amount + $replacement_amount - $payment_amount, 'Manual debit applied' );
2817 t::lib::Mocks::mock_preference( 'AccountAutoReconcile', 1 );
2819 my $credit_return_id = C4::Circulation::_FixAccountForLostAndFound( $item->itemnumber, $patron->id );
2820 my $credit_return = Koha::Account::Lines->find($credit_return_id);
2822 is( $account->balance, $manual_debit_amount - $payment_amount, 'Balance is PROCESSING - payment (LOST_FOUND)' );
2824 my $manual_debit = Koha::Account::Lines->search({ borrowernumber => $patron->id, debit_type_code => 'OVERDUE', status => 'UNRETURNED' })->next;
2825 is( $manual_debit->amountoutstanding + 0, $manual_debit_amount - $payment_amount, 'reconcile_balance was called' );
2829 subtest '_FixOverduesOnReturn' => sub {
2832 my $manager = $builder->build_object({ class => "Koha::Patrons" });
2833 t::lib::Mocks::mock_userenv({ patron => $manager, branchcode => $manager->branchcode });
2835 my $biblio = $builder->build_sample_biblio({ author => 'Hall, Kylie' });
2837 my $branchcode = $library2->{branchcode};
2839 my $item = $builder->build_sample_item(
2841 biblionumber => $biblio->biblionumber,
2842 library => $branchcode,
2843 replacementprice => 99.00,
2848 my $patron = $builder->build( { source => 'Borrower' } );
2850 ## Start with basic call, should just close out the open fine
2851 my $accountline = Koha::Account::Line->new(
2853 borrowernumber => $patron->{borrowernumber},
2854 debit_type_code => 'OVERDUE',
2855 status => 'UNRETURNED',
2856 itemnumber => $item->itemnumber,
2858 amountoutstanding => 99.00,
2859 interface => 'test',
2863 C4::Circulation::_FixOverduesOnReturn( $patron->{borrowernumber}, $item->itemnumber, undef, 'RETURNED' );
2865 $accountline->_result()->discard_changes();
2867 is( $accountline->amountoutstanding+0, 99, 'Fine has the same amount outstanding as previously' );
2868 isnt( $accountline->status, 'UNRETURNED', 'Open fine ( account type OVERDUE ) has been closed out ( status not UNRETURNED )');
2869 is( $accountline->status, 'RETURNED', 'Passed status has been used to set as RETURNED )');
2871 ## Run again, with exemptfine enabled
2874 debit_type_code => 'OVERDUE',
2875 status => 'UNRETURNED',
2876 amountoutstanding => 99.00,
2880 C4::Circulation::_FixOverduesOnReturn( $patron->{borrowernumber}, $item->itemnumber, 1, 'RETURNED' );
2882 $accountline->_result()->discard_changes();
2883 my $offset = Koha::Account::Offsets->search({ debit_id => $accountline->id, type => 'Forgiven' })->next();
2885 is( $accountline->amountoutstanding + 0, 0, 'Fine amountoutstanding has been reduced to 0' );
2886 isnt( $accountline->status, 'UNRETURNED', 'Open fine ( account type OVERDUE ) has been closed out ( status not UNRETURNED )');
2887 is( $accountline->status, 'FORGIVEN', 'Open fine ( account type OVERDUE ) has been set to fine forgiven ( status FORGIVEN )');
2888 is( ref $offset, "Koha::Account::Offset", "Found matching offset for fine reduction via forgiveness" );
2889 is( $offset->amount + 0, -99, "Amount of offset is correct" );
2890 my $credit = $offset->credit;
2891 is( ref $credit, "Koha::Account::Line", "Found matching credit for fine forgiveness" );
2892 is( $credit->amount + 0, -99, "Credit amount is set correctly" );
2893 is( $credit->amountoutstanding + 0, 0, "Credit amountoutstanding is correctly set to 0" );
2896 subtest '_FixAccountForLostAndFound returns undef if patron is deleted' => sub {
2899 my $manager = $builder->build_object({ class => "Koha::Patrons" });
2900 t::lib::Mocks::mock_userenv({ patron => $manager, branchcode => $manager->branchcode });
2902 my $biblio = $builder->build_sample_biblio({ author => 'Hall, Kylie' });
2904 my $branchcode = $library2->{branchcode};
2906 my $item = $builder->build_sample_item(
2908 biblionumber => $biblio->biblionumber,
2909 library => $branchcode,
2910 replacementprice => 99.00,
2915 my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
2917 ## Start with basic call, should just close out the open fine
2918 my $accountline = Koha::Account::Line->new(
2920 borrowernumber => $patron->id,
2921 debit_type_code => 'LOST',
2923 itemnumber => $item->itemnumber,
2925 amountoutstanding => 99.00,
2926 interface => 'test',
2932 my $return_value = C4::Circulation::_FixAccountForLostAndFound( $patron->id, $item->itemnumber );
2934 is( $return_value, undef, "_FixAccountForLostAndFound returns undef if patron is deleted" );
2938 subtest 'Set waiting flag' => sub {
2941 my $library_1 = $builder->build( { source => 'Branch' } );
2942 my $patron_1 = $builder->build( { source => 'Borrower', value => { branchcode => $library_1->{branchcode}, categorycode => $patron_category->{categorycode} } } );
2943 my $library_2 = $builder->build( { source => 'Branch' } );
2944 my $patron_2 = $builder->build( { source => 'Borrower', value => { branchcode => $library_2->{branchcode}, categorycode => $patron_category->{categorycode} } } );
2946 my $item = $builder->build_sample_item(
2948 library => $library_1->{branchcode},
2952 set_userenv( $library_2 );
2953 my $reserve_id = AddReserve(
2955 branchcode => $library_2->{branchcode},
2956 borrowernumber => $patron_2->{borrowernumber},
2957 biblionumber => $item->{biblionumber},
2959 itemnumber => $item->{itemnumber},
2963 set_userenv( $library_1 );
2964 my $do_transfer = 1;
2965 my ( $res, $rr ) = AddReturn( $item->{barcode}, $library_1->{branchcode} );
2966 ModReserveAffect( $item->{itemnumber}, undef, $do_transfer, $reserve_id );
2967 my $hold = Koha::Holds->find( $reserve_id );
2968 is( $hold->found, 'T', 'Hold is in transit' );
2970 my ( $status ) = CheckReserves($item->{itemnumber});
2971 is( $status, 'Reserved', 'Hold is not waiting yet');
2973 set_userenv( $library_2 );
2975 AddReturn( $item->{barcode}, $library_2->{branchcode} );
2976 ModReserveAffect( $item->{itemnumber}, undef, $do_transfer, $reserve_id );
2977 $hold = Koha::Holds->find( $reserve_id );
2978 is( $hold->found, 'W', 'Hold is waiting' );
2979 ( $status ) = CheckReserves($item->{itemnumber});
2980 is( $status, 'Waiting', 'Now the hold is waiting');
2982 #Bug 21944 - Waiting transfer checked in at branch other than pickup location
2983 set_userenv( $library_1 );
2984 (undef, my $messages, undef, undef ) = AddReturn ( $item->{barcode}, $library_1->{branchcode} );
2985 $hold = Koha::Holds->find( $reserve_id );
2986 is( $hold->found, undef, 'Hold is no longer marked waiting' );
2987 is( $hold->priority, 1, "Hold is now priority one again");
2988 is( $hold->waitingdate, undef, "Hold no longer has a waiting date");
2989 is( $hold->itemnumber, $item->{itemnumber}, "Hold has retained its' itemnumber");
2990 is( $messages->{ResFound}->{ResFound}, "Reserved", "Hold is still returned");
2991 is( $messages->{ResFound}->{found}, undef, "Hold is no longer marked found in return message");
2992 is( $messages->{ResFound}->{priority}, 1, "Hold is priority 1 in return message");
2995 subtest 'Cancel transfers on lost items' => sub {
2997 my $library_1 = $builder->build( { source => 'Branch' } );
2998 my $patron_1 = $builder->build( { source => 'Borrower', value => { branchcode => $library_1->{branchcode}, categorycode => $patron_category->{categorycode} } } );
2999 my $library_2 = $builder->build( { source => 'Branch' } );
3000 my $patron_2 = $builder->build( { source => 'Borrower', value => { branchcode => $library_2->{branchcode}, categorycode => $patron_category->{categorycode} } } );
3001 my $biblio = $builder->build_sample_biblio({branchcode => $library->{branchcode}});
3002 my $item = $builder->build_sample_item({
3003 biblionumber => $biblio->biblionumber,
3004 library => $library_1->{branchcode},
3007 set_userenv( $library_2 );
3008 my $reserve_id = AddReserve(
3010 branchcode => $library_2->{branchcode},
3011 borrowernumber => $patron_2->{borrowernumber},
3012 biblionumber => $item->biblionumber,
3014 itemnumber => $item->itemnumber,
3018 #Return book and add transfer
3019 set_userenv( $library_1 );
3020 my $do_transfer = 1;
3021 my ( $res, $rr ) = AddReturn( $item->barcode, $library_1->{branchcode} );
3022 ModReserveAffect( $item->itemnumber, undef, $do_transfer, $reserve_id );
3023 C4::Circulation::transferbook( $library_2->{branchcode}, $item->barcode );
3024 my $hold = Koha::Holds->find( $reserve_id );
3025 is( $hold->found, 'T', 'Hold is in transit' );
3027 #Check transfer exists and the items holding branch is the transfer destination branch before marking it as lost
3028 my ($datesent,$frombranch,$tobranch) = GetTransfers($item->itemnumber);
3029 is( $tobranch, $library_2->{branchcode}, 'The transfer record exists in the branchtransfers table');
3030 my $itemcheck = Koha::Items->find($item->itemnumber);
3031 is( $itemcheck->holdingbranch, $library_1->{branchcode}, 'Items holding branch is the transfers origin branch before it is marked as lost' );
3033 #Simulate item being marked as lost and confirm the transfer is deleted and the items holding branch is the transfers source branch
3034 $item->itemlost(1)->store;
3035 LostItem( $item->itemnumber, 'test', 1 );
3036 ($datesent,$frombranch,$tobranch) = GetTransfers($item->itemnumber);
3037 is( $tobranch, undef, 'The transfer on the lost item has been deleted as the LostItemCancelOutstandingTransfer is enabled');
3038 $itemcheck = Koha::Items->find($item->itemnumber);
3039 is( $itemcheck->holdingbranch, $library_1->{branchcode}, 'Lost item with cancelled hold has holding branch equallying the transfers source branch' );
3042 subtest 'CanBookBeIssued | is_overdue' => sub {
3045 # Set a simple circ policy
3046 Koha::CirculationRules->set_rules(
3048 categorycode => undef,
3049 branchcode => undef,
3053 reservesallowed => 25,
3055 lengthunit => 'days',
3056 renewalsallowed => 1,
3058 norenewalbefore => undef,
3066 my $now = dt_from_string;
3067 my $five_days_go = output_pref({ dt => $now->clone->add( days => 5 ), dateonly => 1});
3068 my $ten_days_go = output_pref({ dt => $now->clone->add( days => 10), dateonly => 1 });
3069 my $library = $builder->build( { source => 'Branch' } );
3070 my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } );
3072 my $item = $builder->build_sample_item(
3074 library => $library->{branchcode},
3078 my $issue = AddIssue( $patron->unblessed, $item->{barcode}, $five_days_go ); # date due was 10d ago
3079 my $actualissue = Koha::Checkouts->find( { itemnumber => $item->{itemnumber} } );
3080 is( output_pref({ str => $actualissue->date_due, dateonly => 1}), $five_days_go, "First issue works");
3081 my ($issuingimpossible, $needsconfirmation) = CanBookBeIssued($patron,$item->{barcode},$ten_days_go, undef, undef, undef);
3082 is( $needsconfirmation->{RENEW_ISSUE}, 1, "This is a renewal");
3083 is( $needsconfirmation->{TOO_MANY}, undef, "Not too many, is a renewal");
3086 subtest 'ItemsDeniedRenewal preference' => sub {
3089 C4::Context->set_preference('ItemsDeniedRenewal','');
3091 my $idr_lib = $builder->build_object({ class => 'Koha::Libraries'});
3092 Koha::CirculationRules->set_rules(
3094 categorycode => '*',
3096 branchcode => $idr_lib->branchcode,
3098 reservesallowed => 25,
3100 lengthunit => 'days',
3101 renewalsallowed => 10,
3103 norenewalbefore => undef,
3111 my $deny_book = $builder->build_object({ class => 'Koha::Items', value => {
3112 homebranch => $idr_lib->branchcode,
3116 itemcallnumber => undef,
3120 my $allow_book = $builder->build_object({ class => 'Koha::Items', value => {
3121 homebranch => $idr_lib->branchcode,
3124 location => 'NOPROC'
3128 my $idr_borrower = $builder->build_object({ class => 'Koha::Patrons', value=> {
3129 branchcode => $idr_lib->branchcode,
3132 my $future = dt_from_string->add( days => 1 );
3133 my $deny_issue = $builder->build_object({ class => 'Koha::Checkouts', value => {
3134 returndate => undef,
3137 borrowernumber => $idr_borrower->borrowernumber,
3138 itemnumber => $deny_book->itemnumber,
3139 onsite_checkout => 0,
3140 date_due => $future,
3143 my $allow_issue = $builder->build_object({ class => 'Koha::Checkouts', value => {
3144 returndate => undef,
3147 borrowernumber => $idr_borrower->borrowernumber,
3148 itemnumber => $allow_book->itemnumber,
3149 onsite_checkout => 0,
3150 date_due => $future,
3156 my ( $idr_mayrenew, $idr_error ) =
3157 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
3158 is( $idr_mayrenew, 1, 'Renewal allowed when no rules' );
3159 is( $idr_error, undef, 'Renewal allowed when no rules' );
3161 $idr_rules="withdrawn: [1]";
3163 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
3164 ( $idr_mayrenew, $idr_error ) =
3165 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
3166 is( $idr_mayrenew, 0, 'Renewal blocked when 1 rules (withdrawn)' );
3167 is( $idr_error, 'item_denied_renewal', 'Renewal blocked when 1 rule (withdrawn)' );
3168 ( $idr_mayrenew, $idr_error ) =
3169 CanBookBeRenewed( $idr_borrower->borrowernumber, $allow_issue->itemnumber );
3170 is( $idr_mayrenew, 1, 'Renewal allowed when 1 rules not matched (withdrawn)' );
3171 is( $idr_error, undef, 'Renewal allowed when 1 rules not matched (withdrawn)' );
3173 $idr_rules="withdrawn: [1]\nitype: [HIDE,INVISIBLE]";
3175 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
3176 ( $idr_mayrenew, $idr_error ) =
3177 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
3178 is( $idr_mayrenew, 0, 'Renewal blocked when 2 rules matched (withdrawn, itype)' );
3179 is( $idr_error, 'item_denied_renewal', 'Renewal blocked when 2 rules matched (withdrawn,itype)' );
3180 ( $idr_mayrenew, $idr_error ) =
3181 CanBookBeRenewed( $idr_borrower->borrowernumber, $allow_issue->itemnumber );
3182 is( $idr_mayrenew, 1, 'Renewal allowed when 2 rules not matched (withdrawn, itype)' );
3183 is( $idr_error, undef, 'Renewal allowed when 2 rules not matched (withdrawn, itype)' );
3185 $idr_rules="withdrawn: [1]\nitype: [HIDE,INVISIBLE]\nlocation: [PROC]";
3187 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
3188 ( $idr_mayrenew, $idr_error ) =
3189 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
3190 is( $idr_mayrenew, 0, 'Renewal blocked when 3 rules matched (withdrawn, itype, location)' );
3191 is( $idr_error, 'item_denied_renewal', 'Renewal blocked when 3 rules matched (withdrawn,itype, location)' );
3192 ( $idr_mayrenew, $idr_error ) =
3193 CanBookBeRenewed( $idr_borrower->borrowernumber, $allow_issue->itemnumber );
3194 is( $idr_mayrenew, 1, 'Renewal allowed when 3 rules not matched (withdrawn, itype, location)' );
3195 is( $idr_error, undef, 'Renewal allowed when 3 rules not matched (withdrawn, itype, location)' );
3197 $idr_rules="itemcallnumber: [NULL]";
3198 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
3199 ( $idr_mayrenew, $idr_error ) =
3200 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
3201 is( $idr_mayrenew, 0, 'Renewal blocked for undef when NULL in pref' );
3202 $idr_rules="itemcallnumber: ['']";
3203 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
3204 ( $idr_mayrenew, $idr_error ) =
3205 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
3206 is( $idr_mayrenew, 1, 'Renewal not blocked for undef when "" in pref' );
3208 $idr_rules="itemnotes: [NULL]";
3209 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
3210 ( $idr_mayrenew, $idr_error ) =
3211 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
3212 is( $idr_mayrenew, 1, 'Renewal not blocked for "" when NULL in pref' );
3213 $idr_rules="itemnotes: ['']";
3214 C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
3215 ( $idr_mayrenew, $idr_error ) =
3216 CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
3217 is( $idr_mayrenew, 0, 'Renewal blocked for empty string when "" in pref' );
3220 subtest 'CanBookBeIssued | item-level_itypes=biblio' => sub {
3223 t::lib::Mocks::mock_preference('item-level_itypes', 0); # biblio
3224 my $library = $builder->build( { source => 'Branch' } );
3225 my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } )->store;
3227 my $item = $builder->build_sample_item(
3229 library => $library->{branchcode},
3233 my ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
3234 is_deeply( $needsconfirmation, {}, 'Item can be issued to this patron' );
3235 is_deeply( $issuingimpossible, {}, 'Item can be issued to this patron' );
3238 subtest 'CanBookBeIssued | notforloan' => sub {
3241 t::lib::Mocks::mock_preference('AllowNotForLoanOverride', 0);
3243 my $library = $builder->build( { source => 'Branch' } );
3244 my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } )->store;
3246 my $itemtype = $builder->build(
3248 source => 'Itemtype',
3249 value => { notforloan => undef, }
3252 my $item = $builder->build_sample_item(
3254 library => $library->{branchcode},
3255 itype => $itemtype->{itemtype},
3258 $item->biblioitem->itemtype($itemtype->{itemtype})->store;
3260 my ( $issuingimpossible, $needsconfirmation );
3263 subtest 'item-level_itypes = 1' => sub {
3266 t::lib::Mocks::mock_preference('item-level_itypes', 1); # item
3267 # Is for loan at item type and item level
3268 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
3269 is_deeply( $needsconfirmation, {}, 'Item can be issued to this patron' );
3270 is_deeply( $issuingimpossible, {}, 'Item can be issued to this patron' );
3272 # not for loan at item type level
3273 Koha::ItemTypes->find( $itemtype->{itemtype} )->notforloan(1)->store;
3274 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
3275 is_deeply( $needsconfirmation, {}, 'No confirmation needed, AllowNotForLoanOverride=0' );
3278 { NOT_FOR_LOAN => 1, itemtype_notforloan => $itemtype->{itemtype} },
3279 'Item can not be issued, not for loan at item type level'
3282 # not for loan at item level
3283 Koha::ItemTypes->find( $itemtype->{itemtype} )->notforloan(undef)->store;
3284 $item->notforloan( 1 )->store;
3285 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
3286 is_deeply( $needsconfirmation, {}, 'No confirmation needed, AllowNotForLoanOverride=0' );
3289 { NOT_FOR_LOAN => 1, item_notforloan => 1 },
3290 'Item can not be issued, not for loan at item type level'
3294 subtest 'item-level_itypes = 0' => sub {
3297 t::lib::Mocks::mock_preference('item-level_itypes', 0); # biblio
3299 # We set another itemtype for biblioitem
3300 my $itemtype = $builder->build(
3302 source => 'Itemtype',
3303 value => { notforloan => undef, }
3307 # for loan at item type and item level
3308 $item->notforloan(0)->store;
3309 $item->biblioitem->itemtype($itemtype->{itemtype})->store;
3310 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
3311 is_deeply( $needsconfirmation, {}, 'Item can be issued to this patron' );
3312 is_deeply( $issuingimpossible, {}, 'Item can be issued to this patron' );
3314 # not for loan at item type level
3315 Koha::ItemTypes->find( $itemtype->{itemtype} )->notforloan(1)->store;
3316 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
3317 is_deeply( $needsconfirmation, {}, 'No confirmation needed, AllowNotForLoanOverride=0' );
3320 { NOT_FOR_LOAN => 1, itemtype_notforloan => $itemtype->{itemtype} },
3321 'Item can not be issued, not for loan at item type level'
3324 # not for loan at item level
3325 Koha::ItemTypes->find( $itemtype->{itemtype} )->notforloan(undef)->store;
3326 $item->notforloan( 1 )->store;
3327 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
3328 is_deeply( $needsconfirmation, {}, 'No confirmation needed, AllowNotForLoanOverride=0' );
3331 { NOT_FOR_LOAN => 1, item_notforloan => 1 },
3332 'Item can not be issued, not for loan at item type level'
3336 # TODO test with AllowNotForLoanOverride = 1
3339 subtest 'AddReturn should clear items.onloan for unissued items' => sub {
3342 t::lib::Mocks::mock_preference( "AllowReturnToBranch", 'anywhere' );
3343 my $item = $builder->build_sample_item(
3345 onloan => '2018-01-01',
3349 AddReturn( $item->barcode, $item->homebranch );
3350 $item->discard_changes; # refresh
3351 is( $item->onloan, undef, 'AddReturn did clear items.onloan' );
3355 subtest 'AddRenewal and AddIssuingCharge tests' => sub {
3360 t::lib::Mocks::mock_preference('item-level_itypes', 1);
3362 my $issuing_charges = 15;
3363 my $title = 'A title';
3364 my $author = 'Author, An';
3365 my $barcode = 'WHATARETHEODDS';
3367 my $circ = Test::MockModule->new('C4::Circulation');
3369 'GetIssuingCharges',
3371 return $issuing_charges;
3375 my $library = $builder->build_object({ class => 'Koha::Libraries' });
3376 my $itemtype = $builder->build_object({ class => 'Koha::ItemTypes', value => { rentalcharge_daily => 0.00 }});
3377 my $patron = $builder->build_object({
3378 class => 'Koha::Patrons',
3379 value => { branchcode => $library->id }
3382 my $biblio = $builder->build_sample_biblio({ title=> $title, author => $author });
3383 my $item_id = Koha::Item->new(
3385 biblionumber => $biblio->biblionumber,
3386 homebranch => $library->id,
3387 holdingbranch => $library->id,
3388 barcode => $barcode,
3389 replacementprice => 23.00,
3390 itype => $itemtype->id
3392 )->store->itemnumber;
3393 my $item = Koha::Items->find( $item_id );
3395 my $context = Test::MockModule->new('C4::Context');
3396 $context->mock( userenv => { branch => $library->id } );
3398 # Check the item out
3399 AddIssue( $patron->unblessed, $item->barcode );
3400 t::lib::Mocks::mock_preference( 'RenewalLog', 0 );
3401 my $date = output_pref( { dt => dt_from_string(), dateonly => 1, dateformat => 'iso' } );
3402 my %params_renewal = (
3403 timestamp => { -like => $date . "%" },
3404 module => "CIRCULATION",
3405 action => "RENEWAL",
3407 my $old_log_size = Koha::ActionLogs->count( \%params_renewal );;
3408 AddRenewal( $patron->id, $item->id, $library->id );
3409 my $new_log_size = Koha::ActionLogs->count( \%params_renewal );
3410 is( $new_log_size, $old_log_size, 'renew log not added because of the syspref RenewalLog' );
3412 my $checkouts = $patron->checkouts;
3413 # The following will fail if run on 00:00:00
3414 unlike ( $checkouts->next->lastreneweddate, qr/00:00:00/, 'AddRenewal should set the renewal date with the time part');
3416 my $lines = Koha::Account::Lines->search({
3417 borrowernumber => $patron->id,
3418 itemnumber => $item->id
3421 is( $lines->count, 2 );
3423 my $line = $lines->next;
3424 is( $line->debit_type_code, 'RENT', 'The issue of item with issuing charge generates an accountline of the correct type' );
3425 is( $line->branchcode, $library->id, 'AddIssuingCharge correctly sets branchcode' );
3426 is( $line->description, '', 'AddIssue does not set a hardcoded description for the accountline' );
3428 $line = $lines->next;
3429 is( $line->debit_type_code, 'RENT_RENEW', 'The renewal of item with issuing charge generates an accountline of the correct type' );
3430 is( $line->branchcode, $library->id, 'AddRenewal correctly sets branchcode' );
3431 is( $line->description, '', 'AddRenewal does not set a hardcoded description for the accountline' );
3433 t::lib::Mocks::mock_preference( 'RenewalLog', 1 );
3435 $context = Test::MockModule->new('C4::Context');
3436 $context->mock( userenv => { branch => undef, interface => 'CRON'} ); #Test statistical logging of renewal via cron (atuo_renew)
3438 my $now = dt_from_string;
3439 $date = output_pref( { dt => $now, dateonly => 1, dateformat => 'iso' } );
3440 $old_log_size = Koha::ActionLogs->count( \%params_renewal );
3441 my $sth = $dbh->prepare("SELECT COUNT(*) FROM statistics WHERE itemnumber = ? AND branch = ?");
3442 $sth->execute($item->id, $library->id);
3443 my ($old_stats_size) = $sth->fetchrow_array;
3444 AddRenewal( $patron->id, $item->id, $library->id );
3445 $new_log_size = Koha::ActionLogs->count( \%params_renewal );
3446 $sth->execute($item->id, $library->id);
3447 my ($new_stats_size) = $sth->fetchrow_array;
3448 is( $new_log_size, $old_log_size + 1, 'renew log successfully added' );
3449 is( $new_stats_size, $old_stats_size + 1, 'renew statistic successfully added with passed branch' );
3451 AddReturn( $item->id, $library->id, undef, $date );
3452 AddIssue( $patron->unblessed, $item->barcode, $now );
3453 AddRenewal( $patron->id, $item->id, $library->id, undef, undef, 1 );
3454 my $lines_skipped = Koha::Account::Lines->search({
3455 borrowernumber => $patron->id,
3456 itemnumber => $item->id
3458 is( $lines_skipped->count, 5, 'Passing skipfinecalc causes fine calculation on renewal to be skipped' );
3462 subtest 'ProcessOfflinePayment() tests' => sub {
3469 my $patron = $builder->build_object({ class => 'Koha::Patrons' });
3470 my $library = $builder->build_object({ class => 'Koha::Libraries' });
3471 my $result = C4::Circulation::ProcessOfflinePayment({ cardnumber => $patron->cardnumber, amount => $amount, branchcode => $library->id });
3473 is( $result, 'Success.', 'The right string is returned' );
3475 my $lines = $patron->account->lines;
3476 is( $lines->count, 1, 'line created correctly');
3478 my $line = $lines->next;
3479 is( $line->amount+0, $amount * -1, 'amount picked from params' );
3480 is( $line->branchcode, $library->id, 'branchcode set correctly' );
3484 subtest 'Incremented fee tests' => sub {
3487 my $dt = dt_from_string();
3488 Time::Fake->offset( $dt->epoch );
3490 t::lib::Mocks::mock_preference( 'item-level_itypes', 1 );
3493 $builder->build_object( { class => 'Koha::Libraries' } )->store;
3495 my $module = new Test::MockModule('C4::Context');
3496 $module->mock( 'userenv', sub { { branch => $library->id } } );
3498 my $patron = $builder->build_object(
3500 class => 'Koha::Patrons',
3501 value => { categorycode => $patron_category->{categorycode} }
3505 my $itemtype = $builder->build_object(
3507 class => 'Koha::ItemTypes',
3509 notforloan => undef,
3511 rentalcharge_daily => 1,
3512 rentalcharge_daily_calendar => 0
3517 my $item = $builder->build_sample_item(
3519 library => $library->{branchcode},
3520 itype => $itemtype->id,
3524 is( $itemtype->rentalcharge_daily+0,
3525 1, 'Daily rental charge stored and retreived correctly' );
3526 is( $item->effective_itemtype, $itemtype->id,
3527 "Itemtype set correctly for item" );
3529 my $now = dt_from_string;
3530 my $dt_from = $now->clone;
3531 my $dt_to = $now->clone->add( days => 7 );
3532 my $dt_to_renew = $now->clone->add( days => 13 );
3536 AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
3537 my $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
3538 is( $accountline->amount+0, 7,
3539 "Daily rental charge calculated correctly with rentalcharge_daily_calendar = 0"
3541 $accountline->delete();
3542 AddRenewal( $patron->id, $item->id, $library->id, $dt_to_renew, $dt_to );
3543 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
3544 is( $accountline->amount+0, 6,
3545 "Daily rental charge calculated correctly with rentalcharge_daily_calendar = 0, for renewal"
3547 $accountline->delete();
3550 t::lib::Mocks::mock_preference( 'finesCalendar', 'noFinesWhenClosed' );
3551 $itemtype->rentalcharge_daily_calendar(1)->store();
3553 AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
3554 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
3555 is( $accountline->amount+0, 7,
3556 "Daily rental charge calculated correctly with rentalcharge_daily_calendar = 1"
3558 $accountline->delete();
3559 AddRenewal( $patron->id, $item->id, $library->id, $dt_to_renew, $dt_to );
3560 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
3561 is( $accountline->amount+0, 6,
3562 "Daily rental charge calculated correctly with rentalcharge_daily_calendar = 1, for renewal"
3564 $accountline->delete();
3567 my $calendar = C4::Calendar->new( branchcode => $library->id );
3568 # DateTime 1..7 (Mon..Sun), C4::Calender 0..6 (Sun..Sat)
3570 ( $dt_from->day_of_week == 6 ) ? 0
3571 : ( $dt_from->day_of_week == 7 ) ? 1
3572 : $dt_from->day_of_week + 1;
3573 my $closed_day_name = $dt_from->clone->add(days => 1)->day_name;
3574 $calendar->insert_week_day_holiday(
3575 weekday => $closed_day,
3576 title => 'Test holiday',
3577 description => 'Test holiday'
3580 AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
3581 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
3582 is( $accountline->amount+0, 6,
3583 "Daily rental charge calculated correctly with rentalcharge_daily_calendar = 1 and closed $closed_day_name"
3585 $accountline->delete();
3586 AddRenewal( $patron->id, $item->id, $library->id, $dt_to_renew, $dt_to );
3587 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
3588 is( $accountline->amount+0, 5,
3589 "Daily rental charge calculated correctly with rentalcharge_daily_calendar = 1 and closed $closed_day_name, for renewal"
3591 $accountline->delete();
3594 $itemtype->rentalcharge(2)->store;
3595 is( $itemtype->rentalcharge+0, 2,
3596 'Rental charge updated and retreived correctly' );
3598 AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
3600 Koha::Account::Lines->search( { itemnumber => $item->id } );
3601 is( $accountlines->count, '2',
3602 "Fixed charge and accrued charge recorded distinctly" );
3603 $accountlines->delete();
3604 AddRenewal( $patron->id, $item->id, $library->id, $dt_to_renew, $dt_to );
3605 $accountlines = Koha::Account::Lines->search( { itemnumber => $item->id } );
3606 is( $accountlines->count, '2',
3607 "Fixed charge and accrued charge recorded distinctly, for renewal" );
3608 $accountlines->delete();
3610 $itemtype->rentalcharge(0)->store;
3611 is( $itemtype->rentalcharge+0, 0,
3612 'Rental charge reset and retreived correctly' );
3615 Koha::CirculationRules->set_rule(
3617 categorycode => $patron->categorycode,
3618 itemtype => $itemtype->id,
3619 branchcode => $library->id,
3620 rule_name => 'lengthunit',
3621 rule_value => 'hours',
3625 $itemtype->rentalcharge_hourly('0.25')->store();
3626 is( $itemtype->rentalcharge_hourly,
3627 '0.25', 'Hourly rental charge stored and retreived correctly' );
3629 $dt_to = $now->clone->add( hours => 168 );
3630 $dt_to_renew = $now->clone->add( hours => 312 );
3632 $itemtype->rentalcharge_hourly_calendar(0)->store();
3634 AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
3635 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
3636 is( $accountline->amount + 0, 42,
3637 "Hourly rental charge calculated correctly with rentalcharge_hourly_calendar = 0 (168h * 0.25u)" );
3638 $accountline->delete();
3639 AddRenewal( $patron->id, $item->id, $library->id, $dt_to_renew, $dt_to );
3640 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
3641 is( $accountline->amount + 0, 36,
3642 "Hourly rental charge calculated correctly with rentalcharge_hourly_calendar = 0, for renewal (312h - 168h * 0.25u)" );
3643 $accountline->delete();
3646 $itemtype->rentalcharge_hourly_calendar(1)->store();
3648 AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
3649 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
3650 is( $accountline->amount + 0, 36,
3651 "Hourly rental charge calculated correctly with rentalcharge_hourly_calendar = 1 and closed $closed_day_name (168h - 24h * 0.25u)" );
3652 $accountline->delete();
3653 AddRenewal( $patron->id, $item->id, $library->id, $dt_to_renew, $dt_to );
3654 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
3655 is( $accountline->amount + 0, 30,
3656 "Hourly rental charge calculated correctly with rentalcharge_hourly_calendar = 1 and closed $closed_day_name, for renewal (312h - 168h - 24h * 0.25u" );
3657 $accountline->delete();
3660 $calendar->delete_holiday( weekday => $closed_day );
3662 AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
3663 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
3664 is( $accountline->amount + 0, 42,
3665 "Hourly rental charge calculated correctly with rentalcharge_hourly_calendar = 1 (168h - 0h * 0.25u" );
3666 $accountline->delete();
3667 AddRenewal( $patron->id, $item->id, $library->id, $dt_to_renew, $dt_to );
3668 $accountline = Koha::Account::Lines->find( { itemnumber => $item->id } );
3669 is( $accountline->amount + 0, 36,
3670 "Hourly rental charge calculated correctly with rentalcharge_hourly_calendar = 1, for renewal (312h - 168h - 0h * 0.25u)" );
3671 $accountline->delete();
3676 subtest 'CanBookBeIssued & RentalFeesCheckoutConfirmation' => sub {
3679 t::lib::Mocks::mock_preference('RentalFeesCheckoutConfirmation', 1);
3680 t::lib::Mocks::mock_preference('item-level_itypes', 1);
3683 $builder->build_object( { class => 'Koha::Libraries' } )->store;
3684 my $patron = $builder->build_object(
3686 class => 'Koha::Patrons',
3687 value => { categorycode => $patron_category->{categorycode} }
3691 my $itemtype = $builder->build_object(
3693 class => 'Koha::ItemTypes',
3697 rentalcharge_daily => 0
3702 my $biblioitem = $builder->build( { source => 'Biblioitem' } );
3703 my $item = $builder->build_object(
3705 class => 'Koha::Items',
3707 homebranch => $library->id,
3708 holdingbranch => $library->id,
3712 itype => $itemtype->id,
3713 biblionumber => $biblioitem->{biblionumber},
3714 biblioitemnumber => $biblioitem->{biblioitemnumber},
3719 my ( $issuingimpossible, $needsconfirmation );
3720 my $dt_from = dt_from_string();
3721 my $dt_due = $dt_from->clone->add( days => 3 );
3723 $itemtype->rentalcharge(1)->store;
3724 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, $dt_due, undef, undef, undef );
3725 is_deeply( $needsconfirmation, { RENTALCHARGE => '1.00' }, 'Item needs rentalcharge confirmation to be issued' );
3726 $itemtype->rentalcharge('0')->store;
3727 $itemtype->rentalcharge_daily(1)->store;
3728 ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, $dt_due, undef, undef, undef );
3729 is_deeply( $needsconfirmation, { RENTALCHARGE => '3' }, 'Item needs rentalcharge confirmation to be issued, increment' );
3730 $itemtype->rentalcharge_daily('0')->store;
3733 subtest "Test Backdating of Returns" => sub {
3736 my $branch = $library2->{branchcode};
3737 my $biblio = $builder->build_sample_biblio();
3738 my $item = $builder->build_sample_item(
3740 biblionumber => $biblio->biblionumber,
3746 my %a_borrower_data = (
3747 firstname => 'Kyle',
3749 categorycode => $patron_category->{categorycode},
3750 branchcode => $branch,
3752 my $borrowernumber = Koha::Patron->new(\%a_borrower_data)->store->borrowernumber;
3753 my $borrower = Koha::Patrons->find( $borrowernumber )->unblessed;
3755 my $due_date = dt_from_string;
3756 my $issue = AddIssue( $borrower, $item->barcode, $due_date );
3759 issue_id => $issue->id(),
3760 itemnumber => $item->itemnumber,
3761 borrowernumber => $borrowernumber,
3763 amountoutstanding => .25,
3769 my ( undef, $message ) = AddReturn( $item->barcode, $branch, undef, $due_date );
3771 my $accountline = Koha::Account::Lines->find( { issue_id => $issue->id } );
3772 is( $accountline->amountoutstanding+0, 0, 'Fee amount outstanding was reduced to 0' );
3773 is( $accountline->amount+0, 0, 'Fee amount was reduced to 0' );
3776 $schema->storage->txn_rollback;
3777 C4::Context->clear_syspref_cache();
3778 $cache->clear_from_cache('single_holidays');