3 # This file is part of Koha.
5 # Koha is free software; you can redistribute it and/or modify it
6 # under the terms of the GNU General Public License as published by
7 # the Free Software Foundation; either version 3 of the License, or
8 # (at your option) any later version.
10 # Koha is distributed in the hope that it will be useful, but
11 # WITHOUT ANY WARRANTY; without even the implied warranty of
12 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 # GNU General Public License for more details.
15 # You should have received a copy of the GNU General Public License
16 # along with Koha; if not, see <http://www.gnu.org/licenses>.
20 use Test::More tests => 45;
21 use DateTime::Duration;
24 use t::lib::TestBuilder;
38 use Koha::CirculationRules;
41 require_ok('C4::Circulation');
59 my $schema = Koha::Database->schema;
60 $schema->storage->txn_begin;
61 my $dbh = C4::Context->dbh;
63 my $builder = t::lib::TestBuilder->new();
65 $dbh->do(q|DELETE FROM issues|);
66 $dbh->do(q|DELETE FROM items|);
67 $dbh->do(q|DELETE FROM borrowers|);
68 $dbh->do(q|DELETE FROM categories|);
69 $dbh->do(q|DELETE FROM accountlines|);
70 $dbh->do(q|DELETE FROM circulation_rules|);
71 $dbh->do(q|DELETE FROM reserves|);
72 $dbh->do(q|DELETE FROM old_reserves|);
73 $dbh->do(q|DELETE FROM statistics|);
75 # Generate sample datas
76 my $itemtype = $builder->build(
77 { source => 'Itemtype',
78 value => { notforloan => undef, rentalcharge => 0 }
81 my $branchcode_1 = $builder->build({ source => 'Branch' })->{branchcode};
82 my $branchcode_2 = $builder->build({ source => 'Branch' })->{branchcode};
83 my $branchcode_3 = $builder->build({ source => 'Branch' })->{branchcode};
84 my $categorycode = $builder->build({
86 value => { enrolmentfee => undef }
89 # A default issuingrule should always be present
90 Koha::CirculationRules->set_rules(
105 my $dt_today = dt_from_string;
106 my $today = output_pref(
109 timeformat => '24hr',
114 my $dt_today2 = dt_from_string;
115 my $dur10 = DateTime::Duration->new( days => -10 );
116 $dt_today2->add_duration($dur10);
117 my $daysago10 = output_pref(
120 timeformat => '24hr',
125 # Add biblio and item
126 my $record = MARC::Record->new();
127 $record->append_fields(
128 MARC::Field->new( '952', '0', '0', a => $branchcode_1 ) );
130 my ( $biblionumber, $biblioitemnumber ) = C4::Biblio::AddBiblio( $record, '' );
132 my $barcode_1 = 'barcode_1';
133 my $barcode_2 = 'barcode_2';
134 my @sampleitem1 = C4::Items::AddItem(
136 barcode => $barcode_1,
137 itemcallnumber => 'callnumber1',
138 homebranch => $branchcode_1,
139 holdingbranch => $branchcode_1,
146 my $item_id1 = $sampleitem1[2];
147 my @sampleitem2 = C4::Items::AddItem(
149 barcode => $barcode_2,
150 itemcallnumber => 'callnumber2',
151 homebranch => $branchcode_2,
152 holdingbranch => $branchcode_2,
159 my $item_id2 = $sampleitem2[2];
162 my $borrower_id1 = Koha::Patron->new({
163 firstname => 'firstname1',
164 surname => 'surname1 ',
165 categorycode => $categorycode,
166 branchcode => $branchcode_1
167 })->store->borrowernumber;
168 my $patron_1 = Koha::Patrons->find( $borrower_id1 );
169 my $borrower_1 = $patron_1->unblessed;
170 my $borrower_id2 = Koha::Patron->new({
171 firstname => 'firstname2',
172 surname => 'surname2 ',
173 categorycode => $categorycode,
174 branchcode => $branchcode_2,
175 })->store->borrowernumber;
176 my $patron_2 = Koha::Patrons->find( $borrower_id2 );
177 my $borrower_2 = $patron_2->unblessed;
179 t::lib::Mocks::mock_userenv({ patron => $patron_1 });
184 my $query = " SELECT count(*) FROM issues";
185 my $sth = $dbh->prepare($query);
187 my $countissue = $sth -> fetchrow_array;
188 is ($countissue ,0, "there is no issue");
189 my $issue1 = C4::Circulation::AddIssue( $borrower_1, $barcode_1, $daysago10,0, $today, '' );
190 is( ref $issue1, 'Koha::Checkout',
191 'AddIssue returns a Koha::Checkout object' );
192 my $datedue1 = dt_from_string( $issue1->date_due() );
195 qr/^\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}/,
196 "Koha::Checkout->date_due() returns a date"
198 my $issue_id1 = $issue1->issue_id;
200 my $issue2 = C4::Circulation::AddIssue( $borrower_1, 'nonexistent_barcode' );
201 is( $issue2, undef, "AddIssue returns undef if no datedue is specified" );
204 $countissue = $sth -> fetchrow_array;
205 is ($countissue,1,"1 issues have been added");
207 #Test AddIssuingCharge
208 $query = " SELECT count(*) FROM accountlines";
209 $sth = $dbh->prepare($query);
211 my $countaccount = $sth->fetchrow_array;
212 is ($countaccount,0,"0 accountline exists");
213 my $checkout = Koha::Checkouts->find( $issue_id1 );
214 my $charge = C4::Circulation::AddIssuingCharge( $checkout, 10, 'RENT' );
215 is( ref( $charge ), 'Koha::Account::Line', "An issuing charge has been added" );
216 is( $charge->issue_id, $issue_id1, 'Issue id is set correctly for issuing charge' );
217 my $offset = Koha::Account::Offsets->find( { debit_id => $charge->id } );
218 is( $offset->credit_id, undef, 'Offset was created');
220 $countaccount = $sth->fetchrow_array;
221 is ($countaccount,1,"1 accountline has been added");
225 my $se = Test::MockModule->new( 'C4::Context' );
226 $se->mock( 'interface', sub {return 'intranet'});
228 # Let's renew this one at a different library for statistical purposes to test Bug 17781
229 # Mocking userenv with a different branchcode
230 t::lib::Mocks::mock_userenv({ patron => $patron_2, branchcode => $branchcode_3 });
232 my $datedue3 = AddRenewal( $borrower_id1, $item_id1, $branchcode_1, $datedue1, $daysago10 );
234 # Restoring the userenv with the original branchcode
235 t::lib::Mocks::mock_userenv({ patron => $patron_1});
239 qr/^\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}/,
240 "AddRenewal returns a date"
243 my $stat = $dbh->selectrow_hashref("SELECT * FROM statistics WHERE type = 'renew' AND borrowernumber = ? AND itemnumber = ? AND branch = ?", undef, $borrower_id1, $item_id1, $branchcode_3 );
244 ok( $stat, "Bug 17781 - 'Improper branchcode set during renewal' still fixed" );
246 $se->mock( 'interface', sub {return 'opac'});
248 #Let's do an opac renewal - whatever branchcode we send should be used
249 my $opac_renew_issue = $builder->build({
252 date_due => '2017-01-01',
253 branch => $branchcode_1,
255 borrowernumber => $borrower_id1
259 my $datedue4 = AddRenewal( $opac_renew_issue->{borrowernumber}, $opac_renew_issue->{itemnumber}, "Stavromula", $datedue1, $daysago10 );
261 $stat = $dbh->selectrow_hashref("SELECT * FROM statistics WHERE type = 'renew' AND borrowernumber = ? AND itemnumber = ? AND branch = ?", undef, $opac_renew_issue->{borrowernumber}, $opac_renew_issue->{itemnumber}, "Stavromula" );
262 ok( $stat, "Bug 18572 - 'Bug 18572 - OpacRenewalBranch is now respected" );
266 #Test GetBiblioIssues
267 is( GetBiblioIssues(), undef, "GetBiblio Issues without parameters" );
270 is( GetOpenIssue(), undef, "Without parameter GetOpenIssue returns undef" );
271 is( GetOpenIssue(-1), undef,
272 "With wrong parameter GetOpenIssue returns undef" );
273 my $openissue = GetOpenIssue($borrower_id1, $item_id1);
277 my $issue3 = C4::Circulation::AddIssue( $borrower_1, $barcode_1 );
278 #Without anything in DB
279 @renewcount = C4::Circulation::GetRenewCount();
282 [ 0, 0, 0 ], # FIXME Need to be fixed, see FIXME in GetRenewCount
283 "Without issuing rules and without parameter, GetRenewCount returns renewcount = 0, renewsallowed = undef, renewsleft = 0"
285 @renewcount = C4::Circulation::GetRenewCount(-1);
288 [ 0, 0, 0 ], # FIXME Need to be fixed
289 "Without issuing rules and without wrong parameter, GetRenewCount returns renewcount = 0, renewsallowed = undef, renewsleft = 0"
291 @renewcount = C4::Circulation::GetRenewCount($borrower_id1, $item_id1);
295 "Without issuing rules and with a valid parameter, renewcount = 2, renewsallowed = undef, renewsleft = 0"
298 #With something in DB
299 @renewcount = C4::Circulation::GetRenewCount();
303 "With issuing rules (renewal disallowed) and without parameter, GetRenewCount returns renewcount = 0, renewsallowed = 0, renewsleft = 0"
305 @renewcount = C4::Circulation::GetRenewCount(-1);
309 "With issuing rules (renewal disallowed) and without wrong parameter, GetRenewCount returns renewcount = 0, renewsallowed = 0, renewsleft = 0"
311 @renewcount = C4::Circulation::GetRenewCount($borrower_id1, $item_id1);
315 "With issuing rules (renewal disallowed) and with a valid parameter, Getrenewcount returns renewcount = 2, renewsallowed = 0, renewsleft = 0"
318 # Add a default rule: renewal is allowed
319 Koha::CirculationRules->set_rules(
321 categorycode => undef,
325 renewalsallowed => 3,
329 @renewcount = C4::Circulation::GetRenewCount($borrower_id1, $item_id1);
333 "With issuing rules (renewal allowed) and with a valid parameter, Getrenewcount of item1 returns 3 renews left"
336 AddRenewal( $borrower_id1, $item_id1, $branchcode_1,
337 $datedue3, $daysago10 );
338 @renewcount = C4::Circulation::GetRenewCount($borrower_id1, $item_id1);
342 "With issuing rules (renewal allowed, 1 remaining) and with a valid parameter, Getrenewcount of item1 returns 0 renews left"
345 $dbh->do("DELETE FROM old_issues");
346 AddReturn($barcode_1);
347 my $return = $dbh->selectrow_hashref("SELECT DATE(returndate) AS return_date, CURRENT_DATE() AS today FROM old_issues LIMIT 1" );
348 ok( $return->{return_date} eq $return->{today}, "Item returned with no return date specified has todays date" );
350 $dbh->do("DELETE FROM old_issues");
351 C4::Circulation::AddIssue( $borrower_1, $barcode_1, $daysago10, 0, $today );
352 AddReturn($barcode_1, undef, undef, dt_from_string('2014-04-01 23:42'));
353 $return = $dbh->selectrow_hashref("SELECT * FROM old_issues LIMIT 1" );
354 ok( $return->{returndate} eq '2014-04-01 23:42:00', "Item returned with a return date of '2014-04-01 23:42' has that return date" );
357 ($biblionumber, $biblioitemnumber, $itemnumber) = C4::Items::AddItem(
359 barcode => 'barcode_3',
360 itemcallnumber => 'callnumber3',
361 homebranch => $branchcode_1,
362 holdingbranch => $branchcode_1,
369 t::lib::Mocks::mock_preference( 'UpdateNotForLoanStatusOnCheckin', q{} );
370 AddReturn( 'barcode_3', $branchcode_1 );
371 my $item = Koha::Items->find( $itemnumber );
372 ok( $item->notforloan eq 1, 'UpdateNotForLoanStatusOnCheckin does not modify value when not enabled' );
374 t::lib::Mocks::mock_preference( 'UpdateNotForLoanStatusOnCheckin', '1: 9' );
375 AddReturn( 'barcode_3', $branchcode_1 );
376 $item = Koha::Items->find( $itemnumber );
377 ok( $item->notforloan eq 9, q{UpdateNotForLoanStatusOnCheckin updates notforloan value from 1 to 9 with setting "1: 9"} );
379 AddReturn( 'barcode_3', $branchcode_1 );
380 $item = Koha::Items->find( $itemnumber );
381 ok( $item->notforloan eq 9, q{UpdateNotForLoanStatusOnCheckin does not update notforloan value from 9 with setting "1: 9"} );
384 ($biblionumber, $biblioitemnumber, $itemnumber2) = C4::Items::AddItem(
386 barcode => 'barcode_4',
387 itemcallnumber => 'callnumber4',
388 homebranch => $branchcode_1,
389 holdingbranch => $branchcode_1,
396 t::lib::Mocks::mock_preference( 'UpdateItemLocationOnCheckin', q{} );
397 AddReturn( 'barcode_4', $branchcode_1 );
398 my $item2 = Koha::Items->find( $itemnumber2 );
399 ok( $item2->location eq 'FIC', 'UpdateItemLocationOnCheckin does not modify value when not enabled' );
401 t::lib::Mocks::mock_preference( 'UpdateItemLocationOnCheckin', 'FIC: GEN' );
402 AddReturn( 'barcode_4', $branchcode_1 );
403 $item2 = Koha::Items->find( $itemnumber2 );
404 ok( $item2->location eq 'GEN', q{UpdateItemLocationOnCheckin updates location value from 'FIC' to 'GEN' with setting "FIC: GEN"} );
405 ok( $item2->permanent_location eq 'GEN', q{UpdateItemLocationOnCheckin updates permanent_location value from 'FIC' to 'GEN' with setting "FIC: GEN"} );
406 AddReturn( 'barcode_4', $branchcode_1 );
407 $item2 = Koha::Items->find( $itemnumber2 );
408 ok( $item2->location eq 'GEN', q{UpdateItemLocationOnCheckin does not update location value from 'GEN' with setting "FIC: GEN"} );
410 t::lib::Mocks::mock_preference( 'UpdateItemLocationOnCheckin', '_ALL_: CART' );
411 AddReturn( 'barcode_4', $branchcode_1 );
412 $item2 = Koha::Items->find( $itemnumber2 );
413 ok( $item2->location eq 'CART', q{UpdateItemLocationOnCheckin updates location value from 'GEN' with setting "_ALL_: CART"} );
414 ok( $item2->permanent_location eq 'GEN', q{UpdateItemLocationOnCheckin does not update permanent_location value from 'GEN' with setting "_ALL_: CART"} );
415 AddIssue( $borrower_1, 'barcode_4', $daysago10,0, $today, '' );
416 $item2 = Koha::Items->find( $itemnumber2 );
417 ok( $item2->location eq 'GEN', q{Location updates from 'CART' to permanent location on issue} );
419 t::lib::Mocks::mock_preference( 'UpdateItemLocationOnCheckin', "GEN: _BLANK_\n_BLANK_: PROC\nPROC: _PERM_" );
420 AddReturn( 'barcode_4', $branchcode_1 );
421 $item2 = Koha::Items->find( $itemnumber2 );
422 ok( $item2->location eq '', q{UpdateItemLocationOnCheckin updates location value from 'GEN' to '' with setting "GEN: _BLANK_"} );
423 AddReturn( 'barcode_4', $branchcode_1 );
424 $item2 = Koha::Items->find( $itemnumber2 );
425 ok( $item2->location eq 'PROC' , q{UpdateItemLocationOnCheckin updates location value from '' to 'PROC' with setting "_BLANK_: PROC"} );
426 ok( $item2->permanent_location eq '' , q{UpdateItemLocationOnCheckin does not update permanent_location value from '' to 'PROC' with setting "_BLANK_: PROC"} );
427 AddReturn( 'barcode_4', $branchcode_1 );
428 $item2 = Koha::Items->find( $itemnumber2 );
429 ok( $item2->location eq '' , q{UpdateItemLocationOnCheckin updates location value from 'PROC' to '' with setting "PROC: _PERM_" } );
430 ok( $item2->permanent_location eq '' , q{UpdateItemLocationOnCheckin does not update permanent_location from '' with setting "PROC: _PERM_" } );
435 # Bug 14640 - Cancel the hold on checking out if asked
436 my $reserve_id = AddReserve($branchcode_1, $borrower_id1, $biblionumber,
437 undef, 1, undef, undef, "a note", "a title", undef, '');
438 ok( $reserve_id, 'The reserve should have been inserted' );
439 AddIssue( $borrower_2, $barcode_1, dt_from_string, 'cancel' );
440 my $hold = Koha::Holds->find( $reserve_id );
441 is( $hold, undef, 'The reserve should have been correctly cancelled' );
444 $schema->storage->txn_rollback;